Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Disable the OK button on the organise dialog when the destination device doesn't have enough free space. Fixes issue #539

This commit is contained in:
David Sansome 2010-07-30 22:25:32 +00:00
parent 06ce5e5253
commit cb2ae56949
2 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/ui/organisedialog.cpp
View File

@ -36,7 +36,8 @@ const char* OrganiseDialog::kSettingsGroup = "OrganiseDialog";
OrganiseDialog::OrganiseDialog(TaskManager* task_manager, QWidget *parent)
: QDialog(parent),
ui_(new Ui_OrganiseDialog),
task_manager_(task_manager)
task_manager_(task_manager),
total_size_(0)
{
ui_->setupUi(this);
connect(ui_->buttonBox->button(QDialogButtonBox::Reset), SIGNAL(clicked()), SLOT(Reset()));
@ -121,6 +122,7 @@ void OrganiseDialog::SetFilenames(const QStringList& filenames, quint64 total_si
}
ui_->free_space->set_additional_bytes(total_size);
total_size_ = total_size;
UpdatePreviews();
}
@ -166,17 +168,6 @@ void OrganiseDialog::UpdatePreviews() {
}
}
// Update the format object
format_.set_format(ui_->naming->toPlainText());
format_.set_replace_non_ascii(ui_->replace_ascii->isChecked());
format_.set_replace_spaces(ui_->replace_spaces->isChecked());
format_.set_replace_the(ui_->replace_the->isChecked());
const bool format_valid = format_.IsValid();
ui_->buttonBox->button(QDialogButtonBox::Ok)->setEnabled(format_valid && storage);
if (!format_valid)
return;
// Update the free space bar
quint64 capacity = destination.data(MusicStorage::Role_Capacity).toLongLong();
quint64 free = destination.data(MusicStorage::Role_FreeSpace).toLongLong();
@ -189,6 +180,23 @@ void OrganiseDialog::UpdatePreviews() {
ui_->free_space->set_total_bytes(capacity);
}
// Update the format object
format_.set_format(ui_->naming->toPlainText());
format_.set_replace_non_ascii(ui_->replace_ascii->isChecked());
format_.set_replace_spaces(ui_->replace_spaces->isChecked());
format_.set_replace_the(ui_->replace_the->isChecked());
const bool format_valid = format_.IsValid();
// Are we gonna enable the ok button?
bool ok = format_valid && storage;
if (capacity != 0 && total_size_ > free)
ok = false;
ui_->buttonBox->button(QDialogButtonBox::Ok)->setEnabled(ok);
if (!format_valid)
return;
// Update the previews
ui_->preview->clear();
ui_->preview_group->setVisible(has_local_destination);

1
src/ui/organisedialog.h
View File

@ -72,6 +72,7 @@ private:
QStringList filenames_;
SongList preview_songs_;
quint64 total_size_;
};
#endif // ORGANISEDIALOG_H