John Maguire
341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
Jim Broadus
1f7607b1db
Get backend from application in PlaylistContainer::SetApplication
...
The manager's library backend may not be set when this is called.
2020-07-12 09:44:47 +01:00
Jim Broadus
c75fa0077e
Fix playlist memory leak
...
When the current playlist is changed, PlaylistContainer::SetViewModel is called
to set the new list. This calls PlaylistView::SetItemDelegates, which allocates
several objects that are never freed. Instead, move the call to SetItemDelegates
to PlaylistContainer::SetApplication, which is only called once.
2020-07-10 10:28:19 +01:00
Antonio Russo
ccaa59cc66
Periodically save current playlist tab
...
Building on the previous commit, we save the current playlist (tab)
periodically as well.
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2019-09-10 18:41:18 -06:00
Jonas Kvinge
d4fab4a2ea
Merge remote-tracking branch 'upstream/master' into qt5-update
2018-11-11 22:46:07 +01:00
Victor Parmar
f4d84bc05a
Split last.fm scrobbling and play count calculation, closes #5771 ( #6179 )
...
Also add a configurable option to increment the play count if song has played for a shorter duration.
2018-10-20 12:57:49 +01:00
Antonio Russo
6a312e7459
Limit both QSettings reads and writes ( #6057 )
...
Any access, read or write, via QSettings requires locking
`Clementine.conf`. On some devices, this can be slow. Moreover, it also
increases power use and wear on devices such as SSDs.
To improve the situation, defer QSettings updates until program close
for window resize, current playlist tab, and playlist geometry, i.e.
`PlaylistView::SaveGeometry`.
Also, limit `PlaylistView::LoadGeometry` to once per program run.
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2018-05-22 11:18:54 +01:00
Andreas Sturmlechner
55a39a9609
Fix build with Qt 5.11 ( #6029 )
2018-03-17 02:16:49 -04:00
vikramambrose
2e4a67b8da
Add appearance option to hide playlist filter toolbar ( #5942 )
...
Gives the user the option of a cleaner looking interface if the
filter toolbar isn't used.
2018-01-03 15:24:56 +00:00
Grace Dolphy
bdda50b28f
Continuation of "Seek instead of navigation with arrow keys" #5550 , now allows up arrow key. ( #5721 )
...
* Continuation of "Seek instead of navigation with arrow keys" #5550 , now allows up arrow key to not restart the song over when the library is in focus. Works as usuhal when playlist is in focus (song gets started over).
* Update playlistview.cpp
Added in the part that is responsible for seeking properly.
2017-05-30 18:19:08 +01:00
Ivan Leontiev
9afd71c651
Fix pressing "Backspace" key on a playlist results in appending "^H" character to the filter
2016-03-25 03:45:33 +03:00
John Maguire
0ea84e129e
Merge pull request #5210 from narunlifescience/patch-2
...
Use icon loader for remaining icons
2016-02-11 11:24:09 +00:00
Arun Narayanankutty
9a7732577d
Remove unwanted lines from playlistcontainer
2016-01-16 07:06:27 -06:00
Arun Narayanankutty
29b8d308b3
Use icon loader for remaining icons
2016-01-14 06:10:54 -06:00
narunlifescience
dd953fd86c
check custom icon location, then system theme & then fallback theme
...
icons added & replaced
2015-10-13 22:35:49 -05:00
Arnaud Bienner
7ae9e0dd9b
Set starting_up_ to false in playlist container when manager is done adding playlists.
...
Otherwise, it was never set to false at startup if no "current_playlist" was saved in the settings, then there was no new value saved for "current_playlist".
Fixes #4011 .
2015-03-25 22:13:39 +01:00
Arnaud Bienner
f6e6d3b937
Revert "Finished the changes to the quick change menu. Everything should work."
...
This reverts commit a468085c3a
.
Conflicts:
src/playlist/playlistcontainer.cpp
src/playlist/playlistcontainer.h
src/ui/behavioursettingspage.cpp
2014-10-07 00:29:46 +02:00
Gavin Howard
9141cd65bc
Fixes requested by ArnaudBienner.
2014-08-19 13:26:00 -06:00
Gavin Howard
f41bebbeb2
Ran 'make format' on my patch.
2014-08-18 09:56:01 -06:00
Gavin Howard
d8ba0c4f91
Minor changes requested by hatstand.
2014-08-18 08:08:14 -06:00
Gavin Howard
a468085c3a
Finished the changes to the quick change menu. Everything should work.
2014-08-15 18:52:01 -06:00
Gavin Howard
1cddc696ae
Add a quick change menu to the playlist container.
2014-08-15 15:37:31 -06:00
Arnaud Bienner
0976cc7e5c
Give Clementine the answer to the ultimate question of life, the universe and everything
...
Probably my most valuable contribution so far
2014-07-24 23:48:45 +02:00
John Maguire
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
Arnaud Bienner
253a8ffde4
Add save action from playlistlist tab, so we can save favorite playlists without opening them.
...
Remove unnecessary/duplicate actions from playlistlist tab.
2013-05-23 20:09:35 +02:00
Arnaud Bienner
5e6821dead
Add a 'favorite' widget to playlist tab, and keep in playlistlist container only favorite playlists, instead of all playlists.
2013-05-11 23:18:03 +02:00
David Sansome
9fae3881ed
Add a new "Playlists" tab to the sidebar that contains all the playlists created by or imported into Clementine. The tab bar now contains only "open" playlists - closing a tab closes the playlist without deleting it.
...
Update issue 1811
Added a Playlists tree view to the sidebar.
2012-10-30 23:04:22 -07:00
David Sansome
885d98b5f0
Remove the SpecialPlaylistType class, it hasn't been used since Spotify and Grooveshark search results went into the sidebar tree.
2012-10-30 22:53:09 -07:00
Michael Niggli
96654efd3f
Delay queries on large playlists.
...
Fixes issue 3148
2012-09-09 00:35:50 +02:00
Arnaud Bienner
3b50ed8953
Clear playlist search field when Esc is pressed
2012-07-14 00:00:16 +02:00
John Maguire
83f1aa9252
Copy the character that triggered a search box focus into the search box.
2012-07-12 19:09:03 +02:00
John Maguire
b01a0de8d6
Re-enable a few disabled features from the Qocoa porting.
2012-06-28 12:35:20 +02:00
John Maguire
569c8295db
Add qocoa and use it for the playlist search field.
2012-06-28 11:39:43 +02:00
David Sansome
7d9f2b7b7d
Use LineEdit::set_focus() instead of QWidget::setFocus() on LineEdit widgets that might be OS X search widgets
...
Fixes issue 2823
2012-03-25 21:14:39 +01:00
David Sansome
35e34c6ca5
Hide the did you mean widget when leaving the search box, Don't lose the spotify tab icon when stopping playback, add a helpful label to the empty spotify search tab, remove the playlist CSS hook, fix double clicking the "Search spotify" item in the list
2011-04-29 11:24:58 +00:00
David Sansome
b20d280156
Add a "Did you mean ...?" widget when searching on spotify
2011-04-28 20:48:53 +00:00
John Maguire
d51c99382e
Fix crash on Mac.
2011-04-28 20:19:48 +00:00
David Sansome
06852aaeb7
Show spotify search results in a separate playlist tab rather than in a tree in the sidebar.
2011-04-28 17:50:45 +00:00
Arnaud Bienner
6653d740fc
Adding shorcuts for navigating over the tabs. Fixes issue 1568
2011-04-19 20:11:24 +00:00
Andrea Decorte
ecda0ada4a
Playlists get an automatic name, no more prompts. Fixes issue #423
2011-03-25 19:16:12 +00:00
Andrea Decorte
a88e02c452
Added right-click menu option to copy track to specific playlist. Fixes issue 1289
2011-03-20 17:38:15 +00:00
Arnaud Bienner
7f783d088e
Minor change
2011-02-24 00:00:10 +00:00
Arnaud Bienner
9c0094b9a6
Improve playlist view: focus on playlistview or search filter, depending on keyboard event. Fixes issue 606
2011-02-23 22:21:17 +00:00
John Maguire
4e2d82f3fb
Fix mac build.
2010-12-20 14:49:47 +00:00
David Sansome
c8520021d7
Start of a new edit tag dialog. Lots of things don't work and it doesn't actually save tags yet (so it's about as useful as before).
2010-12-19 23:40:36 +00:00
David Sansome
05a1bf6e37
Make the clear button a part of the search textbox. Fixes issue #1071
2010-12-18 20:32:05 +00:00
David Sansome
59875c9708
Make F2 edit the first playlist column again after the cursor has been moved. Fixes issue #939
2010-11-28 15:14:48 +00:00
David Sansome
ed1a25693c
Add missing licenses to debian/copyright, and add copyright information to each source file
2010-11-20 13:27:10 +00:00
David Sansome
56d72a00bf
Try the next UI experiment - wide buttons down the side like Qt Creator
2010-10-01 19:27:01 +00:00