1
0
mirror of https://github.com/clementine-player/Clementine synced 2024-12-23 00:09:14 +01:00
Commit Graph

7554 Commits

Author SHA1 Message Date
dmdmdm
949c20abdf Compress PNGs (second attempt) 2020-05-21 21:45:04 +01:00
dmdmdm
7caf200efa Added CBC Podcasts 2020-05-21 02:04:08 +01:00
John Maguire
157a9d1d1f Only run once for PRs 2020-05-21 02:03:34 +01:00
John Maguire
a17f968b46 Trigger workflow for PRs 2020-05-21 02:03:34 +01:00
Jim Broadus
879dfa3d79 icecast: free backend on exit
Use a shared pointer since the model and search provider both hold pointers to
the backend object. Also removed unused accessor method.
2020-05-20 21:33:47 +01:00
Jim Broadus
8f56fbb83b Fix timer errors on exit
The NetworkRemote is moved to a new thread after creation. On that thread, its
child classes create timers. When the network remote class is deleted on the
main thread, we see "Timers cannot be stopped from another thread".

To avoid this error, use deleteLater to delete NetworkRemote and its composition
classes on its own thread.
2020-05-19 10:39:06 +01:00
Jim Broadus
5b918a70aa Add an optional delete function for Lazy pointers.
This allows a delete function to be provided with the prototype: void d(T*)
This function is passed to the unique_ptr constructor to be used when the object
is released. The default function simply deletes the object, where the default
behavior for unique_ptr would have a specialization for arrays. If Lazy is ever
used with arrays, a delete function should be provided.
2020-05-19 10:39:06 +01:00
John Maguire
912589439e Add bionic builder 2020-05-16 18:51:00 +01:00
John Maguire
bc16747009 Add buster builder 2020-05-16 18:34:14 +01:00
John Maguire
833f8256c8 Add debian stretch github job 2020-05-16 18:18:55 +01:00
John Maguire
f46241e75a Add eoan github job 2020-05-16 18:00:12 +01:00
John Maguire
18497dcb66 Add Fedora 32 build 2020-05-16 17:38:19 +01:00
John Maguire
d7c1431193 Add Fedora 31 job 2020-05-16 14:26:17 +01:00
Jim Broadus
6a5cb0712d gstengine: Fix gtreamer request pad leak
According to the gst_element_request_pad documentation, request pads must be
released after usage. They aren't automatically released and dereferenced when
the element is destroyed.
2020-05-15 11:12:34 +01:00
John Maguire
2b91bbe978 Add mingw job 2020-05-14 15:21:09 +01:00
John Maguire
e1f82b24a1 Add focal build 2020-05-14 15:21:09 +01:00
John Maguire
4da609d459 Add mac workflow 2020-05-14 15:21:09 +01:00
Michael Kuc
baea2d488f Revert "Revert "Updated GLEW headers.""
This reverts commit ce4ce6ce36.
2020-05-14 15:10:35 +01:00
Michael Kuc
ade1e7f30b Revert "Revert "Use newer compiler than C++98.""
This reverts commit dcf078acca.
2020-05-14 15:10:35 +01:00
Michael Kuc
43a171512b Revert "Revert "Fix deprecated comparison.""
This reverts commit 0782489feb.
2020-05-14 15:10:35 +01:00
Michael Kuc
38207e4ea7 Replace deprecated std::auto_ptr with new std::unique_ptr. 2020-05-14 15:10:35 +01:00
Michael Kuc
823aed98a1 Fix narrowing issues preventing MacOS build. 2020-05-14 15:10:35 +01:00
Jim Broadus
58569d9d0d Remove fetcher list from OutgoingDataCreator class. 2020-05-14 11:01:49 +01:00
Jim Broadus
83fc376b08 subsonic: Consolidate read song code 2020-05-14 11:01:22 +01:00
Jim Broadus
ddba21a46f subsonic: Move ReadSong method to SubsonicService. 2020-05-14 11:01:22 +01:00
Jim Broadus
5efcae398e subsonic: Use correct URL query params to fetch cover 2020-05-13 22:23:40 +01:00
John Maguire
ce4ce6ce36 Revert "Updated GLEW headers."
This reverts commit 3ca4973ea7.
2020-05-13 12:43:08 +01:00
John Maguire
dcf078acca Revert "Use newer compiler than C++98."
This reverts commit a07a0de231.
2020-05-13 12:43:08 +01:00
John Maguire
0782489feb Revert "Fix deprecated comparison."
This reverts commit be144d4611.
2020-05-13 12:43:08 +01:00
Jim Broadus
96a17c9f40 settings: Only save settings for visited pages
Set a flag when a page is shown. On apply or accept, only save if that flag is
set.
2020-05-12 10:21:44 +01:00
Jim Broadus
77badd37ff settings: Add dialog methods to settings pages
Add Accept, Apply, Reject methods to settings pages to mirror dialog. This will
allow settings pages to handle these events at a more granular level and will
allow common behavor in the base class.
2020-05-12 10:21:44 +01:00
Michael Kuc
be144d4611 Fix deprecated comparison.
Using references no longer requires null checking.
2020-05-09 21:38:50 +01:00
Michael Kuc
a07a0de231 Use newer compiler than C++98.
Required for standard library headers.
2020-05-09 21:38:50 +01:00
Michael Kuc
3ca4973ea7 Updated GLEW headers.
An attempt to fix headers so outdated they no longer compiled.
2020-05-09 21:38:50 +01:00
Jim Broadus
096203ac88 visualisations: Fix close action
Pressing the close button on the window sends a close event, where other methods
of exiting visualization just hide the window. If shown again after close, the
window will be empty. To fix this, handle and reject the close event. Call hide
instead.
2020-05-09 13:28:29 +01:00
Jim Broadus
7e7d271b30 Properly handle removal of top level items in StandardItemIconLoader
The rowsAboutToBeRemoved signal from the model provides a parent index, but with
QStandardItemModel, top level items are added to an invisible root item that
doesn't have a valid index. This causes the range check to miss top level items
due to a perceived parent mismatch. When the load completes, it attempts to
access an object that has been deleted.
2020-05-04 10:09:51 +01:00
Jim Broadus
dc4270076d Change StandardItemIconLoader to require a QStandardItemModel
This should be a safe assumption since the loader operates on QStandardItem
objects.
2020-05-04 10:09:51 +01:00
John Maguire
cb64d97050 Don't bother with i386 for focal 2020-04-23 22:02:21 +01:00
John Maguire
42b2cd6945 Add focal builds 2020-04-23 22:02:21 +01:00
John Maguire
b007e54b3d Add liblastfm for windows 2020-04-23 01:18:32 +01:00
Jim Broadus
0ecb773355 Handle lyrics tag for mp4
Translation table in mp4tag.cpp for reference.
2020-04-19 14:01:25 +01:00
Jim Broadus
509c65ced7 tagreader: Add debug handler for taglib
Pass taglib debug messages through qLog instead of printing directly to stderr.
2020-04-19 14:00:35 +01:00
John Maguire
934fd336da Install liblastfm for mac 2020-04-17 13:02:26 +01:00
Pierre Langlois
6285c11bc3 Fix tranlations test.
"Library" is translated to "Fonoteca" since
1504d8be1c so we can adapt the test.
2020-04-17 11:42:03 +01:00
John Maguire
b0c92ae784 Install windows style plugin
Fixes #6523
2020-04-12 22:00:45 +01:00
John Maguire
ae1a99d90c Copy windows styles plugin 2020-04-12 22:00:45 +01:00
John Maguire
539e7d7e22
Update README.md 2020-04-12 21:07:29 +01:00
John Maguire
c82ff30b43
Update README.md 2020-04-12 21:06:57 +01:00
Sophie Tauchert
ef3021dff2 Add tasks back in using ScopedTask 2020-04-12 21:03:18 +01:00
Sophie Tauchert
38a5d183c2 Cache SubsonicService in SubsonicDynamicPlaylist 2020-04-12 21:03:18 +01:00