John Maguire
01915cc351
Remove taglib prefix from #includes in tests.
2011-02-04 13:29:49 +00:00
John Maguire
084b9a2fe3
Remove taglib prefix from includes as the taglib include path contains it already.
2011-02-04 12:36:56 +00:00
John Maguire
ab2f3360e2
Add Linux variable and set -Werror for Linux builds.
2011-02-04 12:07:00 +00:00
John Maguire
c680c55379
Fix a couple of warnings found by Clang.
2011-02-04 11:17:31 +00:00
Paweł Bara
ed4b7abde0
changed my mind - reverting my playlist changes to previous status quo (just making the PlaylistParser's contract more explicit)
...
this doesn't mean the previous revision was pointless - it still fixed one CUE related bug which I forgot to mention...
2011-02-03 22:21:15 +00:00
David Sansome
a361dc128d
Sort out the cmake dependency mess when generating/compiling translations - should hopefully fix some compile issues with parallel jobs.
2011-02-03 22:01:31 +00:00
David Sansome
e586ca12e5
Link clementine_lib instead of clementine against qtsparkle, fixing the tests on Windows
2011-02-03 21:06:05 +00:00
David Sansome
3ef0bf65a8
Fix the last.fm icon while a last.fm station is loading
2011-02-03 20:59:53 +00:00
David Sansome
2a68ecc726
Remove some unused bits
2011-02-03 20:59:14 +00:00
Paweł Bara
7bdac8fba6
when loading playlist, take only it's valid songs (+ force validity of CUE and PLS related songs)
2011-02-03 17:47:32 +00:00
Arnaud Bienner
74a878be41
Minor modication thanks to David comment
2011-02-02 23:27:55 +00:00
Arnaud Bienner
e8720f5bda
Display item info in playlist view only if text displayed is elided
2011-02-02 22:58:19 +00:00
Paweł Bara
2623a170a4
forgot this
2011-02-02 21:05:07 +00:00
Paweł Bara
77151d7ebd
Hiding some of Song's cover art logic complexity in Song's API (namely: embedded and manually unset covers).
2011-02-02 21:01:08 +00:00
John Maguire
f0ac22e31b
Fix crash in mac on show duplicates only.
...
Fixes issue #1396
2011-02-02 19:16:27 +00:00
Paweł Bara
12099d48f6
maybe fix the mac build
2011-02-02 17:22:30 +00:00
Paweł Bara
ce104b9cf4
working on making disable for library filter widget work on MacOS (Updates issue #1396 )
2011-02-02 16:46:57 +00:00
Paweł Bara
8aedda1795
moving the 'Save cover to file' action into AlbumCoverChoiceController; implementing the action in all related places (now playing widget, album cover manager, edit tag dialog)
...
now playing widget: disable all cover related context menu options (except for the 'save cover' one) when in 'Kittens' mode
2011-02-02 16:22:04 +00:00
Arnaud Bienner
b52f3b6082
Improve track selection dialog: allow expanding, use linedit for filename and minor other modifications. Fixes issue 1392
2011-02-01 20:59:33 +00:00
David Sansome
e4d9d54414
Link Clementine against SIP and PyQt on Windows, and add the modules to python's inittab
2011-01-31 23:44:44 +00:00
John Maguire
6d98f24f30
Add wavpack plugin on OS X.
...
Update issue #1398
This probably fixes it.
2011-01-31 22:19:49 +00:00
John Maguire
9786570f35
Add support for saving album covers/kittens.
...
Fixes issue #1395
2011-01-31 20:53:38 +00:00
Paweł Bara
5b5d3f0c2e
watch out for optional last.fm dependencies in AlbumCoverChoiceController -> fixes issue #1393
...
from the creators of "david is always right" movie -> maybe fix issue #1396
2011-01-31 15:21:32 +00:00
Paweł Bara
2959dbff85
'show duplicates only' view for library where you can see which songs in your library are duplicated and delete unnecessary duplicates (fixes issue #1328 )
2011-01-30 21:00:49 +00:00
Paweł Bara
35441d829e
fixed a bug where 'Show cover in full size' and 'Unset cover' actions were incorrectly being disabled in the 'Now playing' widget
2011-01-30 20:17:09 +00:00
John Maguire
06c62f169f
Set default mac sidebar to Large and allow building on mac without tunepimp & scripting.
2011-01-29 21:28:11 +00:00
Arnaud Bienner
9159e3c47e
Oups... miss to also correct this
2011-01-29 16:11:20 +00:00
Arnaud Bienner
8b681a5dd2
Allow autotagging for non-library music files. Fixes issue 1389
2011-01-29 16:02:23 +00:00
Arnaud Bienner
6c42240b02
Minor correction in tagfetcher. Thanks David
2011-01-29 15:32:55 +00:00
John Maguire
03c2da63e0
Add tunepimp mp3 plugin to Fedora spec.
2011-01-29 15:31:36 +00:00
Arnaud Bienner
e9f19f2cdb
Correct regression introduced in r2705. Partially fixes issue 1390
2011-01-29 15:18:14 +00:00
David Sansome
618aec2c74
Clean module dicts properly when unloading a script - works around a bug in Python 2.7.0 only
2011-01-29 00:57:58 +00:00
David Sansome
bcc35ec29c
Add a test for stuff in the module's global dict
2011-01-28 21:43:10 +00:00
David Sansome
9ca237bfa2
Add a unit test for some basic python scripting functionality
2011-01-28 20:52:38 +00:00
David Sansome
e312057068
Maybe fix the fc14 build
2011-01-27 21:02:08 +00:00
David Sansome
3967437cba
Bring (parts of) gmock into the repository instead of it being an svn:external
2011-01-27 19:49:08 +00:00
John Maguire
ba0c7bab65
Change "kittens" feature to fetch the kittens tag instead of cat tag for fluffier kittens.
2011-01-27 16:54:03 +00:00
John Maguire
16b5466922
Nicer platform specific sip flags.
2011-01-27 15:40:53 +00:00
John Maguire
508aaed088
Fix pyqt on mac.
2011-01-27 15:29:26 +00:00
John Maguire
703a3b43d6
Mac build fixes for musicbrainz integration.
2011-01-27 14:48:58 +00:00
Arnaud Bienner
05a4cae370
Add track seeking from playlistview
2011-01-26 23:20:56 +00:00
Paweł Bara
2fec795b89
fixed an error where entering the Cover Searcher dialog without query would make it show the busy indicator forever
...
further refactoring of album cover changes (QMenu in controller)
2011-01-25 23:33:27 +00:00
Andrea Decorte
4e9aef16cb
forgot to add these files, sorry
2011-01-25 20:13:28 +00:00
Paweł Bara
b959792116
initial version of setlist.fm script...
...
... which downloads the latest setlist of artist chosen by user and then fills the current playlist with songs that were played during that set and are in the library at the same time
2011-01-25 19:28:25 +00:00
Andrea Decorte
f98b89a2d8
Fixed issue #764
2011-01-25 19:15:51 +00:00
John Maguire
c4f4ee6fe5
Add preview script.
...
Update issue #459
Basic script added.
2011-01-25 16:48:12 +00:00
David Sansome
f929a88473
Fix mpris
2011-01-24 21:25:09 +00:00
David Sansome
0beb12fc14
Add some options to control what happens when you double click or use the menu to add tracks to the playlist
2011-01-24 21:16:26 +00:00
John Maguire
2ad5acdd29
Move version information in to separate file to decrease churn on svn up.
...
Fix inverted error message for Avahi.
2011-01-24 20:45:15 +00:00
David Sansome
5e9edd52fe
Hold the taglib mutex while loading embedded cover art from files. Fixes issue #1350
2011-01-24 20:06:59 +00:00