Commit Graph

2874 Commits

Author SHA1 Message Date
ByteHamster 949260658b Fixed rare 'file not found' errors when starting playback
The `getPlayLastPlayedMediaIntent` method was originally added in 2013
to avoid starting the service without a media file. The bind method
should actually never need to start the service in the first place,
though.
2021-02-19 21:22:19 +01:00
ByteHamster 8fdd034e9e Added a real file to test chapters with
Thanks to the Sendegate community
https://sendegate.de/t/gesucht-beispieldateien-mit-kapitelmarken/13228
2021-02-19 14:21:44 +01:00
Yaron Shahrabani 7b39ef8953
Fixed typo
Epsiodes->Episodes
2021-02-18 00:57:48 +02:00
ByteHamster 12e22849e6 Added more id3 parser tests 2021-02-17 14:48:31 +01:00
ByteHamster 28d6551dbc Removed plural form because Transifex only allows 2 forms in English 2021-02-17 11:39:30 +01:00
ByteHamster 9e68b8b0a3 Fixed NPE when loading ogg chapters 2021-02-16 16:09:18 +01:00
ByteHamster 3f1c1c4bf5 Rewrite chapter parser for testability 2021-02-16 14:39:49 +01:00
ByteHamster 0f692be2d4
Merge pull request #4940 from ByteHamster/more-reliable-chapters
More reliable chapter loading
2021-02-16 09:39:23 +01:00
ByteHamster 4f2dcc189c Fix parsing chapters with multiple null bytes
Previously, we relied on the string to fill the complete frame.
Some podcasts terminate the string early and leave some garbage in
the frame data. Skip that garbage, so that the reader is at a valid
frame header position when starting the next iteration.
2021-02-15 23:13:29 +01:00
ByteHamster 57587c928e Removed method that does the same as loadMediaInfo anyway 2021-02-15 22:02:55 +01:00
ByteHamster 339aa936bf Removed return parameter of loadMediaInfo
We return true anyways. The call for actually loading is asynchronous,
so returning anything here does not make sense.

Reduces likelihood of loader being interrupted to just load the same
item again when the state changes.
2021-02-15 21:56:06 +01:00
Geist5000 aaeea78b37
changed the "Use Episode Cover" setting to only apply to list items. (#4908) 2021-02-15 16:04:03 +01:00
ByteHamster 42ce907aaf
Merge pull request #4936 from ByteHamster/chapter-reader
Simplified chapter reader
2021-02-15 15:21:49 +01:00
ByteHamster b1bf77d4e3 New workaround for hiding the notification directly 2021-02-15 11:44:02 +01:00
ByteHamster 4aa5443529 Refresh all feeds at once instead of sending tons of lists with 1 feed each 2021-02-15 11:43:57 +01:00
ByteHamster 52421d81f7 Removed some unnecessary calls to startForeground 2021-02-15 11:28:03 +01:00
ByteHamster 5a234a367d Simplified chapter reader
No longer uses code duplication for opening local and remote streams.
Also, switched to OkHttp to handle redirects.
2021-02-15 11:08:00 +01:00
ByteHamster 66ae028719 Merge branch 'master' into develop 2021-02-14 22:44:08 +01:00
Tony Tam f57cf0c317
New preference to show the remaining time in the 'queue' and podcast episode view (#4880) 2021-02-14 12:18:27 +01:00
ByteHamster 010ed376cd Move basic views to new module 2021-02-12 21:00:39 +01:00
ByteHamster 24ea4708ea Remove PlaybackServiceCallbacks 2021-02-12 18:08:58 +01:00
Herbert Reiter 60968089ae
Refactoring: Remove ClientConfig.automaticDownloadAlgorithm (#4924) 2021-02-07 17:57:09 +01:00
Jonas Kalderstam ae8759869d Fixed default number of items to clean up
Not sure why this worked before TBH - but default value should
naturally be to reduce to desired cache size.

Probably makes no difference in actual use - but it is how the tests
are constructed.
2021-02-06 21:43:34 +01:00
Jonas Kalderstam 3a9e1fc2dd
Applied code review suggestions
Co-authored-by: ByteHamster <ByteHamster@users.noreply.github.com>
2021-02-06 15:54:25 +01:00
Jonas Kalderstam 08edd151f9 Added new cleanup option: when not favorited
This is another way of solving #2077.

The root issue is that queued episodes are never auto-deleted
currently which means that if you automatically add episodes to the
queue you will eventually end up with AntennaPod refusing to auto
download more episodes because the cache is full and it can't make
space.

This option will only refuse to delete favorited items. Otherwise it
will simply delete the oldest episodes.
2021-02-05 11:15:22 +01:00
ByteHamster aa64ae132f Updated translations 2021-02-04 13:05:40 +01:00
ByteHamster 9924952e2f
Merge pull request #4900 from ByteHamster/decouple-widget
Reduce coupling between widget and playback service
2021-02-03 23:56:33 +01:00
ByteHamster b6f72f8847 Reduce coupling between widget and playback service
Instead of binding to the service, pass the required data. This also
ensures that the widget is updated instantly when calling from
PlaybackService. JobService had the problem that the OS sometimes
took some seconds before actually executing the job.
2021-02-03 23:37:51 +01:00
Tim Schumacher 1297a16850
Allow remapping hardware buttons (#4881) 2021-02-03 12:50:01 +01:00
Tony Tam 4ff6ff4fb7
Fix Android Auto next episode (#4895) 2021-01-31 23:17:33 +01:00
ByteHamster 4af0f98d2f Fixed update event sending incomplete item 2021-01-26 18:58:26 +01:00
Christopher Lorenz df45f60cf3 Bugfix: Read feed when updating item in database 2021-01-26 18:47:33 +01:00
Tony Tam f3bf708e26
Show publish date for podcasts and file creation date for local feeds (#4862) 2021-01-25 14:17:30 +01:00
Margaret Borowiec cd23eccf95
Google Assistant App Actions for AntennaPod (#4417) 2021-01-24 15:41:55 +01:00
Tony Tam c32239be0e
Android auto skip button (#4865) 2021-01-24 12:27:37 +01:00
ByteHamster a36d66bf35
Merge pull request #4893 from damoasda/robolectric-feed-parser2
Run AtomParserTest and RssParserTest with Robolectric
2021-01-24 12:20:09 +01:00
ByteHamster 72ab17f153
Merge pull request #4894 from damoasda/robolectric-DbReaderTest
Run DbReaderTest etc. with Robolectric
2021-01-24 12:01:10 +01:00
Herbert Reiter a87c505380 Run DbReaderTest etc. with Robolectric 2021-01-23 23:12:01 +01:00
Herbert Reiter ce48b186ed Run AtomParserTest and RssParserTest with Robolectric 2021-01-23 21:21:36 +01:00
ByteHamster b5f547bd9f
Merge pull request #4892 from ByteHamster/every-hours
Added new string for 'every x hours'
2021-01-23 19:44:08 +01:00
ByteHamster 37b5becd59 Added new string for 'every x hours' 2021-01-23 14:24:30 +01:00
Jonas Burian 35d010caa2
Use podcast image as fallback when episode image returns 404 (#4861) 2021-01-23 13:03:53 +01:00
Connectety-T b84b202629
add setGroupAlertBehavior to episode notifications. 2021-01-23 02:46:34 +01:00
Connectety 03c71ee6c5
Add Notifications for episodes (#4646)
Co-authored-by: ByteHamster <info@bytehamster.com>
2021-01-22 17:27:46 +01:00
ByteHamster 7bd20ae406
Merge pull request #4563 from SebiderSushi/fix_episodes_list_item_loading_b
Keep loading on the All Episodes tab even if items are filtered out
2021-01-22 15:46:21 +01:00
ByteHamster f610ceffc2 Split up filter model and database handling 2021-01-22 15:09:43 +01:00
ByteHamster 0399052866 Added show button to authentication dialog 2021-01-22 12:26:35 +01:00
Tony Tam e89a805bbd
Added indication for unsupported players (#4869) 2021-01-22 11:36:11 +01:00
ByteHamster cdf59a1c8e Merge branch 'develop' into fix_episodes_list_item_loading_b 2021-01-22 11:07:40 +01:00
asdoi 2a8abb02f6
Add scrubbing time overlay (#4786) 2021-01-21 18:37:04 +01:00
ByteHamster 86bf6a50f3
Merge pull request #4888 from ByteHamster/fix-extended-widget-actions
Fix extended widget buttons
2021-01-21 18:34:38 +01:00
Jonas Burian 44989b815a
HTML entities not processed in the authors field (#4887) 2021-01-21 18:33:59 +01:00
ByteHamster 9e1bd149b8 Fix extended widget buttons 2021-01-21 18:16:43 +01:00
Herbert Reiter e56f203c6d Refactoring: Split test methods to remove anonymous blocks 2021-01-13 21:20:16 +01:00
Herbert Reiter 5d1ef31a4a Refactor method: Use early return instead of late return to make the code more readable 2021-01-13 21:11:17 +01:00
Herbert Reiter 1f329cdde0 Avoid assertTrue() for better error messages 2021-01-13 20:51:49 +01:00
Herbert Reiter fd3b07cafb Use any image for local folders 2021-01-13 20:51:49 +01:00
Tony Tam 5be6f5feba
Send Authorization header to be able to stream password protected media (#4843) 2021-01-13 18:51:58 +01:00
Tony Tam 08d1400951
Add rewind, ff, skip button and layout for extra info in Widget (#4746) 2021-01-13 18:38:16 +01:00
Tony Tam 7659fd25d8
Do not retry autodownload after SSL errors (#4821) 2021-01-13 10:56:34 +01:00
Thom Merrilin ffc12060be Added share icon to feed_info menu, moved the Website Address and Podcast Feed URL into a submenu of this icon.
Will resolve #4734

Details:
        Website Address and Podcast Feed URL menu options were previously always in the overflow menu, which is inconsistent with over menus such as the FeedList menu where these options are under a "Share..." submenu.
	Two new vector drawables were added for the black and white options of a "Share" icon, these are used to create a submenu for Website Address and Podcast Feed URL if there's room, otherwise the submenu text "Share..." is used in the overflow menu.
2021-01-03 13:17:01 +00:00
ByteHamster 5a8bfc0ea4 Fix checkstyle 2021-01-02 21:25:15 +01:00
ByteHamster f4bbc5535c Added basic UI for editing tags 2021-01-02 21:17:40 +01:00
ByteHamster 19e427b524 Store tags in the database 2021-01-02 21:03:21 +01:00
ByteHamster 1eb47a2d6b Build tags based on feed properties 2021-01-02 20:45:05 +01:00
ByteHamster 3104232e5d Calculate layer in makeFlatDrawerData 2021-01-02 20:17:17 +01:00
Herbert Reiter 542dbd190c
Run more util tests with Robolectric (#4815) 2021-01-02 17:49:30 +01:00
Herbert Reiter 486de46b8f
Run DbWriterTest with Robolectric (#4814) 2021-01-02 17:46:10 +01:00
ByteHamster c4db0ffb1f Added support for folder counter 2021-01-02 17:25:53 +01:00
ByteHamster b107e6da95 Fixed crash when opening subscriptions screen 2021-01-02 17:16:57 +01:00
ByteHamster 3ed3379432 Merge branch 'develop' into folders 2021-01-02 16:58:43 +01:00
Herbert Reiter a52beda1f1
Run FeedFilterTest and FeedItemTest without Android emulator (#4807) 2021-01-02 16:53:39 +01:00
Herbert Reiter 0b715d5494
Run DateUtilsTest as Unit Test (#4805) 2021-01-02 12:59:26 +01:00
ByteHamster 34e9c31899 Revert back to device selection instead of linking
Until this is fixed upstream on the gpodder.net server.
2021-01-02 11:53:58 +01:00
ByteHamster 7b8208a2a7 Simplified gpodder login process 2021-01-02 11:53:58 +01:00
ByteHamster e96affe3c7 Tear down database after db cleanup test 2021-01-02 11:47:59 +01:00
ByteHamster 3411fcd10d Merge branch 'master' into develop 2021-01-01 20:04:08 +01:00
ByteHamster 773f98fafc Updated translations 2021-01-01 19:33:51 +01:00
ByteHamster f3c76e7677
Merge pull request #4822 from ByteHamster/update-export-design
Adapted design of html export
2021-01-01 18:31:38 +01:00
binarytoto f4a6b45627
Added content description for download cancel button (#4818) 2021-01-01 17:36:33 +01:00
ByteHamster dba736383b Adapted design of html export 2021-01-01 17:33:16 +01:00
ByteHamster dd541ced44
Merge pull request #4819 from damoasda/robolectric-DbTasksTest
Run DbTasksTest with Robolectric
2021-01-01 14:40:14 +01:00
ByteHamster 19e3159162
Merge pull request #4820 from damoasda/robolectric-DbNullCleanupAlgorithmTest
Run DbNullCleanupAlgorithmTest with Robolectric
2021-01-01 14:38:44 +01:00
Max Wittig 054a4f42a3
feat: add five, ten and twenty minutes sleep timer extend buttons (#4803) 2021-01-01 13:18:53 +01:00
Herbert Reiter 43c747d983 Run DbNullCleanupAlgorithmTest with Robolectric 2020-12-31 22:00:12 +01:00
Herbert Reiter 41119f6aed Run DbTasksTest with Robolectric 2020-12-31 21:14:52 +01:00
s3lph f2942033e6 Fix #4772: custom host not working on gpodnet sync 2020-12-30 16:01:24 +01:00
ByteHamster 5998e28497
Merge pull request #4811 from damoasda/robolectric-ExternalMediaTest
Run ExternalMediaTest with Robolectric
2020-12-30 15:53:42 +01:00
ByteHamster 8d50af58ac
Merge pull request #4797 from PtilopsisLeucotis/fix_translations
Fix translations
2020-12-30 15:19:09 +01:00
Herbert Reiter 994ee0e0a2
Fix #4775: Illegal connection pointer in Robolectric tests (awaitTermination) (#4794) 2020-12-30 15:15:23 +01:00
Herbert Reiter 90b8655ee9 Run ExternalMediaTest with Robolectric 2020-12-30 10:59:43 +01:00
PtilopsisLeucotis 0d4dc82496 Fixed wrong attribute translate to translatable in strings.xml 2020-12-22 19:20:18 +03:00
Herbert Reiter 20db2c2f5c Fix #4765: Disable autoDownload for local feeds 2020-12-20 21:51:49 +01:00
ByteHamster dcd40d4cac
Merge pull request #4774 from damoasda/robolectric-DownloadRequestTest
Run DownloadRequestTest with Robolectric
2020-12-20 18:51:46 +01:00
Herbert Reiter 72f4296150
Run AtomTextTest with Robolectric (#4771) 2020-12-20 16:06:14 +01:00
Herbert Reiter f6c39ad0fe Run DownloadRequestTest with Robolectric 2020-12-19 15:29:54 +01:00
Herbert Reiter c10d1a1d79
Refactoring: Remove class LangUtils (#4763) 2020-12-16 21:06:50 +01:00
ByteHamster e8351ffdc5
Merge pull request #4760 from damoasda/cleanup-imports
Refactoring: Remove unused import statements
2020-12-15 22:48:42 +01:00
ByteHamster 540656f61c
Merge pull request #4762 from ByteHamster/parallel-downloads
Added number to parallel downloads string
2020-12-15 22:46:08 +01:00
ByteHamster 6ef80bd69e Added number to parallel downloads string 2020-12-15 16:51:53 +01:00
Herbert Reiter 1d008317aa Remove unused import statements to reduce dependencies 2020-12-13 22:55:11 +01:00
ByteHamster e712a0eca9 Updated translations 2020-12-13 10:53:37 +01:00
Keunes f2c26b11c6
Correct website links (#4740)
With our new website, some of the links have changed. Also, the FAQ is no more.
2020-12-10 23:15:28 +01:00
ByteHamster b42e5e6eb5
Merge pull request #4733 from ByteHamster/fix-filter-dialog-api21
Fix filter dialog on old Android versions
2020-12-08 14:11:46 +01:00
Mats Wahlberg aeeb6eef37 Add the Let's Encrypt (ISRG Root X1) Root Certificate
This adds the ISRG Root X1 certificate to the backported certificates
introduced in #4497. This should solve the issue when DST Root X3
expires in 2021 (https://letsencrypt.org/2020/11/06/own-two-feet.html).
2020-12-05 14:53:28 +01:00
markamaze e4eacefeb1
added readonly message for feed items w/o media (#4711) 2020-12-03 22:57:58 +01:00
ByteHamster a510cb00fd Fix filter dialog on old Android versions 2020-12-03 22:33:53 +01:00
ByteHamster 779b1715e8 Fixed talkback description missing on chapters screen 2020-12-03 09:47:34 +01:00
ByteHamster b5047c9ead Updated translations 2020-12-02 11:45:28 +01:00
ByteHamster 8c7e209f0b
Merge pull request #4728 from ByteHamster/delete-feed-task
Use RxJava for deleting feeds
2020-12-02 11:39:05 +01:00
ByteHamster 101f4e34ed Use RxJava for deleting feeds 2020-12-02 11:11:13 +01:00
ByteHamster 4d1a7773d0 Catch errors when local feeds fail to update 2020-12-02 10:30:54 +01:00
ByteHamster d20557c1b0
Merge pull request #4721 from tonytamsf/share-by-timecode
share by timecode
2020-11-30 20:00:18 +01:00
ByteHamster 28064ffa19
Merge pull request #4707 from tonytamsf/pause-button-android-auto
pause button for autos
2020-11-30 19:57:48 +01:00
Tony Tam 5661a85eab
Show replay button on the current chapter. (#4706) 2020-11-30 19:56:19 +01:00
Tony Tam 4112a65c20 indent with spaces 2020-11-30 06:17:10 -08:00
Tony Tam 3f104f7e5a
fix bug with how we count downloaded media, show a meaningful messages (#4714) 2020-11-30 11:29:16 +01:00
markamaze c1482fe5b8
Moved export log function to menu and added confirm dialog (#4712) 2020-11-30 11:20:02 +01:00
Tony Tam afb151eb3f share by timecode 2020-11-27 11:32:56 -08:00
ByteHamster 66ee677ebe
Merge pull request #4718 from tonytamsf/queue-image-button
add an icon to the Android Auto queue
2020-11-26 18:24:56 +01:00
Tony Tam 28f72aa586
Fix timing issue with speed settings per podcast (#4713)
when moving to the next episode when phone is locked
2020-11-26 17:48:16 +01:00
Tony Tam 8f0cbb2a88 show number in queue 2020-11-25 17:10:47 -08:00
Tony Tam a8fbb97cfe add an icon to the Android Auto queue 2020-11-25 16:52:20 -08:00
Tony Tam ed47e27baa line > 120 2020-11-22 18:25:33 -08:00
Tony Tam aebc62d136 only show the play button for non-car mode, since that is taken care of already 2020-11-22 18:20:10 -08:00
ByteHamster 41cdeec30c
Merge pull request #4698 from ByteHamster/notification-icon-resolution
Increased resolution of notification icon
2020-11-22 16:09:48 +01:00
Tony Tam 69670e2153
higher contrast color for search bar (#4704) 2020-11-22 15:57:47 +01:00
Tony Tam d9151351b0 pause button for autos 2020-11-21 18:20:17 -08:00
ByteHamster 9bd0babed5 Partially revert "Performance improvements"
Some problems with wrong dates might be caused by the
static date parser no longer being thread safe.

This partially reverts commit 77ef239336.
2020-11-21 23:08:39 +01:00
ByteHamster 9989bbff9b Increased resolution of notification icon
The expanded media style notification has a higher resolution than
normal large icons
2020-11-19 11:27:40 +01:00
ByteHamster 4b252250c0 Merge branch 'master' into develop 2020-11-19 11:24:31 +01:00
Herbert Reiter d68b45fd30 Refactoring: Remove callback functions with constant value 2020-11-15 14:26:07 +01:00
ByteHamster 34f9f01ba1 Updated translations 2020-11-15 12:37:00 +01:00
ByteHamster 8a82b3709d
Merge pull request #4690 from ByteHamster/fix-wording
Fixed wording of counter>0 filter
2020-11-15 12:31:41 +01:00
ByteHamster 02def17f93
Merge pull request #4689 from ByteHamster/stop-foreground-before-stop
Stop foreground in DownloadService before calling stop
2020-11-15 12:28:12 +01:00
ByteHamster 97b557a3b6
Merge pull request #4684 from ByteHamster/fix-null-pubdate-crash
Fixed comparator method contract when date is null
2020-11-15 12:26:52 +01:00
ByteHamster 2d24213171 Fixed wording of counter>0 filter 2020-11-15 12:18:44 +01:00
ByteHamster f5bbdf1666 Stop foreground in DownloadService before calling stop 2020-11-14 18:08:52 +01:00
Herbert Reiter 3aa6b37834 Refactoring: Remove interface DBTasksCallbacks and class DBTasksCallbacksImpl 2020-11-14 11:32:49 +01:00
ByteHamster cabe1a0f66 Fixed comparator method contract when date is null 2020-11-11 22:43:27 +01:00
ByteHamster 4decd1d9fe
Merge pull request #4680 from ByteHamster/fix-file-size-stats
Fixed file size statistics
2020-11-11 22:21:00 +01:00
ByteHamster 0e84f5d90c
Merge pull request #4666 from ByteHamster/db-corruption
Use lazy singleton instead of Bill Pugh singleton
2020-11-11 22:04:54 +01:00
ByteHamster eea503e3e0
Merge pull request #4672 from ByteHamster/fix-update-without-pubdate
Fixed updating feeds where some items do not have a pubdate
2020-11-11 21:56:59 +01:00
ByteHamster 24c15cfc61 Fixed file size statistics 2020-11-09 23:27:05 +01:00
ByteHamster 2249e91578 Update local folder properties on refresh
Fixes updated translations
2020-11-09 23:10:50 +01:00
ByteHamster fe3a44d5fa Fixed updating feeds where some items do not have a pubdate 2020-11-09 12:37:33 +01:00
ByteHamster 8f25f5830a Use lazy singleton instead of Bill Pugh singleton 2020-11-08 09:36:13 +01:00
ByteHamster 0ae6ca8d04 Added support for showing feed item images on Android Auto 2020-11-07 09:29:11 +01:00
ByteHamster 8d2df1afa1 Merge branch 'master' into develop 2020-11-06 23:17:33 +01:00
ByteHamster 29f46d97c0
Merge pull request #4659 from ByteHamster/fix-playback
Fix using wrong playable object
2020-11-06 22:57:57 +01:00