Castopod
/
AntennaPod
mirror of https://github.com/AntennaPod/AntennaPod.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refactor method: Use early return instead of late return to make the code more readable

This commit is contained in:
Herbert Reiter 2021-01-13 21:11:17 +01:00
parent 1f329cdde0
commit 5d1ef31a4a
1 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
core/src/main/java/de/danoeh/antennapod/core/feed/LocalFeedUpdater.java
View File

@ -116,33 +116,24 @@ public class LocalFeedUpdater {
*/
@NonNull
static String getImageUrl(@NonNull Context context, @NonNull DocumentFile documentFolder) {
String imageUrl = null;
// look for special file names
for (String iconLocation : PREFERRED_FEED_IMAGE_FILENAMES) {
DocumentFile image = documentFolder.findFile(iconLocation);
if (image != null) {
imageUrl = image.getUri().toString();
break;
return image.getUri().toString();
}
}
// use the first image in the folder if existing
if (imageUrl == null) {
for (DocumentFile file : documentFolder.listFiles()) {
String mime = file.getType();
if (mime != null && (mime.startsWith("image/jpeg") || mime.startsWith("image/png"))) {
imageUrl = file.getUri().toString();
break;
}
for (DocumentFile file : documentFolder.listFiles()) {
String mime = file.getType();
if (mime != null && (mime.startsWith("image/jpeg") || mime.startsWith("image/png"))) {
return file.getUri().toString();
}
}
// use default icon as fallback
if (imageUrl == null) {
imageUrl = getDefaultIconUrl(context);
}
return imageUrl;
return getDefaultIconUrl(context);
}
/**