Commit Graph

10225 Commits

Author SHA1 Message Date
Vancha 24dc5b10e8 Translated using Weblate (Frisian)
Currently translated at 40.6% (905 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/fy/
2022-05-26 07:32:08 +00:00
Glandos e1285aa50b Translated using Weblate (French)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/fr/
2022-05-26 07:32:08 +00:00
Auri B. P 3336249b00 Translated using Weblate (Catalan)
Currently translated at 84.2% (1874 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/ca/
2022-05-26 07:32:07 +00:00
Johannes Marbach 92a140b504 Add unit tests for filter/map logic 2022-05-25 20:50:58 +02:00
Adam Brown 096db6c35d giving arugment a proper name 2022-05-25 17:34:00 +01:00
Adam Brown 0675b7c16c
Merge pull request #5995 from vector-im/feature/adm/ftue-sign-in
FTUE - Sign in
2022-05-25 17:30:03 +01:00
Johannes Marbach 9e084ec372 Inject permission utils 2022-05-25 16:22:16 +02:00
Johannes Marbach 6ec6d41aa9 Make permission utils instantiable and throw when permission request is null 2022-05-25 15:53:58 +02:00
Benoit Marty 8f06415744 Fix compilation issue after rebase 2022-05-25 15:08:13 +02:00
Maxime NATUREL c8fb034c57
Merge pull request #6128 from vector-im/feature/mna/PSF-999-auto-refresh-db
[Location sharing] - Update DB entity when a live is timed out (PSF-999)
2022-05-25 14:59:54 +02:00
Adam Brown 86c9e60129 formatting 2022-05-25 13:34:08 +01:00
Adam Brown f6190b125c removing extra line 2022-05-25 13:34:08 +01:00
Adam Brown 75d038b058 adding test case around invalid deeplinks within the onboarding flow 2022-05-25 13:34:08 +01:00
Adam Brown 797e0ee706 creating a build meta abstraction for allowing testing classes with build version checks 2022-05-25 13:34:08 +01:00
Adam Brown ea7df9b673 lifting unavailable homeserver rendering to the activity/ftuevariant
- the viewmodel is now responsible for inferring connectivity errors and providing a retry action
2022-05-25 13:34:08 +01:00
Adam Brown 100aa24021 adding helper for inferring if the device has connectivity, this helps with breaking down UnknownHost exceptioncauses and shouldn't be used for checking offline status 2022-05-25 13:34:07 +01:00
Adam Brown 59afb5cf4c downscoping the possible action types when selecting homeservers 2022-05-25 13:34:07 +01:00
Adam Brown b8418f97dc extracting server selection branches to their own functions 2022-05-25 13:34:07 +01:00
Adam Brown 690fda180c providing dedicated reset action for resetting invalid deeplink homeserver
- also fixes the usecase screen becoming stuck with an invalid homeserver deeplink
2022-05-25 13:34:07 +01:00
Maxime NATUREL aa65d82341 Adding unit tests for ViewModel 2022-05-25 14:05:14 +02:00
Maxime NATUREL 65d7ec8696 Adding unit tests for use case to get the list of current running lives 2022-05-25 14:05:14 +02:00
Maxime NATUREL 5efe26c7dd Fix code quality issues 2022-05-25 14:05:14 +02:00
Maxime NATUREL 8145049315 Fix potential access to null value 2022-05-25 14:05:14 +02:00
Maxime NATUREL 7ef91ce717 Adding unit tests for view state mapper 2022-05-25 14:05:14 +02:00
Maxime NATUREL 401027e919 Adding end of live timestamp into view state 2022-05-25 14:05:14 +02:00
Maxime NATUREL bd473375a1 Fix no text visible if using direct pin drawable 2022-05-25 14:05:14 +02:00
Maxime NATUREL 40d8d5c605 Updating user pins on location update 2022-05-25 14:04:22 +02:00
Maxime NATUREL 81b90df909 Observe the current live location shares in a room 2022-05-25 14:04:22 +02:00
Maxime NATUREL 5410b61ae3 Show user pins with correct zoom when map is first opened 2022-05-25 14:03:37 +02:00
Maxime NATUREL d6029210d0 Adding use case to get live location of users 2022-05-25 14:03:37 +02:00
Maxime NATUREL 44ca82bbef Adding ViewModel to Activity 2022-05-25 14:03:37 +02:00
Johannes Marbach f5a621a6d5
Merge pull request #6140 from vector-im/johannes/widget-screen-rotation
Prevent widget web view from reloading on screen / orientation change (PSF-1034)
2022-05-25 13:42:24 +02:00
Johannes Marbach 580bbd60e7 Appease the linter 2022-05-25 13:01:42 +02:00
Johannes Marbach 59c13bf8c1 Make widget web view request system permissions for camera and microphone
Previously the widget web view prompted to grant the widget permissions but it didn't
actually request those permissions from the system. So if the web view requested, e.g.
the camera permission but the app hadn't previously been granted that permission, the
web view wouldn't get camera access even when the widget permission request had been
confirmed.

With this commit, the app will also request camera and microphone permissions from the
system when needed.

Signed-off-by: Johannes Marbach <johannesm@element.io>
2022-05-25 12:35:43 +02:00
Adam Brown 8c44c9828c fixing listener import 2022-05-25 10:22:27 +01:00
Adam Brown 8b2132c6dd fixing detekt/formatting issues 2022-05-25 10:22:27 +01:00
Adam Brown 137fe89938 hiding username/password fields when the homeserver doesn't support them and showing SSO options when available 2022-05-25 10:22:27 +01:00
Adam Brown bc2a99c3cf matching variable name with type 2022-05-25 10:22:27 +01:00
Adam Brown 610c1d1150 extracting sso buttons render method to reduce duplication 2022-05-25 10:22:27 +01:00
Adam Brown d86c12dc7a extracting duplicated field resetting logic 2022-05-25 10:22:27 +01:00
Adam Brown fb1a686f90 extracting the login error handling to its own class 2022-05-25 10:22:27 +01:00
Adam Brown d1bafc531e removing input footer fields, they're only needed for sign up, not login 2022-05-25 10:22:27 +01:00
Adam Brown b2af918969 using correct copy for the login validation errors
- extracts helpers to make the logic more declarative
2022-05-25 10:22:27 +01:00
Adam Brown 25b81c2952 creating subtype for register/login authentication types 2022-05-25 10:22:26 +01:00
Adam Brown c3ce887e33 minor refactors
- extracting login fields validation
- renaming xml fields to login
- renaming direct login property to matrixId
2022-05-25 10:17:51 +01:00
Adam Brown b3bbb0329e directing to the combined login after homeserver check
- also removes the subtitle view which is not needed for login
2022-05-25 10:17:51 +01:00
Adam Brown 4b6f74364d adding dedicated login action 2022-05-25 10:17:51 +01:00
Adam Brown 34e97112a4 adding feature flag and redirecting the sign in flow
- temporarily to the combined register fragment
2022-05-25 10:17:51 +01:00
Adam Brown ae9922a731
Merge pull request #6136 from vector-im/feature/adm/foss-avoid-gms-location-provider
Excluding the gms play-service-location from maplibre for fdroid builds
2022-05-25 08:59:18 +01:00
Glandos 71706bc6a6 Translated using Weblate (French)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/fr/
2022-05-25 07:14:58 +00:00
Jean-Luc KABORE-TURQUIN d0628129f5 Translated using Weblate (French)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/fr/
2022-05-25 07:14:56 +00:00
Adam Brown b4b2b97eb1
Merge pull request #6068 from vector-im/dependabot/gradle/vanniktechEmoji-0.12.0
Bump vanniktechEmoji from 0.9.0 to 0.12.0
2022-05-24 16:26:06 +01:00
Johannes Marbach f95853a7b3 Prevent widget web view from reloading on screen / orientation change (PSF-1034)
Signed-off-by: Johannes Marbach <johannesm@element.io>
2022-05-24 16:29:38 +02:00
Adam Brown bec72264cd excluding the gms play-service-location optional transistive dependency for the fdroid variant
- fixes fdroid being unable to compile the project due to a non foss dependency
2022-05-24 10:10:03 +01:00
Jeremy b131848b72
Fix grammar in strings in strings.xml
`room_list_people_empty_body` and `room_list_rooms_empty_body`
2022-05-24 14:12:49 +12:00
Adam Brown a59b8bf50c
Merge pull request #6065 from vector-im/feature/adm/matrix-org-ordering
FTUE - Only override sign up steps for `matrix.org`
2022-05-23 21:24:48 +01:00
Maxime NATUREL b05fc763ae Rely only on isActive field on UI side 2022-05-23 17:34:52 +02:00
ericdecanini a07c1b8afa Removes top bar back arrow 2022-05-23 13:46:53 +01:00
Maxime NATUREL 9a38d59f9a
Merge pull request #6092 from vector-im/feature/mna/PSF-888-navigation
[Location sharing] - Navigation to Map view from live location message (PSF-888)
2022-05-23 13:54:04 +02:00
Benoit Marty fd252dbaff
Merge pull request #5856 from ofalvai/bugfix/ofa/read-recept-text-scale
Use fixed text size in read receipt counter
2022-05-23 13:41:03 +02:00
Adam Brown 98999c754f
Merge pull request #5868 from vector-im/feature/adm/ftue-email-verification
[FTUE] - Email input and verification
2022-05-23 11:14:46 +01:00
Maxime NATUREL 7bb73ffb57 Making the layout file more generic 2022-05-23 11:41:33 +02:00
Maxime NATUREL b331521e93 Improving code in Fragment 2022-05-23 11:30:57 +02:00
Maxime NATUREL 721d7cb6a0 Remove commented code 2022-05-23 11:30:35 +02:00
Maxime NATUREL c46aaa24a5 Using @AndroidEntryPoint in Fragment 2022-05-23 10:40:52 +02:00
Benoit Marty 71e14ea43b
Merge pull request #6110 from vector-im/defect/jorgem/PSE-613-fix-multi-invites-to-room
Fix sending multiple invites to a room reaching only one or two people
2022-05-23 09:39:47 +02:00
Jorge Martín 96e3544a47 Fix sending multiple invites to a room reaching only one or two people 2022-05-23 08:14:32 +02:00
Auri B. P 76fc3b5336 Translated using Weblate (Catalan)
Currently translated at 83.3% (1855 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/ca/
2022-05-22 20:32:05 +00:00
anoloth 9779e9b9a5 Translated using Weblate (Lao)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/lo/
2022-05-21 17:32:31 +00:00
Jeff Huang 7d9cb1dc0c Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/zh_Hant/
2022-05-21 17:32:13 +00:00
Ihor Hordiichuk b784c0fcc2 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/uk/
2022-05-21 17:32:13 +00:00
LinAGKar 3826b7ba28 Translated using Weblate (Swedish)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/sv/
2022-05-21 17:32:13 +00:00
Jozef Gaal 096e51951a Translated using Weblate (Slovak)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/sk/
2022-05-21 17:32:12 +00:00
homocomputeris 79858a6560 Translated using Weblate (Russian)
Currently translated at 97.6% (2172 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/ru/
2022-05-21 17:32:12 +00:00
lvre b12e0cd9f3 Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/pt_BR/
2022-05-21 17:32:10 +00:00
Didek 946353aeb9 Translated using Weblate (Polish)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/pl/
2022-05-21 17:32:10 +00:00
Piotr Strebski 9710447ea3 Translated using Weblate (Polish)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/pl/
2022-05-21 17:32:09 +00:00
random 165b8d1b93 Translated using Weblate (Italian)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/it/
2022-05-21 17:32:09 +00:00
Linerly d307349ae2 Translated using Weblate (Indonesian)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/id/
2022-05-21 17:32:09 +00:00
Danial Behzadi 7ff9566788 Translated using Weblate (Persian)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/fa/
2022-05-21 17:32:08 +00:00
Priit Jõerüüt 49acc6704f Translated using Weblate (Estonian)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/et/
2022-05-21 17:32:08 +00:00
John Doe aac075fa89 Translated using Weblate (Spanish)
Currently translated at 99.8% (2221 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/es/
2022-05-21 17:32:08 +00:00
waclaw66 422487ea9f Translated using Weblate (Czech)
Currently translated at 100.0% (2225 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/cs/
2022-05-21 17:32:07 +00:00
Auri B. P 97b2dd3d14 Translated using Weblate (Catalan)
Currently translated at 83.3% (1854 of 2225 strings)

Translation: Element Android/Element Android App
Translate-URL: https://translate.element.io/projects/element-android/element-app/ca/
2022-05-21 17:32:07 +00:00
Benoit Marty 6e3979a32d Fix test compilation 2022-05-20 21:14:42 +02:00
Benoit Marty ede784684f Change in KeysBackupService: `isEnabled` and `isStucked` are now fun, and `state` has been renamed to `getState` and is now a fun. 2022-05-20 21:14:42 +02:00
Benoit Marty 1ab4ae9eac Extract KeyRef to its own file 2022-05-20 21:14:42 +02:00
Benoit Marty d3d17ebbcb Extract HttpPusher to its own file 2022-05-20 21:14:42 +02:00
Benoit Marty 768df330b5 Rename `currentThreePid` to `getCurrentThreePid` 2022-05-20 21:14:42 +02:00
Benoit Marty e6c8ffd1b8 Change `val` to `fun` on the SDK interfaces.
Dokka will generate a better documentation (`Functions` and `Properties` are 2 distinct tab), and for Service it's better to have only `fun`
2022-05-20 21:14:42 +02:00
Onuray Sahin 109b381e2e
Merge pull request #6103 from vector-im/feature/ons/fix_live_location_flickering
Glide - Use current drawable while loading new static map image
2022-05-20 18:36:12 +03:00
Adam Brown 2d351aa60f applying api changes 2022-05-20 15:20:24 +01:00
Adam Brown c71f9c81cd provides a dedicated job for the email verification polling to allow it to be cancelled when resetting the auth flow
- extracts an auto cancelling job delegate
2022-05-20 13:10:03 +01:00
Adam Brown 2378643071 adding missing punctuation 2022-05-20 12:13:09 +01:00
Adam Brown 4bcdaa309e removing unused imports 2022-05-20 12:11:44 +01:00
Adam Brown 9fddd09f1c using direct string reference for design preview 2022-05-20 12:11:44 +01:00
Adam Brown 47635aae6e avoiding cancelling the polling job when resending verification email 2022-05-20 12:11:44 +01:00
Adam Brown bc5ebb20b5 adding gradient background to xml preview 2022-05-20 12:11:44 +01:00
Adam Brown 0979d56a36 inlining single use extension function 2022-05-20 12:11:44 +01:00
Adam Brown 4dc8d23826 removing unneeded state reacting when entering email address for verification 2022-05-20 12:11:44 +01:00
Adam Brown 641c06f10d removing this usage for project consistency 2022-05-20 12:11:44 +01:00
Adam Brown 80b6b77a3a reusing editText unboxing extension 2022-05-20 12:11:44 +01:00
Adam Brown c414f80fa6 adding listener suffix for consistency 2022-05-20 12:11:44 +01:00
Adam Brown c4834a44d1 aligning the carousel listener removal with the viewLifecycleOwner
- fixes crash where the scheduled callbacks can attempt to trigger after the view has been destroyed
2022-05-20 12:11:44 +01:00
Adam Brown a4b5d1819d renaming sdk model to matrix 2022-05-20 12:11:44 +01:00
Adam Brown 8136f57b5e making use of the view lifecycle scope for the view based fragment logic 2022-05-20 12:11:44 +01:00
Adam Brown c0efd9f1af updating ignored result register action as the one being used is now consumed 2022-05-20 12:11:44 +01:00
Adam Brown 8e7ae5e9d2 removing extra end of file lines 2022-05-20 12:11:44 +01:00
Adam Brown 350643c8a4 resetting authentication state when the viewmodel resets whilst in the email entry step - matching legacy flow 2022-05-20 12:11:44 +01:00
Adam Brown 9cc646760a removing copied back behaviour, isn't needed for the email entry screen 2022-05-20 12:11:44 +01:00
Adam Brown 8a53eafa72 adding gradient background to the waiting for verification screen, matching designs
- renames drawable which redirects to the attribute colorBackground
2022-05-20 12:11:44 +01:00
Adam Brown eb4d31e955 extracting reusable logic for styling terminating full stops and applying to the waiting for verification title 2022-05-20 12:11:44 +01:00
Adam Brown 817d692471 renaming xml ids to the email verification domain and attaching the click logic for resending verification emails 2022-05-20 12:11:44 +01:00
Adam Brown 4964c9f151 showing loading spinner when returning to the email verification waiting screen 2022-05-20 12:11:44 +01:00
Adam Brown 02b6916487 adding UI for updated email verification waiting screen 2022-05-20 12:11:44 +01:00
Adam Brown b2d8163aad adding unit test around polling for email verification 2022-05-20 12:11:44 +01:00
Adam Brown 074e5bcfb6 porting registration email verification polling to the registration action handler instead of the fragment 2022-05-20 12:11:44 +01:00
Adam Brown d4a5b71a4d adding email input FTUE screen
- lifts the threepid email error handling to the RegistrationActionHandler rather than having the UI infer success from a 401
2022-05-20 12:11:44 +01:00
Onuray Sahin 2b681a43c8 Use current drawable while loading new map image. 2022-05-20 12:16:35 +03:00
Benoit Marty f5d0663b06 Remove non needed extra spaces 2022-05-20 09:48:17 +02:00
Benoit Marty 51fe7b9a93 Detekt: Fix OutdatedDocumentation 2022-05-20 09:48:05 +02:00
ClaireG b379ef46ec
Revert: Use member name instead of room name in DM creation item (#6049) 2022-05-19 14:14:58 +00:00
Olivér Falvai f036d35829 Merge branch 'develop' into dependency-cleanup 2022-05-19 12:27:09 +02:00
Onuray Sahin 2e2dffd9c9 Merge branch 'develop' into live_location_labs_flag
* develop:
  Space explore rooms screen alignment with design in figma (#5834)
  leaving space aligned with ios (#5942)
  Fix usage of System.currentTimeMillis(). This a bit mocky but anyway it's better to use SystemClock.elapsedRealtime() for this case.
2022-05-19 12:52:05 +03:00
fedrunov a30912f688
Space explore rooms screen alignment with design in figma (#5834) 2022-05-19 11:49:20 +02:00
fedrunov 18842b5e3d
leaving space aligned with ios (#5942) 2022-05-19 11:49:08 +02:00
Onuray Sahin 51ac6f22d7 Labs flag added for enabling live location sharing. 2022-05-19 12:01:42 +03:00
ericdecanini 93264812c0 Adds back navigation to spaces 2022-05-19 10:20:46 +02:00
Michael Kaye 5260e729ac
Merge pull request #6095 from vector-im/michaelk/correct_well_known_behaviour
Well known lookups should be to port 443 only.
2022-05-18 16:50:43 +01:00
Benoit Marty 12644e9915
Merge pull request #5947 from vector-im/feature/bma/renaming
Small changes
2022-05-18 16:27:48 +02:00
Michael Kaye e66284fbd3 Rename 'getDomain' to 'getServerName'.
In the context of matrix IDs, this removes the leading @name: leaving the hostname or hostname and port.
2022-05-18 15:21:33 +01:00
Benoit Marty 7ae3f6ea40
Merge pull request #6083 from vector-im/feature/bma/remove_badge
Remove ShortcutBadger lib and usage (it was dead code)
2022-05-18 16:19:37 +02:00
Maxime NATUREL 738ce18a2f
Merge pull request #5989 from vector-im/feature/mna/PSF-884-location-view
[Location sharing] - Message for live sharing in timeline (PSF-884)
2022-05-18 15:39:51 +02:00
Benoit Marty 3a6c03a895 Ah it was used in Gplay variant. Anyway I think we can still remove this now. 2022-05-18 15:05:23 +02:00
Maxime NATUREL 5265856772 Remove unused imports 2022-05-18 14:44:44 +02:00
Maxime NATUREL 4864980a5a Enable navigation only from running state item 2022-05-18 14:44:44 +02:00
Maxime NATUREL 23e8cad10f Rollback to Fragment to be able to use Maverick capabilities 2022-05-18 14:44:44 +02:00
Maxime NATUREL 26cddd2d0d Use SupportMapFragment instead of custom fragment 2022-05-18 14:44:44 +02:00
Maxime NATUREL 54d7d47dfc Updating the title of the map view screen 2022-05-18 14:44:44 +02:00
Maxime NATUREL 52c0fa41c6 Creation of map view screen and basic navigation 2022-05-18 14:44:44 +02:00
Olivér Falvai 388e35e828 Remove even more deps 2022-05-18 14:19:11 +02:00
Olivér Falvai 2dcc120cf7 Merge remote-tracking branch 'origin/develop' into dependency-cleanup
# Conflicts:
#	build.gradle
#	dependencies.gradle
2022-05-18 11:47:21 +02:00
ericdecanini d12ab17516 Fixes lint errors 2022-05-18 11:29:23 +02:00
Michael Kaye f7303789a0
Merge pull request #6025 from vector-im/michaelk/skip_tests_failing_on_ci
Improve test handling in CI
2022-05-18 09:51:17 +01:00
Maxime NATUREL e9d93194f1 Adding comments on some strings and removing non necessary plural 2022-05-18 09:48:34 +02:00
Benoit Marty adb537006a Remove ShortcutBadger lib and usage (it was dead code) 2022-05-18 09:06:04 +02:00
Benoit Marty 8f7789f269 Version++ 2022-05-17 21:28:11 +02:00
ericdecanini 03acf4505a Uses second layout to center room summary item title 2022-05-17 18:03:34 +02:00
Benoit Marty 553f8aa37e Remove empty translations 2022-05-17 16:31:15 +02:00
Benoit Marty ff46791df9 Let's keep this one even if not used. 2022-05-17 16:23:48 +02:00