FindProtobuf provided by CMake forgets that it should depend on libabsl,
and link fails.
This change makes it to use files provided by Protobuf library, which
don't miss that important detail. That also required switch from
protobuf_generate_cpp() to protobuf_generate() because that's the
function which it has. FindProtobuf.cmake also provides
protobuf_generate() but only since CMake 3.13.
Fix#7272
In f3837f95db61a8d79c40c8da8467c7e502fc2156, QTSINGLECOREAPPLICATION_LIBRARIES was mistakenly removed, which prevents building with USE_SYSTEM_QTSINGLEAPPLICATION enabled.
This seem to have gone broken over time.
As far as I can tell, upstream QtSingleApplication works fine!
Signed-off-by: Marcus Müller <marcus_clementine@baseband.digital>
This policy allowed included files and modules to affect policy in the
parent scope. Besides the top level, 3rdparty/libprojectm is the only
place where old policy is set.
Reference: https://cmake.org/cmake/help/latest/policy/CMP0011.html
Compatibility with versions prior to 2.8.12 is being deprecated,
resulting in build warning messages. The minimum for the official
supported distros is 3.7.2 (Stretch), so the version could be moved
forward when newer features are required.
Reference: https://cmake.org/cmake/help/v3.19/release/3.19.html#deprecated-and-removed-features
Move /src/config.h to /include/clementine-config.h. The new name
prevents conflict with 3rdparty/taglib/config.h. A stub src/config.h will
remain for a transition period. This is a first step in eliminating the
dependency of /ext components on /src.
* Qt5::Test is not required in the global QT_LIBRARIES definition
* Qt5::DBus had already been optional, drop bogus pkgconfig search
This partially reverts commit 4321ecf7d26c5eed577a97d230786bb9f56ea37f.
* Find X11 only once, in root CMakeLists.txt
Since we have HAVE_X11, use HAVE_X11 in cmake.
This tool was once used generate data/lyrics/ultimate_providers.xml from
the sites.js file. Judging by the file histories, recent changes has
been done directly in the xml file, bypassing this tool. Moreover,
sites.js has contained syntax errors for the past three years without
anyone noticing.
Furthermore, this tool is the only part of Clementine that uses
QtWebKit. Since support for this has been removed in both the master and
qt5 branch it won't build anyway.
