Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
mirror of https://github.com/clementine-player/Clementine synced 2025-02-02 20:36:44 +01:00
Code Issues Releases Wiki Activity
6,461 Commits 23 Branches 550 Tags 193 MiB
Commit Graph

6461 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chocobozzz
e6e189967d Merge remote-tracking branch 'upstream/master' into qt5 2016-02-29 18:03:02 +01:00
Clementine Buildbot
357af2263b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-29 10:00:41 +00:00
Clementine Buildbot
9252925a56 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-22 10:00:42 +00:00
John Maguire
51c1c36934 Merge pull request #5263 from simark/fix-moodbar-crash 
moodbar: check QSlider max/min before using them in division
 2016-02-18 14:17:58 +00:00
Simon Marchi
725e1d8f0d moodbar: check QSlider max/min before using them in division 
When switching playback from an item for which the moodbar is not
displayed (e.g. an internet stream), to an item for which it is
displayed (e.g. a local mp3 file), Clementine sometimes crashes.

This happens because the slider_opt->maximum and slider_opt->minimum
have the value 0 (their default value), and the difference is used as a
divisor.  This gives a division by 0, and a SIGFPE.

This problem has been fixed in commit af42cce.  However, when a9f9b0e
reverted 3f79fa5, a little to much was reverted and we lost what af42cce
did.  This patch re-introduces the fix.

Fixes #5261

moodbar: Add comment
 2016-02-18 09:15:44 -05:00
John Maguire
4cd20ffdaa Cope with receiving no images from spotify 2016-02-17 18:06:30 +00:00
John Maguire
abc6370b00 Don't force native windows on OS X with qt5 2016-02-17 17:14:14 +00:00
John Maguire
52c72f95ba Too clever for old GCC versions. 2016-02-17 16:42:03 +00:00
John Maguire
1304f8898e Fetch artist images from spotify. 2016-02-17 15:55:37 +00:00
John Maguire
5b4c0c920c Blacklist artist images from echonest using dead last.fm server. 2016-02-17 15:55:37 +00:00
John Maguire
a80e241bbe Make image requests follow redirects 2016-02-17 15:55:32 +00:00
John Maguire
b0322e7e7d Cleanup ApplicationImpl 2016-02-15 17:41:39 +00:00
John Maguire
20bfade965 Hide Application classes behind pimpl. 
This should also fix the build on windows where gcc gets confused as
libmygpo declares DELETE as part of an enum and mingw #defines DELETE in
winnt.h
 2016-02-15 17:39:50 +00:00
Clementine Buildbot
b3d5cabdc1 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-15 10:00:41 +00:00
John Maguire
affb215a52 Move cover providers initialisation later in startup. 2016-02-12 16:25:01 +00:00
John Maguire
dcdd81d69f Moar Lazy migrations 2016-02-12 16:10:56 +00:00
John Maguire
b99b090adc Refactor simple dialogs to use Lazy 2016-02-12 16:01:35 +00:00
John Maguire
74e6a1744f Convert edit tag & settings dialog to Lazy. 2016-02-12 15:56:08 +00:00
John Maguire
589f2ff62e Lazy initialise organise dialog 2016-02-12 12:25:35 +00:00
John Maguire
0cf83b19ee Eagerly initialise TagReaderClient 2016-02-12 12:07:26 +00:00
John Maguire
86a6345995 Merge pull request #5251 from santigl/gainLabel 
EqualizerSlider: move include from .h to .cpp
 2016-02-11 18:03:18 +00:00
Santi
1fa4201926 EqualizerSlider move include from .h to .cpp 2016-02-11 14:59:39 -03:00
John Maguire
7d1abbda55 Don't connect action signals multiple times. 
Fixes #5249
 2016-02-11 17:07:00 +00:00
John Maguire
ce3ba02749 Fix songkick concert fetching 2016-02-11 16:59:40 +00:00
John Maguire
d06f337ade Remove special deletion of objects in threads. 
Fixes #5250
 2016-02-11 16:31:08 +00:00
John Maguire
729dc8e281 Merge pull request #5182 from abika/fix-fetch_edit_dialog 
Fix bug in edit tag dialog when fetching (2)
 2016-02-11 15:30:51 +00:00
John Maguire
f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Alexander Bikadorov
56e95839f0 Revert to iterator usage in edit tag dialog 2016-02-11 16:09:38 +01:00
John Maguire
6844dcc140 Remove unused variable 2016-02-11 14:19:01 +00:00
John Maguire
a7ca007e24 Tidy up lazy implementation. 2016-02-11 14:09:36 +00:00
John Maguire
4c8b1d8143 Add lazy initialisation helper. 2016-02-11 13:46:23 +00:00
John Maguire
ea12cfacac Merge pull request #5209 from narunlifescience/patch-1 
move duplicated code to annonymous namespace static function
 2016-02-11 11:58:06 +00:00
Arun Narayanankutty
b4fe7ac7e2 move duplicated code to annonymous namespace static function 
update
 2016-02-11 05:45:08 -06:00
John Maguire
0ea84e129e Merge pull request #5210 from narunlifescience/patch-2 
Use icon loader for remaining icons
 2016-02-11 11:24:09 +00:00
narunlifescience
b6bf54be6c remove magic numbers 2016-02-11 04:41:37 -06:00
John Maguire
100222477c Merge pull request #5218 from santigl/gainLabel 
Add gain label to EqualizerSlider
 2016-02-10 15:46:47 +00:00
Santi
ec89bd3ea2 Add gain label to equalizerSlider 2016-02-10 12:44:33 -03:00
Alexander Bikadorov
9d413ad01d Edit tag dialog: merged duplicate code 2016-02-09 21:56:22 +01:00
John Maguire
1cc889fbfc Only set lastfm to https for liblastfm1 2016-02-09 15:17:20 +00:00
John Maguire
be471e1792 Merge pull request #5181 from Korvox/master 
OPML imports should prefer title to text attributes for podcast names
 2016-02-09 14:05:10 +00:00
John Maguire
80bf644f8a Merge pull request #5214 from narunlifescience/patch-4 
Remove unwanted lines from playlistcontainer
 2016-02-09 13:59:15 +00:00
John Maguire
05c0d647f8 Merge pull request #5219 from narunlifescience/patch-5 
use normal text color for volume
 2016-02-09 13:56:15 +00:00
John Maguire
8dd933b265 Merge pull request #5233 from naokiiwakami/5151 
Fix issue in checking existence of media files pointed by CUE files
 2016-02-09 13:55:40 +00:00
John Maguire
3ef46f016f Revert "Don't use https since it's not supported on windows and ubuntu 12.04" 
This reverts commit ab5e86fec9ec29b8fb4c114f74b3a4b9a95697d0.
 2016-02-09 11:52:04 +00:00
Clementine Buildbot
9ba41411d3 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-08 10:00:52 +00:00
ArnaudBienner
50c1fcb112 Merge pull request #5213 from ivan-leontiev/fix-tree-view 
Resolve some issues related to "AutoExpandingTreeView"
 2016-02-07 00:32:24 +01:00
John Maguire
20de7a1a81 Don't leak AudioScrobbler. 2016-02-04 17:13:42 +00:00
John Maguire
ccedb0fdc6 At least try to authenticate with last.fm over https 2016-02-04 17:12:42 +00:00
Andreas
ab5e86fec9 Don't use https since it's not supported on windows and ubuntu 12.04 2016-02-03 16:33:43 +01:00
Andreas
6c726e3e38 Use desktopauth instead of mobileauth for last.fm 
It now uses an oauth like authentication process so the user isn't required to enter the last.fm password in Clementine but rather authenticate through the last.fm website.

Updates #5028
 2016-02-03 15:33:46 +01:00