Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity
7,659 Commits 23 Branches 536 Tags 240 MiB
Commit Graph

533 Commits

Author SHA1 Message Date
Marko Hauptvogel 57d00394ee Bugfix for resume playback on start 
This fixes issue #5365.

Because of the asynchronous loading of playlists introduced by
09e83935, the resume playback on startup logic finds the active
playlist as empty, because it is not restored yet. By attaching
the playback resume to the RestoreFinish signal, the playback
will be triggered as soon as the playlist is restored. It may be
possible (but unlikely) that the playlist will already be restored
before we wait for the signal, and playback won't be resumed.

Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
 2017-01-05 17:09:57 +00:00
Santiago Gil d3898d2f47 Add dialog to display streams' audio details (#5547) 
* Add Stream Details window

* Fix capitalization in StreamDiscoverer::Discover()

* StreamDiscoverer::Discover(): get URL by const reference

* Refactor StreamDiscoverer::Discover

* Rename StreamDiscoverer callbacks

* StreamDiscoverer::OnDiscovered: fix nullptr comparison

* StreamDiscoverer: rename DiscoverFinished signal

* StreamDiscoverer::DataReady: receive const reference

* StreamDiscoverer: Remove unsigned types

* StreamDetailsDialog: rename Close slot

* StreamDetailsDialog: rename ui pointer to ui_

* MainWindow::ShowStreamDetails: receive a const reference

* StreamDetailsDialog: use unique_ptr, remove unsigned types
 2016-12-21 16:57:04 +00:00
Chocobozzz 18a89f78a9 Merge remote-tracking branch 'upstream/master' into qt5 2016-10-07 14:30:09 +02:00
Santiago Gil 8da53abcfa Add option to show/hide sidebar (#5459) 2016-09-06 07:28:25 -05:00
Ilya Selyuminov 09b0fab87c Add new command line option for creating a new one playlist #5373 (#5468) 2016-08-26 08:59:11 -05:00
Mattias Andersson 0b6d531bd3 Focus the library tab when using the 'Show in library' feature 2016-07-01 11:37:04 +02:00
Chocobozzz 0aa3405274 Merge remote-tracking branch 'upstream/master' into qt5 2016-05-09 12:46:08 +02:00
Alex 11670e1760 Fix playlist behaviour (#5330) 
* Do not restore playback state on application start if overwritten by command line options

This also fixes unwanted pausing if a new instance is started with commandline URL combined with playback restore.
Note that the actual buggy code (MainWindow::ResumePlayback()) is not fixed here.

* Fix for commandline URLs for new instances are always appended to playlist.
 2016-04-12 15:53:43 +01:00
Ivan Leontiev 75d4731534 Move global search settings loading later in "MainWindow" initialisation 
Fixes #5312.
 2016-03-30 04:58:47 +03:00
Chocobozzz 4898d20ce2 Merge remote-tracking branch 'upstream/master' into qt5 2016-03-28 11:38:22 +02:00
René Tronsgaard Rasmussen 8e70046e4b Add -q,--stop-after-current commandline flag 2016-03-18 20:21:34 +01:00
Chocobozzz e6e189967d Merge remote-tracking branch 'upstream/master' into qt5 2016-02-29 18:03:02 +01:00
John Maguire dcdd81d69f Moar Lazy migrations 2016-02-12 16:10:56 +00:00
John Maguire b99b090adc Refactor simple dialogs to use Lazy 2016-02-12 16:01:35 +00:00
John Maguire 74e6a1744f Convert edit tag & settings dialog to Lazy. 2016-02-12 15:56:08 +00:00
John Maguire 589f2ff62e Lazy initialise organise dialog 2016-02-12 12:25:35 +00:00
John Maguire 6844dcc140 Remove unused variable 2016-02-11 14:19:01 +00:00
John Maguire c9b0bb2044 Revert "Add an option to inhibit suspend while playing" 2016-01-08 15:09:07 +00:00
John Maguire a9b5947fb0 Merge pull request #5150 from narunlifescience/master 
Add an option to inhibit suspend while playing
 2016-01-07 18:32:29 +00:00
Chocobozzz 5675091816 Add error message if editing tag from playlist fails 2015-12-20 19:07:15 +01:00
Chocobozzz ff7026c9fe Merge remote-tracking branch 'upstream/master' into qt5 2015-12-13 20:05:12 +01:00
narunlifescience 9f121f4a9d move dbus names to unique namespace -> dbusidlehandler.cc & other minor updates 
fix InhibitwhilePlaying signals
 2015-12-11 08:49:12 -06:00
narunlifescience b13f0690c8 Add an option to inhibit suspend while playing 
minor modifications
 2015-12-10 03:20:29 -06:00
narunlifescience 2603cf2088 use iconloader & cleanup previous remnants 
update
 2015-12-01 00:32:20 -06:00
John Maguire 3cc9c1e446 Remove ModelFutureWatcher 2015-11-26 19:02:08 +00:00
Mark Furneaux fa0a9d315c Respawn mainwindow on correct monitor 
PR #5081 created a regression where the mainwindow will always start on the primary monitor regardless of which one it was closed on when maximized. This restores previous functionality.
 2015-11-22 00:35:27 -05:00
narunlifescience 6a11ac6162 remember normal window state when user closes clementine in maximized state 2015-10-20 04:44:42 -05:00
narunlifescience dd953fd86c check custom icon location, then system theme & then fallback theme 
icons added & replaced
 2015-10-13 22:35:49 -05:00
Chocobozzz f5cd85c6de Fix the command line options when another instance is running 2015-10-12 14:07:10 +02:00
Ethan Warth 262ea27ec0 consolidated the options for double clicking a playlist 
see https://github.com/clementine-player/Clementine/pull/4991#issuecomment-140082879
 2015-09-25 22:39:21 -05:00
Chocobozzz 631a6cdabd Merge branch 'master' into qt5 2015-09-16 17:40:54 +02:00
Ethan Warth 40d985c7f9 performed a make format 2015-08-14 15:48:01 -05:00
Ethan Warth 2356a9b591 Merge branch 'master' into double_click_playlist 
this will allow the make format to happen without causing a merge conflict
 2015-08-14 15:45:01 -05:00
Ivan Leontiev e85424cdd7 Fix time labels blinking when playing streams without known duration 2015-08-10 12:01:42 +00:00
Ethan Warth a85f2e3076 fixed the miscellaneous bugs; time for a pull request! 2015-08-10 02:43:45 -05:00
Ethan Warth a7a83b3953 double clicking playlist options should now be implmented 
the code compiles; runtime testing will follow
 2015-08-09 22:43:16 -05:00
Eduardo Sánchez Muñoz 11b61c2a67 Use Player::SeekForward() and Player::SeekBackward() to handle seeking with arrow keys. 2015-07-02 14:59:30 +02:00
John Maguire 1323af5025 Merge pull request #4910 from Chocobozzz/global_shortcut 
Add love/ban (lastfm) global shortcuts
 2015-06-17 09:49:19 -04:00
Chocobozzz 7b8552ab6d Add love/ban (lastfm) global shortcuts 2015-06-17 14:21:24 +02:00
Mark Furneaux f4b7c22bc2 Revert "Revert "Add track intro mode"" 
This reverts commit ece262f7f4.
 2015-06-15 16:27:40 -04:00
John Maguire ece262f7f4 Revert "Add track intro mode" 2015-06-15 15:49:08 -04:00
Mark Furneaux b57cebbf2d Add track intro mode 
This repeat mode plays the beginning of each track, good for quickly getting a feel for a new album for example.
 2015-06-14 13:32:58 -04:00
Chocobozzz 5aec1c0e24 Merge remote-tracking branch 'upstream/master' into qt5 
Update qt version to 5.4.2
 2015-06-03 22:57:58 +02:00
Chocobozzz 10de0d8f74 Fix save state when the song was paused 2015-06-02 18:11:58 +02:00
Chocobozzz e986ab5a4b Merge master branch and adapt it to qt5 2015-04-16 17:16:34 +02:00
Chocobozzz 4d0e413fb9 Finally use of qtsingleapplication adapted to qt5 2015-04-16 15:06:00 +02:00
Chocobozzz 8b226c2171 Update non optionnals sources to qt5 2015-04-11 23:24:07 +02:00
Martin Babutzka 258ae281d8 IDv3 tag lyrics support. 
Squashed the following commits:

5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:

-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
 2015-04-10 21:05:07 +02:00
Arnaud Bienner ccf5bffd99 Oops, this should just be a comment (remove warning) 2015-03-30 18:34:45 +02:00
Arnaud Bienner 9877ac49fa Use Alt+Tab to switch between playlist tabs on OS X, as Cmd+Tab is already used by default for switching applications 2015-03-28 17:18:22 +01:00
Mattias Andersson 7d0d7be568 Some ui changes to the ripcd dialog. 
- Move the Rip audio CD menu item to the Tools menu.

- Hide the progress bar if the CD ripper isn't working when the CD ripping
dialog is shown.
 2015-02-18 20:08:02 +01:00
Mattias Andersson fc2e4db229 Split the CD ripper into two classes 
Separate the cd ripper dialog from the ripper itself.
 2015-02-18 20:08:02 +01:00
Mattias Andersson eb8a618197 Move the CD ripper into its own directory. 2015-02-18 20:08:02 +01:00
Krzysztof Sobiecki fa9ea6ec5f Fix compilation with moved files in internet/ 2014-12-18 23:35:21 +01:00
Arnaud Bienner a8266173c5 Start to reactivate audio CD support 2014-10-26 00:28:03 +02:00
Arnaud Bienner f6e6d3b937 Revert "Finished the changes to the quick change menu. Everything should work." 
This reverts commit a468085c3a.

Conflicts:
	src/playlist/playlistcontainer.cpp
	src/playlist/playlistcontainer.h
	src/ui/behavioursettingspage.cpp
 2014-10-07 00:29:46 +02:00
David Sansome a2408f7c0e Merge branch 'master' into gstreamer-1.2 
Conflicts:
	src/moodbar/moodbarloader.cpp
 2014-09-21 19:39:27 +10:00
David Sansome 6b32ecec27 Various bits for gstreamer-1.0 compatability 2014-09-21 19:38:13 +10:00
ppkt 43a6740b48 Remove unavailable items from playlist 2014-08-24 10:44:27 +02:00
Gavin Howard f41bebbeb2 Ran 'make format' on my patch. 2014-08-18 09:56:01 -06:00
Gavin Howard a468085c3a Finished the changes to the quick change menu. Everything should work. 2014-08-15 18:52:01 -06:00
David Sansome 6bb81328e8 Merge branch 'master' into gstreamer-1.2 
Conflicts:
	ext/clementine-spotifyblob/mediapipeline.cpp
	gst/moodbar/gstfftwspectrum.c
	src/core/songloader.cpp
	src/core/songloader.h
	src/engines/gstengine.cpp
	src/engines/gstenginepipeline.cpp
	src/moodbar/moodbarpipeline.cpp
	src/musicbrainz/chromaprinter.cpp
	src/transcoder/transcoder.cpp
	src/ui/mainwindow.cpp
	src/visualisations/projectmvisualisation.cpp
 2014-06-09 16:20:24 +10:00
David Sansome 162b2efbb0 If we don't know the length of a song from the metadata, get it from the pipeline which has the real length. Fixes #2818 when the length isn't in the podcast metadata. 2014-05-29 21:33:53 +10:00
David Sansome 453a012f21 Make it impossible to collapse either side of the MainWindow splitter. Fixes #4384 2014-05-29 20:43:43 +10:00
Mark Furneaux 805d8f85b0 Add icons to extras: hypnotoad, kittens, enterprise 
Fixes totally critical bug #1601
 2014-05-21 07:26:16 -04:00
Mark Furneaux bd87230301 Change constant format 2014-05-20 07:44:30 -04:00
Mark Furneaux 7fb30f2596 Add constants to track progress timers 2014-05-20 07:29:59 -04:00
Mark Furneaux b76af5f792 Increase update rate of track slider 
Increases the refresh rate of the track progress bar to 25fps.
This looks much better with moodbars than the previous 1fps.
All the common code that use to run at 1fps still retains that
rate so the overhead due to this is negligible.
 2014-05-19 11:51:40 -04:00
Mattias Andersson 31400f2740 Run 'make format' 2014-04-12 09:20:25 +02:00
Mattias Andersson d66a73bed5 Merge remote-tracking branch 'origin/master' into HEAD 
Conflicts:
	src/ui/mainwindow.cpp
	src/ui/ripcd.cpp
 2014-04-12 09:08:21 +02:00
John Maguire 4ab4bbc23f Remove Last.fm radio support. 
Fixes #4259
 2014-03-28 14:55:04 +01:00
Maltsev Vlad a7b0accd93 Add Vk.com plugin. 2014-03-08 00:58:50 +07:00
John Maguire b46e9ff55c Seems this should be the other way around. 2014-02-14 15:51:08 +01:00
John Maguire c162a9316d Fix clang warning. 2014-02-14 14:36:47 +01:00
Arnaud Bienner faaa75cb61 Few style fixes + avoid unneeded copies 2014-02-12 22:11:28 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for 
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
 2014-02-10 14:43:32 +01:00
David Sansome 67f6560c04 Merge pull request #4194 from abika/master 
Use double click settings as default behaviour for new files added as command line arguments.  Fixes #4183
 2014-02-09 16:51:10 +11:00
Mladen Pejaković da535d6429 More disambiguations 2014-02-08 15:11:06 +01:00
Dave Sansome 89369029ab Merge branch 'skip_track' of https://github.com/asiviero/Clementine into asiviero-skip_track 
Conflicts:
	src/playlist/playlist.cpp
	src/playlist/playlistitem.h
	src/ui/mainwindow.cpp
 2014-02-08 13:19:23 +11:00
Alexander Bikadorov 2ab8ab8077 Use double click settings as default behaviour for new files added as command line arguments. 2014-02-07 20:28:37 +01:00
Krzysztof A. Sobiecki 0ecf1e76a6 Reformat done with clang-3.5 svn200967 2014-02-07 17:08:31 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++. 
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
 2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
asiviero 62d919c1b5 Fixing segfaults, checking for cd change on the fly 2014-02-04 23:29:39 -02:00
asiviero 4251fd4331 Checks for CD before opening window (addresses #4165) 2014-02-03 22:40:56 -02:00
asiviero c0132b2ed3 Renaming skip properties, strike out track when it is to be skipped 2014-01-27 00:26:51 -02:00
David Sansome 5ac83bd463 Merge branch 'master' into gstreamer-1.2 2014-01-25 00:24:31 +11:00
John Maguire b594f44c64 Merge branch 'cdrip' of https://github.com/asiviero/Clementine 
Fixes #3490
Closes #4113
 2014-01-23 16:33:28 +01:00
Andre Siviero a827d71f4a Moving ifdef inside the function 2014-01-23 13:18:35 -02:00
Andre Siviero bbf7ff61af Included OpenRipCD in a conditional 2014-01-23 11:04:30 -02:00
asiviero d07174c1d4 Adding ifdefs to make cdio detection on compile time 2014-01-22 23:11:41 -02:00
asiviero 7cebf23bba Added ripcd to optional features, deleted ui_ripcd on destruction, added a warning in case cdio_open returns NULL 2014-01-22 01:45:55 -02:00
asiviero c817431593 Greying out song and added verification to next on album mode 2014-01-20 22:35:01 -02:00
asiviero 5c21768760 Minor fixes and label adjustments 2014-01-20 22:10:23 -02:00
asiviero 1c0a221563 Added skip track feature 2014-01-20 22:10:16 -02:00
asiviero 94aa151f1a Added event handlers to Skip Track 2014-01-20 22:09:58 -02:00
asiviero 457d240854 Using QByteArray and QFile instead of FILE and int16_t, adapting to code style corrections? 2014-01-15 03:00:41 -02:00
Arnaud Bienner c7b0c02800 Sanity check 2014-01-12 21:25:53 +01:00
asiviero d14e272018 Merge branch 'master' of https://github.com/clementine-player/Clementine 2014-01-12 13:39:12 -02:00