Commit Graph

382 Commits

Author SHA1 Message Date
Chocobozzz da99c55eed Use constructor for QString 2014-11-05 12:25:55 +01:00
Chocobozzz 2e64b24290 Revert "Use constructor for QString and make format"
This reverts commit 5a2348fae6.
2014-11-05 12:25:09 +01:00
Chocobozzz 5a2348fae6 Use constructor for QString and make format 2014-11-05 11:51:38 +01:00
Chocobozzz 942fda88bf Check if there is a current icon item in the device manager. Fixes #4604 #4555 2014-11-04 21:46:10 +01:00
Arnaud Bienner 7ac9e4c6d1 Fix a bug in InsertItems functions that makes Cdda tracks to not be saved/restored correctly when restarting Clementine 2014-10-26 17:08:12 +01:00
Arnaud Bienner 5a7c462fc3 Remove useless includes 2014-10-26 03:37:17 +01:00
Arnaud Bienner dc0d3436c8 Finish CD integration update to Gstreamer 1.0
Move everything related to CDDA to a seperate class, so we can more easily reuse it in SongLoader
2014-10-26 03:32:37 +01:00
Arnaud Bienner a8266173c5 Start to reactivate audio CD support 2014-10-26 00:28:03 +02:00
David Sansome 39d99247a2 gstreamer-cdda is in gst-plugins-base in 1.0 and has a different header name.
This still doesn't work because the API has changed and track listings are
now delivered via a bus message instead of direct access to the struct's
members.
2014-09-22 22:28:53 +10:00
Mattias Andersson 0be0498e94 Reset the model during init of CddaDevice
This ensures that the track list in the device tab is correctly updated when a
disc is replaced with one that doesn't exist in the MusicBrainz database.
2014-05-24 13:54:07 +02:00
John Maguire 5146bcdebc Some more NULL -> nullptr conversions. 2014-02-21 17:30:46 +01:00
John Maguire 192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
Krzysztof A. Sobiecki 0ecf1e76a6 Reformat done with clang-3.5 svn200967 2014-02-07 17:08:31 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
John Maguire b96ec7555a Reformat all Objective-C++ files with clang-format.
clang-format -style=Google -i src/*/*.mm
2014-01-30 14:54:51 +01:00
David Sansome 8416188056 Show a message in the Devices pane on Windows to say that most devices won't work. Fixes #4059 2014-01-05 11:32:07 +11:00
John Maguire 95330a3d7c Deal more gracefully with a device's library not having any directories on second mount.
Fixes issue #3940
2013-11-04 18:44:07 +01:00
John Maguire a650ac91bd Don't probe stupid printers on OS X. 2013-07-09 12:03:01 +02:00
David Sansome eb20fb5945 Remove all the soruce for WMDM devices. Fixes issue 3748 2013-06-30 08:25:12 +00:00
John Maguire 3d434f1c88 Remove iDevice support as it doesn't work well for modern devices and libgpod shows no signs of updating to support them.
Fixes issue #3683
2013-05-17 15:30:56 +02:00
David Sansome d89954ae31 Fix style, hide the new columns by default, and move the new columns to the end of the enum 2013-03-10 18:16:14 +11:00
Uwe Klotz a6d3b48231 Extend tag support: performer, grouping
The transaction handling while upgrading the database schema had to be revised.
Furthermore some QSqlQuery statements needed to be finished properly.

Fixes issue 2556
2013-03-10 18:16:03 +11:00
John Maguire 42e7e4ff6f Use boost::bind in DeviceManager. 2012-11-21 17:21:20 +01:00
John Maguire 80d35ef128 Merge remote branch 'origin/mingw-w64' 2012-11-19 18:17:19 +01:00
Arnaud Bienner e9c98733b3 Also update song count when tags are loaded: I don't know why but there not updated in Init 2012-11-18 22:14:06 +01:00
Arnaud Bienner fb07308607 Slightly modify the way CddaLister::Init worksr: as cdio_get_devices sometimes return only symlinks, we should not ignore them. 2012-11-18 22:05:18 +01:00
John Maguire 8501ac0d96 Do WMDM static init in main() to avoid static mutex. 2012-11-15 22:08:04 +00:00
John Maguire 543a6bf2fa Remove use of linked SAC shim and depend on DLL version (which doesn't exist yet) 2012-11-13 17:04:54 +01:00
John Maguire 79318cc4e1 Build fixes for mingw-w64 2012-11-13 14:43:13 +01:00
Veniamin Gvozdikov e6e72dc68d Change the include order to fix a build error on FreeBSD.
Fixes issue 3247
2012-10-31 10:45:18 -07:00
John Maguire 896a8739e9 Maybe fix mac build. 2012-09-26 18:12:14 +02:00
John Maguire 5ddabb4b76 Remove use of functions deprecated in Mountain Lion. 2012-09-13 16:24:45 +02:00
Arnaud Bienner 0e3dc5a8be Add new ConcurrentRun templates for void functions, and functions with 3 arguments + corresponding test cases.
+ SongLoader now has its own QThreadPool to load folders/playlist in background.
Update issue 2598
This should fix slowliness problems reported.
2012-07-16 00:06:55 +02:00
John Maguire 905ef90882 Add missing header. 2012-06-29 17:06:47 +02:00
John Maguire 20b11961f9 Set the max size of the DeviceManager thread pool to 1. 2012-06-29 16:58:30 +02:00
John Maguire 58a3a6831a Move loading of devices from the database onto a different thread. 2012-06-29 16:56:17 +02:00
John Maguire cbc650f44b Use CHECKED_GCONNECT instead of g_signal_connect everywhere. 2012-06-08 15:34:00 +02:00
Patrick Stewart fd35ce8b5d When listing devicekit devices, include drives that only contain a single partition (with no partition table).
Fixes issue 1508
2012-06-05 18:42:11 +01:00
John Maguire c62e996607 Fix come compile warnings from Clang 3.1 2012-06-04 17:44:01 +02:00
David Sansome 5d4844acdd Add copyright headers to ilister.{cpp,h} 2012-03-27 21:31:20 +01:00
David Sansome 119c9c27ac Detect libimobiledevice 1.1.2 and use its new "udid" field instead of "uuid". 2012-03-27 21:24:38 +01:00
David Sansome 526a9d9960 Fix compilation of the WMDM device lister on windows 2012-02-26 16:00:00 +00:00
David Sansome ab5ccf69da Refactoring: remove BackgroundThread 2012-02-26 15:05:46 +00:00
David Sansome bacef04405 Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader. 2012-02-26 14:40:51 +00:00
David Sansome 48f15c9fc7 Refactoring: instead of passing individual pointers to useful core classes (like TaskManager or LibraryBackend) to each class that uses them, pass one singleton-like Application instance everywhere. 2012-02-26 14:40:51 +00:00
David Sansome 10af3fef37 Maybe fix a string concatenation crash on startup on OS X. 2012-02-21 12:10:25 +00:00
John Maguire 3e65d3d5f0 Add ScopedNSAutoreleasePool from Chromium. 2012-01-31 13:54:03 +01:00
John Maguire b86be65ea1 Add ScopedIOObject. 2012-01-23 18:12:51 -08:00
Руслан Ижбулатов 5c45e22e28 Make SAC and WMDM optional 2012-01-22 14:35:22 +00:00
John Maguire ab33d9aa8c Fix a bunch of small memory leaks in the mac device handling code. 2012-01-20 16:25:05 -08:00
John Maguire 028ac3126c Use scoped_nsobject & ScopedCFTypeRef in a load of places. 2012-01-20 16:06:56 -08:00
John Maguire fddde512c9 Update old logging statements. 2012-01-20 15:22:14 -08:00
David Sansome e9c0b4bd69 Musicbrainz tagging improvements:
* Fix a bug where the song title would be used for the album field
  * Get the album's year as well
  * Include all releases for a song in the results list
  * Remove duplicate albums
  * Sort results
2012-01-07 21:51:02 +00:00
David Sansome b873209d39 Remove the <xiphcomment.h> include from song.h so that windows headers don't infect everything else. Also move other bits of song.h into song.cpp, and reduce the number of includes in song.h. 2011-11-28 13:56:55 +00:00
John Maguire 177c658366 Fix CF handle leak. 2011-11-21 16:33:01 +01:00
John Maguire b74c735268 Don't probe USB hubs and HID devices on Mac as some of them don't like it.
Update issue #981
Hopefully this fixes it.
2011-11-21 15:16:24 +01:00
John Maguire 9c6964da2c Remove another deprecated glib function call. 2011-10-26 12:06:51 +02:00
John Maguire 01f3f5c5ea Stop using deprecated glib eject functions. 2011-10-26 11:51:11 +02:00
John Maguire 309634bc18 Blacklist eLicenser copy protection dongle from Mac MTP probing.
Fixes issue #2232
2011-09-15 17:42:03 +02:00
John Maguire e1f66960f8 Swap vendor id and product id for ilok2.
Update issue #2226
D'oh, fixed.
2011-09-13 16:39:40 +02:00
John Maguire 17adb2bd6d Blacklist ilok2 device from Mac MTP detection.
Update issue #2226
Hopefully this will fix it.
2011-09-13 15:57:13 +02:00
David Sansome 143bbb4019 Make the BusyIndicator contain a label too 2011-08-27 15:03:04 +01:00
Arnaud Bienner 5841bb58a7 Correct typo in comment 2011-08-19 22:31:48 +02:00
Arnaud Bienner f33b62a877 Oops... Actually, it's better like this :) 2011-08-18 22:10:09 +02:00
Arnaud Bienner 299f15b7ee Allow GIO to handle CD devices if libcdio isn't installed 2011-08-18 21:41:14 +02:00
Arnaud Bienner 91537777c8 Ignore cdda devices detected via gio ealier, to avoid crash when getting device's filesystem info. This seems to happen because both giolister and cddadevice try to access to the device at the same time 2011-08-18 21:34:45 +02:00
Arnaud Bienner 419447e192 Reset song count during init 2011-08-18 20:23:11 +02:00
John Maguire 8ad150bd6b Don't detect CD devices on Mac when we can't use them and fix an iokit
device leak.
2011-08-15 18:13:05 +02:00
John Maguire 56a4d6b743 Fix double unref on cdda element. 2011-08-15 18:08:09 +02:00
John Maguire 50824cafe9 Make AskForScan() per-device rather than per device lister and fix cddadevice to use the url rather than the unique id. 2011-08-11 22:10:14 +02:00
John Maguire b458c9d24c Merge branch 'master' of https://code.google.com/p/clementine-player
Conflicts:
	src/devices/devicemanager.cpp
2011-08-11 21:46:48 +02:00
John Maguire 75a53d0b36 Detect CD removal on mac. 2011-08-11 21:43:00 +02:00
John Maguire 47a171fca7 Detect cd insertion on mac. 2011-08-11 21:37:09 +02:00
Arnaud Bienner 4509757233 We cannot change CD device's content: return false for those methods. This will display an error message, more explicit than doing nothing without any warning 2011-08-11 01:16:08 +02:00
Arnaud Bienner 3b6af2298d Remove useless return statement which prevents using the 'friendly name' (even if we're supposed to rarely go here) 2011-08-11 01:10:45 +02:00
Arnaud Bienner 1a4aa8f641 Make the 'dont ask on first connect' more generic 2011-08-11 00:59:34 +02:00
Arnaud Bienner f963ae524a Ignore devices that correspond to symlink to avoid duplicate 2011-08-11 00:15:26 +02:00
David Sansome 082716e9c9 Don't try to compile audio CD support if libcdio isn't installed. 2011-08-10 16:30:36 +01:00
Arnaud Bienner 0b795841d5 Merge branch 'master' of https://code.google.com/p/clementine-player 2011-08-10 00:49:43 +02:00
Arnaud Bienner 07ce755060 Work with multiple CD devices 2011-08-10 00:49:36 +02:00
John Maguire 6d9bc9d3f4 Don't constantly refresh the cd device if it doesn't support checking for media changes.
Filter out irrelevant devices on OS X.
2011-08-09 21:30:28 +02:00
John Maguire 176efeb4b0 Add debug logging to cdda lister. 2011-08-09 20:28:50 +02:00
John Maguire d0a3cd2455 Fix crash in cdio on Mac. 2011-08-08 13:59:21 +02:00
David Sansome cbc05354ee Merge branch 'master' of https://code.google.com/p/clementine-player 2011-08-05 08:33:42 +01:00
Black Jack 3de111d84f Fix a crash that occurs when mounting a device with an empty backends container. Fixes issue 2121 2011-08-05 08:20:04 +01:00
Arnaud Bienner c3c4e87827 Remove now useless debug message 2011-08-05 02:35:38 +02:00
Arnaud Bienner f7859f591c Adding CD devices in devices tab. Fixes issue 701. 2011-08-05 02:15:16 +02:00
David Sansome 9fadf57acc Revert "Move TaskManager::Task and UrlHandler::LoadResult structs out of their parent classes - PythonQt doesn't understand nested structs."
This reverts commit 5234798a7f.
2011-07-23 15:32:12 +01:00
David Sansome 5234798a7f Move TaskManager::Task and UrlHandler::LoadResult structs out of their parent classes - PythonQt doesn't understand nested structs. 2011-05-21 10:43:25 +00:00
David Sansome 5c1139747f Update a log line in the device kit lister 2011-05-19 23:02:30 +00:00
David Sansome c22c5eb917 Fix a build failure on Windows 2011-04-29 21:01:20 +00:00
David Sansome ccb9f8cf94 Use URLs everywhere instead of filenames. Move the URL parsing and song loading code out of individual playlist parsers and into the base class. Fix the playlist parser unit tests. 2011-04-28 12:27:53 +00:00
David Sansome 3d6677fe6d Allow radio services (Spotify) to store whole songs in playlist items 2011-04-26 22:06:58 +00:00
David Sansome 071f1f4f7e Add loads more debug logging on startup 2011-04-24 18:07:09 +00:00
David Sansome 3eedc916ad Add a new logging system 2011-04-22 16:50:29 +00:00
David Sansome eddc47cc64 Recognise iPods correctly when using GIO. 2011-04-12 17:27:01 +00:00
John Maguire 41ef30151a Remove debug output. 2011-04-04 13:16:13 +00:00
John Maguire ab363a54ea Fix free space & capacity counts for MTP devices on Mac. 2011-04-04 13:15:56 +00:00
David Sansome 9f04aa7bb2 Remove an unused variable. 2011-03-28 12:52:20 +00:00
David Sansome f37467ac69 Don't try to create a pixmap from an invalid HICON on Windows. Fixes issue 1417 2011-03-13 22:14:23 +00:00
David Sansome 2b08d27a88 Show loading indicators in the library model and the status bar when asynchronously loading songs during initialisation. 2011-02-26 14:27:57 +00:00
Paweł Bara 7de912d3a1 moving the responsibility for naming playlists into mimeData() methods (into models)
this means that pretty names for new playlists now also work when double clicking (in certain mode) or dragging and dropping
fixes issue #1477
2011-02-16 18:29:35 +00:00
Paweł Bara 0182829223 user-friendly name for 'Open in new playlist' playlists (fixes issue #1445) 2011-02-14 17:00:13 +00:00
Paweł Bara 60ac6768b8 Fresh new 'open in new playlist' action (Updates issue #1431). 2011-02-09 17:51:59 +00:00
Paweł Bara 4cd01a43b7 fixing names of all the 'add to playlist' items in context menus (Fixes issue #1421) 2011-02-08 22:42:09 +00:00
Paweł Bara 9a9d8ad177 don't let invalid CUE related media files into library (invalid == those which were not recognized by TagLib)
better logging of erroneous DB queries (error + query + bound values instead of just error)
2011-02-05 13:43:04 +00:00
David Sansome 7880026767 Add some better error handling to the WMDM device lister if parts of WMP aren't installed 2011-01-22 11:29:47 +00:00
David Sansome 135b32642e Refactor all the code that handles adding items to the playlist - whether it be by a context menu item, double clicking in a view or dragging. Everything now uses the models' mimeData() instead of duplicating the same code everywhere. 2011-01-10 22:26:13 +00:00
David Sansome e3a9bd7b26 Make DBUS bits optional on Linux. Thanks Nickollai. Fixes issue #1177 2010-12-26 13:38:35 +00:00
David Sansome ced9a8b6e2 Test we can connect to udisks before connecting signals and reset the pointer of the interface. Thanks mail@holger-mense.de. 2010-12-25 14:25:05 +00:00
David Sansome 9b1765d1b0 The DeviceKit service not being around is not necessarily an error - it might get started automatically. Thanks mail@holger-mense.de. Fixes issue #1060 2010-12-25 13:23:25 +00:00
David Sansome 89e3fde23b Add missing copyright headers to the icecast source and objective-c 2010-11-23 11:42:19 +00:00
David Sansome ed1a25693c Add missing licenses to debian/copyright, and add copyright information to each source file 2010-11-20 13:27:10 +00:00
David Sansome ac90d74a28 Don't show CD drives in the devices tab 2010-10-17 20:52:07 +00:00
David Sansome 95556df6aa Move database schema into a subdirectory of data/ 2010-10-17 11:22:34 +00:00
David Sansome 56d72a00bf Try the next UI experiment - wide buttons down the side like Qt Creator 2010-10-01 19:27:01 +00:00
John Maguire e993909bd0 Fix USB mass storage devices on Mac.
Fixes issue #821
2010-09-27 17:27:08 +00:00
John Maguire 2072d6cf9e Fix crashes to do with iThings on Mac. 2010-09-20 21:03:31 +00:00
David Sansome 8c0b17c000 Ooops, perhaps the code to stop devices from auto-expanding would work better in the DeviceView class. 2010-09-18 14:29:43 +00:00
David Sansome 44f0934fed Don't crash when physically removing a device 2010-09-18 13:54:23 +00:00
John Maguire b61a05889a Disable detection of iPhone 4 and iPad until libgpod supports them.
Updates issue #742
I've blacklisted the iPhone 4 and iPad for now.
2010-09-13 17:08:10 +00:00
David Sansome c65a687678 Remove GIO devices from the list that are unmounted outside clementine 2010-09-12 19:20:06 +00:00
David Sansome c2ac3f8f32 Don't mount GIO devices automatically, instead put them in a "not mounted" state in the GUI and mount them when double-clicked on. Fixes issue #719. Probably fixes issue #723. 2010-09-11 12:29:44 +00:00
David Sansome 8f29764817 Fix a Qt 4.7 assert when drawing device item backgrounds 2010-09-10 19:59:29 +00:00
David Sansome aa6e67eb1f Some native path separator fixes for libgpod on Windows, should fix loading of classic iPods on Windows. 2010-09-09 21:49:51 +00:00
John Maguire be6e887375 Fix quirks table and add my device manually :-)
Also fixes error dialog for organise files.
2010-09-04 20:11:14 +00:00
John Maguire 885a711d3a Detect MTP device removal & free space/capacity on Mac. 2010-09-04 19:32:36 +00:00
David Sansome 28a7039977 Show a warning when the user tries to connect a MTP device or iPod when they've compiled out support for libmtp or libgpod 2010-09-04 12:57:34 +00:00
David Sansome bb4bb28c04 Automatically mount GIO volumes that get plugged in. Nautilus already does this for us in Gnome, this makes it work as expected in KDE too. 2010-09-04 12:34:01 +00:00
David Sansome d69f239eea Disable the "Copy to library" option in the device view if the device isn't a filesystem device 2010-09-04 11:27:59 +00:00
David Sansome c9e5a3dce7 Lock access to WMDM devices 2010-09-04 11:18:59 +00:00
David Sansome 034555942b Return some hardware information for WMDM devices, and fix drive paths on Windows 7 2010-09-04 11:09:59 +00:00
John Maguire 902e4906e2 Some more Mac MTP work.
Reminder: Ship libusb-compat, not legacy libusb as it is fucked.
2010-09-02 22:35:00 +00:00
John Maguire 75a576a5c2 MTP support for Mac... Currently crashes the entire USB bus so I wouldn't use it. 2010-09-02 21:20:27 +00:00
John Maguire 916502fcca Ignore non-USB disk mounts on Mac. 2010-09-02 18:24:39 +00:00
John Maguire 310fa00701 Get address and bus number of MTP devices on Mac. 2010-09-02 18:10:40 +00:00
John Maguire 1b78e8137c Remove libusb references. 2010-09-01 21:51:45 +00:00
John Maguire 9e34783602 Add references for MTP detection code. 2010-09-01 21:50:05 +00:00
John Maguire 08f257d3ee Clean up Mac MTP detection code. 2010-09-01 21:43:23 +00:00
John Maguire cce7fadc89 Dodgy code for detecting MTP devices on Mac without crashing (I'm looking at you libmtp). 2010-09-01 20:31:10 +00:00
David Sansome 1747241041 Don't crash on XP SP < 2, and output some more debugging info when guessing drive letters. 2010-08-30 20:37:53 +00:00
David Sansome 1dd6ac323e Get the drive letter for MSC WMDM devices on Windows 7 2010-08-30 19:58:01 +00:00
David Sansome e779190b2f Update free space on WMDM devices 2010-08-30 17:23:24 +00:00
David Sansome 30911ba1ad Make the second line of the device a bit smaller on Linux again 2010-08-30 14:47:30 +00:00
David Sansome e4efa8a93e Show the total song count on each device, instead of the mountpoint 2010-08-30 14:45:27 +00:00
David Sansome 210d7636f4 Oops, fix some build errors in the WMDM device 2010-08-30 12:38:09 +00:00
David Sansome 0ed30857db Fix free space reporting for WMDM and MTP 2010-08-30 12:28:03 +00:00