1
0
mirror of https://github.com/clementine-player/Clementine synced 2025-01-21 22:25:39 +01:00
Commit Graph

6821 Commits

Author SHA1 Message Date
Mattias Andersson
765ee3461b Remove unused directory 3rdparty/fancytabwidget 2018-07-22 21:21:09 +01:00
raphj
292fd0b009 Use QString fromLatin1 instead of fromAscii
Methods QString::fromAscii and QString::toAscii have been deprecated in Qt 5 (https://doc.qt.io/qt-5/qstring-obsolete.html).
This commit replaces calls to QString::fromAscii by calls to QString::fromLatin1 and calls to QString::toAscii by calls to QString::toLatin1.
This allows successful build when merging branch master into branch qt5.
2018-07-11 13:40:01 +01:00
Mark Furneaux
2b280de663 Attempt to fix track change hang
When switching between tracks with different sample rates, the probe queue blocks before the pipeline can emit EOS.
This prevents the track change from proceeding without manual intervention. This appears to be because the queue
element doesn't handle the rate change correctly (either due to buffer length, or cap negotiation).
The queue2 element however does handle this without blocking indefinitely.
2018-07-09 12:05:48 +01:00
Mattias Andersson
31002ca534 Resolve an ambiguous function call 2018-07-08 23:09:41 +01:00
Mattias Andersson
e9a4db0192 Prevent closing of the RipCDDialog if the ripper is running
This prevents a segfault when a running dialog is closed and later reopened.
2018-07-07 10:23:49 +01:00
Mattias Andersson
10d4c502fd Set the parent to avoid a memory leak 2018-07-06 17:09:21 +01:00
Mattias Andersson
3e53e23bb8 Fix formatting 2018-07-06 17:09:21 +01:00
Mattias Andersson
2c084e45b6 Finnish immideately if there are no tracks to rip 2018-07-06 17:09:21 +01:00
Mattias Andersson
059b5ed04f Add Musicbrainz integration to the cd ripper 2018-07-06 17:09:21 +01:00
Mattias Andersson
84f1b7bae0 Load the audio cd in a separate thread 2018-07-06 17:09:21 +01:00
Mattias Andersson
4458d45200 Give the cd device some more time to spin up 2018-07-06 17:09:21 +01:00
Jonas Kvinge
b897651cdb Device fixes for MacOs (#6098)
* Fix setting device for newer MacOs

* Fix setting device if there is an empty description
2018-07-06 10:04:40 +01:00
Eoin O'Neill
4733185d08 Added basic VGM format playback and tag reading. (#6089)
Current VGM format implementation in GStreamer (gstgme) only supports Sega Geneses (Mega Drive) and Sega Master System emulation.
GStreamer also cannot handle the VGZ format (a shorthand for vgm.gz, a gzipped archive that contains a song) which means
that users will currently have to extract the contents of their VGZ files to individual vgm files.
2018-06-18 14:26:11 +01:00
vaterlangen
fcf96cb6ff Queue size and duration is now displayed in queue manager && Album Cover Popup fixes (#6086) 2018-06-18 14:21:44 +01:00
Eoin O'Neill
e2f63e3945 Implemented SPC playback functionality.
Would like to add more playback support for additional GME supported file types. GME is already supported by the GStreamer backend.
2018-06-16 10:06:37 +01:00
Jonas Kvinge
a397871123 Fix loading output/device setting 2018-06-14 21:39:16 +01:00
Jonas Kvinge
5dbdcca54f Set empty string for sinks with default devices and auto sink 2018-06-14 21:39:16 +01:00
Clang Formatter
083129f41c Automatically formatted 2018-06-13 20:37:13 +00:00
vaterlangen
465fa2ce87 Clicking on songs in playlists via remote control now respecting behavioural settings from GUI (either direct changes it or enques it) 2018-06-13 22:03:23 +02:00
Jonas Kvinge
f3aab34d3a Add ALSA Device Finder (#6079) 2018-06-13 09:56:42 +01:00
Jonas Kvinge
41ed505277 Fix git revision string (#6083) 2018-06-13 09:38:56 +01:00
Jonas Kvinge
da648fd08f Fix setting device on windows (#6081) 2018-06-12 09:27:10 +01:00
John Maguire
1b4955cc4a
Merge pull request #6076 from jonaski/taglib
Audio file detection by content supported by newer taglib
2018-06-10 00:04:07 +01:00
Jonas Kvinge
925e74f909 Fix crash when uridecodebin fails. (#6077)
Let's the user see the error message what failed instead of Clementine crashing.

Also don't do gst_object_unref unless bin is set.
This fixes GStreamer-CRITICAL gst_object_unref: assertion 'object != NULL' failed
2018-06-06 23:53:25 +01:00
Jonas Kvinge
03261f5b8d Use bultin taglib as default
Only use systems taglib if it's newer than the current release because of audio file detection by content.
2018-06-06 22:59:21 +02:00
Jonas Kvinge
e0d2d9b424 Use taglib to check for valid audio file 2018-06-06 22:54:48 +02:00
Jonas Kvinge
ef5a23a3fe Bump taglib 2018-06-06 22:47:08 +02:00
aqua36
6f3032a1ec add genius.com as lyrics provider (#6073) 2018-06-04 09:55:09 +01:00
ftiede
c01b7bc430 Add option to verify subsonic server certificate. (#6060)
* Add option to verify subsonic server certificate.

Defaults to true, as it is safer to have a server certificate verified,
even more so, if the server is used over an insecure WAN link.
During subsonic configuration the checkbox can be deactivated, so that
no certificate verification will occur when talking to a subsonic
server, allowing for self-signed certificates.

With the proliferation of let's encrypt certificates there's probably
less need for this option but it has been requested and hard-coding
verify-off is IMHO bad security practice.
If a valid certificate has been installed, the configuration file can be
modified manually and after a restart Clementine will perform a proper
server certificate verification.

The patch might need some UI polishing and asks for string translations
but is operational so far.

* Satisfy CLang format checker.

* Use QSettings' default value support.

* Consistently use QSettings' default value method.
2018-05-23 14:23:53 +01:00
Chocobozzz
5bd2c77c58 Fix compilation with GCC 8 (#6053) 2018-05-13 18:02:33 +01:00
Jonas Kvinge
37912a87b8 Fix WavPack playback (#6048) 2018-05-01 18:29:47 +01:00
John Maguire
776fb3830e
Merge pull request #6043 from TheUbuntuGuy/feature/mf.playnext
Add Play Next Option to Queue
2018-04-15 12:35:25 +01:00
Mark Furneaux
d28a318437 Clang format 2018-04-14 16:57:06 -04:00
Mark Furneaux
2793cfa7fb Add to loaderinserter 2018-04-14 16:31:48 -04:00
Mark Furneaux
3626d84964 Add play next from library 2018-03-18 22:44:00 -04:00
Mark Furneaux
a789ce82ca Allow playing of tracks already in queue 2018-03-18 22:03:04 -04:00
Mark Furneaux
6e387c2578 Initial playlist implementation 2018-03-18 14:43:44 -04:00
Jonas Kvinge
e52c7f6475 Fix formatting 2018-03-12 07:55:59 -04:00
Jonas Kvinge
d33ac6ef81 Fix background not loading. 2018-03-12 07:55:59 -04:00
Jonas Kvinge
c393926be6 Fix background not loading. 2018-03-12 07:55:59 -04:00
Jonas Kvinge
de23c3181f Fix resume playback on start not working. 2018-03-12 07:55:59 -04:00
Jonas Kvinge
c3a7920cb4 Don't use empty URL's from LastFM. 2018-03-12 07:55:59 -04:00
Pulfer
ddfa5e63f1 Fix channels loading for DI.fm services after API domain changes (#6023) 2018-03-10 18:35:09 +00:00
Jonas Kvinge
c9d954f8a3 Fix bug in covermanager not saving album cover to DB. (#6011)
* Fix bug in covermanager not saving album cover to DB.
2018-03-04 14:13:34 +00:00
Antonio Russo
1732e56fe6 Hide TrackSliderPopup on appropriate leaveEvent
The previous fix introduces a regression on some platforms
which did not generate a leaveEvent with the TrackSliderPopup
was displayed. Logic is introduced to identify bonafide mouse
motion out of the TrackSliderSlider.
2018-02-24 23:42:29 +00:00
John Maguire
9929450cc2 Revert "Hide TrackSliderPopup on exit from popup"
This reverts commit f629d37315.
2018-02-24 22:35:40 +00:00
Antonio Russo
f629d37315 Hide TrackSliderPopup on exit from popup
The previous behavior exited on leaving TrackSliderSlider,
which causes the popup to flicker, as it is shown and
hidden rapidly.
2018-02-24 17:16:51 +00:00
John Maguire
43e1b69229 Fix docker run command 2018-02-19 16:20:56 +00:00
John Maguire
c98a8cdae1 Experiment with building in docker on Travis. 2018-02-19 14:26:47 +00:00
John Maguire
33e1a9bc32
Update README.md 2018-02-14 23:30:47 +00:00