Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity
6,443 Commits 23 Branches 533 Tags 239 MiB
Commit Graph

5130 Commits

Author SHA1 Message Date
John Maguire 1d07be584e Fix annotations on mpris1 args. 2016-03-30 15:50:08 +01:00
John Maguire 9c33369fcc Merge pull request #5292 from printesoi/fix-mpris-signals 
Fix mpris dbus notifications
 2016-03-30 15:36:04 +01:00
Victor Dodon 3dd55e1c86 mpris2: fix format 
Minor code refactoring:
- Use ternary operator in Mpri2::CanSeek
- Run make format
 2016-03-29 21:29:47 -07:00
David Sansome 2257dcd278 Merge pull request #5318 from goggle/master 
Fixed compile error for the subsonic module.
 2016-03-30 10:01:07 +11:00
John Maguire b20d0d87fd Revert "Adding support for subsonic cover art download" 2016-03-29 21:12:54 +01:00
Alex Seiler 6cc60d0cf8 Fixed compile error for the subsonic module. 2016-03-29 21:23:53 +02:00
John Maguire ca487a5166 Merge pull request #5270 from davidgfnet/master 
Adding support for subsonic cover art download
 2016-03-29 16:44:21 +01:00
John Maguire c22911815a Merge pull request #5285 from santigl/dummyBands 
Add dummy bands to avoid #695
 2016-03-29 15:35:43 +01:00
Clementine Buildbot 2e66eeb61f Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-28 10:00:51 +00:00
Ivan Leontiev 9afd71c651 Fix pressing "Backspace" key on a playlist results in appending "^H" character to the filter 2016-03-25 03:45:33 +03:00
Clementine Buildbot 23c0fe9f12 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-23 16:52:38 +00:00
René Tronsgaard Rasmussen 8e70046e4b Add -q,--stop-after-current commandline flag 2016-03-18 20:21:34 +01:00
David Guillen Fandos 10bac1cd2d Fixing issues in the pull request. 2016-03-12 19:44:32 +00:00
Pavel Vatagin b2db55e772 fix "undefined reference to" for clementine when build in MXE 2016-03-12 18:14:40 +03:00
Victor Dodon 91c144478b mpris2: emit CanSeek notification in EngineStateChanged 
When the engine status is Playing must emit the notification CanSeek
 2016-03-10 21:29:09 +00:00
Victor Dodon 5b066991ab playlist: call InformOfCurrentSongChange only after updating the virtual index 
Calling InformOfCurrentSongChange before updating the virtual index results in
sending the CanGoNext and CanGoPrevious notifications with the wrong values.
 2016-03-10 21:20:53 +00:00
Victor Dodon 5f14e887a7 mpris2: more notifications in RepeatModeChanged 
Emit CanGoNext, CanGoPrevious notifications in RepeatModeChanged
 2016-03-10 21:20:17 +00:00
Victor Dodon 3cf6cdb925 mpris2: more notifications in CurrentSongChanged 
Emit CanGoNext, CanGoPrevious, CanSeek notifications in CurrentSongChanged
 2016-03-10 21:14:31 +00:00
Victor Dodon c973c446e3 mpris2: add support for CanGoNext, CanGoPrevious, CanSeek 2016-03-10 21:11:05 +00:00
JulianVolodia e1124403fd Require Qt4.8.1 and CMake deprecate warnings ... 
... "com.trolltech.*" changed to "org.qtproject"
 2016-03-09 18:26:43 +01:00
Santi ed7375d7da Add dummy bands to equalizer (Fixes #695) 2016-03-08 15:26:45 -03:00
Clementine Buildbot e2fbb8e966 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-07 10:00:42 +00:00
Clementine Buildbot 357af2263b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-29 10:00:41 +00:00
David Guillen Fandos e4efde900a Adding support for subsonic cover art download 2016-02-26 23:29:13 +00:00
Clementine Buildbot 9252925a56 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-22 10:00:42 +00:00
John Maguire 51c1c36934 Merge pull request #5263 from simark/fix-moodbar-crash 
moodbar: check QSlider max/min before using them in division
 2016-02-18 14:17:58 +00:00
Simon Marchi 725e1d8f0d moodbar: check QSlider max/min before using them in division 
When switching playback from an item for which the moodbar is not
displayed (e.g. an internet stream), to an item for which it is
displayed (e.g. a local mp3 file), Clementine sometimes crashes.

This happens because the slider_opt->maximum and slider_opt->minimum
have the value 0 (their default value), and the difference is used as a
divisor.  This gives a division by 0, and a SIGFPE.

This problem has been fixed in commit af42cce.  However, when a9f9b0e
reverted 3f79fa5, a little to much was reverted and we lost what af42cce
did.  This patch re-introduces the fix.

Fixes #5261

moodbar: Add comment
 2016-02-18 09:15:44 -05:00
John Maguire 4cd20ffdaa Cope with receiving no images from spotify 2016-02-17 18:06:30 +00:00
John Maguire 52c72f95ba Too clever for old GCC versions. 2016-02-17 16:42:03 +00:00
John Maguire 1304f8898e Fetch artist images from spotify. 2016-02-17 15:55:37 +00:00
John Maguire 5b4c0c920c Blacklist artist images from echonest using dead last.fm server. 2016-02-17 15:55:37 +00:00
John Maguire a80e241bbe Make image requests follow redirects 2016-02-17 15:55:32 +00:00
John Maguire b0322e7e7d Cleanup ApplicationImpl 2016-02-15 17:41:39 +00:00
John Maguire 20bfade965 Hide Application classes behind pimpl. 
This should also fix the build on windows where gcc gets confused as
libmygpo declares DELETE as part of an enum and mingw #defines DELETE in
winnt.h
 2016-02-15 17:39:50 +00:00
Clementine Buildbot b3d5cabdc1 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-15 10:00:41 +00:00
John Maguire affb215a52 Move cover providers initialisation later in startup. 2016-02-12 16:25:01 +00:00
John Maguire dcdd81d69f Moar Lazy migrations 2016-02-12 16:10:56 +00:00
John Maguire b99b090adc Refactor simple dialogs to use Lazy 2016-02-12 16:01:35 +00:00
John Maguire 74e6a1744f Convert edit tag & settings dialog to Lazy. 2016-02-12 15:56:08 +00:00
John Maguire 589f2ff62e Lazy initialise organise dialog 2016-02-12 12:25:35 +00:00
John Maguire 0cf83b19ee Eagerly initialise TagReaderClient 2016-02-12 12:07:26 +00:00
John Maguire 86a6345995 Merge pull request #5251 from santigl/gainLabel 
EqualizerSlider: move include from .h to .cpp
 2016-02-11 18:03:18 +00:00
Santi 1fa4201926 EqualizerSlider move include from .h to .cpp 2016-02-11 14:59:39 -03:00
John Maguire 7d1abbda55 Don't connect action signals multiple times. 
Fixes #5249
 2016-02-11 17:07:00 +00:00
John Maguire ce3ba02749 Fix songkick concert fetching 2016-02-11 16:59:40 +00:00
John Maguire d06f337ade Remove special deletion of objects in threads. 
Fixes #5250
 2016-02-11 16:31:08 +00:00
John Maguire 729dc8e281 Merge pull request #5182 from abika/fix-fetch_edit_dialog 
Fix bug in edit tag dialog when fetching (2)
 2016-02-11 15:30:51 +00:00
John Maguire f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Alexander Bikadorov 56e95839f0 Revert to iterator usage in edit tag dialog 2016-02-11 16:09:38 +01:00
John Maguire 6844dcc140 Remove unused variable 2016-02-11 14:19:01 +00:00