ByteHamster
c3e1f8afbb
Made a bit more space
2020-02-05 16:43:41 +01:00
ByteHamster
f790b78b1a
Merge branch 'master' into develop
2020-02-05 13:10:04 +01:00
H. Lehmann
634c98317f
Merge pull request #3830 from ByteHamster/search-podcasts
...
Improved search function
2020-02-05 11:52:57 +01:00
ByteHamster
3ca6be8b04
Increase touchable area
2020-02-05 11:39:28 +01:00
ByteHamster
f3cbaee61b
Replaced eye icon with video cam
2020-02-05 10:07:01 +01:00
ByteHamster
3be4f80a5c
Removed search strings
2020-02-05 09:55:55 +01:00
ByteHamster
f4cfe7bdca
Do not search in chapters
...
This speeds up searching a LOT. I hope that most podcasts use good descriptions
and we do not need to search for chapters. Podcasts outside of Germany use chapters
only very infrequently.
2020-02-05 09:51:32 +01:00
H. Lehmann
8036498484
Merge pull request #3787 from ByteHamster/splash-for-all-screens
...
Display splash for all screens
2020-02-05 00:54:44 +01:00
H. Lehmann
3f85413b8d
Merge pull request #3831 from ByteHamster/verify-database
...
Verify database version before import
2020-02-05 00:51:26 +01:00
ByteHamster
75e0d2d7e1
Verify database version before import
2020-02-05 00:35:48 +01:00
ByteHamster
8d23571bba
Search for feeds separately
2020-02-05 00:06:32 +01:00
ByteHamster
50dd85276c
Fixed search returning duplicates
2020-02-04 23:50:38 +01:00
ByteHamster
cb702a2de6
Cleaned up layout
2020-02-04 22:46:13 +01:00
Keunes
12288d01a5
Update strings.xml
...
With the removal of the subheading (#3811 ), it isn't clear anymore when AP will vibrate. This will clarify the function/checkbox.
2020-02-04 22:18:04 +01:00
H. Lehmann
9c1232532c
Merge pull request #3825 from ByteHamster/do-not-linkify-duration
...
Do not linkify shownotes duration
2020-02-04 15:14:49 +01:00
ByteHamster
cae04b5b13
Extract queue item holder to new class
...
First step to use a single item holder in the future
2020-02-04 14:53:52 +01:00
ByteHamster
6a0542ca1f
Moved css to readable file instead of variable
2020-02-04 00:02:19 +01:00
ByteHamster
c524d20cc9
Do not add timecode link if timecode equals duration
2020-02-04 00:02:15 +01:00
H. Lehmann
7e2fd0b1d7
Merge pull request #3820 from ByteHamster/checkstyle
...
Enforce more checkstyle rules
2020-02-03 23:17:58 +01:00
H. Lehmann
da890bba52
Merge pull request #3819 from ByteHamster/notify-default-playback-speed
...
Update speed when changing feed defaults
2020-02-03 11:15:36 +01:00
ByteHamster
719af170a7
Enforce SeparatorWrap
2020-02-02 18:42:10 +01:00
ByteHamster
b656cb91a2
Enforce MethodParamPad
2020-02-02 18:42:06 +01:00
ByteHamster
8f08bd1f6d
Enforce method names
2020-02-02 17:48:30 +01:00
ByteHamster
b2fb239853
Enforce valid javadoc
2020-02-02 17:48:30 +01:00
ByteHamster
998a17a852
Update speed when changing feed defaults
2020-02-02 17:09:25 +01:00
H. Lehmann
4a4bbe16a6
Merge pull request #3818 from ByteHamster/fix-link-crash
...
Fixed crash when tapping external link in shownotes
2020-02-02 11:46:04 +01:00
ByteHamster
05b4945233
Fixed crash when tapping external link in shownotes
2020-02-02 10:50:16 +01:00
H. Lehmann
c16385743c
Merge pull request #3814 from ByteHamster/clean-up-statistics
...
Clean up statistics
2020-02-02 10:04:12 +01:00
ByteHamster
42313f5cea
Removed unused code
2020-02-01 19:24:19 +01:00
ByteHamster
edef730bd4
Clean up statistics
...
Removed unused `StatisticsData` wrapper class and extracted `StatisticsItem` to new class
2020-02-01 19:20:17 +01:00
ByteHamster
c174b3dcc1
Updated translations
2020-02-01 18:28:58 +01:00
H. Lehmann
63290ae762
Merge pull request #3813 from ByteHamster/shownotes-webview
...
ShownotesWebView improvements
2020-02-01 18:18:38 +01:00
ByteHamster
8356226e97
Always allow clicking timecodes
2020-02-01 18:02:19 +01:00
H. Lehmann
f5a30f6eed
Merge pull request #3811 from ByteHamster/sleep-timer-ui
...
Updated sleep timer UI
2020-02-01 11:05:04 +01:00
ByteHamster
17444d9a3c
Updated sleep timer UI
2020-02-01 10:50:44 +01:00
ByteHamster
29bc5109a6
Do not restart sleep timer when automatically playing next episode
2020-01-31 16:37:42 +01:00
ByteHamster
bb8a7a2ac0
Removed OPML import activity with only one button
2020-01-29 11:08:11 +01:00
ByteHamster
639c586a80
Cleanup
2020-01-29 11:08:11 +01:00
ByteHamster
8ecbe95e16
Moved database import/export to settings
2020-01-29 11:08:06 +01:00
ByteHamster
0c7dd3cc24
Added summaries
2020-01-29 11:04:08 +01:00
ByteHamster
2311c756ae
Updated html export design
2020-01-27 18:42:00 +01:00
ByteHamster
5e84229918
Enable PiP by default
2020-01-27 09:09:14 +01:00
H. Lehmann
8dd595e0e8
Merge pull request #3248 from maxbechtold/feat/simple-adjust-volume-per-feed
...
Feat/simple adjust volume per feed
2020-01-26 17:08:50 +01:00
ByteHamster
116125f721
Display splash for all screens
2020-01-26 13:44:30 +01:00
ByteHamster
964a519b8c
Always mock full feedMedia
2020-01-25 23:18:56 +01:00
ByteHamster
e09fae22a2
Fix volume adaption while paused
2020-01-25 22:53:26 +01:00
ByteHamster
190b54ad70
Converted to EventBus instead of broadcast
2020-01-25 22:52:00 +01:00
ByteHamster
e2ec07f607
Database upgrade
2020-01-25 22:35:18 +01:00
H. Lehmann
c8a05a83f9
Merge pull request #3782 from ByteHamster/seek-reliability
...
Make seeking more reliable
2020-01-25 22:22:47 +01:00
ByteHamster
3913ff8c45
Make seeking more reliable
2020-01-25 14:32:46 +01:00
H. Lehmann
d3964dac74
Merge pull request #3690 from ByteHamster/more-forgiving-duplicate-detection
...
More forgiving duplicate detection
2020-01-20 16:29:41 +01:00
ByteHamster
ac0cb04154
More forgiving duplicate detection
2020-01-20 15:39:00 +01:00
ByteHamster
b4b46fb4d8
Fix playback button
...
Steps to reproduce:
- Play
- Pause
- Close AudioPlayerActivity
- Open AudioPlayerActivity
- Tap speed button
- Always sets to the one after 1.0
2020-01-20 15:33:31 +01:00
ByteHamster
7702c9ee8c
Convert playback speeds to float
...
Advantage: When setting the speed to a value that is not available for the button
using the audio controls dialog, we no longer jump to the lowest value. Instead,
we jump to the next bigger one.
2020-01-20 15:33:24 +01:00
J.P.Klippel
7930d62bc0
changed mentions of 'feed' to 'podcast'
2020-01-19 11:07:14 +01:00
ByteHamster
8d0e89b255
Pulled translations
2020-01-16 00:23:11 +01:00
H. Lehmann
2f0c627b15
Merge pull request #3523 from wseemann/develop
...
Show storage size of downloaded episodes
2020-01-12 09:52:04 +01:00
William Seemann
6817c00491
Show storage size of downloaded episodes
2020-01-12 09:35:21 +01:00
ByteHamster
352078eeeb
Do not create new httpclient for each download
...
This is a memory leak and can cause crashes on some devices
2020-01-11 17:28:26 +01:00
H. Lehmann
2c45c4cd10
Merge pull request #3743 from txtd/mark-as-played
...
Show "mark as read" rather than "mark as play" in case item has no media
2020-01-11 12:47:22 +01:00
txtd
ce659f5cb2
Show mark as read rather than mark as played in case item has no media
2020-01-11 11:26:34 +01:00
Tony Tam
970cdd9905
Add summary to main settings/preferences screen ( #3745 )
2020-01-09 22:28:53 +01:00
H. Lehmann
b3f76e333b
Merge pull request #3711 from ByteHamster/load-more-new-episodes
...
Added paged loading to 'new episodes' list
2020-01-09 20:59:19 +01:00
H. Lehmann
5975f579d4
Merge pull request #3719 from ByteHamster/removed-unused-code
...
Removed unused code
2020-01-09 20:56:11 +01:00
ByteHamster
128f80fe55
Added paged loading to 'new episodes' list
2020-01-09 20:41:50 +01:00
H. Lehmann
cd0a69ef63
Merge pull request #3715 from ByteHamster/speed-up-search
...
Increased search performance
2020-01-09 17:27:48 +01:00
ByteHamster
2d93af6707
Use Google Trust provider
2020-01-07 12:17:08 +01:00
ByteHamster
3e8c1ee117
Only modify and query downloads array in main thread
...
This fixes a ConcurrentModificationException if the thread that queues downloads (database IO)
adds the item to the downloads list and the notification updater queries the downloads list at
the same time.
2020-01-03 22:50:30 +01:00
ByteHamster
44bb7d53a2
Removed custom ArrayList implementation that was only used in one location
2020-01-02 18:34:46 +01:00
ByteHamster
687693ccb0
Removed unused methods
2020-01-02 18:29:45 +01:00
ByteHamster
8119b4a8e1
Replaced custom background with selectableItemBackground
2020-01-02 18:22:53 +01:00
ByteHamster
417dcdacf0
Removed API checks
2020-01-02 18:22:46 +01:00
ByteHamster
e119b154cb
Do not enqueue on main tread (database IO)
2020-01-02 18:01:00 +01:00
ByteHamster
41af487a5b
Increased search performance
2020-01-01 16:21:28 +01:00
Max Bechtold
3fa210c414
remove check of media type
2019-12-30 12:39:59 +01:00
ByteHamster
d8a1744cd8
Fixed ArrayIndexOutOfBoundsException when updating feeds
2019-12-29 15:30:54 +01:00
Max Bechtold
3e610c85b9
provide drawable for volume adaption setting
2019-12-29 11:42:45 +01:00
Max Bechtold
95fd348c11
unregister volume adaption receiver
2019-12-29 11:21:30 +01:00
ByteHamster
a7a35b1569
Updated translations
2019-12-24 10:29:18 +01:00
Max Bechtold
12be60f1ba
resolve review remarks w.r.t naming: volume reduction -> volume adaption
2019-12-21 12:21:05 +01:00
Max Bechtold
9ca5cab246
Merge remote-tracking branch 'upstream/develop' into feat/simple-adjust-volume-per-feed
2019-12-21 11:52:01 +01:00
H. Lehmann
14d02f5143
Merge pull request #3695 from ByteHamster/playback-icon-size
...
Fixed playback speed icon mismatch
2019-12-20 00:15:08 +01:00
H. Lehmann
707fcdbc7f
Merge pull request #3654 from ByteHamster/emulator-test
...
Run integration tests on CI
2019-12-20 00:12:51 +01:00
ByteHamster
98647a705f
Fixed playback speed icon mismatch
2019-12-19 17:37:03 +01:00
ByteHamster
6785eb7689
Do not crash when clicking menu items while loading
2019-12-19 16:52:37 +01:00
ByteHamster
ecad7bdf94
Updated translations
2019-12-19 16:40:22 +01:00
ByteHamster
c148f76ef7
Signal unread items update after downloading
2019-12-17 15:23:52 +01:00
H. Lehmann
72520d7ac4
Merge pull request #3687 from ByteHamster/cancel-notification-updater
...
Cancel notification after cancelling notification updater
2019-12-15 10:26:48 +01:00
ByteHamster
3461bc376b
Cancel notification after cancelling notification updater
...
Otherwise, the notification can stay while the service is actually stopped
2019-12-15 10:03:18 +01:00
ByteHamster
e9f11c6c57
Extracted string resource
2019-12-13 10:00:37 +01:00
ByteHamster
51442cb047
Making sure to not click the wrong list
...
We might have multiple lists with the same ID in the hierarchy
2019-12-12 09:47:16 +01:00
ByteHamster
e2aa83f047
Remove queue item without checking taskmanager first
2019-12-12 09:47:16 +01:00
H. Lehmann
c21bc58525
Merge pull request #3680 from ByteHamster/create-channels
...
Make sure to create notification channels
2019-12-12 09:46:38 +01:00
ByteHamster
29f468b332
Make sure to create notification channels
2019-12-12 09:41:35 +01:00
H. Lehmann
3758caeefe
Merge pull request #3677 from ByteHamster/mark-seen-after-download
...
Mark as seen after download completed
2019-12-11 08:25:57 +01:00
ByteHamster
4530413d97
Fix DownloadService deadlock
...
downloadExecutor.take() clears the interrupted state of the thread when throwing an
InterruptedException. When getting this exception, we need to return instead of relying
on the loop to get cancelled.
2019-12-10 23:01:19 +01:00
ByteHamster
2c9f758f39
Mark as seen after download completed
2019-12-10 22:25:21 +01:00
H. Lehmann
a99a41e3bb
Merge pull request #3666 from ByteHamster/fix-cancellation-exception
...
Ignore cancellationException
2019-12-02 13:13:33 +01:00
ByteHamster
c752d90f4f
Wait for downloadCompletionThread to finish before stopping executors used by the thread
2019-12-02 13:07:51 +01:00
ByteHamster
cb3b1f2b1f
Ignore cancellationException
2019-12-02 13:04:52 +01:00
ByteHamster
26e91c0b81
Avoid too much nesting
2019-12-02 10:30:49 +01:00
H. Lehmann
cbcd97f6c9
Merge pull request #3663 from ByteHamster/continuous-playback-show-new-info
...
Show new info if playback stopped because continuous playback is off
2019-12-01 23:02:23 +01:00
Jonas Kalderstam
407e70ad2b
Added playback params to wrapper so speed can be changed while paused
...
You can't modify playback params on the ExoPlayer while paused (see
https://github.com/google/ExoPlayer/issues/4064 ) so added a member
object which *can* be modified while playback is paused. These
parameters are always applied on start of playback.
Fixes #3651
2019-12-01 21:54:00 +01:00
ByteHamster
4b0f6fb22a
Show new info if playback stopped because continuous playback is off
2019-12-01 19:34:39 +01:00
H. Lehmann
f6495232c5
Merge pull request #3647 from ByteHamster/fix-downloadservice-notification
...
Do not start download service if there is nothing to download
2019-11-26 21:02:57 +01:00
ByteHamster
bbb7cfe7ed
Do not start download service if there is nothing to download
2019-11-26 20:54:26 +01:00
ByteHamster
9d6225b022
Fixed NPE in DownloadRequester
2019-11-26 16:07:53 +01:00
ByteHamster
f2771f953f
Decrease connection timeout
...
If the server does not reply within 10 seconds, the download will also most likely fail.
2019-11-24 20:24:26 +01:00
ByteHamster
5c8f2b6e37
Added names to threads
2019-11-24 20:13:05 +01:00
ByteHamster
5f5cf628ca
Making sure that DownloadService always calls startForeground
2019-11-24 20:05:07 +01:00
ByteHamster
4bda044472
Fixed crash in download service
2019-11-24 19:57:56 +01:00
ByteHamster
523e084404
Updated translations
2019-11-24 10:28:44 +01:00
ByteHamster
02caa29faf
Hotfix: Do not delete episodes
2019-11-24 09:47:40 +01:00
H. Lehmann
7c514c0d0c
Merge pull request #3621 from ByteHamster/debug-icon
...
Added different icon to debug version
2019-11-22 22:48:27 +01:00
H. Lehmann
f5dd806279
Merge pull request #3637 from ByteHamster/remove-prestissimo
...
Removed prestissimo
2019-11-22 22:30:19 +01:00
H. Lehmann
1a6cb9bd41
Merge pull request #3639 from ByteHamster/show-failed-parse-badge
...
Show update failed badge on parse errors
2019-11-22 22:19:43 +01:00
H. Lehmann
c6fb84fa1f
Merge branch 'develop' into remove-prestissimo
2019-11-22 22:18:52 +01:00
H. Lehmann
f3008f442e
Merge pull request #3636 from ByteHamster/api-16
...
Bumped minimum API version to 16
2019-11-22 22:18:04 +01:00
ByteHamster
ef8202149d
Sending event after feed update failed
2019-11-22 22:12:57 +01:00
ByteHamster
71d09e321e
Save feed failed also when parsing failed
2019-11-22 22:02:03 +01:00
ByteHamster
4a3db25876
Fixed some lint errors
2019-11-22 19:29:17 +01:00
ByteHamster
9f1eb5a175
Removed prestissimo
2019-11-22 18:56:36 +01:00
ByteHamster
201bb0fe91
Bumped minimum API version to 16
2019-11-22 18:50:32 +01:00
H. Lehmann
a5ee83f373
Merge pull request #3629 from ByteHamster/streaming-icon
...
Updated streaming icon
2019-11-21 15:46:08 +01:00
H. Lehmann
275d608711
Merge pull request #3631 from ByteHamster/fix-sleep-timer
...
Stop listening to shake events and reset volume if sleep timer is reset
2019-11-21 14:16:16 +01:00
H. Lehmann
7fd8aa8503
Merge pull request #3630 from ByteHamster/podcast-settings-icon
...
Added icons to podcast settings
2019-11-21 14:13:10 +01:00
H. Lehmann
6c0f773188
Merge pull request #3628 from ByteHamster/explicitly-set-streaming
...
Explicitly set default download/streaming value for existing users
2019-11-21 14:08:50 +01:00
ByteHamster
69be01db4a
Stop listening to shake events and reset volume if sleep timer is reset
2019-11-21 11:42:39 +01:00
ByteHamster
06fe53f607
Added icons to podcast settings
2019-11-21 11:22:24 +01:00
ByteHamster
08cbb0bf96
Updated streaming icon
2019-11-21 11:08:31 +01:00
ByteHamster
4a6731d4e1
Explicitly set default download/streaming value for existing users
...
This mankes it easier to change the default later without affecting existing installs
2019-11-21 10:28:36 +01:00
H. Lehmann
f7dc2d6a7d
Merge pull request #3624 from ByteHamster/fix-download-order
...
Fix download order list
2019-11-21 10:05:48 +01:00
ByteHamster
6c43263446
Show custom title on download log page
2019-11-20 20:41:11 +01:00
ByteHamster
5bd3698e81
Fix download order list
2019-11-20 19:52:19 +01:00
ByteHamster
d8fce1ccbf
Added different icon to debug version
2019-11-20 17:58:26 +01:00
H. Lehmann
a6e4c4756c
Merge pull request #3611 from ByteHamster/feeditem-viewpager
...
Switched from gestures to ViewPager
2019-11-15 17:13:37 +01:00
ByteHamster
3c6540b82e
Added pubDate test
2019-11-15 15:41:55 +01:00
ByteHamster
5f7a11a865
Fixed feeditem date update
...
Bug introduced in d88e1202b1
2019-11-15 15:25:39 +01:00
ByteHamster
4336c10fb1
Tiny layout improvements
2019-11-15 10:43:26 +01:00
ByteHamster
27b92532da
Added overflow property
2019-11-13 11:02:20 +01:00
ByteHamster
cf2e784792
Reformatted css for readability
2019-11-13 11:02:07 +01:00
H. Lehmann
a3a5ac5de7
Merge pull request #3592 from orionlee/more_respect_download_order_2448_handle_cancel
...
More respect download order - handle cancel
2019-11-12 19:29:25 +01:00
H. Lehmann
60a070b56c
Merge pull request #3597 from ByteHamster/rework-about-screen
...
Rework about screen
2019-11-09 10:15:18 +01:00
ByteHamster
dfe463393b
Added developers list
2019-11-09 09:52:20 +01:00
ByteHamster
04e6764085
Made add podcast button even more prominent
2019-11-07 20:16:49 +01:00
orionlee
dc6221fb82
respect download order - dequeue upon cancelling download
2019-11-06 14:03:26 -08:00
orionlee
a6e5cd144d
refactor downloadMedia() - make DownloadService accepts a batch of DownloadRequests.
...
- the DB logic originally in DBTasks.downloadFeedItems() are moved to DownloadService.
2019-11-06 14:03:21 -08:00
orionlee
7bc5ca74f1
make DownloadRequest ArrayList parcelable (support a batch of them)
2019-11-06 13:54:20 -08:00
orionlee
fe33821e68
Refactor downloadMedia() : move entry points to DownloadRequester (from DBTasks)
2019-11-06 13:54:20 -08:00
H. Lehmann
3c0489890c
Merge pull request #3587 from ByteHamster/remove-commons-text
...
Removed commons text library that was just used 2 times
2019-11-06 19:38:01 +01:00
ByteHamster
a6624a9d05
Moved robotium dependency to test flavour
2019-11-06 18:47:13 +01:00
ByteHamster
d953692443
Removed commons text library that was just used 2 times
2019-11-06 17:18:08 +01:00
H. Lehmann
9df14af284
Merge pull request #3583 from ByteHamster/fix-headset-button-play
...
Fixed pressing play from headset button
2019-11-05 23:59:40 +01:00
H. Lehmann
17dc3c7471
Merge pull request #3584 from ByteHamster/fix-streaming-notification
...
Do not display streaming notification if continuous playback is disabled
2019-11-05 23:59:25 +01:00
ByteHamster
48dc4a8345
Do not display streaming notification if continuous playback is disabled
2019-11-05 23:51:38 +01:00
ByteHamster
24a7c11788
Fixed pressing play from headset button
...
When pausing, we stop the foreground service. This prevented re-entering
foreground state later, which lead to Android killing the service after a
few seconds.
2019-11-05 23:47:40 +01:00
H. Lehmann
af3cebbd08
Merge pull request #3582 from ByteHamster/empty-view-subscriptions
...
Added empty view to subscription list
2019-11-05 23:39:02 +01:00
ByteHamster
cbc4e9dc36
Added empty view to subscription list
2019-11-05 23:34:16 +01:00
H. Lehmann
e7b0fb729b
Merge pull request #3581 from ByteHamster/feedview-dialog
...
Style OnlineFeedViewActivity like a dialog
2019-11-05 23:30:42 +01:00
orionlee
89d76702c0
code style - reduce nested ifs
2019-11-05 12:34:12 -08:00
orionlee
9d6db7b9fc
enqueue respect download order: add test case for download failures.
2019-11-05 12:34:11 -08:00
orionlee
6e019f72de
code style / comment tweak per review
2019-11-05 12:34:11 -08:00
orionlee
b80973bc30
refactor - make enqueue position logic more readable per review.
2019-11-05 12:34:11 -08:00
orionlee
52f6a121f1
AFTER_CURRENTLY_PLAYING enqueue location option - test boundary condition handling
2019-11-05 12:34:11 -08:00
orionlee
e233398753
code style fixes: naming, indentation.
2019-11-05 12:34:11 -08:00
orionlee
bddd2bfa2e
enqueue location: use the new 3-value settings
2019-11-05 12:34:11 -08:00
orionlee
52521ecddb
#2652 the UI of a new setting enqueue location
...
- replaced existing enqueue at front
- the option after current episode will replace Keep In-Progress in Queue that was in the PR (30f104f4
).
2019-11-05 12:34:11 -08:00
orionlee
406f1cceb8
refactor move generic Collection helpers to CollectionTestUtil
2019-11-05 12:34:11 -08:00
orionlee
d24669d4c1
refactor extract common FeedItem List to IDs method
2019-11-05 12:34:11 -08:00
orionlee
69c0022472
code style fixes - naming, indentation, etc.
2019-11-05 12:34:11 -08:00
orionlee
418d4fa4d4
bugfix respect download order - obey user settings "Enqueue Downloaded"
2019-11-05 12:34:11 -08:00
orionlee
fb6fa010f8
Enqueue tweaks - replace custom stub DownloadStateProvider with mockito mocks in test
2019-11-05 12:34:11 -08:00
orionlee
2f82a5d464
refactor - rename FeedFileDownloadStatusRequesterInterface to a more generic DownloadStateProvider.
2019-11-05 12:34:11 -08:00
orionlee
cd3d20d613
refactor - move ItemEnqueuePositionCalculator to top-level per review.
2019-11-05 12:33:58 -08:00
orionlee
2d1ee52014
fix imports post androidX migration
2019-11-05 11:04:23 -08:00
orionlee
fb7fb05b5e
test case tweak: preserve download order test, fix test case name
...
(remove the incomplete expected from test case name)
2019-11-05 11:04:23 -08:00
orionlee
820b0b0793
test case bug fix: Bulk download 2nd item position should be 1
2019-11-05 11:04:23 -08:00
orionlee
ce5aa26878
refactoring test - factor out common operations of calc position,
...
add to queue and verify result into common helper.
2019-11-05 11:04:23 -08:00
orionlee
fb824b541d
Test cases readability: change expected format from position to the actual queue
...
(list of IDs), to make the test case more readable.
2019-11-05 11:04:23 -08:00
orionlee
97905e5ed4
#2448 : make podcast episode enqueue position respect download start order
2019-11-05 11:04:17 -08:00
orionlee
0973efa943
refactor test - break ItemEnqueuePositionCalculatorTest to be more modular
...
to prepare for testing more complex enqueue options.
2019-11-05 10:54:21 -08:00
orionlee
17e61335db
#2652 (part of): Expose keep in-progress at front as a preference
...
(in Playback > Queue section)
2019-11-05 10:54:21 -08:00
orionlee
30f104f40b
#2652 (part of): The in-progress podcast at the front of the queue
...
should remain at the front.
2019-11-05 10:54:21 -08:00
orionlee
bfde3c7315
refactor - DBWriterTest: parametrize the set of tests
2019-11-05 10:54:21 -08:00
orionlee
ba27ec6b31
refactor - DBWriter.addQueueItem() : refactor enqueue position calculation
...
to be a unit-testable component (static inner class)
2019-11-05 10:54:21 -08:00
ByteHamster
8aff9709c3
Style OnlineFeedViewActivity like a dialog
...
User study showed that new users do not get the difference between the actual
feed list and the preview. If the preview is a dialog, this is a lot easier to see.
Additionally, the "dialog" now closes after the subscription succeeded.
2019-11-05 15:28:32 +01:00
sevenmaster
386395629b
Clearer button text for feching podcast ( #3575 )
...
When subscribing to a podcast, the old text might be confusing to new users (it's not downloading an episode, just the feed. That is not considered downloading for most users)
Signed-off-by: sevenmaster <seven-master@hotmail.de>
2019-10-31 23:00:39 +01:00
H. Lehmann
2a2ced1631
Merge pull request #3572 from ByteHamster/downloadservice-refactoring
...
DownloadService refactoring
2019-10-31 09:23:47 +01:00
H. Lehmann
e7367e218d
Merge pull request #3571 from ByteHamster/hide-play-button-on-destroy
...
Updating notification play button in onDestroy
2019-10-30 19:30:20 +01:00
ByteHamster
69f3a1210f
Do not refresh feeds more often than necessary
2019-10-30 19:27:38 +01:00
ByteHamster
6825cca32a
Updating notification more often
2019-10-30 18:19:36 +01:00
ByteHamster
dd5ba4d38d
Do not access context in constructor
2019-10-30 18:16:34 +01:00
ByteHamster
ea6b41116f
Extracted DownloaderFactory to new class
2019-10-30 18:16:26 +01:00
ByteHamster
8f168948ad
Reordered methods to have setup on top
2019-10-30 18:06:44 +01:00
ByteHamster
366e60990d
Posting downloaders on executor
2019-10-30 18:05:26 +01:00
ByteHamster
fe17f1bcb5
Extracted handling completed downloads to method
2019-10-30 17:51:22 +01:00
ByteHamster
74621170fe
Converted our own FeedSyncThread to a task+executor
2019-10-30 11:10:44 +01:00
ByteHamster
798868db9c
Extracted notification from DownloadService
2019-10-29 23:58:44 +01:00
ByteHamster
056d7db16b
Extracted feed sync from DownloadService
2019-10-29 23:39:29 +01:00
ByteHamster
7ae5424479
Updating notification play button in onDestroy
2019-10-29 22:37:58 +01:00