code style / comment tweak per review
This commit is contained in:
parent
b80973bc30
commit
6e019f72de
|
@ -40,8 +40,10 @@ class ItemEnqueuePositionCalculator {
|
|||
case BACK:
|
||||
return curQueue.size();
|
||||
case FRONT:
|
||||
// return NOT 0, so that when a list of items are inserted, the items inserted
|
||||
// keep the same order. Returning 0 will reverse the order
|
||||
// Return not necessarily 0, so that when a list of items are downloaded and enqueued
|
||||
// in succession of calls (e.g., users manually tapping download one by one),
|
||||
// the items enqueued are kept the same order.
|
||||
// Simply returning 0 will reverse the order.
|
||||
return getPositionOfFirstNonDownloadingItem(0, curQueue);
|
||||
case AFTER_CURRENTLY_PLAYING:
|
||||
int currentlyPlayingPosition = getCurrentlyPlayingPosition(curQueue, currentPlaying);
|
||||
|
|
|
@ -189,17 +189,13 @@ public class ItemEnqueuePositionCalculatorTest {
|
|||
// A shallow copy, as the test code will manipulate the queue
|
||||
List<FeedItem> queue = new ArrayList<>(queueInitial);
|
||||
|
||||
|
||||
// Test body
|
||||
|
||||
Playable currentlyPlaying = getCurrentlyPlaying(idCurrentlyPlaying);
|
||||
|
||||
// User clicks download on feed item 101
|
||||
FeedItem tFI101 = setAsDownloading(101, stubDownloadStateProvider);
|
||||
doAddToQueueAndAssertResult(message + " (1st download)",
|
||||
calculator, tFI101, queue, currentlyPlaying,
|
||||
idsExpectedAfter101);
|
||||
|
||||
// Then user clicks download on feed item 102
|
||||
FeedItem tFI102 = setAsDownloading(102, stubDownloadStateProvider);
|
||||
doAddToQueueAndAssertResult(message + " (2nd download, it should preserve order of download)",
|
||||
|
@ -225,10 +221,6 @@ public class ItemEnqueuePositionCalculatorTest {
|
|||
}
|
||||
|
||||
|
||||
// Common helpers:
|
||||
// - common queue (of items) for tests
|
||||
// - construct FeedItems for tests
|
||||
|
||||
static void doAddToQueueAndAssertResult(String message,
|
||||
ItemEnqueuePositionCalculator calculator,
|
||||
FeedItem itemToAdd,
|
||||
|
|
Loading…
Reference in New Issue