Commit Graph

5690 Commits

Author SHA1 Message Date
ByteHamster d9e122f6d2 Added licenses screen 2019-11-09 09:56:42 +01:00
ByteHamster b401c5b64b Added commit to new about screen 2019-11-09 09:55:49 +01:00
ByteHamster ace46235c6 Added translators screen 2019-11-09 09:52:39 +01:00
ByteHamster dfe463393b Added developers list 2019-11-09 09:52:20 +01:00
H. Lehmann 43be061a64
Merge pull request #3588 from ByteHamster/remove-materialdialogs
Removed MaterialDialog dependency
2019-11-06 19:38:29 +01:00
H. Lehmann 3c0489890c
Merge pull request #3587 from ByteHamster/remove-commons-text
Removed commons text library that was just used 2 times
2019-11-06 19:38:01 +01:00
H. Lehmann fda1a783e8
Merge pull request #3589 from ByteHamster/move-robotium-to-test
Moved robotium dependency to test flavour
2019-11-06 19:37:34 +01:00
ByteHamster a6624a9d05 Moved robotium dependency to test flavour 2019-11-06 18:47:13 +01:00
ByteHamster fdd29fa3ec Removed MaterialDialog dependency
The AlertDialogs from Androidx are material, too.
2019-11-06 18:44:08 +01:00
ByteHamster d953692443 Removed commons text library that was just used 2 times 2019-11-06 17:18:08 +01:00
H. Lehmann 9df14af284
Merge pull request #3583 from ByteHamster/fix-headset-button-play
Fixed pressing play from headset button
2019-11-05 23:59:40 +01:00
H. Lehmann 17dc3c7471
Merge pull request #3584 from ByteHamster/fix-streaming-notification
Do not display streaming notification if continuous playback is disabled
2019-11-05 23:59:25 +01:00
ByteHamster 48dc4a8345 Do not display streaming notification if continuous playback is disabled 2019-11-05 23:51:38 +01:00
ByteHamster 24a7c11788 Fixed pressing play from headset button
When pausing, we stop the foreground service. This prevented re-entering
foreground state later, which lead to Android killing the service after a
few seconds.
2019-11-05 23:47:40 +01:00
H. Lehmann af3cebbd08
Merge pull request #3582 from ByteHamster/empty-view-subscriptions
Added empty view to subscription list
2019-11-05 23:39:02 +01:00
ByteHamster cbc4e9dc36 Added empty view to subscription list 2019-11-05 23:34:16 +01:00
H. Lehmann 562391c7d9
Merge pull request #3580 from ByteHamster/swipe-direction
Modified episode swipe directions
2019-11-05 23:31:01 +01:00
H. Lehmann e7b0fb729b
Merge pull request #3581 from ByteHamster/feedview-dialog
Style OnlineFeedViewActivity like a dialog
2019-11-05 23:30:42 +01:00
H. Lehmann 808f273c09
Merge pull request #2714 from orionlee/enqueue_keep_inprogress_front_2652_respect_download_start_order_2448
Enqueue fixes: keep inprogress front, respect download start order
2019-11-05 23:29:52 +01:00
orionlee 89d76702c0 code style - reduce nested ifs 2019-11-05 12:34:12 -08:00
orionlee 9e8904bbca code style fixes 2019-11-05 12:34:11 -08:00
orionlee 9d6db7b9fc enqueue respect download order: add test case for download failures. 2019-11-05 12:34:11 -08:00
orionlee 6e019f72de code style / comment tweak per review 2019-11-05 12:34:11 -08:00
orionlee b80973bc30 refactor - make enqueue position logic more readable per review. 2019-11-05 12:34:11 -08:00
orionlee f8fbc8e649 test fix: ensure test is not dependent on UserPreferences's enqueueLocation 2019-11-05 12:34:11 -08:00
orionlee 52f6a121f1 AFTER_CURRENTLY_PLAYING enqueue location option - test boundary condition handling 2019-11-05 12:34:11 -08:00
orionlee e233398753 code style fixes: naming, indentation. 2019-11-05 12:34:11 -08:00
orionlee bddd2bfa2e enqueue location: use the new 3-value settings 2019-11-05 12:34:11 -08:00
orionlee 52521ecddb #2652 the UI of a new setting enqueue location
- replaced existing enqueue at front
- the option after current episode will replace Keep In-Progress in Queue that was in the PR (30f104f4).
2019-11-05 12:34:11 -08:00
orionlee 406f1cceb8 refactor move generic Collection helpers to CollectionTestUtil 2019-11-05 12:34:11 -08:00
orionlee d24669d4c1 refactor extract common FeedItem List to IDs method 2019-11-05 12:34:11 -08:00
orionlee 69c0022472 code style fixes - naming, indentation, etc. 2019-11-05 12:34:11 -08:00
orionlee 418d4fa4d4 bugfix respect download order - obey user settings "Enqueue Downloaded" 2019-11-05 12:34:11 -08:00
orionlee fb6fa010f8 Enqueue tweaks - replace custom stub DownloadStateProvider with mockito mocks in test 2019-11-05 12:34:11 -08:00
orionlee 2f82a5d464 refactor - rename FeedFileDownloadStatusRequesterInterface to a more generic DownloadStateProvider. 2019-11-05 12:34:11 -08:00
orionlee cd3d20d613 refactor - move ItemEnqueuePositionCalculator to top-level per review. 2019-11-05 12:33:58 -08:00
orionlee 2d1ee52014 fix imports post androidX migration 2019-11-05 11:04:23 -08:00
orionlee fb7fb05b5e test case tweak: preserve download order test, fix test case name
(remove the incomplete expected from test case name)
2019-11-05 11:04:23 -08:00
orionlee 820b0b0793 test case bug fix: Bulk download 2nd item position should be 1 2019-11-05 11:04:23 -08:00
orionlee ce5aa26878 refactoring test - factor out common operations of calc position,
add to queue and verify result into common helper.
2019-11-05 11:04:23 -08:00
orionlee fb824b541d Test cases readability: change expected format from position to the actual queue
(list of IDs), to make the test case more readable.
2019-11-05 11:04:23 -08:00
orionlee 97905e5ed4 #2448: make podcast episode enqueue position respect download start order 2019-11-05 11:04:17 -08:00
orionlee 0973efa943 refactor test - break ItemEnqueuePositionCalculatorTest to be more modular
to prepare for testing more complex enqueue options.
2019-11-05 10:54:21 -08:00
orionlee 17e61335db #2652 (part of): Expose keep in-progress at front as a preference
(in Playback > Queue section)
2019-11-05 10:54:21 -08:00
orionlee 30f104f40b #2652 (part of): The in-progress podcast at the front of the queue
should remain at the front.
2019-11-05 10:54:21 -08:00
orionlee bfde3c7315 refactor - DBWriterTest: parametrize the set of tests 2019-11-05 10:54:21 -08:00
orionlee ba27ec6b31 refactor - DBWriter.addQueueItem() : refactor enqueue position calculation
to be a unit-testable component (static inner class)
2019-11-05 10:54:21 -08:00
ByteHamster 8aff9709c3 Style OnlineFeedViewActivity like a dialog
User study showed that new users do not get the difference between the actual
feed list and the preview. If the preview is a dialog, this is a lot easier to see.
Additionally, the "dialog" now closes after the subscription succeeded.
2019-11-05 15:28:32 +01:00
ByteHamster 9d5abba312 Modified episode swipe directions
- Allow queue swiping in both directions
- Do not allow swiping on tabbed screens where it interferes with tab switching
2019-11-03 23:47:15 +01:00
sevenmaster 363c3614f8 episodes should not look like a link (#3576) 2019-11-01 14:26:04 +01:00