Commit Graph

1634 Commits

Author SHA1 Message Date
Nathan Mascitelli 7e3ccd97da Fix regex 2019-03-02 12:12:26 -05:00
Nathan Mascitelli 6f69b4b140 Adjust regext to ignore X:Y timecodes 2019-03-02 08:47:52 -05:00
orionlee a3389490bb ensure the service continues to run in the event it takes a long time for the service to load the media to play, e.g.,
streaming over a slow network.
2019-02-27 14:59:31 -08:00
orionlee ab78c1d410 bug fix for Android8+: revert context.startService() calls back to
ContextCompat.startForegroundService(), to ensure PlaybackService
can be started.

While PlaybackService itself ensures it will be raised to foreground
when appropriate, Android 8+ forbids creating the (background)
services to begin with (and throw IllegalStateException) in some
situation (e.g., BroadcastReceiver).

https://developer.android.com/about/versions/oreo/android-8.0-changes#atap
2019-02-27 14:52:34 -08:00
orionlee 2c5db08e25 minor cleanup of Log codes and comments. 2019-02-27 14:52:34 -08:00
orionlee 221cd4b480 refactor stop PlaybackService setupNotification() - extract common
code as private helper.
2019-02-27 14:52:34 -08:00
orionlee f0f8623937 refactor stop PlaybackService codes - remove legacy dead codes 2019-02-27 14:52:34 -08:00
orionlee 584865ad18 review stop PlaybackService codes (stopSelf, stopForeground, etc.) 2019-02-27 14:52:34 -08:00
orionlee 3f14fac479 remove static PlaybackService.started, in favor of the start state
managed by inner ServiceManager.
Also add a generic java8-like Optional class for use with RxJava2 where
null was to be returned (RxJava2 requires non-null).
2019-02-27 14:52:34 -08:00
orionlee e26a54bdbc start playbackService code paths reviewed (context.startService() and
ContextCompat.startForegroundService())
2019-02-27 14:52:34 -08:00
orionlee 76fbab8e82 more #2716 - fix VideoPlayback upon hitting home button. 2019-02-27 14:52:34 -08:00
orionlee f3980091a9 #2716 Prototype for the revamped PlaybackService to fix phantom
notification. Many rough edges. Notable TODOs are marked with [2716].
2019-02-27 14:52:34 -08:00
ByteHamster 6dafc8b127 Transifex: removed duplicate Italian translation
Using it_IT for all italian languages because it's 100% finished
2019-02-21 15:17:59 +01:00
Nathan Mascitelli e94e4bc3d0 Use a single format for short timecodes
It is unlikely that multiple formats for short timecodes would be used
in one document. Therefor we will parse all the short timecodes to see
if they are all less then the duration as HH:MM. If they are we will use
that, otherwise we will parse them as MM:SS.
2019-02-13 21:06:19 -05:00
Nathan Mascitelli c49e98b546 Handle more then 23 hours 2019-02-12 20:53:17 -05:00
Nathan Mascitelli 39b9df5064 Timecode parsing logic now handles two short formats
We now handle both HH:MM and MM:SS when paring timecodes. We will move
in reverse order (assuming that the timecodes will increase over the
course of the document) and parse short codes as HH:MM. When we get a
result that does not fit into the duration we will change to parse as
MM:SS and use that for the rest of the document.
2019-02-12 19:43:57 -05:00
Nathan Mascitelli d0f617880c Converter handles HH:MM and MM:SS 2019-02-12 19:43:37 -05:00
Nathan Mascitelli 96b0336b2c Update Timeline regex
Regex now looks for the new types of short and long timestamps.
2019-02-10 18:01:00 -05:00
ByteHamster abe68ec7bd Merge remote-tracking branch 'upstream/develop' into auto_download_12_hour_option_2685 2019-02-01 16:25:20 +01:00
Burt Wiley Snyder 7f100b3fa6 Null handling in OnlineFeedViewActivity (#3004) 2019-02-01 15:57:19 +01:00
Hannes Achleitner 0663e422a6 unify lint options for all modules 2019-01-27 12:54:56 +01:00
Hannes Achleitner e9c10cdaa8 simplify build concerning maven repos 2019-01-27 12:45:32 +01:00
Hannes Achleitner 9ca7888d92 remove buildtools specification 2019-01-27 12:42:02 +01:00
pachecosf a80435a03b switched implementation to ussing attr 2019-01-18 12:09:24 -08:00
pachecosf fd83665970 Changed implementation using themeUtils instead 2019-01-17 16:21:34 -08:00
pachecosf 7da762b8ea Changed implementation using themeUtils instead 2019-01-17 16:18:50 -08:00
pachecosf ecff66eff6 fixed styles 2019-01-17 12:29:23 -08:00
pachecosf 43642a5e6b adding highlighting of drawer item functunality 2019-01-16 20:51:54 -08:00
pachecosf 5d3e3687f9 Adding some highlighting of drawer items 2019-01-16 18:26:42 -08:00
ByteHamster 994a73a06f NonNull annotation 2019-01-15 20:48:15 +01:00
ByteHamster 35f6050194 Only delete from queue if deletion of media succeeds 2019-01-15 11:30:48 +01:00
H. Lehmann cf477de365
Merge pull request #2921 from qkolj/delete-episodes
Add delete option to episode's context menu
2019-01-15 11:23:44 +01:00
ByteHamster 71fdc65c5b Hiding settings that ExoPlayer does not yet support 2019-01-15 11:18:02 +01:00
H. Lehmann 3cad182e41
Merge pull request #2961 from HaBaLeS/AP2253
Remove silence in podcast episodes
2019-01-15 11:08:56 +01:00
H. Lehmann 7265fc55ba
Merge pull request #2969 from ByteHamster/colorDark
Expanding toolbar
2019-01-15 10:44:05 +01:00
H. Lehmann d62aaf1026
Merge pull request #2968 from ByteHamster/translation-update
Translation updates
2019-01-15 10:43:04 +01:00
orionlee 9090d697b0 #2947 - fix app crash in some error case with ExoPlayer.
(It does not address root problems in #2947 though).
2019-01-11 13:33:25 -08:00
ByteHamster 6c9f15e0bc Splash status bar color 2019-01-10 13:12:23 +01:00
ByteHamster 84ede1b22d Expanding toolbar 2019-01-09 22:55:50 +01:00
ByteHamster 0914ac2b4a Updated strings.xml translations 2019-01-09 21:17:47 +01:00
H. Lehmann b2e18b8128
Merge pull request #2944 from abendebury/develop
Fix bug preventing database import on Android 9.
2019-01-06 00:04:08 +01:00
falko 73c8635354 Add skip silence checkbox to audio control
Add new Checkbox to dialog. Enable only if ExoPlayer is selected.

Selection directly changes player behavior
2019-01-05 23:15:02 +01:00
falko 1d8509fd8a Enable ExoPlayer feature to skip silence
SetSpeed was change to SetPlaybackParams which contain speed and a switch to skip silence. For Players that fo not support this the call is ignored or only SetSpeed is used. It is only working if ExoPlayeris used

Default is OFF
2019-01-05 23:14:08 +01:00
falko 33603f8edd Update ExoPlayer Version to 2.9.3
In order to support the feature to skip silence audio ExoPlayer must be
updated. Lateste avaiable Version is 2.9.3
2019-01-05 14:20:26 +01:00
orionlee eff2f154b5 fix code formatting 2019-01-04 10:33:26 -08:00
orionlee d1c73dda5b episode cleanup 12 hour option - use hours internally part 2 (persisted shared preference)
requires data migartion: app versionCode increased to 1070196
2019-01-04 10:33:26 -08:00
orionlee 566a682122 episode cleanup 12 hour option - use hours internally part 1 (actual algorithm, no persistence) 2019-01-04 10:33:25 -08:00
orionlee 4ff5690341 episode cleanup 12 hour option: add unit test to prepare for using hours
rather than days as data structure
2019-01-04 10:32:14 -08:00
orionlee 1bb0694403 Mark method only used in testing. 2019-01-04 10:32:14 -08:00
orionlee df6424be60 #2685: add "12 hours after finishing" option for auto download episodes cleanup 2019-01-04 10:32:14 -08:00
orionlee 33810b203e Mark method only used in testing. 2019-01-04 10:32:14 -08:00
orionlee 5bc497009a #2685: add "12 hours after finishing" option for auto download episodes cleanup 2019-01-04 10:32:14 -08:00
orionlee 949a05c17a fix #2956 - prevent ANR during some automatic feed update 2019-01-04 10:15:09 -08:00
Petar Kukolj dfcb16d77b Include Awaitility in app module and properly fix the added test 2019-01-04 00:13:00 +01:00
Petar Kukolj ebc0200968 Fix a style issue and fix the test 2019-01-03 22:50:30 +01:00
H. Lehmann 8252f6a41d
Merge pull request #2913 from orionlee/auto_feed_update_fix_in_airplane_2906
Auto feed update fix in airplane mode
2019-01-03 19:25:51 +01:00
H. Lehmann d7e7684cc0
Merge pull request #2859 from ByteHamster/glide-48
Upgraded Glide to version 4.8.0
2019-01-03 19:05:03 +01:00
ByteHamster b1ae1f8f2f Fixed loading embedded picture 2019-01-03 18:43:19 +01:00
ByteHamster 02bf71551b Code style 2018-12-26 08:53:41 +01:00
ByteHamster bb4b4655d2 Merge branch 'develop' into rxjava2 2018-12-26 08:40:40 +01:00
Alexei Bendebury f90ce4228b Fix bug preventing database import on Android 9.
Fixes #2925, fix suggested by ByteHamster.
2018-12-25 15:33:53 -08:00
H. Lehmann 580cc49b1b
Merge branch 'develop' into glide-48 2018-12-23 15:25:59 +01:00
Petar Kukolj b53a3c2ecf Move "Delete Removes from Queue" logic to DBWriter 2018-12-02 23:17:56 +01:00
qkolj 90e6259331
Fix grammar in strings
Co-Authored-By: qkolj <qkolj@users.noreply.github.com>
2018-12-02 17:10:40 +01:00
ByteHamster 3ca230ce60 Made it easier to see that 'go to page' has a submenu 2018-11-30 22:11:45 +01:00
Petar Kukolj 53957c9aa1 Use a resoruce array for fragments tags 2018-11-30 18:11:29 +01:00
Petar Kukolj a1f81d4144 Add delete option to episode's context menu
This PR makes following changes:

 - Adds delete option to episode's context menus in queue and feed list

 - Adds a storage preference that allows episodes to be automatically removed from queue when they are deleted (by clicking delete in context menu,
or pressing trash can icon on `Completed` tab of `Downloads` page)

 - Adds a test for the aforementioned preference
2018-11-29 21:56:29 +01:00
orionlee feef92f802 #2906: refactor: move auto feed update by interval helper,
checkShouldRefreshFeeds(), to proper level of abstraction.
2018-11-21 12:11:39 -08:00
orionlee 1dc366544e #2906: fix automatic feed update (by time interval) incorrectly run in airplane mode 2018-11-21 11:08:50 -08:00
Petar Kukolj 0d1b9c4c55 Use fragment tags instead of position indexes for saving chosen fragment 2018-11-17 20:13:35 +01:00
Petar Kukolj 6262f98e39 Add go to page option 2018-11-15 20:58:54 +01:00
Petar Kukolj b3fbb0ec75 Add configurable behavior of the back button
This PR allows users to change how the back button functions. Closes #2196

Possible choices are following:

 - **Default** - back button functions how it currently functions (closes the app if there is nowhere to go back to)

 - **Open navigation drawer** - back button always opens the navigation drawer instead of closing the app

 - **Double tap to exit** - like default, but requires two taps to close the app

 - **Confirm to exit** - like default, but prompts user if they really want to exit
2018-11-14 16:40:59 +01:00
Martin Fietz 68b245701e
Merge pull request #2870 from ByteHamster/tests-fix
Updated tests
2018-11-11 11:01:24 +01:00
Cameron Banga 82a9758147 Previously couldn't see the highlighted chapter on trueblack AMOLED because it was same color as background color. 2018-11-11 10:08:27 +01:00
Martin Fietz 816eb99e36
Merge pull request #2889 from AntennaPod/2882
Prevent NPE
2018-11-11 10:06:22 +01:00
Martin Fietz 2578d33206 2463 Do not close the database anymore 2018-11-07 21:11:28 +01:00
Martin Fietz 006204c3df 2463 Disable WAL 2018-11-07 21:10:25 +01:00
Martin Fietz 3ee412a560 Prevent NPE 2018-11-04 20:44:39 +01:00
Cameron Banga f30b76fe6c Changed show notes background color to black, and then as well as the overlay scrubber background to black. 2018-10-22 21:07:25 -05:00
ByteHamster 168b41a825 Updated tests 2018-10-21 22:12:07 +02:00
H. Lehmann 94a4b78449
Merge branch 'develop' into glide-48 2018-10-21 19:12:14 +02:00
Martin Fietz 59c2c5b1d6
Merge pull request #2868 from mfietz/feature/2849-fix-code-warnings
Feature/2849 fix code warnings
2018-10-21 11:25:25 +02:00
Martin Fietz 4621a38a11
Merge branch 'develop' into settings_icon_fix 2018-10-21 11:22:07 +02:00
egsavage a52f1ba34f Remove redundant type casts 2018-10-21 11:15:47 +02:00
egsavage 2dbcae1576 Optimize imports 2018-10-21 11:14:03 +02:00
Martin Fietz f069894b92
Merge pull request #2854 from gaul/error-prone
Fix error-prone errors
2018-10-21 11:06:04 +02:00
Martin Fietz a8fdf88b74
Merge pull request #2863 from ByteHamster/mark-all-below
Allow to select all above/below in batch editor
2018-10-21 11:05:43 +02:00
Martin Fietz 12c5819380 Merge branch 'develop' 2018-10-20 21:55:44 +02:00
Martin Fietz 2ccdb6ace8
Merge pull request #2861 from ByteHamster/pref-expanded-notification
Hiding expand notification preference on API 26
2018-10-20 11:30:52 +02:00
Martin Fietz e309b8db90 Update translations 2018-10-20 11:30:06 +02:00
Martin Fietz 790dce9164 Override JobIntentService to catch SecurityExceptions 2018-10-16 20:31:42 +02:00
ByteHamster 8ebb9854e6 Allow to select all above in batch editor 2018-10-16 14:31:49 +02:00
ByteHamster 221de87c04 Hiding expand notification preference on API 26 2018-10-15 15:31:14 +02:00
ByteHamster a05f386793 Upgraded Glide to version 4.8.0 2018-10-14 10:26:36 +02:00
sevenmaster 0435ea1a1a new icon for user interface preference 2018-10-13 11:21:06 +02:00
sevenmaster 432f405fe9 Revert "resized icon in settings to correct size"
This reverts commit 0ef011b464.
2018-10-13 10:58:30 +02:00
Andrew Gaul d88e1202b1 Fix error-prone errors 2018-10-13 00:23:50 -07:00
Martin Fietz de16a40691 Update translations 2018-10-08 18:34:24 +02:00
sevenmaster 0ef011b464 resized icon in settings to correct size 2018-10-04 14:01:21 +02:00
sevenmaster 1094ec9a56 made icons available throughout the whole project 2018-10-04 11:50:32 +02:00
sevenmaster df8024bb3e added icons in settings 2018-10-04 09:23:17 +02:00
Martin Fietz a79c7c0cfc
Merge pull request #2839 from AntennaPod/bugfix/2691-auto-update-network-not-ready
When auto refreshing feeds, give network some time to get available
2018-09-30 21:11:04 +02:00
Martin Fietz 3de661d953 Migrate rxjava to version 2 2018-09-30 19:58:53 +02:00
Martin Fietz 7269e3cb68 2815 Extract version 2018-09-30 17:08:17 +02:00
H. Lehmann c5245f5081
Merge pull request #2838 from AntennaPod/feature/2828-filter-favorites
Add feed filter criteria 'is favorite'
2018-09-30 14:06:03 +02:00
Martin Fietz c105a63165
Merge pull request #2665 from ByteHamster/prevent-thrashing
Prevent thrashing the database by opening and closing rapidly
2018-09-30 13:33:02 +02:00
Martin Fietz e1422acae3
Merge pull request #2689 from orionlee/auto_download_fix_during_feed_update_2577
Ensure that during feeds update, automatic (episodes) download the latest ones
2018-09-30 13:31:21 +02:00
Martin Fietz 340fbfb231
Merge pull request #2666 from orionlee/mark_as_seen_in_context_menu_2580
Expose "Mark as seen" as a context menu item in Episodes screen
2018-09-27 17:32:30 +02:00
Martin Fietz 3e6fc34550 When auto refreshing feeds, give network some time to get available 2018-09-27 17:24:41 +02:00
Martin Fietz 5a4219bf09
Merge pull request #2802 from 1nsidE/develop
[#2801] (AntennaPod failing to parse date in "Sun 01 Mar 2015 01:00:00 GMT-0400 (EDT)" format)
2018-09-27 16:30:05 +02:00
Martin Fietz 0ca7fc60b2
Merge pull request #2832 from ByteHamster/null-media-player
Do not crash if mediaPlayer is null
2018-09-27 13:53:41 +02:00
Martin Fietz c7ec2f26c6
Merge pull request #2834 from ByteHamster/npe-remote-psmp
Allow mediaPlayer to be null
2018-09-27 13:52:35 +02:00
Martin Fietz 96145eed11 Add feed filter criteria 'is favorite' 2018-09-27 13:49:30 +02:00
ByteHamster 7dc5d9cfb1 Allow mediaPlayer to be null 2018-09-26 17:32:39 +02:00
ByteHamster 33674625b4 Do not crash if mediaPlayer is null 2018-09-26 17:13:56 +02:00
Martin Fietz 7cf75c7cac 2815 Enqueue jobs with a unique job id per class
As Job IDs must be unique per uid, use IDs that no one else will use...
2018-09-06 16:49:12 +02:00
H. Lehmann 9512c0133f
Merge pull request #2785 from keunes/patch-1
Update (preference) strings
2018-09-04 23:45:08 +02:00
Koen Glotzbach b4e875cb09
Update strings.xml
Correct plural/singular in search strings
2018-09-04 23:09:46 +02:00
Koen Glotzbach 8379a21583
Lowercase strings
use lowercase for particular strings
2018-09-04 23:06:19 +02:00
InsidE 1796b5d739 Updated DateUtilTest to include new date format test. 2018-08-29 23:32:21 +02:00
InsidE 1e598156ae Fix date parsing error on "https://s3.us-east-2.amazonaws.com/podcast.intelligence.org/razmedia/razfeed.xml" 2018-08-19 14:06:00 +02:00
H. Lehmann 1d265a9c3a
Database access threading (#2781) 2018-08-06 23:38:37 +02:00
Koen Glotzbach 0fbee8f0ca
Update pref strings
Mainly replace all 'feed' mentions by 'podcast'
2018-07-29 15:22:00 +02:00
Koen Glotzbach 3bd9123852
Update strings.xml
Escape apostrophes
2018-07-28 10:56:26 +02:00
Koen Glotzbach 0172293a6d
Update strings.xml
- improved preferences strings
- improved sharing strings
2018-07-28 10:39:36 +02:00
H. Lehmann 4d79e44aa3
Merge pull request #2765 from ByteHamster/runtime-permissions
Requesting storage permissions for external files
2018-07-26 11:52:18 +02:00
H. Lehmann 06e3dc5829
Merge pull request #2780 from ByteHamster/audio-ducking
Requesting audio focus on Android O
2018-07-26 11:50:39 +02:00
H. Lehmann f68364d6fc
Merge pull request #2778 from ByteHamster/about-screen
Improved about screen
2018-07-26 11:49:53 +02:00
ByteHamster 7e05ff2a4e Theming support for about screen 2018-07-26 10:26:00 +02:00
ByteHamster c7d876c8ae Requesting audio focus on Android O 2018-07-25 23:56:35 +02:00
ByteHamster a691ab2614 Prevent NPE 2018-07-25 23:14:41 +02:00
Martin Fietz e1b0da978d Update translations 2018-07-22 18:37:37 +02:00
Martin Fietz 9646cc883c
Merge pull request #2655 from ByteHamster/exo-player
Added ExoPlayer
2018-07-22 18:22:16 +02:00
Martin Fietz 1b6f98203f
Merge pull request #2762 from ByteHamster/feed-description
Do not overwrite feed description with item description
2018-07-22 18:15:29 +02:00
H. Lehmann fc2bd0e19b
Merge pull request #2760 from ByteHamster/delete-item
Improve item deletion
2018-07-15 15:43:42 +02:00
ByteHamster c2184cfab2 Merge branch 'develop' into exo-player 2018-07-13 19:26:09 +02:00
ByteHamster 0d43cc8658 Requesting storage permissions for external files 2018-07-13 18:29:05 +02:00
ByteHamster 626621044f Player names are not translatable 2018-07-13 10:33:01 +02:00
H. Lehmann 5566b28943
Merge pull request #2761 from ByteHamster/notification-badges
Do not show badges for ongoing notifications (Closes #2724)
2018-07-13 10:30:34 +02:00
ByteHamster 3fce9490c2 Do not overwrite feed description with item description 2018-07-13 10:18:29 +02:00
ByteHamster 683e576987 Do not show badges for ongoing notifications (Closes #2724) 2018-07-13 09:38:34 +02:00
ByteHamster 53a3b85272 Actually stop PlaybackService 2018-07-13 09:23:36 +02:00
H. Lehmann eff72db7c4
Merge pull request #2754 from AntennaPod/bugfix/2749-parse-error
Assume version 2.0 for RSS if property is missing
2018-07-09 12:43:25 +02:00
ByteHamster 37f407dc07 Do not authenticate image without user 2018-07-07 09:48:12 +02:00
Martin Fietz 43911c3dab Assume version 2.0 for RSS if property is missing 2018-07-07 09:09:57 +02:00
ByteHamster 8a0769d466 Better feed parser errors 2018-07-06 10:10:21 +02:00
ByteHamster a9d9a5ac42 Added Exoplayer to new method 2018-07-04 23:54:04 +02:00
ByteHamster 3d1646c205 Merge branch 'develop' into exo-player 2018-07-04 23:53:02 +02:00
ByteHamster 67d3115049 Only highlight currently playing item if playback service is running
Killing the service while playing left the queue entry highlighted
2018-07-04 23:28:19 +02:00
ByteHamster dc8bd43d06 Merge branch 'develop' into playbackservice-improvements 2018-07-04 22:51:30 +02:00