Commit Graph

2251 Commits

Author SHA1 Message Date
bhlee 53073c958c add android:imeOptions="flagNoFullscreen" attribute in EditText 2019-07-14 21:14:54 +09:00
bhlee 329750ca01 add android:imeOptions="flagNoFullscreen" attribute in EditText 2019-07-14 21:09:56 +09:00
H. Lehmann 3b4fd3f414
Merge pull request #3271 from ByteHamster/fix-batch-edit
Fixed batch edit items grayed out on API 23 and 24
2019-07-14 10:30:10 +02:00
bhlee 339569421a add android:imeOptions="flagNoFullscreen" attribute in EditText 2019-07-14 01:48:50 +09:00
ByteHamster 5e1ab265b5 Fixed batch edit items grayed out on API 23 and 24 2019-07-13 17:47:27 +02:00
H. Lehmann 9fe4fed874
Merge pull request #3233 from jas14/pad-scrubber
Pad scrubber on large devices
2019-07-13 17:01:36 +02:00
H. Lehmann ed338edea4
Merge pull request #3266 from ByteHamster/remove-flattr
Removed Flattr support
2019-07-13 15:04:05 +02:00
bhlee f1d5c00f3b Resolves #3235. Refer to the changes.
- Remove android:screenOrientation="portrait" for rotating.
- Remove override onConfigurationChanged function that does nothing.
2019-07-13 20:14:16 +09:00
H. Lehmann c8fc1f90e0
Merge pull request #3265 from ByteHamster/storage-label
Added total space to storage select dialog
2019-07-12 22:51:11 +02:00
ByteHamster 641ee60cbf Removed Flattr support 2019-07-12 19:28:22 +02:00
ByteHamster b5b2bccda4 Added total space to storage select dialog 2019-07-12 18:59:43 +02:00
ByteHamster cbf3a2102f Simplified encoding query 2019-07-12 15:28:33 +02:00
ByteHamster 3962fdd6f8 Added CombinedSearcher for podcasts 2019-07-12 15:24:06 +02:00
ByteHamster eda23ca4bb Updated SearchPreference 2019-07-12 14:35:38 +02:00
H. Lehmann 9f6529d4bc
Merge branch 'develop' into 2747-completed-downloads-update 2019-07-11 12:43:30 +02:00
H. Lehmann e78e4d5656
Merge pull request #3261 from archibishop/fix-removing-wrong-favourite-message
Fix removing wrong favourite message
2019-07-11 12:42:14 +02:00
Wagubi Brian 782fce76d0 Fix removing wrong favoruite message 2019-07-10 12:29:48 +03:00
damoasda 9b7a61471d Queue: Keep sorted #1556 2019-07-09 08:55:46 +02:00
H. Lehmann 9e72780bc8
Merge pull request #3254 from jas14/feed-rotation-crash-3245
New ViewModel for loading feed preferences across lifecycle
2019-07-06 15:10:57 +02:00
H. Lehmann ce649ec087
Merge pull request #3249 from archibishop/imagecover-playpause-fuctionality
Extend play/pause functionality to Image Cover
2019-07-06 15:00:30 +02:00
Wagubi Brian e887996053 Extend play/pause functionality to Image Cover 2019-07-02 21:58:30 +03:00
Joe Stein 3b6cfb711f New ViewModel for loading feed preferences across lifecycle 2019-07-02 18:33:32 +02:00
Joe Stein 4bc8821845 Increase scrubber padding for large devices 2019-07-01 12:31:14 +02:00
ByteHamster 2d91292937 Combined podcast search 2019-06-26 08:27:19 +02:00
Wagubi Brian 7f1f725bfe validate username for characters not accepted. 2019-06-26 04:50:18 +03:00
Anderson Mesquita 8e95ed75ab Fix recycler and empty view hide/show logic
The `emptyViewHandler` already handles hiding and showing both the empty
view and the recycler view on data changes, so this commit removes this
part of the logic from the episodes fragment.

It also hides the empty view right after creating the recycle adapter
for the first time (when the fragment is created) to prevent the
progress bar and the empty view from being displayed at the same time.

`createRecycleAdapter()` signature was changed to make it explicit that
it depends on both the `recyclerView` and `emptyViewHandler`. Similarly,
`onFragmentLoaded()`, since it also depends on the new data that gets
loaded.
2019-06-24 09:32:06 -04:00
Anderson Mesquita bb8b1fc58f Reorganize subscription fragment lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita fd07a10f03 Reorganize search fragment lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita 5e5dfa5584 Reorganize playback history lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita 90d5208402 Reorganize item fragments lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita e22adbe451 Reorganize DownloadLogFragment lifecycle 2019-06-24 08:38:04 -04:00
Anderson Mesquita bbcec5d0aa Reorganize Episode Fragments lifecycle
This uses the existing android lifecycle methods to avoid having to do
null checks and state saving in various places.
2019-06-24 08:38:04 -04:00
Anderson Mesquita aabe370db3 Fix whitespace 2019-06-24 08:38:04 -04:00
Anderson Mesquita 486ceed0ef Reorganize downloads fragments lifecycle
Unregistering from the EventDistributor on stop will prevent downloads
from updating when an episode finishes playing while the screen was off
(#2747), so this registers/unregisters on view create/destroy.

Disposing of the request to load items on stop could potentially cause
the same issue. Since we're disposing of this request on destroy,
there's no need to keep checking and disposing of it in the several
lifecycle methods.

There's no need to call `onFragmentLoaded()` on attach, since this is
the first lifecycle method to be called [[1]], meaning the items will
always be null by the time this method is called.

Finally, since `loadItems` depends on the view being created, it is now
only called on view create to avoid having to store state in the class
about whether the view has been created, taking advantage of the native
fragment lifecycle.

[1]: https://developer.android.com/guide/components/fragments

Closes: #2747
2019-06-24 08:38:04 -04:00
Anderson Mesquita a556183d60 Extract methods from onViewCreated 2019-06-24 08:38:04 -04:00
Anderson Mesquita 69f116904d Fix IDE warnings
Deprecated method, null pointer exceptions, and simpler switch with only
two cases.
2019-06-24 08:38:04 -04:00
Anderson Mesquita 56dc16802a Fix whitespace 2019-06-24 08:38:04 -04:00
ByteHamster f3cd43b972 Cleanup 2019-06-14 10:45:45 +02:00
ByteHamster 5a7cbdfaca Added authentication and episode filter dialogs 2019-06-14 10:34:55 +02:00
ByteHamster 8f11f8a271 Updated feed settings screen 2019-06-14 00:38:34 +02:00
H. Lehmann 8931d5b795
Merge pull request #3227 from ByteHamster/restructure-settings
Restructured preferences code
2019-06-13 23:38:18 +02:00
ByteHamster 85ef61f4ef Removed deleted receiver from manifest 2019-06-13 23:18:12 +02:00
ByteHamster 99acff3b8f Restructured preferences code 2019-06-13 23:12:41 +02:00
H. Lehmann 3331b663e1
Merge pull request #3213 from fabolhak/add_episode_cache_summary
add pref_episode_cache_summary
2019-06-13 21:55:33 +02:00
Unknown ee1809001d don't override summary value in PreferenceController 2019-06-04 23:58:17 +02:00
H. Lehmann 405db1f169
Merge pull request #3164 from ByteHamster/work-manager
Work manager
2019-06-03 11:59:23 +02:00
ByteHamster 8dc4c9ff56 Upgrade preferences independently from database 2019-06-03 11:56:44 +02:00
Unknown 605e02fa70 add pref_episode_cache_summary 2019-06-01 18:16:47 +02:00
ByteHamster f05132a716 Allow to disable auto updates 2019-05-28 18:11:12 +02:00
ByteHamster 4443d629fc Merge branch 'develop' into work-manager 2019-05-28 17:56:05 +02:00
ByteHamster ce8adc4b26 Use annotation processor for EventBus 2019-05-28 17:26:09 +02:00
H. Lehmann d81cb2ff39
Merge pull request #3043 from CedricCabessa/remaining_time_playback_speed
Fixes #2197: Remaining time playback speed
2019-05-28 15:52:54 +02:00
Cédric Cabessa 60771673dc rename category title to match with "playback speeds"
also rename the key to be consistent with the content
2019-05-28 12:03:28 +02:00
H. Lehmann f563fe48b5
Merge pull request #3207 from ByteHamster/sort-description
Sort options: 'old to new' instead of 'ascending'
2019-05-27 22:54:21 +02:00
Anderson Mesquita 2450b0817b Replace action/callback utils with ItemActionButton
This just replaces all previous usages of `ActionButtonUtils` and
`DefaultActionButtonCallback` with the newly created `ItemActionButton`
class.
2019-05-27 16:06:55 -04:00
Anderson Mesquita 1d64057fd4 Extract action button utils/callback into classes
This splits the logic in `ActionButtonUtils` and
`DefaultActionButtonCallback` into multiple specialized classes to
reduce duplication figuring out which button/action to use while at the
same time making each individual button to have a single responsability.
2019-05-27 16:01:54 -04:00
ByteHamster 81a3d756eb Sort options: 'old to new' instead of 'ascending' 2019-05-27 21:09:55 +02:00
Martin Fietz c327fd59c9
Merge pull request #3206 from ByteHamster/clear-text-traffic
Clear text traffic in shownotes
2019-05-27 19:24:46 +02:00
ByteHamster 2d5995d1a5 Allow mixed content 2019-05-27 13:06:52 +02:00
ByteHamster 5ea11ca748 Allow cleartext traffic 2019-05-27 12:48:49 +02:00
H. Lehmann 46103883ce
Merge pull request #3191 from jas14/stricter-db-import
Check SQLite3 magic bytes before import
2019-05-27 12:44:44 +02:00
H. Lehmann 35770dc2e2
Merge pull request #3198 from jas14/fix-3196
Avoid error delivery to disposed Disposable
2019-05-27 12:41:33 +02:00
Joe Stein 382860d65e Avoid error delivery to disposed Disposable 2019-05-23 08:48:34 -04:00
Joe Stein 4f3fa6246e Added test for shutdown/widget updater race in PSTM 2019-05-21 18:36:04 -04:00
Joe Stein 09e138b51f Check SQLite3 magic bytes before import 2019-05-20 17:41:20 -04:00
H. Lehmann c98a7c0c38
Merge pull request #3136 from andersonvom/develop
Add progress bar with space information to data folder selection dialog
2019-05-19 19:38:37 +02:00
Anderson Mesquita e4a17562cb Improve space wording on choose data folder dialog
This makes it clear that the number refers to the **free** space left on
the device, as opposed to the total space available.
2019-05-19 13:25:27 -04:00
Anderson Mesquita 9396d41dcc Add space usage bar to data folder dialog
This displays a progress bar with the amount of used/free space in each
storage location to make it easier to identify storage devices. This is
particularly useful for devices that use non-standard names.

Reference: #3049
2019-05-19 13:25:27 -04:00
Anderson Mesquita 683f7e46a2 Extract data folder dialog layout
This is in preparation to add a progress bar displaying the amount of
used/free space in the dialog (#3049). Since we'll need a custom view to
do it, this extracts the layout beforehand.
2019-05-19 13:25:27 -04:00
Anderson Mesquita 31adff0dcc Extract methods in ChooseDataFolderDialog
This makes the main `showDialog()` method a bit shorter by extracting
behavior into shorter methods.
2019-05-19 13:25:27 -04:00
ByteHamster b2ea26d489 No longer try to remove log 2019-05-19 19:23:33 +02:00
H. Lehmann a8b05c3c66
Merge pull request #3165 from ByteHamster/opml-import-mismatch
Removed opml pick action
2019-05-19 19:22:14 +02:00
H. Lehmann 0b6930517a
Merge pull request #3109 from ByteHamster/eventbus-v3
Eventbus v3
2019-05-19 19:19:52 +02:00
ByteHamster 55874607df No longer need to listen to serviceEvent. PlaybackController does that automatically 2019-05-19 19:14:11 +02:00
ByteHamster ccbcdb6861 Fixed crash 2019-05-19 19:01:26 +02:00
ByteHamster 73744e3d4c Merge branch 'develop' into eventbus-v3 2019-05-19 18:59:03 +02:00
H. Lehmann fa03edf419
Merge pull request #3177 from andersonvom/fix-episodes-searchbar
Prevent actionbar items from moving when searching for episodes
2019-05-19 18:46:07 +02:00
Martin Fietz 5db139958a
Merge pull request #3162 from andersonvom/2853-chapter-scrolling
Scroll to chapter currently being played
2019-05-19 12:14:56 +02:00
Martin Fietz 8f93e3b2e2
Merge pull request #3172 from andersonvom/3169-cover-fragment-small-screen
Fix cover fragment in small screens
2019-05-19 12:01:45 +02:00
Martin Fietz 751670a659
Merge pull request #3168 from ByteHamster/about-open-browser
About screen: Open web links in browser
2019-05-19 11:34:17 +02:00
ByteHamster b89271329b Bumped version to 1.7.2b 2019-05-17 19:20:10 +02:00
H. Lehmann 1a327a2aae
Merge pull request #3188 from ByteHamster/revert-playbackservice-changes
Revert playbackservice changes
2019-05-17 15:23:41 +02:00
ByteHamster 3fca616e30 Revert "Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716"
This reverts commit 643173de14, reversing
changes made to f2d103736d.
2019-05-17 09:45:22 +02:00
ByteHamster 068a4255c1 Do not deliver result if view is destroyed 2019-05-14 22:19:56 +02:00
ByteHamster b617397397 Bumped version to 1.7.2 2019-05-12 18:25:15 +02:00
ByteHamster e99ce0a33b Do not query database on main thread 2019-05-12 00:20:30 +02:00
Anderson Mesquita 65abd2bbb4 Prevent actionbar items from moving when searching
Previously, when the user clicked the search button, the context menu
would be hidden and the refresh button would move way too close to the
edge of the screen.

This makes sure that when a user clicks the search button on the
episodes screen, the remaining actionbar items (refresh and context
menu) stay where they are.
2019-05-11 14:20:57 -04:00
ByteHamster c9b17c14f1 Bumped version to 1.7.2-RC5 2019-05-08 19:55:00 +02:00
H. Lehmann 96f582a4d4
Merge pull request #3166 from ByteHamster/fix-some-tests
Fixed some integration tests
2019-05-08 19:30:04 +02:00
Anderson Mesquita e9e61776ed Fix cover fragment in small screens
The cover fragment would hide both podcast and episode names in small
screen devices or multi-window mode.

This replaces the deprecated PercentRelativeLayout in favor of a regular
LinearLayout with weights to make sure that each section of the fragment
(podcast title, image, episode name) will have the necessary space in
the screen.

Since PercentRelativeLayout was only being used here, it also removes
the dependencies from the gradle files.

Closes: #3169
2019-05-08 09:48:00 -04:00
ByteHamster e464569712 Fixed NPE 2019-05-08 15:37:53 +02:00
ByteHamster df395ea388 Open web links in browser 2019-05-07 17:56:35 +02:00
ByteHamster 7ce4685447 Bumped version to 1.7.2-RC4 2019-05-07 15:54:36 +02:00
ByteHamster ae3cef3bd2 Fixed some integration tests 2019-05-06 23:52:02 +02:00
ByteHamster 0dc23a6c99 Removed opml pick action 2019-05-06 23:20:25 +02:00
ByteHamster dbda4a9aa8 Using WorkManager for feed updates 2019-05-06 23:04:19 +02:00
Anderson Mesquita 419c10632b Scroll to chapter currently being played
This is especially helpful for episodes that have a large number of
chapters.

Closes: #2853
2019-05-05 08:22:31 -04:00
Anderson Mesquita af31464cd5 Fix padding when count is zero and error happened
When we're not able to get the episode count for a podcast and updating
the feed fails, the error icon shown in the navbar is too close to the
right/end border of the nav drawer.

This fixes this padding.

Closes: #2982
2019-05-04 18:14:28 -04:00
H. Lehmann 0107cf22cc
Merge pull request #3155 from ByteHamster/empty-view-simplification
Simplify empty view handling on recycler views
2019-05-03 12:24:27 +02:00
ByteHamster 7f514384fc Fixed NPE when selected item is null
The method is called again with a valid listAdapter automatically
Closes #3154
2019-05-03 11:56:27 +02:00
ByteHamster 06c15fd9e6 Simplify empty view handling on recycler views 2019-05-03 11:06:04 +02:00
ByteHamster 7a921e0024 Fixed about screen readability in amoled theme (Closes #3151) 2019-05-03 10:20:23 +02:00
Martin Fietz 954cf87eff
Merge pull request #3147 from ByteHamster/fix-empty-list
Fixed empty list not receiving updates
2019-04-30 20:55:12 +02:00
ByteHamster 9b91a51df8 Fixed empty list not receiving updates 2019-04-30 18:57:09 +02:00
Anderson Mesquita a2cd8cca73 Return Optional feed when loading feed items
RxJava 2.x no longer accepts `null` values and will yield a
`NullPointerException` immediately or as a signal to downstream [1].

This returns an Optional<Feed> instead to avoid errors.

[1]: https://github.com/ReactiveX/RxJava/wiki/What's-different-in-2.0#nulls
2019-04-30 06:10:41 -04:00
Cédric Cabessa b2dc208019 force refresh time when playback speed change
This is useful when media is paused
2019-04-28 21:03:18 +02:00
Cédric Cabessa cf638a4978 use time converter and pref in MediaPlayer and Widget 2019-04-28 21:03:18 +02:00
Cédric Cabessa 743ec1927c add preference for "Time respects playback speed" 2019-04-28 21:03:18 +02:00
Anderson Mesquita 34d33f796e Close OkHttp request before making new ones
When adding certain podcasts [1], a `LeakedClosableViolation` is thrown
due to the fact that we're reusing the OkHttpClient to make multiple
requests (one to get the iTunes toplist for the user's language, and
another one defaulting to US).

This makes sure that all requests are closed to prevent this exception,
according to OkHttp docs [2].

[1]: https://podcasts.apple.com/us/podcast/stupid-genius-with-emma-chamberlain/id1458568923
[2]: https://github.com/square/okhttp/blob/18f2b5e/okhttp/src/main/java/okhttp3/Call.kt#L32-L40
2019-04-28 09:10:02 -04:00
ByteHamster a4dc3d9e96 Bumped version to RC3 2019-04-28 14:39:01 +02:00
ByteHamster 835d1f8cd3 Made null check work 2019-04-28 14:18:47 +02:00
ByteHamster 881578ee41 Bumped version to 1.7.2-RC2 2019-04-26 19:12:50 +02:00
ByteHamster 8e25f188c5 Fixed crash where recyclerAdapter is null
Closes #3138
2019-04-26 19:10:27 +02:00
ByteHamster 48ead285b3 Imported store description into new publisher layout 2019-04-26 18:10:56 +02:00
ByteHamster d0cbe158bb New Play publisher directory layout 2019-04-26 17:58:48 +02:00
H. Lehmann 309cd20d66
Merge pull request #3134 from ByteHamster/prepare-release
Prepare 1.7.2 release
2019-04-26 16:55:12 +02:00
ByteHamster 57301cf81c Making sure that publisher releases to alpha first, so we can wait for Pre-Launch-Report 2019-04-26 10:38:34 +02:00
ByteHamster f96c1d5367 Bumped versionCode 2019-04-26 10:37:05 +02:00
Anderson Mesquita fd2424edd4 Cleanup compiler warnings
Removes redundant casts and adds generic type to avoid compiler warnings.
2019-04-25 18:45:36 -04:00
ByteHamster 0925078770 Translation updates 2019-04-24 23:19:52 +02:00
ByteHamster 46f9a9c65b Added release notes 2019-04-24 23:12:03 +02:00
H. Lehmann 3b9e34e18e
Merge pull request #3131 from ByteHamster/fix-hiding-ExternalPlayer
Hiding ExternalPlayerFragment onStart
2019-04-24 23:05:55 +02:00
ByteHamster 92165f9021 Hiding ExternalPlayerFragment onStart
If the playback is finished in background, the fragmentLayout is not hidden.
Steps to reproduce (without this commit):
- Start last item in queue
- Leave app using home button
- Finish playback by using notification skip button
- Resume to AntennaPod
- ExternalPlayerFragment is shown (in invalid state) but should be hidden
2019-04-24 22:56:37 +02:00
Ali f2a777bd06 bugfix #3092 - time left on Queue screen not updated after download completes 2019-04-19 04:34:06 +01:00
ByteHamster f947b0a90d Fixed NPE 2019-04-13 16:01:17 +02:00
H. Lehmann 7c4d4656f8
Merge pull request #3113 from ByteHamster/fix-crash-npe
Fixed NPE
2019-04-12 23:20:29 +02:00
ByteHamster 8284251a91 Fixed NPE 2019-04-12 23:19:45 +02:00
ByteHamster 8ebc98af13 Fixed crash when re-using released controller 2019-04-12 11:55:41 +02:00
ByteHamster 09f4ebf08a Let PlaybackController handle listening for service start 2019-04-12 11:39:38 +02:00
ByteHamster 7d20baf4f9 Upgraded EventBus to v3
Also made sure that register/unregister are called in onStart/onStop
instead of onResume/onPause (prevents possible MultiWindow problems
where updates are not received because activity is not fucused).
2019-04-12 11:32:31 +02:00
H. Lehmann 3f1e6b5d50
Merge pull request #3106 from ByteHamster/subscriptions-columns
Set number of subscription columns
2019-04-12 10:56:26 +02:00
ByteHamster 777d92d4be Set number of subscription columns 2019-04-11 21:24:51 +02:00
ByteHamster d4c87facaf Fix displaying progress indicator in multi window 2019-04-11 20:54:48 +02:00
H. Lehmann 97d08f3b00
Merge pull request #3097 from ByteHamster/exoplayer-main-thread
Executing all ExoPlayer methods on main thread
2019-04-11 20:50:56 +02:00
H. Lehmann be6eb1c738
Merge pull request #3102 from ByteHamster/no-state-in-fragments
Do not hold state in fragments
2019-04-11 20:50:34 +02:00
ByteHamster 1d0e22135e Making sure that ExternalPlayerFragment is updated when starting first media 2019-04-11 20:41:39 +02:00
ByteHamster 0e3cabb86d Do not hold state in fragments 2019-04-10 01:05:36 +02:00
Martin Fietz d8a010ad48
Merge pull request #3100 from orionlee/bugfix_bulk_action_ui_survive_split_screen_3088
bugfix - bulk actions - make UI survive upon split screen
2019-04-08 18:54:01 +02:00
orionlee 345e6863c3 bugfix #3099 - add podcast by URL - show error dialog when URL points to no feed. 2019-04-07 14:56:15 -07:00
orionlee 1928411694 bugfix #3088 - bulk edit - make UI survive upon split screen 2019-04-07 14:27:29 -07:00
orionlee e16f44ad5d bugfix - rxjava2 null return - wrap nullable return with Optional 2019-04-06 14:22:53 -07:00
orionlee c04f340ae2 #2966 RxJava2 null - case underlying method has needs to return null.
Need to wrap return result with Optional<>
Mark code path with TODO. Actual fix is pending #2954 merge.

Rx observer: underlying sources that need to return Optional<>
OnlineFeedViewActivity.parseFeed : <anonymous subscriber>
PlaybackController.bindToService : fixed in #2954
2019-04-06 13:43:12 -07:00
orionlee 1655d234af #2966 RxJava2 null - case the underlying method may return null, but
should never happen in the code path, e.g.,
 return the current FeedItem in ItemFragment UI.
Mark underlying method as @Nullable, and let observer's existing
 onError() to handle null case

Rx observer : underlying sources marked as @Nullable
 ItemFragment.load : .loadInBackground
 MediaplayerActivity.checkFavorite : DBReader.getFeedItem
 ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem
 ItemlistFragment.loadItems : .loadData
2019-04-06 13:43:11 -07:00
orionlee 0472bb9237 #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
to be on the safe side, for cases that the consuming observers checks null
unnecessarily.

Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.startFeedDownload : Downloader.getResult
AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData
PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory
QueueFragment.loadItems : DBReader.getQueue
SearchFragment.search : .performSearch
2019-04-06 13:43:11 -07:00
orionlee 670fc124eb #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull
to be on the safe side, for cases that the consuming observers
already assumes the result is not null.

Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.listener member : DBReader.getFeedList
StatisticsActivity.loadStatistics : DBReader.getStatistics
CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt
CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems
DownloadLogFragment.loadItems : DBReader.getDownloadedItems
ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes
SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData
SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead
PreferenceController.export : ExportWorker.output member
2019-04-06 13:43:11 -07:00
H. Lehmann 5f86af88b1
Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145
Bulk remove from queue
2019-04-06 21:45:55 +02:00
ByteHamster 74fdabba69 Show single item after undo in EpisodesFragment 2019-04-06 21:32:03 +02:00
orionlee cb14fd930f refactor - rename string resource name `remove_episode_lable` , which was ambiguous with typos, to `delete_episode_label`
- non-default string resources to be handled by Transifex
2019-04-06 11:27:20 -07:00
orionlee 075547947e tweak - batch edit UI - support longer action label 2019-04-06 11:15:35 -07:00
orionlee 3bf880e34a remove comment to reduce mental work per review feedback 2019-04-06 11:15:35 -07:00
orionlee 86bf3ef3e0 remove outdated comment - support for vector drawables for pre Android 5 devices is here to stay. 2019-04-06 11:15:34 -07:00
orionlee 0204c1cebd tweak - bulk edit UI - remove hiding FAB during scroll per review feedback 2019-04-06 11:15:34 -07:00
orionlee 3311b4371e tweak - bulk edit UI - use Snackbar for selection message
- to be consistent with the action message in previous commit.
2019-04-06 11:15:34 -07:00
orionlee cc43af110a tweak - bulk edit UI - show a message after an action is applied. 2019-04-06 11:15:14 -07:00
orionlee 46f7805a96 refactor - bulk edit UI - make fab clickable on Pre-Lollipop devices without custom codes. 2019-04-06 11:12:34 -07:00
Martin Fietz 6c3033409d Create new adapter to show single item after undo 2019-04-06 16:28:07 +02:00
orionlee 836334798d refactor - UI - make OPML import screen use the new select all / none icons as well (so that only single set of icons are needed) 2019-04-04 13:58:50 -07:00
orionlee d186309066 bulk edit - UI - new select all / none icons, based on
standard Material icons.
2019-04-04 13:50:55 -07:00
orionlee dfe2241b4c bulk remove episodes from queue - UI - icon for dark themes. 2019-04-04 13:12:09 -07:00
Martin Fietz 4797d3ae56
Merge pull request #3086 from ByteHamster/fix-double-slash-url
Specifying base url
2019-04-04 19:06:34 +02:00
H. Lehmann 643173de14
Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716
Fix phantom service notification
2019-04-04 11:59:30 +02:00
orionlee b683d33bcb bulk edit - refactor - reorder method parameter for DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API. 2019-04-03 14:21:35 -07:00
orionlee bcaba92851 bulk edit - refactor - factorize common codes in binding action to its UI and actual logic. 2019-04-03 14:15:05 -07:00
orionlee 1052b393d2 bulk edit - refactor - rename menu ids, to be consistent with single edit counterparts 2019-04-03 13:40:55 -07:00
orionlee a1d718a59a bulk edit - refactor - rename internal constant flags so that the names are consistent 2019-04-03 13:31:32 -07:00
ByteHamster ce013bb225 Specifying base url
Fixes <a href="//example.com"> links
2019-04-03 18:53:11 +02:00
H. Lehmann 7a98e3c231
Merge pull request #3082 from ByteHamster/mobile-updates
Mobile updates: Allow images
2019-04-03 17:43:53 +02:00
H. Lehmann b6e50c61d6
Merge pull request #3060 from jatinkumarg/issue-3052
Added empty views to the PlayBack History, Queue,and Downloads
2019-04-03 17:42:09 +02:00
orionlee 48cf33d7da bulk edit - no longer defaulted to check all 2019-04-02 17:34:48 -07:00
orionlee 3768dfb0ff bulk edit - "N selected" UI logic 2019-04-02 17:34:05 -07:00
orionlee b8bb908b67 fix typo in comments 2019-04-02 16:56:22 -07:00
orionlee 364c9a308d bulk remove from queue - backend - implement the new API 2019-04-02 15:59:27 -07:00
Jatin Kumar f6370cc2b9 Renamed text view ids and added tools namespace 2019-04-02 17:36:27 -04:00
orionlee 7d78b88a1c bulk remove from queue - frontend logic, with a stub backend. 2019-04-02 14:11:22 -07:00
orionlee acbb1cf5e2 document android:elevation API compatibility 2019-04-02 13:59:54 -07:00
orionlee 9925830fff batch edit - replace the bottom button UI with FAB Speed Dial (no new actions yet) 2019-04-02 13:52:34 -07:00
orionlee 9f854fbd3b fix speed dial buttons order 2019-04-02 11:47:57 -07:00
orionlee 53e2511642 ensure speed dials clickable (for pre-Android 5 devices) 2019-04-02 11:47:57 -07:00
orionlee 4918a743a7 stub speed action action listener 2019-04-02 11:47:57 -07:00
orionlee f7fa0836ea make speed dials scrollable, so that they work in landscape / split window mode. 2019-04-02 11:47:57 -07:00
orionlee 737f7571ab UI Prototype for Batch Edit Episodes rework (from #1145) 2019-04-02 11:47:57 -07:00
ByteHamster 0fda36b9b3 Add preference to allow mobile updates of images 2019-04-02 17:41:15 +02:00
Jatin Kumar c661be344e Added include to the queue and episode layout 2019-04-01 20:40:58 -04:00
Jatin Kumar 7f035b8b4b Updated text sizes from dp to sp 2019-03-30 21:42:55 -04:00
H. Lehmann c6344f5bc0
Merge pull request #3073 from deandreamatias/fix-button-shadow-3040
Fix #3040 Video playback control button shadow
2019-03-31 00:44:50 +01:00
Matias de Andrea 007f92c291 Change the icons in interface #3040 2019-03-29 22:23:52 +01:00
Jatin Kumar 209b0b3880 Fixed typos 2019-03-29 14:20:11 -04:00
ByteHamster 8d8e333b84 Fixed fyyd feed search 2019-03-29 18:26:34 +01:00
Jatin Kumar cabf6fee7b Updated NewEpisodesFragment and FavoriteEpisodesFragment files 2019-03-27 04:55:50 -04:00
Jatin Kumar bdf7bf6844 Fixes #3052: Added empty views to the Playback History, Queue, Downloads and Episodes 2019-03-27 04:16:06 -04:00
ByteHamster 022a7f6981 Fixed FeedHandlerTest 2019-03-23 10:45:50 +01:00
Jatin Kumar 6662205167 Added empty views to the PlayBack History, Queue,and Downloads 2019-03-21 03:05:01 -04:00
orionlee 6f7b937d07 bugfix - video playback upon press back button (and pause), playback notification might reappear if one swipes it away quickly. 2019-03-09 14:16:53 -08:00
H. Lehmann 6212455431
Merge pull request #3048 from ByteHamster/new-episodes-download
Fixed download status update in NewEpisodesFragment
2019-03-08 12:15:23 +01:00
ByteHamster f2306d2950 Fixed download status update in NewEpisodesFragment 2019-03-08 11:39:24 +01:00
Matthieu De Beule c362a50e1b Fix #3028: actually use encodedQuery from URLEncoder to avoid encoding issues 2019-03-07 20:53:22 +01:00
H. Lehmann c1bfb9183c
Merge pull request #3013 from hannesa2/buildImprovements
Build improvements
2019-03-05 23:49:00 +01:00
H. Lehmann c0f534e825
Merge pull request #3050 from ByteHamster/add-backup-keyword
Add backup keyword to search
2019-03-04 18:57:37 +01:00
H. Lehmann cfa9304c82
Merge pull request #3047 from ByteHamster/move-to-unit-test
Moved some implementation tests to unit tests
2019-03-04 18:56:51 +01:00
H. Lehmann 3d9811d1e3
Merge pull request #3044 from mamehacker/min_max_speeds_from_preferences
Set min/max playback speeds from preferences
2019-03-04 18:53:34 +01:00
ByteHamster 579b263a86 Add backup keyword to search 2019-03-04 14:33:39 +01:00
ByteHamster c50d37fa1b Moved some implementation tests to unit tests 2019-03-03 23:55:52 +01:00
Nathan Mascitelli 7e3ccd97da Fix regex 2019-03-02 12:12:26 -05:00
Nathan Mascitelli 6f69b4b140 Adjust regext to ignore X:Y timecodes 2019-03-02 08:47:52 -05:00
orionlee e26a54bdbc start playbackService code paths reviewed (context.startService() and
ContextCompat.startForegroundService())
2019-02-27 14:52:34 -08:00
orionlee 76fbab8e82 more #2716 - fix VideoPlayback upon hitting home button. 2019-02-27 14:52:34 -08:00
orionlee f3980091a9 #2716 Prototype for the revamped PlaybackService to fix phantom
notification. Many rough edges. Notable TODOs are marked with [2716].
2019-02-27 14:52:34 -08:00
Shinichiro Fujiwara 6a56260157 Set min/max playback speeds from preferences 2019-02-27 22:29:28 +09:00
Nathan Mascitelli e94e4bc3d0 Use a single format for short timecodes
It is unlikely that multiple formats for short timecodes would be used
in one document. Therefor we will parse all the short timecodes to see
if they are all less then the duration as HH:MM. If they are we will use
that, otherwise we will parse them as MM:SS.
2019-02-13 21:06:19 -05:00
Nathan Mascitelli c49e98b546 Handle more then 23 hours 2019-02-12 20:53:17 -05:00
Nathan Mascitelli 39b9df5064 Timecode parsing logic now handles two short formats
We now handle both HH:MM and MM:SS when paring timecodes. We will move
in reverse order (assuming that the timecodes will increase over the
course of the document) and parse short codes as HH:MM. When we get a
result that does not fit into the duration we will change to parse as
MM:SS and use that for the rest of the document.
2019-02-12 19:43:57 -05:00
Nathan Mascitelli d0f617880c Converter handles HH:MM and MM:SS 2019-02-12 19:43:37 -05:00
Nathan Mascitelli 9180be85ba Update tests to handle minute timestamps
The definition of 'short timestamp' now means minutes and seconds, while
'long timestamp' means hours, minutes, and seconds. The first part of a
timestamp may have one or two digits. Tests updated for this new
definition.
2019-02-10 18:00:28 -05:00
ByteHamster abe68ec7bd Merge remote-tracking branch 'upstream/develop' into auto_download_12_hour_option_2685 2019-02-01 16:25:20 +01:00
ByteHamster 73bb2f712e Removed misleading comment
Auto-generating the versionCode breaks F-Droid builds, see #3012
2019-02-01 16:00:13 +01:00
ByteHamster 39c6ff5f31 Finish when closing error dialog 2019-02-01 15:59:30 +01:00
Burt Wiley Snyder 7f100b3fa6 Null handling in OnlineFeedViewActivity (#3004) 2019-02-01 15:57:19 +01:00
Hannes Achleitner 0663e422a6 unify lint options for all modules 2019-01-27 12:54:56 +01:00
Hannes Achleitner e9c10cdaa8 simplify build concerning maven repos 2019-01-27 12:45:32 +01:00
Hannes Achleitner 9ca7888d92 remove buildtools specification 2019-01-27 12:42:02 +01:00
Martin Fietz 7f37987bda
Merge branch 'develop' into android_gradle_330_upgrade 2019-01-27 11:40:24 +01:00
Martin Fietz bcfc951f1b
Merge branch 'develop' into android_gradle_330_upgrade 2019-01-27 11:35:46 +01:00
Hannes Achleitner 8e5abeea3a simplify versionCode
removed implementation was some Eclipse/ant style, now it's Gradle style
2019-01-27 10:57:45 +01:00
H. Lehmann 0474717ba1
Merge pull request #3005 from pachecosf/fix-ripple-effect
Reimplemented the ripple effect when choosing a nav item
2019-01-23 15:41:51 +01:00
pachecosf e0d6d35ca5 moved closing backet up one line 2019-01-23 05:22:39 -08:00
pachecosf 6753df01b5 changed location of setupGUI to prevent nullpointerexeptions when saved fragment had no initiliazed id 2019-01-23 00:01:18 -08:00
pachecosf 494b34d421 fixed losing media images and descriptions on rotate 2019-01-22 23:57:37 -08:00
pachecosf 8cb4cb16a5 fixed placing of the attr into nav_feedlistitem 2019-01-22 21:37:11 -08:00
pachecosf 4388c5a92f reimplemented the ripple effect when choosing a nav item 2019-01-22 21:30:15 -08:00
ByteHamster 6c2e9afad4 Fixed displaying feed url
Closes #2989
2019-01-19 10:56:10 +01:00
ByteHamster 24d72f93fa Re-added shorter lt description 2019-01-19 10:26:53 +01:00
H. Lehmann 20def27f22
Merge pull request #2993 from pachecosf/add-highlighting-of-drawer-item
Adding highlighting of drawer item functionality
2019-01-19 09:29:58 +01:00
pachecosf a421c490e4 cleaned up a couple of lines 2019-01-18 12:28:49 -08:00
pachecosf a80435a03b switched implementation to ussing attr 2019-01-18 12:09:24 -08:00
ByteHamster 4df5dd9d5e Added title to every language 2019-01-18 19:43:50 +01:00
ByteHamster 765e975df0 Play publisher forces to provide all resources for all languages
Filling with English until it's translated
2019-01-18 19:38:50 +01:00
ByteHamster 497dd3b493 Disabled lt description until it's short enough 2019-01-18 19:22:56 +01:00
ByteHamster 81612ddea6 Added symlinks to alternative publisher locations 2019-01-18 18:49:45 +01:00
ByteHamster 33f8bd78a4 Allow to configure play api key 2019-01-18 18:41:00 +01:00
pachecosf 7da762b8ea Changed implementation using themeUtils instead 2019-01-17 16:18:50 -08:00
orionlee 62711d9a11 Upgrade android gradle plugin to v3.3.0. Also upgraded plugins that would
otherwise generate warning message (dexcount, play-publisher).
2019-01-17 10:18:29 -08:00
pachecosf 43642a5e6b adding highlighting of drawer item functunality 2019-01-16 20:51:54 -08:00
pachecosf 5d3e3687f9 Adding some highlighting of drawer items 2019-01-16 18:26:42 -08:00
H. Lehmann cf477de365
Merge pull request #2921 from qkolj/delete-episodes
Add delete option to episode's context menu
2019-01-15 11:23:44 +01:00
ByteHamster 71fdc65c5b Hiding settings that ExoPlayer does not yet support 2019-01-15 11:18:02 +01:00
H. Lehmann 3cad182e41
Merge pull request #2961 from HaBaLeS/AP2253
Remove silence in podcast episodes
2019-01-15 11:08:56 +01:00
H. Lehmann 5b9914b435
Merge pull request #2984 from orionlee/to_last_activity_when_launch_2948
make AntennaPod go to last activity (rather than MainActivity) when launched again
2019-01-15 10:57:56 +01:00
H. Lehmann 3bd5679010
Merge pull request #2970 from keunes/patch-1
Remove radio mention
2019-01-15 10:43:43 +01:00
H. Lehmann d62aaf1026
Merge pull request #2968 from ByteHamster/translation-update
Translation updates
2019-01-15 10:43:04 +01:00
orionlee 81a624bd88 #2948: make AntennaPod go to last activity when launched again, per
standard Android App behavior.
2019-01-14 14:17:59 -08:00
orionlee b197914530 #2950 - fix app crash in OPML Export > Send flow
(for non-production builds)
2019-01-11 13:54:20 -08:00
Koen Glotzbach 6b4d947cda
Remove radio mention
AntennaPod doesn't manage radio stations. Related to #2968.
2019-01-10 00:50:09 +01:00
ByteHamster 5b318dfd57 Fixed typo 2019-01-09 22:30:46 +01:00
ByteHamster 28af5ff721 Pulled description 2019-01-09 21:17:47 +01:00
ByteHamster a3118bdc92 File structure to support play publisher
Only the language codes on the following page are supported:
https://support.google.com/googleplay/android-developer/answer/3125566
2019-01-09 21:17:40 +01:00
ByteHamster 1fac4158c3 Fix release build 2019-01-06 00:27:19 +01:00
falko 73c8635354 Add skip silence checkbox to audio control
Add new Checkbox to dialog. Enable only if ExoPlayer is selected.

Selection directly changes player behavior
2019-01-05 23:15:02 +01:00
orionlee 56a7208859 fix import order 2019-01-04 10:51:33 -08:00
orionlee 5d75fd645d correct the misleading comment 2019-01-04 10:33:26 -08:00
orionlee d1c73dda5b episode cleanup 12 hour option - use hours internally part 2 (persisted shared preference)
requires data migartion: app versionCode increased to 1070196
2019-01-04 10:33:26 -08:00
orionlee 566a682122 episode cleanup 12 hour option - use hours internally part 1 (actual algorithm, no persistence) 2019-01-04 10:33:25 -08:00
orionlee 5bc497009a #2685: add "12 hours after finishing" option for auto download episodes cleanup 2019-01-04 10:32:14 -08:00
Petar Kukolj dfcb16d77b Include Awaitility in app module and properly fix the added test 2019-01-04 00:13:00 +01:00
orionlee ab864cd171 enable multidex for debug build only, speeding up release build time 2019-01-03 13:56:40 -08:00
Petar Kukolj ebc0200968 Fix a style issue and fix the test 2019-01-03 22:50:30 +01:00
H. Lehmann 8252f6a41d
Merge pull request #2913 from orionlee/auto_feed_update_fix_in_airplane_2906
Auto feed update fix in airplane mode
2019-01-03 19:25:51 +01:00
H. Lehmann d7e7684cc0
Merge pull request #2859 from ByteHamster/glide-48
Upgraded Glide to version 4.8.0
2019-01-03 19:05:03 +01:00
ByteHamster b1ae1f8f2f Fixed loading embedded picture 2019-01-03 18:43:19 +01:00
ByteHamster e360aa04ef Fixed flickering caused by handler 2019-01-03 15:09:30 +01:00
ByteHamster c05f81a9f1 Encapsulated CoverTarget 2019-01-03 14:59:35 +01:00
ByteHamster a23e3466ad Switched splash screen start
The splash screen was added to prevent seeing the "non-ready" MainActivity.
If the splash is closed before showing MainActivity, the splash does
nothing in most cases, just flashes the screen blue for a few milliseconds.
After that, you see MainActivity just as it was before adding the splash.
2019-01-03 13:48:06 +01:00
ByteHamster 02bf71551b Code style 2018-12-26 08:53:41 +01:00
ByteHamster bb4b4655d2 Merge branch 'develop' into rxjava2 2018-12-26 08:40:40 +01:00
ByteHamster f23682f538 Do not crash 2018-12-23 15:45:30 +01:00
H. Lehmann 580cc49b1b
Merge branch 'develop' into glide-48 2018-12-23 15:25:59 +01:00
H. Lehmann f682a3b56c
Merge pull request #2915 from ahangarha/RTL-enhancement
Improve RTL support
2018-12-03 13:14:32 +01:00
Petar Kukolj c327fd75ee Add a test for "Delete Removes from Queue" behaviour 2018-12-03 01:27:52 +01:00
Petar Kukolj b53a3c2ecf Move "Delete Removes from Queue" logic to DBWriter 2018-12-02 23:17:56 +01:00
Petar Kukolj 9c43438cbe Make "Delete Removes From Queue" work consistently for all cases 2018-12-02 00:13:30 +01:00
Mostafa Ahangarha b9babd9fd1 force LTR dir for play controls 2018-12-01 21:20:34 +03:30
Mostafa Ahangarha 36b1fb4ead Fix padding and margin 2018-12-01 21:11:49 +03:30
Mostafa Ahangarha 519d65ef97 replave right with end for gravity attr 2018-12-01 21:05:20 +03:30
Mostafa Ahangarha 0948bfc4be force LTR dir for progressBar 2018-12-01 21:03:16 +03:30
Mostafa Ahangarha 41137eda62 Added margenLeft for wider support 2018-12-01 20:45:02 +03:30
Mostafa Ahangarha a41bc22916 force LTR dir for play btn 2018-12-01 20:44:24 +03:30
Mostafa Ahangarha e17eb8301c Force LTR in playing btns
Force LTR direction for keeping consistancy in playing experience across
all apps
2018-11-30 23:19:22 +03:30
Mostafa Ahangarha e64aab11a8 Force LTR direction
Playing btns should remain in LTR direction to keep consistancy in playing
media experience  across applications.
2018-11-30 23:12:48 +03:30
Petar Kukolj 53957c9aa1 Use a resoruce array for fragments tags 2018-11-30 18:11:29 +01:00
Petar Kukolj df90cb00eb Fix NPE when selecting Go to page for the first time 2018-11-30 16:52:44 +01:00
Petar Kukolj a1f81d4144 Add delete option to episode's context menu
This PR makes following changes:

 - Adds delete option to episode's context menus in queue and feed list

 - Adds a storage preference that allows episodes to be automatically removed from queue when they are deleted (by clicking delete in context menu,
or pressing trash can icon on `Completed` tab of `Downloads` page)

 - Adds a test for the aforementioned preference
2018-11-29 21:56:29 +01:00
Mostafa Ahangarha 0194d1ae7d fix icon margin in main menu 2018-11-29 01:52:32 +03:30
Mostafa Ahangarha 112c5942be Fix margin for author 2018-11-29 00:30:50 +03:30
H. Lehmann e70a9001dc
Merge pull request #2904 from qkolj/back-button
Add configurable behavior of the back button
2018-11-28 01:06:27 +01:00
Mostafa Ahangarha ff18c72c67 Improve RTL support
For all the layout elements having margin, padding,... to right or left,
releavnt start/end property is added so all the elements are supposed to
be displayed properly in RTL mode.

There are still minor issues related to some icons such as play, ff and
rev. This issue must be addressed separately in future.
2018-11-23 23:34:08 +03:30
Petar Kukolj 2393d4512c Fix coding style problems 2018-11-22 17:05:04 +01:00
orionlee feef92f802 #2906: refactor: move auto feed update by interval helper,
checkShouldRefreshFeeds(), to proper level of abstraction.
2018-11-21 12:11:39 -08:00
Petar Kukolj 98e75fc313 Fix not going back on child fragments 2018-11-20 23:40:31 +01:00
Petar Kukolj 0d1b9c4c55 Use fragment tags instead of position indexes for saving chosen fragment 2018-11-17 20:13:35 +01:00
orionlee 1d87910cbe #2878: fix episode screen context menu is applied on wrong feed item during refresh 2018-11-16 13:42:56 -08:00
Petar Kukolj c2f543ffe4 Add tests for back button behaviors 2018-11-16 18:21:04 +01:00
Petar Kukolj 6262f98e39 Add go to page option 2018-11-15 20:58:54 +01:00
Petar Kukolj b3fbb0ec75 Add configurable behavior of the back button
This PR allows users to change how the back button functions. Closes #2196

Possible choices are following:

 - **Default** - back button functions how it currently functions (closes the app if there is nowhere to go back to)

 - **Open navigation drawer** - back button always opens the navigation drawer instead of closing the app

 - **Double tap to exit** - like default, but requires two taps to close the app

 - **Confirm to exit** - like default, but prompts user if they really want to exit
2018-11-14 16:40:59 +01:00
Martin Fietz 68b245701e
Merge pull request #2870 from ByteHamster/tests-fix
Updated tests
2018-11-11 11:01:24 +01:00
Martin Fietz d26d212607 Prepare 1.7.1 release 2018-11-11 10:08:27 +01:00
Martin Fietz 180fa8084b Minor changes to proguard rules 2018-11-11 10:08:27 +01:00
Martin Fietz 49b7012431 Prepare 1.7.1-RC1 2018-11-07 21:11:39 +01:00
ByteHamster 168b41a825 Updated tests 2018-10-21 22:12:07 +02:00
H. Lehmann 94a4b78449
Merge branch 'develop' into glide-48 2018-10-21 19:12:14 +02:00
Martin Fietz 59c2c5b1d6
Merge pull request #2868 from mfietz/feature/2849-fix-code-warnings
Feature/2849 fix code warnings
2018-10-21 11:25:25 +02:00
Martin Fietz 4621a38a11
Merge branch 'develop' into settings_icon_fix 2018-10-21 11:22:07 +02:00
egsavage a52f1ba34f Remove redundant type casts 2018-10-21 11:15:47 +02:00
egsavage 2dbcae1576 Optimize imports 2018-10-21 11:14:03 +02:00
Martin Fietz f069894b92
Merge pull request #2854 from gaul/error-prone
Fix error-prone errors
2018-10-21 11:06:04 +02:00
Martin Fietz a8fdf88b74
Merge pull request #2863 from ByteHamster/mark-all-below
Allow to select all above/below in batch editor
2018-10-21 11:05:43 +02:00
Martin Fietz 12c5819380 Merge branch 'develop' 2018-10-20 21:55:44 +02:00
Martin Fietz 4ba36b8268 Prepare 1.7.0 2018-10-20 11:35:10 +02:00
Martin Fietz 2ccdb6ace8
Merge pull request #2861 from ByteHamster/pref-expanded-notification
Hiding expand notification preference on API 26
2018-10-20 11:30:52 +02:00
Martin Fietz e309b8db90 Update translations 2018-10-20 11:30:06 +02:00
ByteHamster 8ebb9854e6 Allow to select all above in batch editor 2018-10-16 14:31:49 +02:00
ByteHamster 221de87c04 Hiding expand notification preference on API 26 2018-10-15 15:31:14 +02:00
ByteHamster a05f386793 Upgraded Glide to version 4.8.0 2018-10-14 10:26:36 +02:00
Martin Fietz 2a067df6d1 2855 Cancel UI media info update when fragment is destroyed 2018-10-13 12:09:06 +02:00
sevenmaster 0435ea1a1a new icon for user interface preference 2018-10-13 11:21:06 +02:00
Andrew Gaul d88e1202b1 Fix error-prone errors 2018-10-13 00:23:50 -07:00
Martin Fietz 2d4739bd84 Prepare RC 2018-10-11 20:11:41 +02:00
Martin Fietz 6ab0277bb5 Fix proguard warning 2018-10-11 20:11:26 +02:00
Martin Fietz 8d1a2cdf94 Add proguard config for awaitility 2018-10-11 20:10:14 +02:00
Martin Fietz 32b83a1760
Merge pull request #2848 from egsavage/feature/2829-map-queues-time-left-to-current-playback-speed
Resolves #2829 - Make queue remaining time sensitive to playback speed
2018-10-11 19:09:24 +02:00
Martin Fietz de16a40691 Update translations 2018-10-08 18:34:24 +02:00
egsavage 98a19f0235 Resolves #2829 - Make queue remaining time sensitive to playback speed 2018-10-07 19:48:31 -04:00
sevenmaster df8024bb3e added icons in settings 2018-10-04 09:23:17 +02:00
Martin Fietz 20328dbd97 Fix fyyd 2018-09-30 20:33:40 +02:00
Martin Fietz 3de661d953 Migrate rxjava to version 2 2018-09-30 19:58:53 +02:00
Martin Fietz 340fbfb231
Merge pull request #2666 from orionlee/mark_as_seen_in_context_menu_2580
Expose "Mark as seen" as a context menu item in Episodes screen
2018-09-27 17:32:30 +02:00
ByteHamster 9fee2110c7 Implemented number picker preference 2018-09-26 16:59:51 +02:00
Marc Lasson 2d1045cacf Fix typo 2018-09-08 15:52:16 +02:00
H. Lehmann 9512c0133f
Merge pull request #2785 from keunes/patch-1
Update (preference) strings
2018-09-04 23:45:08 +02:00
H. Lehmann 1d265a9c3a
Database access threading (#2781) 2018-08-06 23:38:37 +02:00
Koen Glotzbach c88df8064c
Put 'mobile updates' above 'parallel downloads' 2018-07-29 15:54:19 +02:00
Koen Glotzbach d9ef971461
Move 'mobile updates' to 'details' section 2018-07-29 12:58:02 +02:00
H. Lehmann 4d79e44aa3
Merge pull request #2765 from ByteHamster/runtime-permissions
Requesting storage permissions for external files
2018-07-26 11:52:18 +02:00
H. Lehmann f68364d6fc
Merge pull request #2778 from ByteHamster/about-screen
Improved about screen
2018-07-26 11:49:53 +02:00
ByteHamster 7e05ff2a4e Theming support for about screen 2018-07-26 10:26:00 +02:00
ByteHamster 14ca32a624 Simplifications 2018-07-25 23:19:25 +02:00
ByteHamster 66fc848fe9 Fixed options menu persisting (Closes #2776) 2018-07-25 16:23:20 +02:00
ByteHamster aa2ec1687f better landscape view 2018-07-25 16:18:19 +02:00
ByteHamster f9eb2f839b Improved about screen 2018-07-25 16:02:44 +02:00
Martin Fietz 0cb8c85e02 Preprare for 1.6.6 2018-07-22 18:40:41 +02:00
Martin Fietz e1b0da978d Update translations 2018-07-22 18:37:37 +02:00
Martin Fietz 9646cc883c
Merge pull request #2655 from ByteHamster/exo-player
Added ExoPlayer
2018-07-22 18:22:16 +02:00
H. Lehmann fc2bd0e19b
Merge pull request #2760 from ByteHamster/delete-item
Improve item deletion
2018-07-15 15:43:42 +02:00
ByteHamster c2184cfab2 Merge branch 'develop' into exo-player 2018-07-13 19:26:09 +02:00
ByteHamster 0d43cc8658 Requesting storage permissions for external files 2018-07-13 18:29:05 +02:00
H. Lehmann 740e202d7f
Merge pull request #2763 from ByteHamster/download-actions
Allow to add to queue from downloads section
2018-07-13 17:27:54 +02:00
ByteHamster 235b81d40a Allow to add to queue from downloads section 2018-07-13 10:52:58 +02:00
ByteHamster cc645c5fb1 Only prevent deletion if PlaybackService is running (Closes #2759) 2018-07-13 09:18:12 +02:00
ByteHamster 8a0769d466 Better feed parser errors 2018-07-06 10:10:21 +02:00
ByteHamster 3d1646c205 Merge branch 'develop' into exo-player 2018-07-04 23:53:02 +02:00
Tobias Preuss 8600a3acdd Render preview for all episodes layout with sample data. 2018-06-27 00:28:46 +02:00
H. Lehmann c9c2e68d7b
Merge pull request #2718 from ByteHamster/broadcasts
Limit broadcasts to current app
2018-06-26 17:31:42 +02:00
H. Lehmann ac2acc65c3
Merge branch 'develop' into remove-unused-code 2018-06-08 20:27:11 +02:00
ByteHamster 83a9df2657 Merge branch 'develop' into exo-player 2018-06-08 20:14:57 +02:00
H. Lehmann f0151501a5
Merge pull request #2726 from ByteHamster/feedimage
Removed FeedImage
2018-06-08 20:13:36 +02:00
Martin Fietz f933cd226b
Merge pull request #2728 from ByteHamster/alifeflow-develop
True Black Theme for AMOLED
2018-06-06 21:53:10 +02:00
ByteHamster 1b84cbbef1 Merge branch 'develop' into feedimage 2018-06-06 17:25:05 +02:00
ByteHamster bb716ce9ea Moved playing background into attr 2018-06-06 16:32:41 +02:00
ByteHamster 2a8408d84d Merge branch 'develop' of https://github.com/alifeflow/AntennaPod into alifeflow-develop 2018-06-06 16:09:15 +02:00
ByteHamster dcb215ad70 Removed unused imports 2018-06-06 16:07:40 +02:00
ByteHamster 9cf71f85b9 Using utils 2018-06-06 16:05:05 +02:00
ByteHamster abb13dc447 Database scheme update 2018-06-06 00:07:21 +02:00
ByteHamster ba2233430e Removed FeedImage 2018-06-05 23:52:19 +02:00
ByteHamster 02186a3f0d Limit broadcasts to current app 2018-05-29 23:25:19 +02:00
ByteHamster 9df23ebbf6 Removed unused code 2018-05-27 20:07:29 +02:00
H. Lehmann f73a64050d
Merge pull request #2710 from ByteHamster/preferences-test
Fixed most preference tests
2018-05-27 19:09:11 +02:00
ByteHamster 5f46182151 Added manual scrolling 2018-05-27 18:54:53 +02:00
ByteHamster 920f061385 Fixed build 2018-05-26 23:49:47 +02:00
H. Lehmann 532d822b3c
Merge branch 'develop' into exo-player 2018-05-26 23:45:18 +02:00
H. Lehmann cd0d23d260
Merge pull request #2638 from ydinath/AboutActivityCleanup
About activity cleanup
2018-05-26 23:40:36 +02:00
H. Lehmann 39a462431f
Merge pull request #2667 from ByteHamster/api-26-support
Api 26 support
2018-05-26 23:39:35 +02:00
ByteHamster 9ce48bd86b Added a refreshAllFeeds method without callback 2018-05-26 23:20:47 +02:00
ByteHamster 3edbbe8c53 Moved notification utils to other package 2018-05-26 23:13:16 +02:00
ByteHamster 577f400a36 Fixed some of the preference tests 2018-05-26 23:08:16 +02:00
ByteHamster cddc1a7354 Improve autodownload in search 2018-05-18 11:54:53 +02:00
H. Lehmann 48294a9f18
Merge pull request #2669 from orionlee/build_tweak_dexcount_optional_in_debug
Build tweak: Speed up debug build by making dexcount optional in debug build
2018-05-14 20:56:20 +02:00
orionlee 0f1dfd0547 dexcount: remove dated comments 2018-05-14 10:55:47 -07:00
orionlee 4d4b1f9c17 make dexCount defaulted to disabled in debug build per reveiw feedback 2018-05-13 15:07:07 -07:00
amhokies 5fe060506a Issue #2680: Display time left in queue info bar 2018-05-10 21:25:36 -04:00
ByteHamster 407f92be12 Merge branch 'develop' into api-26-support 2018-05-07 20:02:07 +02:00
ByteHamster 3b445c3403 Re-enabled flattr 2018-05-07 18:11:43 +02:00
ByteHamster ea96e239fa Updated library 2018-05-07 18:09:07 +02:00
ByteHamster f8950ae9b8 Add search function to preferences 2018-05-07 00:06:38 +02:00
ByteHamster 4787e2ecc9 Fixed starting with DefaultActionButtonCallback 2018-05-06 20:07:35 +02:00
ByteHamster f6082f5808 Using builder to call PlaybackService 2018-05-06 19:46:31 +02:00
ByteHamster cb70aeb3cf Code style improvements 2018-05-06 19:15:40 +02:00
ByteHamster 61f8000352 Using callback instead of sync/async methods 2018-05-06 18:52:16 +02:00
Martin Fietz f6faca95c0
Merge pull request #2673 from ByteHamster/preference-support
Switched to PreferenceFragmentCompat
2018-05-06 17:45:25 +02:00
ydinath 274230ad25 Use filename instead 2018-05-05 18:07:51 -04:00
ydinath ce1f0620fe Fix back press issue 2018-05-05 17:35:43 -04:00
orionlee 221ca84aaf Remove comments per @mfietz feedback. 2018-05-05 13:45:23 -07:00
Martin Fietz e04e537829
Merge pull request #2674 from ByteHamster/delete-while-playing
Prevent deletion of currently playing item
2018-05-05 18:21:14 +02:00
ByteHamster 1628360c4b Prevent deletion of currently playing item
Was already prevented in the download list but not on the details fragment.
Added alpha to make disabled state clear.

Closes #2285
2018-05-05 17:19:37 +02:00
ByteHamster 7107819a6a Moved widget from app to core 2018-05-05 14:04:12 +02:00
ByteHamster 902068723c Added ExoPlayer to about section 2018-05-05 13:46:17 +02:00
ByteHamster 0b54d97a0a Switched widget to JobIntentService 2018-05-05 13:39:57 +02:00
H. Lehmann dacd7787bc
Merge pull request #2664 from orionlee/share_link_improvement_2579
Share link improvement 2579
2018-05-04 23:31:39 +02:00
ByteHamster c3510d821d Moved Flattr/gpodder to their own files 2018-05-04 19:07:17 +02:00
ByteHamster 686801fea2 Switched to PreferenceCompat 2018-05-04 19:06:32 +02:00
ByteHamster f66e19845c Review changes 2018-05-04 14:36:32 +02:00
orionlee 2e38cf3a40 Build tweak: Speed up debug build by making dexcount optional in debug
build, configured with a new gradle property enableDexcountInDebug.
2018-05-03 14:00:48 -07:00
ByteHamster 2190101cf9 Added JobScheduler for feed updates 2018-05-03 19:11:30 +02:00
ByteHamster 3e98ab61ea Start PlaybackService lazily to allow using ForegroundService 2018-05-03 19:11:30 +02:00
ByteHamster 7ad176ce29 Added notification categories
Android treats IMPORTANCE_DEFAULT as IMPORTANCE_HIGH
https://issuetracker.google.com/issues/65108694
2018-05-03 19:11:28 +02:00
orionlee 4c7531d277 Flatten nested ifs, per @ByteHamster feedback 2018-05-02 13:53:56 -07:00
orionlee 9dcbddf371 Issue #2580: Expose "Mark as seen" as a context menu item in Episode
screen, in addition to the existing swipe in Episode > New tab.
2018-05-02 13:15:14 -07:00
orionlee 345fcc17d0 FeedItem Visit Website tweak: use feed website as a fallback,
analogous to how share FeedItem link work.
Applicable to both feed playback screen and feed information screen.
2018-04-30 15:44:19 -07:00
orionlee 36507eb506 Provide share Link in episode information screen, similar to episode playback screen. 2018-04-30 15:14:58 -07:00
orionlee 4bba6b30a1 Issue #2579: Provide share Link in episode playback screen even
when the episode has no link - Use podcast link as the fallback.
Also bug fix share link with position: to include epsiode
and podcast title.
2018-04-30 15:03:04 -07:00
mr-intj 91120d98a4 Added "Random" and "Smart Shuffle" items at the bottom of the Queue|Sort menu.
Added "Permutor" interface to allow specification of reordering logic to be specified in QueueSorter (vs. DBWriter), similar to the existing sort logic.

Added "Random" and "Smart Shuffle" strings to core/src/main/res/values (did not add translations for non-English languages)

Closes #2366, Closes #2602
2018-04-27 17:30:40 -07:00
ydinath bb5f459744 Respect coding standard 2018-04-24 04:48:44 -04:00
ydinath 921665167f canGoBack doesn't work consistently when using loadDataWithBaseURL. Update old logic to allow depth > 1.
https://stackoverflow.com/questions/2686933/android-webview-can-render-html-going-forward-but-not-backward
https://stackoverflow.com/questions/14948652/webview-cangoback-not-working-when-using-loaddatawithbaseurl/15074071#15074071
2018-04-23 20:23:39 -04:00
ByteHamster 2bc3ca711c Merge branch 'develop' into exo-player 2018-04-22 21:33:19 +02:00
ByteHamster 9d3d92cc9d Fixed crash when changing settings
Looking at Fragment1, clicking Fragment2
Fragment2.onCreate
Fragment2.onResume
Fragment1.onPause <- This sets PreferenceUI to Fragment1, so onClickListeners
                     in Fragment2 now have a reference to the wrong fragment
2018-04-22 21:31:48 +02:00
ByteHamster c977e70106 Removed duplicate String 2018-04-22 20:49:41 +02:00
ByteHamster 8b72f35147 Merge branch 'develop' into exo-player 2018-04-22 20:48:00 +02:00
Martin Fietz e9695a426f
Merge pull request #2634 from ByteHamster/preference-rework
Preferences rework
2018-04-22 20:35:13 +02:00
ByteHamster f2ee5d7ff2 Renamed Services to Integrations 2018-04-22 19:20:11 +02:00
ByteHamster 74a8d34354 Added network icon 2018-04-22 19:16:03 +02:00
ByteHamster 1690bd64cc Actually renamy downloads to network 2018-04-22 19:00:07 +02:00
ByteHamster 610b1c05e1 Renamed downloads to network 2018-04-22 18:53:36 +02:00
ByteHamster 03f1af6ad4 Disable items correctly in autodownload 2018-04-22 18:51:10 +02:00
ByteHamster bb42ddbd56 MasterSwitchPreference 2018-04-22 18:41:43 +02:00
ByteHamster a64c996e9c Moved autodownload to new file 2018-04-22 18:12:40 +02:00
ByteHamster 33e695b519 Automation category 2018-04-22 17:49:20 +02:00
Martin Fietz e12751986b
Merge pull request #2564 from xisberto/adaptive_icon
Adaptive icon
2018-04-22 17:25:33 +02:00
ByteHamster 56aa64725c Merge branch 'develop' into preference-rework 2018-04-22 10:01:46 +02:00
Martin Fietz a4a7c9ebb9
Merge pull request #2657 from ByteHamster/more-invalid-positions
Ignore more invalid positions
2018-04-22 09:58:02 +02:00
ByteHamster 6d3fc04f52 Merge branch 'develop' into exo-player 2018-04-22 09:43:59 +02:00
ByteHamster d78191c8e8 Ignore more invalid positions 2018-04-22 09:37:54 +02:00
Martin Fietz 0a4bdfe65a
Merge pull request #2656 from ByteHamster/mark-all-played
Added warning to 'Mark all played'
2018-04-22 09:37:10 +02:00
Martin Fietz ff22099b88
Merge pull request #2641 from ByteHamster/feed-info-and-settings
Split feed info and settings
2018-04-22 08:59:39 +02:00
Martin Fietz 2cb4656d12
Merge pull request #2636 from ByteHamster/feature-graphic
Added feature graphic
2018-04-22 08:47:28 +02:00
Martin Fietz cca1de8d0d
Merge pull request #2637 from ByteHamster/apply-actions
Changed batch edit icon and name
2018-04-22 08:29:24 +02:00
Martin Fietz a9e269b3bf
Merge pull request #2506 from ByteHamster/picture-in-picture
Added Picure in picture
2018-04-22 08:07:05 +02:00
Martin Fietz 1cc72b3728
Merge pull request #2629 from ByteHamster/different-string
Split up two different uses of the string 'New'
2018-04-22 08:02:51 +02:00
ByteHamster f022ddaf8f Added warning to 'Mark all played'
Closes #2643
2018-04-21 19:11:24 +02:00
ByteHamster d50dcac96e Added ExoPlayer setting 2018-04-21 17:58:14 +02:00
ydinath fd13603be6 Use single instead of fromCallable 2018-04-20 21:27:24 -04:00
heckler01 3e10e50741 Remove unncessary inport 2018-04-20 21:27:23 -04:00
heckler01 0499ef60ac Fix typos 2018-04-20 21:27:21 -04:00
heckler01 4c014bd3e3 Remove unnecessary version check 2018-04-20 21:27:20 -04:00