octo/tooot
octo
/
tooot
mirror of https://github.com/tooot-app/app
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Improve sharing error messaging

This commit is contained in:
Zhiyuan Zheng 2022-05-05 23:08:29 +02:00
parent 4503fb991b
commit 8caf315894
3 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
src/Screens.tsx
View File

@ -197,6 +197,13 @@ const Screens: React.FC<Props> = ({ localCorrupt }) => {
'Image type not supported:',
mimeType.split('/')[1]
)
displayMessage({
message: t('shareError.imageNotSupported', {
type: mimeType.split('/')[1]
}),
type: 'error',
theme
})
return
}
images.push({ type: mimeType.split('/')[1], uri: data })
@ -206,6 +213,13 @@ const Screens: React.FC<Props> = ({ localCorrupt }) => {
'Video type not supported:',
mimeType.split('/')[1]
)
displayMessage({
message: t('shareError.videoNotSupported', {
type: mimeType.split('/')[1]
}),
type: 'error',
theme
})
return
}
video = { type: mimeType.split('/')[1], uri: data }
@ -241,6 +255,13 @@ const Screens: React.FC<Props> = ({ localCorrupt }) => {
'Image type not supported:',
item.mimeType.split('/')[1]
)
displayMessage({
message: t('shareError.imageNotSupported', {
type: item.mimeType.split('/')[1]
}),
type: 'error',
theme
})
return
}
images.push({ type: item.mimeType.split('/')[1], uri: d })
@ -250,6 +271,13 @@ const Screens: React.FC<Props> = ({ localCorrupt }) => {
'Video type not supported:',
item.mimeType.split('/')[1]
)
displayMessage({
message: t('shareError.videoNotSupported', {
type: item.mimeType.split('/')[1]
}),
type: 'error',
theme
})
return
}
video = { type: item.mimeType.split('/')[1], uri: d }

2
src/components/Message.tsx
View File

@ -59,7 +59,7 @@ const displayMessage = ({
if (ref) {
ref.current?.showMessage({
duration: type === 'error' ? 5000 : duration === 'short' ? 1500 : 3000,
duration: type === 'error' ? 8000 : duration === 'short' ? 3000 : 5000,
autoHide,
message,
description,

4
src/i18n/en/screens.json
View File

@ -10,5 +10,9 @@
"pushError": {
"message": "Push service error",
"description": "Please re-enable push notification in settings"
},
"shareError": {
"imageNotSupported": "Image type {{type}} not supported",
"videoNotSupported": "Video type {{type}} not supported"
}
}