ff931590b0
configuration/config: Move config loading and saving to functions based off groups ( #4855 )
...
Over time our config values have grown quite numerous in size.
Unfortunately it also makes the single functions we have for loading and
saving values more error prone.
For example, we were loading the core settings twice when they only
should have been loaded once. In another section, a variable was
shadowing another variable used to load settings from a completely
different section.
Finally, in one other case, there was an extraneous endGroup() call used
that didn't need to be done. This was essentially dead code and also a
bug waiting to happen.
This separates the section loading code into its own separate functions.
This keeps variables only visible to the code that actually needs it,
and makes it much easier to visually see the end of each individual
configuration group. It also makes it much easier to visually catch bugs
during code review.
While we're at it, this also uses QStringLiteral instead of raw string
literals, which both avoids constructing a lot of QString instances, but
also makes it much easier to disable implicit ASCII to QString and
vice-versa in the future via setting QT_NO_CAST_FROM_ASCII and
QT_NO_CAST_TO_ASCII as compilation flags.
2019-11-07 17:33:41 +01:00
35690e3ac7
Merge pull request #4948 from vvanelslande/amiibo-dad
...
citra_qt: add amiibo drag and drop support
2019-10-05 10:47:46 -04:00
a7b18efe49
Merge pull request #4945 from zhaobot/tx-update-20190921135538
...
Update translations (2019-09-21)
2019-10-04 08:32:09 +08:00
a757e9dc47
Merge pull request #4960 from zhaowenlan1779/ffmpeg-cmake-fix
...
CMakeLists: Fix `find_package` call
2019-10-03 19:47:49 -04:00
977ccda30f
CMakeLists: Fix `find_package` call
...
Fixes #4959
Previously options for video dumper and audio decoder is separated, but I forgot to split this `find_package` call so that the other libraries won't be necessary when only using the audio decoder.
2019-10-03 09:35:08 +08:00
acf1fe5ee1
externals: Update fmt to master ( #4955 )
2019-09-27 19:26:36 +02:00
80c9137a02
Merge pull request #4952 from FearlessTobi/backport-everything
...
Backport various review changes from yuzu
2019-09-24 22:39:06 -06:00
1e93f568b5
Address review comments
2019-09-22 20:48:32 +02:00
a5d880979c
Backport changes from yuzu-emu/yuzu#2057
2019-09-22 17:47:18 +02:00
0a3f75c25f
Backport changes from yuzu-emu/yuzu#2806
2019-09-22 17:40:04 +02:00
029cc77c4b
Backport changes from yuzu-emu/yuzu#2444
2019-09-22 17:27:01 +02:00
05240770e0
Merge pull request #4946 from vvanelslande/ipc-recorder-fix-ok
...
citra_qt/RecordDialog: close when OK is clicked
2019-09-22 01:44:33 -06:00
cf40735269
Merge pull request #4950 from jroweboy/sdl-title
...
Add FPS to SDL title bar
2019-09-22 01:39:51 -06:00
a650402eb5
citra_qt/RecordDialog: close when OK is clicked
...
The OK button didn't do anything before.
2019-09-21 23:56:07 -05:00
7152f4c748
Add FPS to SDL title bar
...
Also fix a small issue with incorrect shutdown ordering in SDL.
Previously the system would still be running so the telemetry task
didn't launch and detached_tasks would assert(count == 0)
2019-09-21 22:10:24 -06:00
07eb89c6ee
citra_qt: add amiibo drag and drop support
2019-09-21 17:08:19 -05:00
1e0e42044a
Update translations (2019-09-21)
2019-09-21 13:57:24 +00:00
223bfc9a2a
Merge pull request #4847 from zhaowenlan1779/ipc-debugger
...
core, citra_qt: IPC Recorder
2019-09-21 00:04:07 -06:00
04ca7bbc73
Merge pull request #4944 from jroweboy/hostlog
...
Added Host CPU and OS to log
2019-09-20 20:38:24 -06:00
63c31af8ee
Added Host CPU and OS to log
2019-09-20 20:34:01 -06:00
377abfa3e6
Merge pull request #4930 from vitor-k/pause-on-unfocus
...
Pause when in background
2019-09-20 14:51:01 -04:00
176b8b4a0b
Merge pull request #4917 from vitor-k/long-title
...
Allow displaying the long_title of the game
2019-09-20 12:59:04 -04:00
8d8bc8fee7
small changes to ApplicationState handling, just in case
2019-09-19 00:12:36 -03:00
c1d3b5e61c
Merge pull request #4934 from vitor-k/boost_remnant
...
Remove boost headers not currently used
2019-09-18 10:57:37 -06:00
4b05078def
Merge pull request #4922 from Steveice10/master
...
Filter non-executable files out of the game list.
2019-09-16 23:51:44 -06:00
3631490756
Merge pull request #4936 from BreadFish64/msvc-hack-extermination
...
remove ugly msvc hack
2019-09-16 16:01:35 -04:00
d0decf2166
remove ugly msvc hack
...
the bug appears to be fixed so there's no reason to keep this around
2019-09-15 22:35:21 -05:00
147a7f0dec
Remove boost headers not currently used
2019-09-15 15:18:38 -03:00
a65f07301a
Merge pull request #4933 from vitor-k/boost_remnant
...
Remove unused boost header
2019-09-15 13:44:47 -04:00
bb12af1da7
Remove unused boost header
2019-09-15 14:00:55 -03:00
05b1cfc63b
Pause in background guard clause and unused flag
2019-09-15 01:08:12 -03:00
66b1e419c3
Naming changes and clang format
2019-09-14 18:14:23 -03:00
360e6cb513
Merge pull request #4900 from leoetlino/exheader-fix
...
ncch_container: Fix NCCH decryption heuristic when replacing exheader
2019-09-14 10:33:06 -05:00
356fd60520
Add option to enable pause when on background
2019-09-13 23:01:12 -03:00
22d3099ea2
Merge pull request #4925 from vitor-k/icon-style
...
Change the coding style of GameListIconSize bounds check to use the enum
2019-09-13 23:20:45 +08:00
7bfd829c77
Merge pull request #4893 from wwylele/nfc-state
...
NFC: extract frontend-facing tag state
2019-09-13 08:59:51 -06:00
7224ec57f6
Only auto unpause when auto paused
2019-09-11 21:53:26 -03:00
23405b4ce1
Pause on unfocused first draft
...
This is a MVP, still needs one or more configuration option(s) and
review of the code style.
2019-09-10 21:52:17 -03:00
4d2fee31b3
Prevent repetition on config.cpp
...
Type is already indicated on right hand side.
Co-Authored-By: Mat M. <mathew1800@gmail.com>
2019-09-10 00:01:55 -03:00
966d128025
Remove newlines from the long title in row2
2019-09-09 23:40:32 -03:00
719912786a
UISettings::GameListText
...
Append a value to the enum to function as length counter.
Also remove magic numbers where possible, by using the enum instead.
2019-09-09 23:36:21 -03:00
1f1ac98f10
Fix clang format for long-title
2019-09-09 23:36:21 -03:00
c866a8e428
Change GameListText order to improve configuration compatibility
2019-09-09 23:36:21 -03:00
f9cded05fd
Allow displaying of the full title in the interface, as well as use the full title in the search filter
2019-09-09 23:36:21 -03:00
d6f2bc8c04
Merge pull request #4896 from zhaowenlan1779/game-list-fix-3
...
citra_qt: Misc game list updates/fixes
2019-09-09 20:04:04 -06:00
ccf6d380af
Change the coding style of GameListIconSize bounds check to use the enum instead of magic numbers
2019-09-08 19:37:55 -03:00
5cf684c951
Filter non-executable files out of the game list.
2019-09-08 14:19:11 -07:00
24ec11f928
Merge pull request #4915 from FearlessTobi/port-2818
...
Port citra-emu/citra#2818 : "externals: update fmt to 6.0.0"
2019-09-08 08:42:02 -04:00
4bc22aa350
Merge pull request #4918 from vitor-k/warnings
...
Silence warnings from unused code and mismatched declaration
2019-09-06 22:08:06 +08:00
61f9710d95
remove unused call to nodiscard function
2019-09-05 17:11:38 -03:00
Tobias
Weiyi Wang
Pengfei Zhu
MysticExile
James Rowe
vvanelslande
The Citra Community
Pat
vitor-k
BreadFish64
Steveice10