Commit Graph

42 Commits

Author SHA1 Message Date
Thomas Rittson 6bd5d579af
[PS-74] Fix user authentication state checks (#2481)
* Replace vaultTimeoutService.isLocked
2022-05-02 07:57:40 +10:00
Patrick H. Lauke 7b12868c70
[PS-497] Change `<content>` to `<main>`, make it explicitly non-focusable (#2245)
* Make <content> element explicitly non-focusable

Some browsers (Firefox, upcoming versions of Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=585413) make containers with `overflow: auto` / `overflow: scroll` (and the `-x` / `-y` variants) keyboard-focusable. This leads to a very awkward experience for assistive technology users navigating through the extension window, as for every view, the entire `<content>` container receives focus (and screen readers try to announce all its content in one go) before you reach the actual first control. To counteract this behaviour, this adds an explicit `tabindex="-1"` to these elements.

* Change `<content>` to `<main>`

More semantically accurate. See https://github.com/bitwarden/browser/pull/2245#issuecomment-1104553312

* Update scss to target `main` instead of `content`

* Change the previously existing `<main>` to generic `<div>`, tweak styles accordingly

Can't have two separate `<main>` elements, especially not nested ones. The original `<main>` was really just a handy wrapper for the component, but semantically should be neutral
2022-04-29 10:06:33 +10:00
Kyle Spearrin b475f911b6
fix disabling of generate type (#2515) 2022-04-21 17:20:47 -04:00
Thomas Rittson 4ed74416f4
[PS-211] [PS-212] Make Generator page accessible (#2513)
* Fix name attributes for radiobuttons in the same group

* Add role=radiogroup

* Add aria-labelledby

* Fix name
2022-04-21 09:49:13 -04:00
Kyle Spearrin b2def1479d
update generator (#2484)
* update generator

* update jslib

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
2022-03-31 19:03:45 -04:00
Patrick H. Lauke c6c22638d4
Add aria-label to password generator length slider, make it non-keyboard-focusable (#2478) 2022-03-31 13:16:34 +10:00
Kyle Spearrin bf081e0322
username generator (#2468)
* username generator

* pass usernameWebsite

* update jslib ref

* update jslib ref

* update jslib ref

* update jslib ref

* Update jslib to point to jslib master

* Updated package-lock.json after running npm i

* add missing translations

* pr feedback

Co-authored-by: Daniel James Smith <djsmith@web.de>
2022-03-30 17:59:58 -04:00
Oscar Hinton c27f421d56
Add eslint (#2405) 2022-02-24 18:14:04 +01:00
Vincent Salucci 33314869f0
[Icons] Update Font Sheet (#2272)
* [Icons] Update Font Sheet

* Prettier updates

* Updated refresh -> generate

* Updated closed folder icon

* Reverted to using a base class

* Update jslib

* Removed unused import

* Updated eye/eye-slash icon references

* Update jslib

* Updating fallback image for cipher icon

* Update jslib

* Removed duplicate icon base class

* Update jslib

* Prettier

Co-authored-by: Hinton <oscar@oscarhinton.com>
2022-01-28 04:53:06 -06:00
Daniel James Smith bd770c90ed
[Account Switching] Base changes for account switching (#2250)
* Pull in jslib

* Create new state models

* Create browser specific stateService

* Remove registration deprecated services, register stateService

* Replace usage of deprecated services (user, constants)

* Add missing properties to BrowserGroupingsComponentState

* Remove StorageService from initFactory

* Clear the correct state

* Add null check when restoring send-grouping state

* add remember email

* Initialize stateservice in services.module

* Fix 'lock now' not working

* Comment to remove setting defaults on install

* Pull jslib

* Remove setting defaults on install

* Bump jslib

* Pass the current userId to services when logging out

* Bump jslib

* Override vaultTimeout default on account addition

* Pull latest jslib

* Retrieve vaultTimeout from stateService

* Record activity per Account

* Add userId to logout and add fallback if not present

* Register AccountFactory

* Pass userId in messages

* Base changes for account switching di fixes (#2280)

* [bug] Null checks on Account init

* [bug] Use same stateService instance for all operations

We override the stateService in browser, but currently don't pull the background service into popup and allow jslib to create its own instance of the base StateService for jslib services.
This causes a split in in memory state between the three isntances that results in many errors, namely locking not working.

* [chore] Update jslib

* Pull in jslib

* Pull in jslib

* Pull in latest jslib to multiple stateservice inits

* Check vault states before executing processReload

* Adjust iterator

* Update native messaging to include the userId (#2290)

* Re-Add UserVerificationService

* Fix email not being remembered by base component

* Improve readability of reloadProcess

* Removed unneeded null check

* Fix constructor dependency (stateService)

* Added missing await

* Simplify dependency registration

* Fixed typos

* Reverted back to simple loop

* Use vaultTimeoutService to retrieve Timeout

Co-authored-by: Addison Beck <abeck@bitwarden.com>
Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-01-27 22:22:51 +01:00
Oscar Hinton 8fe821b9a3
Apply Prettier (#2238) 2021-12-21 15:43:35 +01:00
Patrick H. Lauke a3f2af707a Add clearer accessible names for password generator options
Closes https://github.com/bitwarden/browser/issues/1985
2021-12-18 22:29:53 +00:00
Patrick H. Lauke c8fc7ee6fc Add basic heading markup 2021-11-02 22:41:17 +00:00
Liu Junqi d48fb927eb also modified the minNumbers&minSpecial field 2021-10-22 11:40:51 +08:00
Liu Junqi 80d4739757 fix issue #1933 2021-10-22 10:11:01 +08:00
Patrick H. Lauke d528d72b4d Change links to buttons
- more semantically accurate, will expose these as buttons to assistive technologies
- note: while having block-level elements like `<div>` inside a `<button>` is an html validation error, it does not affect functionality as long as there's no more structure inside it
2021-07-31 20:50:46 +01:00
Shashank S 914d88770d
Use radio buttons for password generator type instead of dropdown (#1894)
* fix: radio instead of dropdown

* fix: revert changes, use from upstream

* chore: remove unnecessary label

* chore: undo unnecessary formatting

* chore: undo unnecessary formatting

* feat: update jslib version

* chore: add label, remove unnec. intlz.

* Remove unnecessary name attribute

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
2021-07-07 21:39:03 +10:00
Oscar Hinton 4e1958f417
Add jslib as a "real" dependency (#1876)
* Support split jslib

* Fix tests

* Bump jslib
2021-06-07 19:25:37 +02:00
K. Sasa 4a35930e2d
Consistent: Replaced the clipboard icon with a clone icon to improve UX (#1344)
* Replace clone item button fa-clone to fa-files-o

* Replace copy value button fa-clipboard to fa-clone
2020-07-27 13:22:56 -04:00
Vincent Salucci c6b0898213
Enforce Passphrase Policy (#1172)
* Update jslib (44b86f5 -> 36241e9) and initial commit of passphrase policy

* Reverted string changes - updated number of words event trigger

* Update input event to blur to match other number fields

* Update jslib (36241e9 -> 0a30c7e)

Co-authored-by: Vincent Salucci <vsalucci@bitwarden.com>
2020-03-12 17:52:14 -05:00
Kyle Spearrin a06ef80dc6
implement callout component w/ generator policy (#1158) 2020-02-28 16:58:28 -05:00
Vincent Salucci 9b4f1045f3
Enforce Password Generator Policy Options (#1155) 2020-02-28 11:43:27 -06:00
Kyle Spearrin 60f6863e4f a11y work 2019-10-08 17:04:44 -04:00
Kyle Spearrin 6fee946caf capitalize and include number for pass gen 2019-07-02 16:52:01 -04:00
Kyle Spearrin 6c7a0d90df addEditCipherInfo w/ collections from state 2019-06-24 21:12:52 -04:00
Kyle Spearrin 9539662166 fixes for changing generator length 2019-04-15 22:34:22 -04:00
Kyle Spearrin 0e343b9d5e password block fixes around wrapper 2019-04-01 13:45:14 -04:00
Kyle Spearrin e895dd31c8 dont use flex for password-wrapper positioning. 2019-04-01 13:19:00 -04:00
Kyle Spearrin 44af1ccc45 format html files 2019-02-21 16:53:57 -05:00
Kyle Spearrin 4f222e7962 apply flexCopy directive 2019-01-23 16:27:12 -05:00
Kyle Spearrin 6c22919bd9 colorized passwords 2018-12-08 14:00:18 -05:00
Kyle Spearrin b2d7074f11 add passphrase generation 2018-10-09 09:04:00 -04:00
Kyle Spearrin adb3dc78ee remove analytics in favor of platform utils 2018-10-03 00:21:22 -04:00
Kyle Spearrin 89a448b12f platform utils for toasting 2018-10-02 23:33:56 -04:00
Kyle Spearrin e5feb3f465 save length options on input blur 2018-08-30 08:06:37 -04:00
Kyle Spearrin 8737f76edc updated dates and password history 2018-07-30 10:54:38 -04:00
Kyle Spearrin c1b0114f07 large chevron 2018-04-20 16:57:24 -04:00
Kyle Spearrin 04f687d6fc pass window doc to copy function 2018-04-19 08:04:00 -04:00
Kyle Spearrin cfa0e1044f break all instead of word 2018-04-13 23:14:57 -04:00
Kyle Spearrin 1bc1e86a53 break words on password history 2018-04-13 23:05:31 -04:00
Kyle Spearrin 88c961ff05 box lists 2018-04-13 13:42:34 -04:00
Kyle Spearrin 082a74c241 folder listing, add/edit components, cleanup 2018-04-13 00:06:48 -04:00