devol
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity

Use radio buttons for password generator type instead of dropdown (#1894) 

* fix: radio instead of dropdown

* fix: revert changes, use from upstream

* chore: remove unnecessary label

* chore: undo unnecessary formatting

* chore: undo unnecessary formatting

* feat: update jslib version

* chore: add label, remove unnec. intlz.

* Remove unnecessary name attribute

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
This commit is contained in:
Shashank S 2021-07-07 17:09:03 +05:30 committed by GitHub
parent 72f315eada
commit 914d88770d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jslib

@ -1 +1 @@
Subproject commit 9ee31ad2fb950497a7c88c5073e23bf3bddf18c7
Subproject commit aff5ad1faabc4c680a6ff4e68b3abc301a50e9b4

15
src/popup/generator/password-generator.component.html
View File

@ -38,12 +38,15 @@
{{'options' | i18n}}
</div>
<div class="box-content">
<div class="box-content-row" appBoxRow>
<label for="type" class="sr-only">{{'type' | i18n}}</label>
<select id="type" [(ngModel)]="options.type" (change)="saveOptions()">
<option value="password">{{'password' | i18n}}</option>
<option value="passphrase">{{'passphrase' | i18n}}</option>
</select>
<div class="box-content-row">
<label class="sr-only radio-header">{{'type' | i18n}}</label>
<div class="radio-group text-default" appBoxRow *ngFor="let o of passTypeOptions">
<input type="radio" [(ngModel)]="options.type" name="Type_{{o.value}}" id="type_{{o.value}}"
[value]="o.value" (change)="saveOptions()" [checked]="options.type === o.value">
<label for="type_{{o.value}}">
{{o.name}}
</label>
</div>
</div>
</div>
</div>