Commit Graph

3892 Commits

Author SHA1 Message Date
Federico Maccaroni dde00ef10f Merge branch 'master' into PS-80-add-deviceid-2fa-email-resend
* master:
  [PS-74] Fix user authentication state checks (#2481)
2022-05-02 11:58:47 -03:00
Thomas Rittson 6bd5d579af
[PS-74] Fix user authentication state checks (#2481)
* Replace vaultTimeoutService.isLocked
2022-05-02 07:57:40 +10:00
Federico Maccaroni dfc238ed62 Merge branch 'master' into PS-80-add-deviceid-2fa-email-resend
* master:
  [PS-497] Change `<content>` to `<main>`, make it explicitly non-focusable (#2245)
  [PS-329] A11y: make view, copy, etc controls for ciphers/items keyboard focusable/operable, add screen reader improvements (#2507)
2022-04-29 13:18:16 -03:00
Patrick H. Lauke 7b12868c70
[PS-497] Change `<content>` to `<main>`, make it explicitly non-focusable (#2245)
* Make <content> element explicitly non-focusable

Some browsers (Firefox, upcoming versions of Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=585413) make containers with `overflow: auto` / `overflow: scroll` (and the `-x` / `-y` variants) keyboard-focusable. This leads to a very awkward experience for assistive technology users navigating through the extension window, as for every view, the entire `<content>` container receives focus (and screen readers try to announce all its content in one go) before you reach the actual first control. To counteract this behaviour, this adds an explicit `tabindex="-1"` to these elements.

* Change `<content>` to `<main>`

More semantically accurate. See https://github.com/bitwarden/browser/pull/2245#issuecomment-1104553312

* Update scss to target `main` instead of `content`

* Change the previously existing `<main>` to generic `<div>`, tweak styles accordingly

Can't have two separate `<main>` elements, especially not nested ones. The original `<main>` was really just a handy wrapper for the component, but semantically should be neutral
2022-04-29 10:06:33 +10:00
Patrick H. Lauke 9df22d3601
[PS-329] A11y: make view, copy, etc controls for ciphers/items keyboard focusable/operable, add screen reader improvements (#2507) 2022-04-28 18:24:13 +02:00
Federico Maccaroni 2eb5813b0e PS-80 Updated two-factor component to to align to jslib change to send the deviceId on 2fa email resend code 2022-04-27 22:03:12 -03:00
Thomas Rittson 17c3fdd68b
[EC-157] [BEEEP] Remove factory providers in Angular DI (#2516)
* Use initService

* Use InjectionTokens

* Update to use new locked and logout callbacks
2022-04-27 09:11:39 +10:00
Joseph Flinn 510c841359
Merge pull request #2520 from bitwarden/version_bump_1.58.0
Bump version to 1.58.0
2022-04-25 08:02:36 -07:00
github-actions[bot] cc6c51dfb1 Bumped version to 1.58.0 2022-04-25 15:00:35 +00:00
Oscar Hinton 6ad7f5a30a
Add reorganization notice (#2517) 2022-04-22 14:25:11 +02:00
Kyle Spearrin b475f911b6
fix disabling of generate type (#2515) 2022-04-21 17:20:47 -04:00
Thomas Rittson 4ed74416f4
[PS-211] [PS-212] Make Generator page accessible (#2513)
* Fix name attributes for radiobuttons in the same group

* Add role=radiogroup

* Add aria-labelledby

* Fix name
2022-04-21 09:49:13 -04:00
Patrick H. Lauke 58b39c613e
Remove unnecessary `role="button"` on `<button>` elements (#2514) 2022-04-21 14:33:20 +02:00
dwbit 796cc88b46
Merge pull request #2503 from bitwarden/dwbit-patch-1
Contribution Documentation edits
2022-04-21 08:02:05 -04:00
Patrick H. Lauke 2cafed758f
[PS-266] A11y: change tabbed interface to toggle buttons, correctly announce currently active tab as pressed (#2505)
* Change routerLink links to button elements

* Set aria-pressed attribute on button depending on routerLinkActive

* Change base styles to apply to tabs that use `<button>` instead of `<a>`
2022-04-20 14:25:44 +10:00
Thomas Rittson a02e966da4
Update jslib (#2511)
* Update jslib

* Update name of UserVerificationComponent

* Update service deps
2022-04-19 10:30:46 -05:00
Joseph Flinn a07c6869c2
Merge pull request #2504 from bitwarden/patch/download-artifacts-action
Bump pinned commit of download-artifacts
2022-04-18 14:28:55 -07:00
Joseph Flinn b26f9e64bb Bumping pinned commit of the download-artifact action to bypass the broken GitHub api 2022-04-15 07:41:46 -07:00
dwbit 13744e6a29
Contribution Documentation edits
Making corrections to the mobile contributions doc:

    Update Crowdin contact from Kyle to dwbit.
    Update 'User-to-User Support' forum category to 'Ask the Bitwarden Community'
2022-04-15 06:20:05 -04:00
Thomas Rittson 8cc3539716
Don't clear state if not logged in (#2499) 2022-04-13 09:15:46 +10:00
Daniel James Smith 29402f3109
[PS-102] BEEEP: Tab-change performance improvements (#2447)
* Remove passing in main to notification as it's unused

* Remove messages nothing reacts to

* Shorten re-draw of badge and menu on logout

* Remove windows.background and only listen to changes of tabs on focused window

* Only rreact to tab changes of current active tab

* Comments and console-logs

* Removed comments and console.logs

* Updated package-lock.json

* Check if chrome.windows is available

* Simplify check for active tab
2022-04-11 12:00:07 +02:00
github-actions[bot] f614ed877c
Autosync the updated translations (#2497)
Co-authored-by: github-actions <>
2022-04-08 11:48:43 +02:00
Oscar Hinton 24f54c580a
Revert "Update signing certificate" (#2495) 2022-04-07 22:12:41 +02:00
Matt Gibson 4a5feafeb8
Add descriptions for vague messages (#2494)
* Add descriptions for vague messages

* Fix typo
2022-04-07 08:20:48 -05:00
Oscar Hinton f7e0db356e
Update icons to match desktop (#2488) 2022-04-05 18:18:25 +02:00
Micaiah Martin 4a2e1588e8
Merge pull request #2493 from bitwarden/certs/update-signing-cert 2022-04-05 14:47:17 +00:00
Micaiah Martin f196538560 Testing different cert for signing 2022-04-04 12:47:05 -06:00
github-actions[bot] c9ff5a4bbe
Autosync the updated translations (#2487)
Co-authored-by: github-actions <>
2022-04-01 13:03:46 +02:00
Kyle Spearrin b2def1479d
update generator (#2484)
* update generator

* update jslib

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
2022-03-31 19:03:45 -04:00
Thomas Rittson 58f1d14376
Update jslib (#2486) 2022-04-01 07:57:41 +10:00
Patrick H. Lauke c6c22638d4
Add aria-label to password generator length slider, make it non-keyboard-focusable (#2478) 2022-03-31 13:16:34 +10:00
Kyle Spearrin bf081e0322
username generator (#2468)
* username generator

* pass usernameWebsite

* update jslib ref

* update jslib ref

* update jslib ref

* update jslib ref

* Update jslib to point to jslib master

* Updated package-lock.json after running npm i

* add missing translations

* pr feedback

Co-authored-by: Daniel James Smith <djsmith@web.de>
2022-03-30 17:59:58 -04:00
Thomas Rittson 4607e9d0ba
Fix alignment of box content (#2471) 2022-03-29 06:17:01 +10:00
github-actions[bot] f804da3102
Autosync the updated translations (#2469)
Co-authored-by: github-actions <>
2022-03-25 01:25:07 +01:00
Micaiah Martin 1bdbc18a97
Merge pull request #2464 from bitwarden/version_bump_1.57.0 2022-03-22 16:58:05 +00:00
github-actions[bot] c867196624 Bumped version to 1.57.0 2022-03-22 16:49:00 +00:00
Oscar Hinton 0cd7b4dff5
Define Angular CLI globals to support tree shaking (#2450) 2022-03-22 09:58:17 +01:00
Thomas Rittson b54cc6ec8a
[JslibModule] Refactor to use JslibModule (#2462) 2022-03-21 12:13:02 +01:00
Matt Gibson 7fc0844dd4
Update jslib (#2459) 2022-03-18 07:25:33 -05:00
github-actions[bot] b737a9c1e2
Autosync the updated translations (#2458)
Co-authored-by: github-actions <>
2022-03-18 01:15:53 +01:00
Thomas Rittson ae83a693f4
Fix infinite spinner when trying to restore Send state (#2449)
Clear state when re-opening popup
2022-03-18 09:01:22 +10:00
Micaiah Martin 7b08fc34ee
Merge pull request #2453 from bitwarden/build-actions-updates 2022-03-16 16:12:10 +00:00
Micaiah Martin 5dec5dea25
Merge branch 'master' into build-actions-updates 2022-03-16 15:36:24 +00:00
Vince Grassia ea1c33621a
Add Node package caching (#2454) 2022-03-15 17:08:43 -04:00
Chad Scharf 3695cd31f6
Merge pull request #2452 from bitwarden/cscharf-update-security-md-hackerone-link
Update SECURITY.md
2022-03-15 15:50:40 -04:00
Micaiah Martin e06616fe79 Updated actions 2022-03-15 13:43:45 -06:00
Chad Scharf c5dbb85352
Revise language on SECURITY.md 2022-03-15 15:39:14 -04:00
Chad Scharf f2e0c871e3
Update SECURITY.md
Add link to our HackerOne program for submitting potential security issues.
2022-03-15 15:11:48 -04:00
Matt Gibson d1bb8822a9
Update jslib (#2451) 2022-03-15 08:11:55 -05:00
Oscar Hinton d5334360dd
Add support for no intrusive biometric (#2431) 2022-03-15 13:13:39 +01:00