Commit Graph

4376 Commits

Author SHA1 Message Date
Konrad Pozniak 787f88b801
remove Rx from AccountViewModel and ReportViewModel (#3463) 2023-03-22 22:00:03 +01:00
UlrichKu 8c519af611
3408: Only support iconics (get rid of "discouraged api") (#3476)
* 3408: Only support iconics (get rid of "discouraged api")

* 3408: Remove unused import
2023-03-21 22:19:34 +01:00
renovate[bot] 7f7afb3e46
fix(deps): update dependency androidx.recyclerview:recyclerview to v1.3.0 (#3424)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-03-21 20:08:43 +01:00
UlrichKu 182df2bfae
3408 home help message (#3415)
* 3408: First draft of help message on empty home timeline

* 3408: Move image spanning to utils; tweak gui a bit (looks like status)

* 3408: Use proper R again; appease linter

* 3408: Add doc; remove narrow comment

* 3408: null is default

* 3408: Add German text

* 3408: Stack refresh animation on top of help message (reorder)
2023-03-21 19:44:35 +01:00
UlrichKu 9484a8b2b9
3457: Allow multi-line poll options (#3459) 2023-03-21 19:34:18 +01:00
UlrichKu 0c36b369dd
3159: Correctly refresh timestamps (#3456)
* 3159: Correctly refresh timestamp (of all elements) and refresh all on display options change

* Remove unnecessary import

* 3159: Remove unnecessary semicolon

* 3159: Remove todo question
2023-03-21 19:01:33 +01:00
Konrad Pozniak 3d71b6e69a
add lint to ci checks (#3462)
* add lint to ci checks

* update lint baseline
2023-03-21 18:56:11 +01:00
UlrichKu d754df8f07
3472: Give polls a default duration (#3473) 2023-03-21 18:52:38 +01:00
Konrad Pozniak 3fc1892c7d
Merge pull request #3455 from nailyk-weblate/weblate-tusky-tusky
Translations update from Weblate
2023-03-18 11:04:51 +01:00
Nik Clayton 81f725667e
Show better errors when loading notifications fails (#3448)
* Show better errors with notification loading fails

The errors are returned as a JSON object, parse it, and show the error
message it contains.

Handle the cases where there might be no error message, or the JSON may be
malformed.

Add tests.

Fixes #3445

* Lint
2023-03-18 10:25:41 +01:00
Eric af762db529 Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (597 of 597 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (597 of 597 strings)

Co-authored-by: Eric <alchemillatruth@purelymail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/zh_Hans/
Translation: Tusky/Tusky
2023-03-18 09:16:59 +00:00
Danial Behzadi b9e2695597 Translated using Weblate (Persian)
Currently translated at 100.0% (597 of 597 strings)

Co-authored-by: Danial Behzadi <dani.behzi@ubuntu.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/fa/
Translation: Tusky/Tusky
2023-03-18 09:16:59 +00:00
Hồ Nhất Duy b12b06a8c2 Translated using Weblate (Vietnamese)
Currently translated at 100.0% (596 of 596 strings)

Co-authored-by: Hồ Nhất Duy <mastoduy@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/vi/
Translation: Tusky/Tusky
2023-03-18 09:16:59 +00:00
Mārtiņš Bruņenieks 2b13b96372 Translated using Weblate (Latvian)
Currently translated at 91.1% (543 of 596 strings)

Translated using Weblate (Latvian)

Currently translated at 90.7% (541 of 596 strings)

Co-authored-by: Mārtiņš Bruņenieks <martinsb@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/lv/
Translation: Tusky/Tusky
2023-03-18 09:16:59 +00:00
Rhoslyn Prys 5c7bd41109 Translated using Weblate (Welsh)
Currently translated at 100.0% (596 of 596 strings)

Co-authored-by: Rhoslyn Prys <post@meddal.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/cy/
Translation: Tusky/Tusky
2023-03-18 09:16:59 +00:00
renovate[bot] 84188ed10f
fix(deps): update glide to v4.15.1 (#3449)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-03-18 10:12:07 +01:00
Konrad Pozniak 321d17f5de
Remove Rx from EventHub and TimelineCases (#3446)
* remove Rx from EventHub and TimelineCases

* fix tests

* fix AccountViewModel.unblockDomain

* remove debug logging
2023-03-18 10:11:47 +01:00
Konrad Pozniak 66eadabd44
update release process (#3439) 2023-03-18 09:51:21 +01:00
Nik Clayton c36b243745
Show reblog/favourite confirmations as menus not dialogs (#3418)
* Show reblog/favourite confirmations as menus not dialogs

The previous code used dialogs and displayed the text of the status when
reblogging or favouriting.

This didn't work when the post just contained images, and other material
from the status (content warning, polls) was not shown either.

Fix this by displaying a popup menu instead. The status remains visible so
the user can clearly see what they're acting on.

In addition, this lays the groundwork for supporting a long-press menu
in the future to allow the user to reblog/favourite from a different
account.

Fixes https://github.com/tuskyapp/Tusky/issues/3308

* Revert the change that puts the menu immediately over the icon

Although this behavious is consistent with how the option menu works, I
decided that the risk of someone inadvertently double-tapping in the same
location, and the first tap opens the menu and the second tap confirms the
action was too great.

So now the menu appears either above or below the icon depending on space,
and the user has to tap in two slightly different spaces.

This is also consistent with the previous behaviour, where it's highly
unlikely that the confirm button on the dialog would have been directly
under the user's finger if they double-tapped.
2023-03-18 09:37:55 +01:00
Nik Clayton 61720c3472
Meet accessibility guidelines for clickable spans (#3382)
Clickable spans in textviews do not normally meet the Android accessibility
guidelines of a minimum 48dp square touch target.

This can't be fixed with a `TouchDelegate`, as the span is not a separate
view to which the delegate can be attached.

Add `ClickableSpanTextView`. If used instead of a `TextView`, any spans
from `ClickableSpan` will have their touchable area extended to meet the
48dp minimum.

The touchable area is still bounded by the size of the view.

If two spans are closer together than 48dp then the closest span to the
touch wins.

Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
2023-03-18 08:57:39 +01:00
Grigorii Ioffe 75e7b9f1a5
Show toot stat inline (#3413)
* Show toot stat inline

* Correct elements position

* Format stats and show it according to setting

* inline toot statistics setting

* Code formatting

* Use kotlin functions

* Change the statistics setting description

* Use capital letters for all variants

* increase the statistics margin

* Merge fixes

* Code review fixes

* move setReblogsCount and setFavouritedCount to StatusViewHolder

* code cleaning

* code cleaning

* import lexicographical order

---------

Co-authored-by: Grigorii Ioffe <zikasaks@gmail.com>
Co-authored-by: grigoriiioffe <zikasaks@icloud.com>
2023-03-18 08:57:26 +01:00
UlrichKu 9087d0ecdd
Fix doubled line from PR 3188 (support mastodon filter api) (#3460) 2023-03-18 08:05:39 +01:00
Konrad Pozniak 3bb92d51bf
remove Rx from TabPreferenceActivity (#3444) 2023-03-13 13:16:58 +01:00
Konrad Pozniak bab178166d
update AndroidX lifecycle to 2.6.0, fix deprecation (#3443) 2023-03-13 13:16:49 +01:00
Konrad Pozniak d839f18267
update ktlint plugin to 11.3.1, format code (#3442) 2023-03-13 13:16:39 +01:00
Konrad Pozniak 774d79d666
Merge pull request #3423 from nailyk-weblate/weblate-tusky-tusky-app
Translations update from Weblate
2023-03-13 10:53:49 +01:00
Konrad Pozniak 24c4ea13cf
Merge pull request #3411 from nailyk-weblate/weblate-tusky-tusky
Translations update from Weblate
2023-03-13 10:53:37 +01:00
Manuel 6a3d0b574f Translated using Weblate (Italian)
Currently translated at 55.0% (11 of 20 strings)

Translation: Tusky/Tusky description
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky-app/it/
2023-03-13 09:45:18 +00:00
Nik Clayton 3ff8f73246
Enforce lint cleanliness when building (#3363)
* Enforce lint cleanliness when building

The volume of lintable issues is growing. To stem the tide:

1. Add `app/lint-baseline.xml`, which contains the current set of lint issues.
   Any issue appearing here will not cause the build to fail.

2. Move lint configuration settings in to `lint.xml`.

3. Update the lint configuration so that any issue (i.e., any issue not
   in lint-baseline.xml) causes a build failure.

4. Add the lint tasks as depedency when assembling an APK, to ensure the
   lint checks are run.

* lint: Convert launcher images to webp

* Move lint.xml location

* Don't lint when assembling

* Update baseline
2023-03-13 10:23:42 +01:00
Nik Clayton 6dfdaec425
Ignore "@instance..." part of username when computing status length (#3392)
* Move compose.* tests to own namespace

* Ignore "@instance..." part of username when computing status length

In a status with a mention ("@foo@example.org") only the "@foo" part should
be included in the calculated status length. It wasn't, so the app was
prevening people from posting statuses that should have been allowed.

Fix this.

- Lift the length calculation code in to a separate static function (easier
  and faster to test)
- Add a `MentionSpan` type, to reuse existing code for detecting mentions
- Fix a bug in `FakeSpannable.getSpans()` (it was returning the outer type,
  not the wrapped inner span)
- Add additional fast tests

The tests made sense under the `components.compose.ComposeActivity` package,
so I also created that and moved the existing ComposeActivity tests there.

Fixes https://github.com/tuskyapp/Tusky/issues/3339

* Static import assertEquals
2023-03-13 10:22:33 +01:00
renovate[bot] f309c7750f
fix(deps): update dependency org.mockito:mockito-inline to v5.2.0 (#3428)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-03-13 10:20:08 +01:00
Nik Clayton 81116f2df3
Update Robolectric to 4.9.2 (#3422) 2023-03-13 10:18:41 +01:00
Nik Clayton 70dced795c
Don't display error message if user cancels picking an image (#3427)
* Don't display error message if user cancels picking an image

* Update app/src/main/java/com/keylesspalace/tusky/EditProfileActivity.kt
2023-03-13 10:17:41 +01:00
Deleted User ab986a4ca0 Translated using Weblate (German)
Currently translated at 100.0% (596 of 596 strings)

Co-authored-by: Deleted User <noreply+267@weblate.org>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/de/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Deleted User ae3cd32846 Translated using Weblate (German)
Currently translated at 100.0% (596 of 596 strings)

Co-authored-by: Deleted User <noreply+266@weblate.org>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/de/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
ButterflyOfFire d61c630e03 Translated using Weblate (Arabic)
Currently translated at 93.2% (556 of 596 strings)

Co-authored-by: ButterflyOfFire <butterflyoffire@protonmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/ar/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Quentí cac75be82a Translated using Weblate (Occitan)
Currently translated at 99.1% (591 of 596 strings)

Co-authored-by: Quentí <quentinantonin@free.fr>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/oc/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Mārtiņš Bruņenieks 5afdf9bdb6 Translated using Weblate (Latvian)
Currently translated at 93.2% (540 of 579 strings)

Co-authored-by: Mārtiņš Bruņenieks <martinsb@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/lv/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Ihor Hordiichuk 48a9d20c11 Translated using Weblate (Ukrainian)
Currently translated at 100.0% (596 of 596 strings)

Translated using Weblate (Ukrainian)

Currently translated at 100.0% (579 of 579 strings)

Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/uk/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Deleted User 0324bbc0c0 Translated using Weblate (German)
Currently translated at 100.0% (579 of 579 strings)

Co-authored-by: Deleted User <noreply+265@weblate.org>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/de/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
puf a1bff13444 Translated using Weblate (Welsh)
Currently translated at 100.0% (567 of 567 strings)

Co-authored-by: puf <puffinux@tutanota.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/cy/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Rhoslyn Prys 1c26aa4ea7 Translated using Weblate (Welsh)
Currently translated at 100.0% (567 of 567 strings)

Co-authored-by: Rhoslyn Prys <post@meddal.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/cy/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Ricard Torres ca5e08a6f3 Translated using Weblate (Catalan)
Currently translated at 96.1% (573 of 596 strings)

Translated using Weblate (Catalan)

Currently translated at 100.0% (567 of 567 strings)

Co-authored-by: Ricard Torres <ricard@ricard.dev>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/ca/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Manuel 89f827a866 Translated using Weblate (Italian)
Currently translated at 100.0% (567 of 567 strings)

Co-authored-by: Manuel <mannivuwiki@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/it/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Gera, Zoltan a88e4f45cb Translated using Weblate (Hungarian)
Currently translated at 100.0% (567 of 567 strings)

Co-authored-by: Gera, Zoltan <gerazo@manioka.hu>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/hu/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Hồ Nhất Duy a294b4ea24 Translated using Weblate (Vietnamese)
Currently translated at 100.0% (596 of 596 strings)

Translated using Weblate (Vietnamese)

Currently translated at 100.0% (579 of 579 strings)

Translated using Weblate (Vietnamese)

Currently translated at 100.0% (567 of 567 strings)

Co-authored-by: Hồ Nhất Duy <mastoduy@gmail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/vi/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Eric 635d762add Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (596 of 596 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (579 of 579 strings)

Translated using Weblate (Chinese (Simplified))

Currently translated at 100.0% (567 of 567 strings)

Co-authored-by: Eric <alchemillatruth@purelymail.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/zh_Hans/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Danial Behzadi 4b78b41df9 Translated using Weblate (Persian)
Currently translated at 100.0% (596 of 596 strings)

Translated using Weblate (Persian)

Currently translated at 100.0% (579 of 579 strings)

Translated using Weblate (Persian)

Currently translated at 100.0% (567 of 567 strings)

Co-authored-by: Danial Behzadi <dani.behzi@ubuntu.com>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/fa/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Deleted User 3582540e42 Translated using Weblate (German)
Currently translated at 100.0% (567 of 567 strings)

Co-authored-by: Deleted User <noreply+264@weblate.org>
Translate-URL: https://weblate.tusky.app/projects/tusky/tusky/de/
Translation: Tusky/Tusky
2023-03-13 09:15:23 +00:00
Nik Clayton 9ec9d35100
Return the actual error body as a string (#3440)
The previous code returned the text representation of the error body type, which resulted in errors appearing in the UI as:

```
okhttp3.ResponseBody$Companion$asResponseBody$1@...
```

This code actually converts the *body* of the error response to a string, so the error is displayed correctly.
2023-03-13 09:58:15 +01:00