Compare commits

...

4 Commits

Author SHA1 Message Date
Lukas Prediger 6b0435be15
Merge 14abde389c into f76dbffa6b 2024-03-29 15:14:03 +09:00
Clementine Buildbot f76dbffa6b Automatic merge of translations from Transifex 2024-03-24 02:30:19 +00:00
Lukas Prediger 14abde389c
Fix: GstEnginePipeline BusCallback erroneously returned false. 2021-11-10 21:09:16 +02:00
Lukas Prediger 3def4a80f7
Ensuring that GstEnginePipeline decodebin is not dereferenced before its state is set to NULL.
Fixes #7115 which resulted from previous commit.
2021-11-10 21:09:16 +02:00
3 changed files with 12 additions and 9 deletions

View File

@ -28,4 +28,5 @@ void GstElementDeleter::DeleteElementLater(GstElement* element) {
void GstElementDeleter::DeleteElement(GstElement* element) { void GstElementDeleter::DeleteElement(GstElement* element) {
gst_element_set_state(element, GST_STATE_NULL); gst_element_set_state(element, GST_STATE_NULL);
gst_object_unref(element);
} }

View File

@ -565,7 +565,7 @@ gboolean GstEnginePipeline::BusCallback(GstBus*, GstMessage* msg,
break; break;
} }
return FALSE; return TRUE;
} }
GstBusSyncReply GstEnginePipeline::BusCallbackSync(GstBus*, GstMessage* msg, GstBusSyncReply GstEnginePipeline::BusCallbackSync(GstBus*, GstMessage* msg,
@ -1098,6 +1098,7 @@ void GstEnginePipeline::SourceSetupCallback(GstURIDecodeBin* bin,
void GstEnginePipeline::TransitionToNext() { void GstEnginePipeline::TransitionToNext() {
GstElement* old_decode_bin = uridecodebin_; GstElement* old_decode_bin = uridecodebin_;
gst_object_ref(old_decode_bin);
ignore_tags_ = true; ignore_tags_ = true;

View File

@ -42,6 +42,7 @@
# Martin Brodbeck <martin@brodbeck-online.de>, 2013 # Martin Brodbeck <martin@brodbeck-online.de>, 2013
# Martin Herkt <lachs0r@hong-mailing.de>, 2011 # Martin Herkt <lachs0r@hong-mailing.de>, 2011
# Martin Herkt <luck3r@phicode.de>, 2010 # Martin Herkt <luck3r@phicode.de>, 2010
# Michael Kohler, 2024
# MCMicS, 2020 # MCMicS, 2020
# Mohamed Sakhri, 2013 # Mohamed Sakhri, 2013
# Mohamed Sakhri, 2013 # Mohamed Sakhri, 2013
@ -70,7 +71,7 @@ msgstr ""
"Report-Msgid-Bugs-To: \n" "Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2011-04-09 10:24+0000\n" "POT-Creation-Date: 2011-04-09 10:24+0000\n"
"PO-Revision-Date: 2011-10-27 18:53+0000\n" "PO-Revision-Date: 2011-10-27 18:53+0000\n"
"Last-Translator: 6543 <6543@obermui.de>, 2020\n" "Last-Translator: Michael Kohler, 2024\n"
"Language-Team: German (http://app.transifex.com/davidsansome/clementine/language/de/)\n" "Language-Team: German (http://app.transifex.com/davidsansome/clementine/language/de/)\n"
"MIME-Version: 1.0\n" "MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n" "Content-Type: text/plain; charset=UTF-8\n"
@ -219,7 +220,7 @@ msgid "1 track"
msgstr "1 Titel" msgstr "1 Titel"
msgid "128K MP3" msgid "128K MP3"
msgstr "" msgstr "128K MP3"
msgid "128k MP3" msgid "128k MP3"
msgstr "128k MP3" msgstr "128k MP3"
@ -240,7 +241,7 @@ msgid "A Grooveshark Anywhere account is required."
msgstr "" msgstr ""
msgid "A Spotify Premium account is required." msgid "A Spotify Premium account is required."
msgstr "" msgstr "Spotify Premium Zugang wird benötigt."
msgid "" msgid ""
"A smart playlist is a dynamic list of songs that come from your library. " "A smart playlist is a dynamic list of songs that come from your library. "
@ -293,7 +294,7 @@ msgid "Action"
msgstr "Aktion" msgstr "Aktion"
msgid "Active/deactive Wiiremote" msgid "Active/deactive Wiiremote"
msgstr "" msgstr "Aktivieren/deaktivieren Wiiremote"
msgid "Add Stream" msgid "Add Stream"
msgstr "Datenstrom hinzufügen" msgstr "Datenstrom hinzufügen"
@ -326,7 +327,7 @@ msgid "Add folder..."
msgstr "Ordner hinzufügen …" msgstr "Ordner hinzufügen …"
msgid "Add media" msgid "Add media"
msgstr "" msgstr "Medien hinzufügen ..."
msgid "Add new folder..." msgid "Add new folder..."
msgstr "Neuen Ordner hinzufügen …" msgstr "Neuen Ordner hinzufügen …"
@ -386,7 +387,7 @@ msgid "Add wiimotedev action"
msgstr "Aktion für Wii-Fernbedienung hinzufügen" msgstr "Aktion für Wii-Fernbedienung hinzufügen"
msgid "Add..." msgid "Add..."
msgstr "" msgstr "Hinzufügen …"
msgid "Added this month" msgid "Added this month"
msgstr "Diesen Monat hinzugefügt" msgstr "Diesen Monat hinzugefügt"
@ -422,7 +423,7 @@ msgid "Album info on jamendo.com..."
msgstr "Albuminformationen auf jamendo.com …" msgstr "Albuminformationen auf jamendo.com …"
msgid "Albumartist" msgid "Albumartist"
msgstr "" msgstr "Albumkünstler"
msgid "Albums with covers" msgid "Albums with covers"
msgstr "Alben mit Titelbildern" msgstr "Alben mit Titelbildern"
@ -633,7 +634,7 @@ msgid "CUE sheet support"
msgstr "Unterstützung von Cuesheets" msgstr "Unterstützung von Cuesheets"
msgid "Cancel" msgid "Cancel"
msgstr "" msgstr "Abbrechen"
msgid "Change cover art" msgid "Change cover art"
msgstr "Titelbilder ändern" msgstr "Titelbilder ändern"