1
0
mirror of https://github.com/clementine-player/Clementine synced 2025-02-03 12:47:31 +01:00

156 Commits

Author SHA1 Message Date
David Sansome
f16fc8867e Allow podcasts to be added through the normal SongLoader mechanism (dragging to the playlist, on the commandline, "Add Stream", etc.) 2012-03-11 17:57:15 +00:00
David Sansome
75a897e92d Don't require each InternetService to keep track of its own current index - do it in the model instead 2012-03-11 14:44:43 +00:00
David Sansome
d538b71809 Add buttons and menu items to open the Podcast settings page. Also route these requests through Application rather than InternetModel 2012-03-10 22:39:24 +00:00
David Sansome
792a2e239d Better (some) UI feedback of downloading podcasts. Also fix a bug parsing the timestamps you see in some RSS feeds 2012-03-10 21:06:16 +00:00
David Sansome
c91acdb3f1 Add an Add Podcast dialog 2012-03-06 18:39:34 +00:00
Arnaud Bienner
0c1eca5ac1 Extract few other metadata info from GS results when initialising song.
However, currently these fields are filled only when calling getAlbumSongs(), unfortunately.
2012-02-28 23:22:09 +01:00
Arnaud Bienner
747e0f510f When (global) searching GS albums, retrieve albums' songs at the same time (instead of album load time).
Albums search is slower, but we can display songs in search results, which is IMHO really nicer.
2012-02-26 16:51:11 +01:00
David Sansome
ab5ccf69da Refactoring: remove BackgroundThread 2012-02-26 15:05:46 +00:00
David Sansome
bacef04405 Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader. 2012-02-26 14:40:51 +00:00
David Sansome
48f15c9fc7 Refactoring: instead of passing individual pointers to useful core classes (like TaskManager or LibraryBackend) to each class that uses them, pass one singleton-like Application instance everywhere. 2012-02-26 14:40:51 +00:00
Arnaud Bienner
1f93c26d97 Correct another QStringBuilder/QString conversion 2012-02-20 20:38:50 +01:00
Arnaud Bienner
089586ad07 Activate fast QString concatenation.
As this is not source compatible because we sometimes assumed (now wrongly) that '+' operation returns QString object (it now returns QStringBuilder object actually), some minor other corrections were needed.
2012-02-19 14:44:33 +01:00
David Sansome
b4e1cef2c2 Restore last.fm artist and tag radio names properly. Fixes issue 2607 2012-01-29 16:32:58 +00:00
Arnaud Bienner
396f375e8d Correct a bug in Grooveshark that make the subscribed playlists to be added in playlists_.
As a result, subscribed playlists are shown in 'Add to Grooveshark' action (when right clicking a GS song), whereas user cannot actually change this kind of playlist
2012-01-22 17:28:58 +01:00
David Sansome
626ce20ec0 Merge branch 'external-tagreader' 2012-01-08 18:38:48 +00:00
David Sansome
ff92815ef0 Display any SSL or HTTP errors that occur when creating a grooveshark session 2012-01-08 17:46:50 +00:00
David Sansome
bbf99fdd0b Change Spotify to use the new MessageHandler, remove SpotifyMessageHandler 2012-01-08 15:10:11 +00:00
David Sansome
67c6dead5a Rename SpotifyMessage to Message 2012-01-07 23:31:43 +00:00
David Sansome
68a379ef26 Use pb::spotify instead of spotify_pb for the protobuf namespace 2012-01-07 23:26:27 +00:00
David Sansome
4618651cf4 Merge branch 'master' into external-tagreader 2012-01-07 22:52:18 +00:00
David Sansome
e9c0b4bd69 Musicbrainz tagging improvements:
* Fix a bug where the song title would be used for the album field
  * Get the album's year as well
  * Include all releases for a song in the results list
  * Remove duplicate albums
  * Sort results
2012-01-07 21:51:02 +00:00
David Sansome
9be641ee87 The external tagreader mostly works now:
* Make TagReaderClient a singleton until it's easier to pass dependencies around
 * Add a WaitForSignal() that uses a local event loop to wait for a signal to be emitted
 * Add a WaitForFinished() to _MessageReplyBase that blocks using a semaphore
 * Add blocking versions of all TagReaderClient methods
 * Use the TagReaderClient everywhere that Song::InitFromFile and friends were used before
2012-01-07 00:26:07 +00:00
John Maguire
6ac685c4b8 Use correct icon for DI/SkyFM. 2012-01-04 12:39:22 +00:00
John Maguire
bcf9475f2b Add a source column to the playlist view with appropriate icons. 2012-01-04 11:56:09 +00:00
Arnaud Bienner
61aaefd65c Magnatune's URL are already encoded: we shouldn't use QUrl constructor directly because some characters (like ') will be encoded twice (%27 then %2527). Fixes issue 2510 2011-12-26 18:15:35 +01:00
Arnaud Bienner
bc1e5ec11c Add a refresh action to Grooveshark 2011-12-22 20:49:44 +01:00
Arnaud Bienner
d2f531a65b Prefill input dialog with old name when renaming GS playlist 2011-12-22 20:25:45 +01:00
John Maguire
ad9525d7da Fix grooveshark string and update translations file. 2011-12-13 17:27:47 +01:00
Arnaud Bienner
e2dac6785f Remove useless network_ attribute in some settings pages. Thanks Alan 2011-12-06 23:39:26 +01:00
Arnaud Bienner
b364d3fa84 Create GS playlists items when retrieving playlists instead of creating them when retrieving playlists' songs 2011-12-01 23:46:27 +01:00
Arnaud Bienner
74ea844811 Make 'ExtractSongs' not return valid song if 'result' is invalid/empty 2011-12-01 21:46:16 +01:00
Arnaud Bienner
5e80221e18 Ignore invalid urls generated when calling Autoplay 2011-11-30 00:07:10 +01:00
Arnaud Bienner
3f2faf818a Add Grooveshark autoplay radio 2011-11-29 23:52:19 +01:00
David Sansome
c1aaed91be Fix the logic for populating somafm and di.fm lists the first time they are expanded 2011-11-29 14:22:02 +00:00
Arnaud Bienner
6f4fab54a2 Remove useless constructor 2011-11-29 14:15:55 +01:00
Arnaud Bienner
1c99c8cc3b Commit missing GS radio files 2011-11-29 14:13:41 +01:00
Arnaud Bienner
1f5ac97934 Add Grooveshark radios 2011-11-29 13:57:35 +01:00
David Sansome
8d5ef62256 Do spotify image requests with string IDs instead of spotify://image/ urls. For some reason this seems to fix occasional crashes when image results arrive. Fixes issue 2411. 2011-11-29 10:21:40 +00:00
Arnaud Bienner
ff7cd0334e Ability to rename GS playlists 2011-11-28 21:59:25 +01:00
Arnaud Bienner
ac285eeeae Add missing copyright headers 2011-11-28 20:07:18 +01:00
David Sansome
05460f9975 Mark spotify streams as not seekable 2011-11-28 18:45:12 +00:00
David Sansome
22e6a649b7 Remove the custom gstspotifytcpsrc and use tcpserversrc ! gdpdepay to receive data. Use a gstreamer pipeline on the other end as well to send data. 2011-11-28 18:45:12 +00:00
David Sansome
4dc4aa33ac Make the enabled/disabled state of a global search provider separate from its logged in state - means that now Grooveshark and Spotify providers will be enabled as soon as you login 2011-11-28 14:18:20 +00:00
David Sansome
b873209d39 Remove the <xiphcomment.h> include from song.h so that windows headers don't infect everything else. Also move other bits of song.h into song.cpp, and reduce the number of includes in song.h. 2011-11-28 13:56:55 +00:00
David Sansome
89e8634928 Treat relogin failed messages from spotify differently, and only show the error dialog once. 2011-11-28 12:32:45 +00:00
Arnaud Bienner
a77f4b14d5 When creating a new GS playlist, insert the newly created playlist just above the subscribed playlists, instead of inserting it at the end (after the subscribed playlists) 2011-11-28 00:22:19 +01:00
David Sansome
42bf358b81 Use MP3 URLs for Jamendo instead of Ogg since they seem to keep breaking the Ogg URLs. Fixes issue 2417 2011-11-27 21:28:31 +00:00
David Sansome
456011d100 Don't show the "Retrieving Grooveshark playlists" task forever if the user has no playlists. 2011-11-27 19:02:14 +00:00
David Sansome
d0f09d83a1 When a login fails, focus and select all the text in the password field so the user can start typing a new password straight away. 2011-11-27 17:54:36 +00:00
David Sansome
add91d32de Fix the tab order in the magnatune settings page so password comes after username 2011-11-27 17:53:54 +00:00