Commit Graph

163 Commits

Author SHA1 Message Date
Andreas Muttscheller e5ab3e786f Network Remote: Check bytesAvailable >= 4 before reading length integer
This caused Clementine Remote to stop working on Android N. writeInt()
splits the 4 bytes across multiple tcp frames. Clementine would read
a wrong length and thus fail to read any protocol buffer data.
2016-09-12 12:07:28 +02:00
John Maguire 20bfade965 Hide Application classes behind pimpl.
This should also fix the build on windows where gcc gets confused as
libmygpo declares DELETE as part of an enum and mingw #defines DELETE in
winnt.h
2016-02-15 17:39:50 +00:00
John Maguire f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Andreas ab000b1ba5 Fix transcoder settings not applied for network remote
The format was supplied, but the settings for the format was not applied when transcoding files for the network remote.
2016-01-06 13:17:55 +01:00
Mark Furneaux 105ce0dbb7 Fix compile issue in outgoingdatacreator.cpp 2015-06-15 16:28:41 -04:00
Mark Furneaux f4b7c22bc2 Revert "Revert "Add track intro mode""
This reverts commit ece262f7f4.
2015-06-15 16:27:40 -04:00
Mark Furneaux b643e83167 Revert "Fix compile issue"
This reverts commit cb7a5c49c2.
2015-06-15 16:26:23 -04:00
Mark Furneaux 116473c687 Merge branch 'master' of https://github.com/clementine-player/Clementine
Conflicts:
	src/networkremote/outgoingdatacreator.cpp
2015-06-15 16:19:58 -04:00
Mark Furneaux cb7a5c49c2 Fix compile issue 2015-06-15 16:03:48 -04:00
John Maguire ece262f7f4 Revert "Add track intro mode" 2015-06-15 15:49:08 -04:00
Mark Furneaux b57cebbf2d Add track intro mode
This repeat mode plays the beginning of each track, good for quickly getting a feel for a new album for example.
2015-06-14 13:32:58 -04:00
Andreas 0abdf545a0 Network remote: Insert Song as well as urls. Is used for global search to add metadata for non library tracks. 2015-06-13 16:00:15 +02:00
Andreas 3c332782fd Network remote:
- Send status.
- Since QIcon can not be converted in a background thread, create a QImage from it in the SearchProvider itself.
2015-05-31 12:08:33 +02:00
kiselev-dv f7ebeb53da Stop after each track 2015-05-22 18:11:58 +05:00
John Maguire e899598967 Revert "Add stop after each song repeat mode" 2015-05-22 11:33:59 +01:00
kiselev-dv aba271ed6a format code 2015-05-20 17:34:37 +05:00
kiselev-dv 864d4162d3 Add stop after each song repeat mode 2015-05-12 14:05:46 +05:00
Andreas d59e864947 Send search provider icon to the remote when sending the search results. 2015-05-03 18:30:58 +02:00
Andreas a0f24dff86 Network remote: Only start transcoder when we actually have something to transcode. 2015-04-24 17:43:18 +02:00
Andreas c152bc26d9 Network remote: Don't send downloader the first data since it's not needed. 2015-04-24 17:30:21 +02:00
Andreas 136fca6dc2 Network remote: Send filesize on songoffer. 2015-04-24 17:24:14 +02:00
Andreas d93917ce9b Network remote: Send song url as well. 2015-04-24 15:35:18 +02:00
Andreas c9b39e7c83 Fix crash when trying to download a track, but there is no current one playing. 2015-04-24 15:31:09 +02:00
Ivan Leontiev aba0517b4c Fix memory leak in networkremote. 2015-03-24 09:22:02 +00:00
Krzysztof Sobiecki fa9ea6ec5f Fix compilation with moved files in internet/ 2014-12-18 23:35:21 +01:00
Andreas 0f1b29a523 Make sure SongSender is deleted when client disconnects. 2014-12-07 13:54:18 +01:00
Andreas 5e77aed01e Cancel transcode when downloader disconnects. 2014-11-18 11:55:27 +01:00
Andreas 86a375f952 Send correct total file size if files were transcoded. 2014-11-14 17:53:25 +01:00
Andreas ff172f6ed4 Network remote can now transcode lossless files before sending them to the remote.
- It is configurable in the settings.
- Any format can be chosen that is supported by the transcoder.
- The status of the transcoder is send to the remote.

- Transcoder format settings have now a postfix so we can define mutliple transcoder formats and use them separatly. Here one for the normal transcoder and one for the network remote transcode. You can pass the postfix in the constructor.
- Fixed Transcoder crash (was introduced with the gstreamer1.0 merge, decodebin doesn't have a "new-decoded-pad").
- Transcoder emits the output filename as well on "JobComplete" signal
- Transcoder can now convert a file to a temporary file ("AddTemporaryJob")
2014-11-13 22:31:49 +01:00
Andreas 1ad5884b39 Fix some minor C++ things in OutgoingDataCreator. 2014-10-23 18:07:39 +02:00
Andreas c43eb02efd Android Remote: Add global search. 2014-10-21 18:07:02 +02:00
Andreas f52e48c956 Send filesize and file count in advance when client wants to download songs. 2014-05-10 14:53:38 +02:00
Andreas 24481ae7bc Clementine Remote can now download all urls that are in the library. 2014-05-08 19:17:58 +02:00
John Maguire 4ab4bbc23f Remove Last.fm radio support.
Fixes #4259
2014-03-28 14:55:04 +01:00
John Maguire 192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
Arnaud Bienner 7084697aa3 Prevent Clementine to loop forever when trying to play a song with repeat enabled in a playlist which contains only unavailable songs 2014-02-04 22:08:32 +01:00
John Maguire b96ec7555a Reformat all Objective-C++ files with clang-format.
clang-format -style=Google -i src/*/*.mm
2014-01-30 14:54:51 +01:00
Andreas 7ad1d7abc3 Remote: Use sha1 instead of md5 for file hashing. 2014-01-18 18:33:49 +01:00
Andreas 8ff0692809 Network remote: send md5 hash along with library and files. 2013-12-31 15:26:42 +01:00
Andreas 00fd9b4724 Androids like kittens, too 2013-12-22 15:16:42 +01:00
Andreas 03a4145082 Check if track position is valid before sending. Bump protocol version. 2013-12-08 20:19:25 +01:00
Andreas 3122593ab4 Read urls correctly when inserting into playlist.
Fixes issue 4003.
2013-12-05 16:20:59 +01:00
Andreas b5ba1164af Send only songs from library which are available. 2013-12-03 12:19:46 +01:00
Andreas 42d9a86ff0 Calculate chunkcount with the real file size, not the size saved in the database (might be wrong and results in corrupted download). 2013-11-29 13:59:48 +01:00
Andreas 7470f67acf - Fix remove songs from playlist in network remote.
- Update protocol buffer version.
2013-10-31 19:52:02 +01:00
Andreas afae01156d Merge branch 'portable' 2013-10-26 09:34:07 +02:00