The previous fix introduces a regression on some platforms
which did not generate a leaveEvent with the TrackSliderPopup
was displayed. Logic is introduced to identify bonafide mouse
motion out of the TrackSliderSlider.
* Replace Nokia sidebar widget with QTabWidget
The old sidebar widget was written by Nokia 10 years ago
and was a hand made hardcoded mess of widgets trying to
emulate a QTabWidget.
This commit completely replaces it with a widget of the
same name (FancyTabWidget) but is a much simpler subclass
of the standard QTabWidget allowing for a 50% code reduction.
There is still some manual draw code copied over to get the
exact same look of the previous widget but this is not strictly
necessary and can be later refactored with simpler drawControl
code based on styling preferences.
Benefits:
- 50% code reduction
- Easier to understand standard QTabWidget mechanics
- Built-in support for re-arranging and closing tabs
* Save and restore sidebar tab order
Allow the user to rearrange the tab order by dragging
tabs to a new location. Tab order is saved on exit and restored
on start
* Fix some code formatting issues
This issue appeared as a side effect since the commit
bcaa9e4a37, which adds dropdown
animation to the library/internet view.
Reproduce:
Single/double click on a song item in library/internet view
then all double clicks on this item will be ignored, until you
single click on it once again.
The reason of this behavior in that the "setExpanded" method call from the
"ItemClicked" slot makes the invocation of the "mouseDoubleClickEvent"
method in the context where the view is in the "QAbstractTreeView::AnimatingState"
which makes impossible to emit "doubleClicked" signal, because it just
returns immediatelly (see http://code.qt.io/cgit/qt/qt.git/tree/src/gui/itemviews/qtreeview.cpp#n1849).
To get rid of this behavior we emit "doubleClicked" signal ourselves.
Fixes#1218
Windows uses the primary monitor as the origin for coordinates, so any monitor to the left or above the primary uses negative coordinates.
This would cause the OSD to always be displayed on the primary as the negative values would be set to 0.
- Lyrics can now be viewed/edited in the metadata-editor
Squashed commit of the following:
commit 0851f619c27348e3ceeaf31a8edc3a567ccee99c
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Wed Jun 10 21:21:50 2015 +0200
'make format' and brackets in a condition clause.
commit bab7a1d07af3bc53034e3883d352ae6d4dd33e2a
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Sun Jun 7 01:51:31 2015 +0200
Added capability to SAVE lyrics frames to mp3 files in tagreader.
Improved scaling properties of edittags dialog.
commit 4bd71a2d6a4479a664bf8b5b3ead05c23c86e15d
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Sat Jun 6 23:33:22 2015 +0200
Updated lyrics tag buddy to lyrics
commit 2ceb8967f67e76a0f78b25a7a128c4429a93bcd9
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Sun May 17 18:52:33 2015 +0200
Add lyrics field to tag editor
commit 04b65e33a83e449055659a72a283954311a12fb7
Author: Martin Babutzka <martin.babutzka@online.de>
Date: Fri May 8 23:24:02 2015 +0200
Using decode method to fix non-ASCII letters.
Introduced in #4416, clicking the cover will show the large art. In Windows, it seems that the click event is also associated with the right mouse button, so it comes up when you bring up the context menu.
Squashed the following commits:
5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:
-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
Increases the refresh rate of the track progress bar to 25fps.
This looks much better with moodbars than the previous 1fps.
All the common code that use to run at 1fps still retains that
rate so the overhead due to this is negligible.
When in fit width mode with the details below the artwork,
drawing the black background is out of place. This uses the ui colour
making it less obtrusive.
Some people seem to want to have a way of enlarging the now playing
widget cover when in large mode to get rid of the black bars on the sides.
This patch adds an option in the context menu which allows the cover to
fill the width of the panel when either large mode is enabled.
In an attempt to satisfy many users, I have added another mode to the
now playing widget. This shows the large cover art however it draws the song details
below the artwork, without the gradient that everyone seems to have a problem with.
This is just an option and all the original functionality is unchanged.
Chocobozzz
Andreas Sturmlechner
Antonio Russo
John Maguire
Vikram Ambrose
Santiago Gil
Chocobozzz
Florian Bigard
Ted Stein
Pavel Vatagin
Josef Vitu
Arun Narayanankutty
Ivan Leontiev
Eduard Braun
Mark Furneaux
Eduardo Sánchez Muñoz
Mark Furneaux
Martin Babutzka
kiselev-dv
Fletcher Dostie
Krzysztof Sobiecki
Andreas
alecksphillips
David Sansome
Arnaud Bienner