Commit Graph

184 Commits

Author SHA1 Message Date
Jim Broadus 1a3828e2c1 protobuf: Fix namespace conflict
Protobuf 3.15 adds a namespace alias for "pb" that conflicts with
Clementine's. Modify Clementine to use "cpb".

Patch provided by @ahesford

Reference: 5c028d6cf4/src/google/protobuf/port.h (L44)
2021-02-21 14:17:26 +00:00
Matthieu Bruel 41513527cd hatstand code review update 1 2020-12-17 12:23:30 +00:00
Matthieu Bruel 9714b0632d All changes for ClemRemote v1.0 (in one go) 2020-12-17 12:23:30 +00:00
John Maguire 341dc7326f Reformat all C++ 2020-09-22 14:56:06 +01:00
Jim Broadus 84099f2491 Name all threads created by Application
In Application::MoveToNewThread, name the new thread after the object being
moved. Give those objects names as well.

The thread names display in gdb with "info threads".
2020-05-27 10:22:00 +01:00
Jim Broadus 58569d9d0d Remove fetcher list from OutgoingDataCreator class. 2020-05-14 11:01:49 +01:00
Jonas Kvinge 0da490a5e1 Replace QString::null with QString() 2019-11-09 23:45:28 +01:00
John Maguire cb6cd7c485 Merge remote-tracking branch 'origin/master' into qt5 2019-10-04 16:51:43 +01:00
luz.paz fb93ae4b02 Fix misc. source comment typos
Typos found via `codespell`
2019-08-21 23:43:16 -04:00
Jonas Kvinge 1a2274bd2b Merge branch 'master' into qt5-update 2019-07-21 14:20:59 +02:00
Filip Gawin be827f4f7f Simplify some statements 2019-02-22 18:49:48 +01:00
Jonas Kvinge a5e8eba91c Merge remote-tracking branch 'upstream/master' into qt5-update 2018-06-29 02:38:19 +02:00
Clang Formatter 083129f41c Automatically formatted 2018-06-13 20:37:13 +00:00
vaterlangen 465fa2ce87 Clicking on songs in playlists via remote control now respecting behavioural settings from GUI (either direct changes it or enques it) 2018-06-13 22:03:23 +02:00
Benoit Brummer 902c22ef1b fixed issue #5868: IPs were not recognized as private when Qt translates ipv4 to ipv6 (#5896) 2017-12-15 02:10:02 +00:00
Chocobozzz 18a89f78a9 Merge remote-tracking branch 'upstream/master' into qt5 2016-10-07 14:30:09 +02:00
Andreas Muttscheller e5ab3e786f Network Remote: Check bytesAvailable >= 4 before reading length integer
This caused Clementine Remote to stop working on Android N. writeInt()
splits the 4 bytes across multiple tcp frames. Clementine would read
a wrong length and thus fail to read any protocol buffer data.
2016-09-12 12:07:28 +02:00
Chocobozzz e6e189967d Merge remote-tracking branch 'upstream/master' into qt5 2016-02-29 18:03:02 +01:00
John Maguire 20bfade965 Hide Application classes behind pimpl.
This should also fix the build on windows where gcc gets confused as
libmygpo declares DELETE as part of an enum and mingw #defines DELETE in
winnt.h
2016-02-15 17:39:50 +00:00
John Maguire f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Andreas ab000b1ba5 Fix transcoder settings not applied for network remote
The format was supplied, but the settings for the format was not applied when transcoding files for the network remote.
2016-01-06 13:17:55 +01:00
Chocobozzz 631a6cdabd Merge branch 'master' into qt5 2015-09-16 17:40:54 +02:00
Mark Furneaux 105ce0dbb7 Fix compile issue in outgoingdatacreator.cpp 2015-06-15 16:28:41 -04:00
Mark Furneaux f4b7c22bc2 Revert "Revert "Add track intro mode""
This reverts commit ece262f7f4.
2015-06-15 16:27:40 -04:00
Mark Furneaux b643e83167 Revert "Fix compile issue"
This reverts commit cb7a5c49c2.
2015-06-15 16:26:23 -04:00
Mark Furneaux 116473c687 Merge branch 'master' of https://github.com/clementine-player/Clementine
Conflicts:
	src/networkremote/outgoingdatacreator.cpp
2015-06-15 16:19:58 -04:00
Mark Furneaux cb7a5c49c2 Fix compile issue 2015-06-15 16:03:48 -04:00
John Maguire ece262f7f4 Revert "Add track intro mode" 2015-06-15 15:49:08 -04:00
Mark Furneaux b57cebbf2d Add track intro mode
This repeat mode plays the beginning of each track, good for quickly getting a feel for a new album for example.
2015-06-14 13:32:58 -04:00
Andreas 0abdf545a0 Network remote: Insert Song as well as urls. Is used for global search to add metadata for non library tracks. 2015-06-13 16:00:15 +02:00
Chocobozzz 5aec1c0e24 Merge remote-tracking branch 'upstream/master' into qt5
Update qt version to 5.4.2
2015-06-03 22:57:58 +02:00
Andreas 3c332782fd Network remote:
- Send status.
- Since QIcon can not be converted in a background thread, create a QImage from it in the SearchProvider itself.
2015-05-31 12:08:33 +02:00
kiselev-dv f7ebeb53da Stop after each track 2015-05-22 18:11:58 +05:00
John Maguire e899598967 Revert "Add stop after each song repeat mode" 2015-05-22 11:33:59 +01:00
kiselev-dv aba271ed6a format code 2015-05-20 17:34:37 +05:00
kiselev-dv 864d4162d3 Add stop after each song repeat mode 2015-05-12 14:05:46 +05:00
Andreas d59e864947 Send search provider icon to the remote when sending the search results. 2015-05-03 18:30:58 +02:00
Andreas a0f24dff86 Network remote: Only start transcoder when we actually have something to transcode. 2015-04-24 17:43:18 +02:00
Andreas c152bc26d9 Network remote: Don't send downloader the first data since it's not needed. 2015-04-24 17:30:21 +02:00
Andreas 136fca6dc2 Network remote: Send filesize on songoffer. 2015-04-24 17:24:14 +02:00
Andreas d93917ce9b Network remote: Send song url as well. 2015-04-24 15:35:18 +02:00
Andreas c9b39e7c83 Fix crash when trying to download a track, but there is no current one playing. 2015-04-24 15:31:09 +02:00
Chocobozzz e986ab5a4b Merge master branch and adapt it to qt5 2015-04-16 17:16:34 +02:00
Chocobozzz 8b226c2171 Update non optionnals sources to qt5 2015-04-11 23:24:07 +02:00
Ivan Leontiev aba0517b4c Fix memory leak in networkremote. 2015-03-24 09:22:02 +00:00
Krzysztof Sobiecki fa9ea6ec5f Fix compilation with moved files in internet/ 2014-12-18 23:35:21 +01:00
Andreas 0f1b29a523 Make sure SongSender is deleted when client disconnects. 2014-12-07 13:54:18 +01:00
Andreas 5e77aed01e Cancel transcode when downloader disconnects. 2014-11-18 11:55:27 +01:00
Andreas 86a375f952 Send correct total file size if files were transcoded. 2014-11-14 17:53:25 +01:00
Andreas ff172f6ed4 Network remote can now transcode lossless files before sending them to the remote.
- It is configurable in the settings.
- Any format can be chosen that is supported by the transcoder.
- The status of the transcoder is send to the remote.

- Transcoder format settings have now a postfix so we can define mutliple transcoder formats and use them separatly. Here one for the normal transcoder and one for the network remote transcode. You can pass the postfix in the constructor.
- Fixed Transcoder crash (was introduced with the gstreamer1.0 merge, decodebin doesn't have a "new-decoded-pad").
- Transcoder emits the output filename as well on "JobComplete" signal
- Transcoder can now convert a file to a temporary file ("AddTemporaryJob")
2014-11-13 22:31:49 +01:00