NicolasToussaint
b2044a5be5
apply PR recomendations
2020-11-28 20:24:56 +00:00
NicolasToussaint
ee72b974bf
add CLI play-playlist option, to play given playlist name.
2020-11-28 20:24:56 +00:00
zan
16d09ace07
Fix visibility incongruences
2020-11-02 11:07:42 +00:00
Zanny
2bac3626c5
Fix logout cancelling ( #6796 )
2020-09-23 10:39:59 +01:00
John Maguire
2172732b1e
Include windows.h first as it's special
2020-09-22 14:56:06 +01:00
John Maguire
341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
dmdmdm
3a4d7f3a3d
Only enable main window rate button when LastFM is disabled ( #6778 )
2020-08-26 16:06:13 +01:00
dmdmdm
44af6f9d5d
Replaced the heart icon with a star for local files
2020-08-25 21:51:03 +01:00
dmdmdm
c60c523185
Replaced the heart icon with a star for local files
2020-08-25 21:51:03 +01:00
dmdmdm
d9fa56c179
Share the love: Minor corrections
2020-07-30 18:24:58 +01:00
dmdmdm
acb75a5099
Share the love
2020-07-30 18:24:58 +01:00
dmdmdm
75264f314d
Share the love
2020-07-30 18:24:58 +01:00
Mattias Andersson
ebf9ebf080
Show only a basic tooltip in the system tray
...
For environments that implements the D-Bus
http://www.freedesktop.org/wiki/Specifications/StatusNotifierItem/StatusNotifierItem
specification HTML is not supported in the tool tip title. (It is
supported in the tool tip subtitle but this field is not set by
QSystemTrayIcon.)
See the discussion in #6733 for more info.
2020-07-08 17:24:42 +01:00
Jim Broadus
7d28e8700b
Call SettingsPage::showEvent from child class implementations
2020-07-07 10:35:02 +01:00
Jim Broadus
c299c198de
organise: Update the song preview when the selected destination's data changes
...
This will cause the file exensions to change when transcode options are changed.
2020-06-07 14:45:50 +01:00
Jim Broadus
4dd3233976
organise: Set extension override in OrganiseDialog
...
If the destination device has a transcode option set, then compute filenames
with updated extensions. This does not cover the case where Organise needs to
transcode due to format support.
2020-06-07 14:45:50 +01:00
Jim Broadus
0271f43cc9
console: Add a Qt debug tab
...
Add a tab for Qt debug features. Initially provides access to dumpObjectTree() on
Application and MainWindow objects. This dumps the object's child objects to the
log.
2020-05-26 16:57:59 +01:00
Jim Broadus
e3fa03e101
console: Refactor console dialog to use tabs
2020-05-26 16:57:59 +01:00
Jim Broadus
a4e8d57de0
console: re-enable debug console option
...
Keep console option hidden by default, but add using CLEMENTINE_DEBUG_CONSOLE
env variable:
CLEMENTINE_DEBUG_CONSOLE=1 clementine
2020-05-26 16:57:59 +01:00
Jim Broadus
96a17c9f40
settings: Only save settings for visited pages
...
Set a flag when a page is shown. On apply or accept, only save if that flag is
set.
2020-05-12 10:21:44 +01:00
Jim Broadus
77badd37ff
settings: Add dialog methods to settings pages
...
Add Accept, Apply, Reject methods to settings pages to mirror dialog. This will
allow settings pages to handle these events at a more granular level and will
allow common behavor in the base class.
2020-05-12 10:21:44 +01:00
Jim Broadus
7e7d271b30
Properly handle removal of top level items in StandardItemIconLoader
...
The rowsAboutToBeRemoved signal from the model provides a parent index, but with
QStandardItemModel, top level items are added to an invisible root item that
doesn't have a valid index. This causes the range check to miss top level items
due to a perceived parent mismatch. When the load completes, it attempts to
access an object that has been deleted.
2020-05-04 10:09:51 +01:00
Jim Broadus
dc4270076d
Change StandardItemIconLoader to require a QStandardItemModel
...
This should be a safe assumption since the loader operates on QStandardItem
objects.
2020-05-04 10:09:51 +01:00
Jonas Kvinge
b762987cd6
Add missing mapToSource() in MainWindow::PlaylistRightClick
2020-03-06 11:10:02 +00:00
Jim Broadus
a8f656a933
Shortcut settings page cleanup.
...
- Group list and settings so they can be enabled/disabled together.
- Make default selection shortcut list. Previous behavior set options
for the first item, but didn't highlight selection.
- Rename ItemClicked to CurrentItemChanged to reflect correct signal.
2020-02-23 16:08:05 +00:00
Jim Broadus
18a08e87c2
Add a directory_model accessor to Application class.
2020-02-11 08:09:22 +00:00
Pavel Liavonau
3f4c788339
Fixed lastfm workflow with "now playing" and scrobbling feature
...
(Maybe Issue #2672 )
2020-01-07 22:29:23 +00:00
Jim Broadus
39e75071bf
Remove unhelpful debug message.
...
Message contains no context and appears to be a remnant of a debug session.
2020-01-05 16:51:11 -08:00
Jonas Kvinge
1b23417a93
Use QWidget::screen() to fix compile with Qt 5.14
2020-01-05 02:51:08 +01:00
John Maguire
7d2c622d0f
Merge pull request #6507 from jonaski/sprintf
...
Replace use of QString::sprintf with QString::asprintf
2020-01-05 00:40:43 +00:00
Jonas Kvinge
f81a3aa8d8
Replace use of QString::sprintf with QString::asprintf
2020-01-05 00:12:32 +01:00
Jonas Kvinge
9e3461f818
Fix formatting
2020-01-04 21:24:31 +01:00
Jonas Kvinge
6a8f70285f
Replace all uses of QDesktopWidget with QScreen
2020-01-04 21:18:12 +01:00
Thor Merlin Lervik
715da8909f
Fix resuming playback position on startup
2019-12-14 17:22:16 +01:00
John Maguire
8b765a5257
Remove qtsparkle support
2019-11-14 20:53:46 +00:00
Jonas Kvinge
e985bd780a
Fix edit tag dialog
2019-11-13 20:47:14 +01:00
Mattias Andersson
cd3d481eda
Remove an unused file that had been left in the qt5 branch
2019-11-13 09:48:34 +01:00
John Maguire
b7c3173001
Merge pull request #6439 from jonaski/signalmapper
...
Replace all uses of QSignalMapper with C++11 lambda expressions
2019-11-10 19:13:31 +00:00
Jonas Kvinge
344023e6dd
Fix formatting
2019-11-10 15:16:39 +01:00
Jonas Kvinge
ba31c755ef
Replace all uses of QSignalMapper with C++11 lambda expressions
2019-11-10 15:07:12 +01:00
John Maguire
21da802630
Merge pull request #6438 from jonaski/remove-extra-semicolon
...
Remove extra ';'
2019-11-10 00:53:37 +00:00
Jonas Kvinge
d09c27f719
Remove extra ';'
2019-11-10 00:30:18 +01:00
Jonas Kvinge
0da490a5e1
Replace QString::null with QString()
2019-11-09 23:45:28 +01:00
John Maguire
cb6cd7c485
Merge remote-tracking branch 'origin/master' into qt5
2019-10-04 16:51:43 +01:00
Antonio Russo
c5c294ba14
fancytabwidget.cpp: reuse QSettings object
...
avoid excessive locking by reusing a common QSettings object in
loadSettings.
2019-09-10 18:41:18 -06:00
Antonio Russo
ccaa59cc66
Periodically save current playlist tab
...
Building on the previous commit, we save the current playlist (tab)
periodically as well.
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2019-09-10 18:41:18 -06:00
Antonio Russo
e66fdd86da
Periodically save settings
...
Instead of immediately saving, which leads to poor performance,
and possible hardware damage (see #6057 ), limit saves to once
per second (similar to how KDE does it). It also guarantees
that only one save is required per second, by sharing a QSettings
object, and establishes a signaling framework to put other
setting save events into (but only uses this for the two major
offenders: playlist tab switching and window resizing).
This is in contrast to 6a312e7
, which simply deferred the save
until program exit, and caused problems for some people (see #6217
and #6209 ).
Signed-off-by: Antonio Russo <antonio.e.russo@gmail.com>
2019-09-10 18:41:18 -06:00
luz.paz
fb93ae4b02
Fix misc. source comment typos
...
Typos found via `codespell`
2019-08-21 23:43:16 -04:00
John Maguire
75f18dab23
Merge pull request #6374 from jonaski/qt5-update
...
Qt5 update
2019-07-24 11:51:48 +01:00
John Maguire
3694bcfc82
Merge pull request #6371 from areading/limit_tagclient_procs
...
Introduce limit for number of tag client processes.
2019-07-22 10:56:03 +01:00