Commit Graph

6602 Commits

Author SHA1 Message Date
Clementine Buildbot e2fbb8e966 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-03-07 10:00:42 +00:00
Clementine Buildbot 357af2263b Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-29 10:00:41 +00:00
David Guillen Fandos e4efde900a Adding support for subsonic cover art download 2016-02-26 23:29:13 +00:00
Pander 1496d581cd Changed HTTPS to HTTP for Intergalactic FM 2016-02-25 17:37:45 +01:00
Clementine Buildbot e7654d41a2 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer)
(cherry picked from commit 9252925a56)
2016-02-22 18:36:54 +00:00
Clementine Buildbot 9252925a56 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-22 10:00:42 +00:00
Eduard Braun 3ce3dd884e Make repeat/shuffle icons a bit darker
With the previous icons there was almost no difference between enabled/disabled states in the UI
2016-02-21 03:27:17 +01:00
Simon Marchi 89e3d9851e moodbar: check QSlider max/min before using them in division
When switching playback from an item for which the moodbar is not
displayed (e.g. an internet stream), to an item for which it is
displayed (e.g. a local mp3 file), Clementine sometimes crashes.

This happens because the slider_opt->maximum and slider_opt->minimum
have the value 0 (their default value), and the difference is used as a
divisor.  This gives a division by 0, and a SIGFPE.

This problem has been fixed in commit af42cce.  However, when a9f9b0e
reverted 3f79fa5, a little to much was reverted and we lost what af42cce
did.  This patch re-introduces the fix.

Fixes #5261

moodbar: Add comment
(cherry picked from commit 725e1d8f0d)
2016-02-18 14:25:48 +00:00
John Maguire 51c1c36934 Merge pull request #5263 from simark/fix-moodbar-crash
moodbar: check QSlider max/min before using them in division
2016-02-18 14:17:58 +00:00
Simon Marchi 725e1d8f0d moodbar: check QSlider max/min before using them in division
When switching playback from an item for which the moodbar is not
displayed (e.g. an internet stream), to an item for which it is
displayed (e.g. a local mp3 file), Clementine sometimes crashes.

This happens because the slider_opt->maximum and slider_opt->minimum
have the value 0 (their default value), and the difference is used as a
divisor.  This gives a division by 0, and a SIGFPE.

This problem has been fixed in commit af42cce.  However, when a9f9b0e
reverted 3f79fa5, a little to much was reverted and we lost what af42cce
did.  This patch re-introduces the fix.

Fixes #5261

moodbar: Add comment
2016-02-18 09:15:44 -05:00
John Maguire 8d2911bc32 Cope with receiving no images from spotify
(cherry picked from commit 4cd20ffdaa)
2016-02-17 18:07:20 +00:00
John Maguire 4cd20ffdaa Cope with receiving no images from spotify 2016-02-17 18:06:30 +00:00
John Maguire 2219f88484 Too clever for old GCC versions.
(cherry picked from commit 52c72f95ba)
2016-02-17 16:42:30 +00:00
John Maguire 52c72f95ba Too clever for old GCC versions. 2016-02-17 16:42:03 +00:00
John Maguire d2e6282235 Clementine 1.3RC2 2016-02-17 16:38:19 +00:00
John Maguire 99b07fd707 Fetch artist images from spotify.
(cherry picked from commit 1304f8898e)
2016-02-17 16:17:51 +00:00
John Maguire 4bba0fda09 Blacklist artist images from echonest using dead last.fm server.
(cherry picked from commit 5b4c0c920c)
2016-02-17 16:17:46 +00:00
John Maguire 42c21f0d03 Make image requests follow redirects
(cherry picked from commit a80e241bbe)
2016-02-17 16:17:40 +00:00
John Maguire 1304f8898e Fetch artist images from spotify. 2016-02-17 15:55:37 +00:00
John Maguire 5b4c0c920c Blacklist artist images from echonest using dead last.fm server. 2016-02-17 15:55:37 +00:00
John Maguire a80e241bbe Make image requests follow redirects 2016-02-17 15:55:32 +00:00
Clementine Buildbot 01a4387ac4 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer)
(cherry picked from commit b3d5cabdc1)
2016-02-17 13:32:05 +00:00
John Maguire b0322e7e7d Cleanup ApplicationImpl 2016-02-15 17:41:39 +00:00
John Maguire 20bfade965 Hide Application classes behind pimpl.
This should also fix the build on windows where gcc gets confused as
libmygpo declares DELETE as part of an enum and mingw #defines DELETE in
winnt.h
2016-02-15 17:39:50 +00:00
Clementine Buildbot b3d5cabdc1 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2016-02-15 10:00:41 +00:00
Santiago Gil ad62c7476d Merge pull request #7 from clementine-player/master
Update
2016-02-14 02:01:41 -03:00
John Maguire affb215a52 Move cover providers initialisation later in startup. 2016-02-12 16:25:01 +00:00
John Maguire dcdd81d69f Moar Lazy migrations 2016-02-12 16:10:56 +00:00
John Maguire b99b090adc Refactor simple dialogs to use Lazy 2016-02-12 16:01:35 +00:00
John Maguire 74e6a1744f Convert edit tag & settings dialog to Lazy. 2016-02-12 15:56:08 +00:00
John Maguire 589f2ff62e Lazy initialise organise dialog 2016-02-12 12:25:35 +00:00
John Maguire 0cf83b19ee Eagerly initialise TagReaderClient 2016-02-12 12:07:26 +00:00
John Maguire 86a6345995 Merge pull request #5251 from santigl/gainLabel
EqualizerSlider: move include from .h to .cpp
2016-02-11 18:03:18 +00:00
Santi 1fa4201926 EqualizerSlider move include from .h to .cpp 2016-02-11 14:59:39 -03:00
John Maguire 7d1abbda55 Don't connect action signals multiple times.
Fixes #5249
2016-02-11 17:07:00 +00:00
John Maguire c7ca852433 Fix songkick concert fetching
(cherry picked from commit ce3ba02749)
2016-02-11 17:00:21 +00:00
John Maguire ce3ba02749 Fix songkick concert fetching 2016-02-11 16:59:40 +00:00
John Maguire d06f337ade Remove special deletion of objects in threads.
Fixes #5250
2016-02-11 16:31:08 +00:00
John Maguire 729dc8e281 Merge pull request #5182 from abika/fix-fetch_edit_dialog
Fix bug in edit tag dialog when fetching (2)
2016-02-11 15:30:51 +00:00
John Maguire f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Alexander Bikadorov 56e95839f0 Revert to iterator usage in edit tag dialog 2016-02-11 16:09:38 +01:00
John Maguire 6844dcc140 Remove unused variable 2016-02-11 14:19:01 +00:00
John Maguire a7ca007e24 Tidy up lazy implementation. 2016-02-11 14:09:36 +00:00
John Maguire 4c8b1d8143 Add lazy initialisation helper. 2016-02-11 13:46:23 +00:00
John Maguire ea12cfacac Merge pull request #5209 from narunlifescience/patch-1
move duplicated code to annonymous namespace static function
2016-02-11 11:58:06 +00:00
Arun Narayanankutty b4fe7ac7e2 move duplicated code to annonymous namespace static function
update
2016-02-11 05:45:08 -06:00
John Maguire 0ea84e129e Merge pull request #5210 from narunlifescience/patch-2
Use icon loader for remaining icons
2016-02-11 11:24:09 +00:00
narunlifescience b6bf54be6c remove magic numbers 2016-02-11 04:41:37 -06:00
John Maguire 100222477c Merge pull request #5218 from santigl/gainLabel
Add gain label to EqualizerSlider
2016-02-10 15:46:47 +00:00
Santi ec89bd3ea2 Add gain label to equalizerSlider 2016-02-10 12:44:33 -03:00