bd89a1d2de
Fixes for APE filetype.
2019-04-01 22:56:50 -06:00
248f1d8596
Prevent UI hang during device scan. ( #6291 )
...
When unmounting a device, the ConnectedDevice object is destroyed. The
FileSystemDevice destructor waits on its worker thread. If a scan is in
progress, this will block until completion.
There is an existing Stop method in the LibraryWatcher class that is intended to
stop long running operations. To fix, or at least significantly shorten this
hang, we'll call this before waiting for the thread to exit. Also add a
stop_requested check in the cover art scan.
In addition, add a call to Stop in the Library destructor, which has a similar
usage.
2019-02-20 19:03:44 +11:00
d8788d6a0d
Update qt5 branch
2019-01-27 01:00:36 +01:00
7f9cff03b1
Change default group by in library to album artist ( #6264 )
2019-01-21 21:39:39 +00:00
16bdd39c03
Merge remote-tracking branch 'upstream/master' into qt5-update
2018-11-29 23:21:54 +01:00
587e72b8c3
Fix library search queries on fts columns ( #6219 )
...
This fixes a regression introduced in 8818ba340a
2018-11-29 14:36:01 +00:00
d4fab4a2ea
Merge remote-tracking branch 'upstream/master' into qt5-update
2018-11-11 22:46:07 +01:00
80c7235085
Fix no music image ( #6194 )
2018-11-11 16:17:19 +00:00
107e945872
Convert uses of QtAlgorithms to std:: algorithms
2018-10-09 19:17:54 +01:00
c29c2e95cc
Fixed merge conflicts
2018-09-30 15:11:06 +02:00
a65dabcf0a
Date columns for use in library search queries. ( #6135 )
...
* Mention numeric columns in tooltip
* Add date filters in search queries
* Show filter usage in tooltip
* Fix code formatting
2018-09-08 13:18:44 -07:00
68d473cfb1
Add filetype filter in search queries
2018-09-05 01:44:40 -07:00
8818ba340a
More columns for use in library search queries
...
Support more columns for the COLUMN:VALUE syntax
in the library search query
2018-09-05 01:44:40 -07:00
16b4f9a991
Merge remote-tracking branch 'upstream/master' into qt5
2018-05-14 08:25:27 +02:00
d28a318437
Clang format
2018-04-14 16:57:06 -04:00
3626d84964
Add play next from library
2018-03-18 22:44:00 -04:00
c9d954f8a3
Fix bug in covermanager not saving album cover to DB. ( #6011 )
...
* Fix bug in covermanager not saving album cover to DB.
2018-03-04 14:13:34 +00:00
70f68b1926
Merge remote-tracking branch 'upstream/master' into qt5
2018-02-01 09:50:42 +01:00
eab875c46d
Add support for deleting the currently playing track via the commandline ( #5899 )
2017-11-21 10:02:36 +00:00
203ec76973
Add contextual searches to playlists, library and global search. ( #5649 )
...
* Closes #5567 : Contextual album/artist search in library search, global search, and playlists.
* Change artist/album search to 'search for this' in globalsearch
* Change artist/album search to 'search for this' in library
* Applying patch from @Fat-Zer to allow search incl year
* Re-adding missing schema definition
2017-08-09 14:12:36 +01:00
49876536a5
Resolve #3693 ( #5790 )
...
* bring in playlist updates for potential fix
* define signal to handle organise playlist bugs
* work in progress
* fix wrong signal/slot
* next push forward on handling new song creation
* Reorganize signals/slots; still need to figure out why not all signals are being handled
* Get playlists to work when they're in memory
* more changes to playlist updates
* revert unnecessary changes and finalize fix
2017-07-22 18:57:33 +01:00
fc517ce7a5
Merge remote-tracking branch 'upstream/master' into qt5
2017-06-05 21:28:05 +02:00
a8cbb3b18a
Unlock DB mutexes implicitly using scopes. Add error handling for query.
2017-03-06 18:21:27 +00:00
deb7c33c64
Add support for 'album artist' field in the LibraryBackendInterface
2017-03-06 18:21:27 +00:00
62cec8cf28
Prioritize album artist in cover search and manager
2017-03-06 18:21:27 +00:00
8a6cc8b506
Add missing <functional> includes ( #5630 )
2017-02-13 16:46:46 +00:00
18a89f78a9
Merge remote-tracking branch 'upstream/master' into qt5
2016-10-07 14:30:09 +02:00
d96a04431a
added popular libraryfiltergroup filter: Album artist/Album ( #5476 )
2016-09-06 07:28:55 -05:00
0ce9e1696c
Don't cache missing covers ( #5471 )
...
They might change later
2016-08-23 09:26:15 -05:00
0aa3405274
Merge remote-tracking branch 'upstream/master' into qt5
2016-05-09 12:46:08 +02:00
3afa80bef0
Don't scan directories with .nomedia or .nomusic files ( #5327 )
2016-04-15 10:44:44 +01:00
e6e189967d
Merge remote-tracking branch 'upstream/master' into qt5
2016-02-29 18:03:02 +01:00
0ea84e129e
Merge pull request #5210 from narunlifescience/patch-2
...
Use icon loader for remaining icons
2016-02-11 11:24:09 +00:00
b6bf54be6c
remove magic numbers
2016-02-11 04:41:37 -06:00
8dd933b265
Merge pull request #5233 from naokiiwakami/5151
...
Fix issue in checking existence of media files pointed by CUE files
2016-02-09 13:55:40 +00:00
4cb57c0543
Fix issue in checking existence of media files pointed by CUE files
2016-01-30 16:31:10 -08:00
780a34c0bc
Make "AutoExpandingTreeView" animated by default
...
This adds dropdown animation to views which are derived
from "AutoExpandingTreeView" (internet, library, global search etc.)
2016-01-15 07:55:46 +03:00
29b8d308b3
Use icon loader for remaining icons
2016-01-14 06:10:54 -06:00
ff7026c9fe
Merge remote-tracking branch 'upstream/master' into qt5
2015-12-13 20:05:12 +01:00
2ab1c2fe36
Add a Manager dialog for saved groupings
...
- Right now only allows removal
- Could also add support for adding/reordering, but it's not clear
that's necessary
- Triggered from the Display options menu, could also be added to Tools
toolbar menu
2015-12-11 19:49:51 -08:00
862b9a8635
Add saved grouping to the Group by menu
2015-12-11 15:58:06 -08:00
5c256f349a
Add option to save current library grouping
...
- Adds saved groupings to the Group by menu
- Currently missing a way to manage saved groupings
- Saved groupings are in a new section of the config file as
"GroupingName"->ByteArray serialization
2015-12-11 12:02:52 -08:00
f300946c81
Remove most usages of QFutureWatcher
2015-11-27 14:28:12 +00:00
8020749375
add dropdown annimation to library & internet tree view
2015-11-24 19:35:07 -06:00
f03d5356c3
Make a slight modification to library view line & preferences header line
2015-11-24 11:48:16 -06:00
dd953fd86c
check custom icon location, then system theme & then fallback theme
...
icons added & replaced
2015-10-13 22:35:49 -05:00
ec60406f14
make library view sort line themable
...
set line color alpha to 100
2015-09-21 20:17:50 -05:00
774aeaaf11
Revert "clean up library view"
...
This reverts commit 97cbf556a0
2015-09-21 00:23:30 +02:00
631a6cdabd
Merge branch 'master' into qt5
2015-09-16 17:40:54 +02:00
ddade273d8
Merge pull request #5015 from narunlifescience/master
...
clean up library view
2015-09-10 11:13:55 +01:00
97cbf556a0
clean up library view
...
library view sorts the library and display the contents in alphabetical order (bold letter/number followed by a line) . the line cannot be themed as it is hard-coded "QPen line_pen(opt.palette.color(QPalette::Dark))". Here i try to remove the line, align the letter to left and give the letter a highlight using QRect. this way it looks better and is completely themable ...
2015-09-10 03:52:35 -05:00
4722477b1e
Add full rescan reason for original year tag support.
2015-07-01 15:33:25 +02:00
e0816800b1
Add support for original year tags.
2015-06-30 18:34:34 +02:00
d82b0f8a5a
Add ability for sort by group and performer in the library view
2015-06-11 22:45:34 +02:00
5aec1c0e24
Merge remote-tracking branch 'upstream/master' into qt5
...
Update qt version to 5.4.2
2015-06-03 22:57:58 +02:00
60918ef7f8
Return result directly.
2015-05-26 21:51:04 +02:00
aaf2ec25b3
Run make format.
2015-05-23 09:19:23 +02:00
82dcdd3a12
Sort discs numerically when using Group by disc.
2015-05-23 09:19:23 +02:00
e986ab5a4b
Merge master branch and adapt it to qt5
2015-04-16 17:16:34 +02:00
8b226c2171
Update non optionnals sources to qt5
2015-04-11 23:24:07 +02:00
946c0381d1
Don't set thread priority in LibraryWatcher constructor, as this is executed in the main thread.
...
Do it when thread actually starts (create a new Thread class for this purpose).
Fixes #4523 .
2015-02-28 16:44:32 +01:00
0a2a358d8b
"Green Day Problem" solved. Year-Album grouping also obeys grouping tag that allows to order albums released in the same year non-alphabetically
2014-10-29 15:29:45 +02:00
a2df43c830
Reverted changes amde to groupby_performer
2014-10-27 15:49:11 +02:00
7516438c8b
Added disc to the groupby interface. Replced groupby_performer to groupby_disc
2014-10-27 14:47:04 +02:00
0e030b5461
Ran make format.
2014-08-26 10:54:05 -06:00
54742de613
A quick patch to have the library ignore all articles when sorting.
2014-08-25 21:22:53 -06:00
01ae151f8a
Delay writing WMA ratings and play counts until playback has finished. Fixes #3593
2014-06-07 15:29:23 +10:00
f6a72828a9
Write statistics and ratings in Library, not LibraryBackend.
2014-06-07 15:19:43 +10:00
b463f32459
Fix memory leak in pixmap disk cache
2014-05-28 17:30:07 -04:00
b2bd7828c4
More style changes
2014-05-27 20:18:24 -04:00
94b391e0c9
Optimizations and style changes
2014-05-27 18:21:30 -04:00
2332a74bbe
Add persistent disk cache for library pixmaps
...
I'll reference #4379
When viewing the library with album covers visible, the covers load very slowly the first time
as they have to wait on the tagreaders. If I scroll down the library, it takes minutes for the
tagreader to catch up. The nice thing is that the pixmaps are cached. However, once
Clementine is restarted, the whole process has to happen again.
This patch adds a persistent disk cache in the form of a QNetworkDiskCache to store the
pixmaps on disk and load them into the QPixmapCache as required.
I've noted literally night and day performance improvements, not only when scrolling through the library.
There is much better interface responsiveness when searching, and I no longer see the no_cover_icon
temporarily anymore.
2014-05-27 17:40:25 -04:00
24a4cff807
Merge pull request #4288 from sundrythoughts/rating-optimization
...
Increase performance of mass rating changes.
2014-05-20 12:42:39 +01:00
fe4a80b2d5
Removed commented-out code and ran make format.
2014-04-25 19:41:04 -04:00
156728390d
Increase performance of mass rating changes.
2014-04-25 19:37:46 -04:00
5fffbbc689
Add explanatory comment to last commit.
2014-04-22 12:25:59 +02:00
56dade2598
Fix slow library search on sqlite 3.8.
2014-04-19 14:23:50 +02:00
cdf5363320
Prevent translation of the names of the available fields in the tool tip for the library search field.
2014-02-22 18:21:58 +01:00
5146bcdebc
Some more NULL -> nullptr conversions.
2014-02-21 17:30:46 +01:00
3b01247df9
Iterate over a copy of the parents container since we are removing elements from the original.
2014-02-13 10:41:24 +01:00
192b60d965
Use nullptr as parent parameter default everywhere
2014-02-10 16:03:54 +01:00
3323c2d094
Convert all instances of foreach() to a C++11 for
...
find ext src -name '*.cpp' -exec \
sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
175827f73f
Add a tool tip to the library search field.
2014-02-08 14:50:12 +01:00
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
eaf182a59a
Merge pull request #4161 from BrummbQ/master
...
don't rescan unchanged files if library has been unavailable. Fixes #3032
2014-02-07 22:45:55 +11:00
0cab75b28f
removed useless debug log
2014-02-06 19:27:36 +01:00
8d1f4612db
Hide use of boost multi-index behind pimpl.
2014-02-06 17:53:33 +01:00
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
d309d4ab27
Use c++11 instead of boost where possible.
2014-02-06 16:51:39 +01:00
7317b6792e
don't rescan unchanged files if library has been unavailable
2014-02-01 20:21:28 +01:00
08a4629565
'-' is considered as 'NOT' operator by FTS, leading to unexpected results. Not sure how to escape it, better to replace it for now
2014-01-16 16:35:09 +01:00
bd880dcafe
Tweak the replacement of colons.
...
Make sure that there are no trailing whitspaces on tokens before appending "* ".
2014-01-14 01:09:24 +01:00
3f4e8e5b88
Check if token is a valid column name in the fts table before treating it as such.
2014-01-13 16:16:33 +01:00
ad0f8a6f90
playlist context menu entry: Show in library
2014-01-11 15:03:32 -05:00
a39e559425
Implemented sort by bitrate
2013-12-17 16:07:20 +01:00
d53bcde897
Consistently added GroupBy_Bitrate enum item
2013-12-16 19:18:02 +01:00
98dd001a4f
Further work on portable version.
2013-10-03 17:08:42 +02:00
acb18cdcde
First tries on a portable version.
2013-09-29 10:43:34 +02:00
ff71138079
Change file deletion question dialogs to warnings.
2013-06-01 16:23:37 +10:00
88918d45c5
Update issue 1175:
...
Save rating and statistics in two distinct ways, and let users activate them separately in preferences.
2013-03-30 23:42:29 +01:00
James D. Smith
Jim Broadus
Jonas Kvinge
Mattias Andersson
Amish Naidu
Ilgiz Mustafin
Ilgiz Mustafin
Chocobozzz
Mark Furneaux
Jonas Kvinge
Victor Parmar
Jacob Henner
David Roeca
Chocobozzz
santigl
Morris Hafner
Matt
Mark Furneaux
Mildred Ki'Lya
John Maguire
narunlifescience
Naoki Iwakami
Ivan Leontiev
Nick Lanham
Arnaud Bienner
Eduardo Sánchez Muñoz
Ignas Kaziukenas
Gavin Howard
David Sansome
Mark Furneaux
Joseph Freeman
Gregor Tätzner
goetzc
GitAnt
Andreas
Mateusz Kowalczyk