David Sansome
63f13b19f2
Fix a possible crash when an album cover search times out at the same time that it's cancelled or finishes normally. Fixes issue 2752
2012-02-26 15:35:15 +00:00
David Sansome
23724b667f
Start album cover request IDs at 1, so 0 can be invalid
2012-02-26 15:12:39 +00:00
David Sansome
ab5ccf69da
Refactoring: remove BackgroundThread
2012-02-26 15:05:46 +00:00
David Sansome
bacef04405
Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader.
2012-02-26 14:40:51 +00:00
Arnaud Bienner
b32444dce7
Try to fix Debian and Fedora builds
2012-02-19 17:43:23 +01:00
Martin Björklund
00545a4059
Get better discogs results by using the master image before general releases, and also make fewer requests to the server to fetch images.
2012-02-07 13:05:26 +00:00
Martin Björklund
8d63ddd3eb
Add a Discogs cover provider
...
Fixes issue 1794
2012-01-29 14:27:07 +00:00
David Sansome
9be641ee87
The external tagreader mostly works now:
...
* Make TagReaderClient a singleton until it's easier to pass dependencies around
* Add a WaitForSignal() that uses a local event loop to wait for a signal to be emitted
* Add a WaitForFinished() to _MessageReplyBase that blocks using a semaphore
* Add blocking versions of all TagReaderClient methods
* Use the TagReaderClient everywhere that Song::InitFromFile and friends were used before
2012-01-07 00:26:07 +00:00
John Maguire
7585236e20
Use Closure in Amazon cover provider.
2011-12-12 17:36:51 +01:00
John Maguire
5a9bd3e8cf
Add an associate tag to Amazon cover requests.
2011-12-12 17:25:58 +01:00
David Sansome
8d5ef62256
Do spotify image requests with string IDs instead of spotify://image/ urls. For some reason this seems to fix occasional crashes when image results arrive. Fixes issue 2411.
2011-11-29 10:21:40 +00:00
David Sansome
b873209d39
Remove the <xiphcomment.h> include from song.h so that windows headers don't infect everything else. Also move other bits of song.h into song.cpp, and reduce the number of includes in song.h.
2011-11-28 13:56:55 +00:00
David Sansome
e9253af931
Load cover art for the library in a background thread. Fixes issue 2243
2011-11-13 00:31:27 +00:00
David Sansome
a6f4a76618
Hide an occasional crash when playing a spotify track and loading spotify art at the same time - for some reason printing this URL triggers it...
2011-09-24 18:16:35 +01:00
David Sansome
b1fe146966
Maybe fix the mac build
2011-07-23 23:40:24 +01:00
David Sansome
1f8263d329
Add a C++ implementation of the Amazon cover provider
2011-07-23 19:34:54 +01:00
David Sansome
38100f5e59
Make CoverProviders not a singleton
2011-07-23 19:34:41 +01:00
Tyler Rhodes
ded8e5f6f0
Refactor "Radio" files into "Internet" files.
2011-07-15 13:27:50 +00:00
David Sansome
7773e98ebf
Keep track of some statistics while searching for album covers, and show a statistics dialog at the end. Fixes issue 1921
2011-06-26 15:07:48 +00:00
David Sansome
42801a967b
Cancel album cover loads properly
2011-06-26 15:07:29 +00:00
David Sansome
f8045af720
Various album cover search changes:
...
- Download several covers and use some heuristics to decide which cover is the best, rather than just taking the first one.
- Timeout album cover downloads after 2.5s
- Show covers properly in the album cover manager if they were manually unset, and then Clementine was restarted.
2011-06-26 15:07:19 +00:00
David Sansome
bac414a630
Allow the artist and album to be specified separately when searching for album covers
2011-06-22 19:07:15 +00:00
David Sansome
2e9ec3e9d4
Don't crash on exit when unregistering cover providers
2011-06-22 19:06:57 +00:00
David Sansome
9023aafdef
Try fixing the build again
2011-06-20 10:24:31 +00:00
David Sansome
62bd3694ec
Remove cover provider factories and refactor everything else to use cover providers directly instead.
2011-06-19 23:15:51 +00:00
David Sansome
c6e2981860
Group album cover search results by category
2011-06-19 23:15:29 +00:00
David Sansome
7de618beff
Fix registration of metatypes for list handlers on Qt 4.7
2011-05-29 14:08:55 +00:00
David Sansome
9e6fea9d27
Refactor AlbumCoverFetcherSearch to not delete replies while they might still be used, and to remove unnecessary mutex locking
2011-05-28 16:00:46 +00:00
David Sansome
3ac2ae6a83
Fix a segfault that occurred when an album cover search finished - seen more often with Python providers.
2011-05-28 16:00:38 +00:00
David Sansome
e1620385d5
Fix the Amazon covers script to work with PythonQt, and some minor style fixes
2011-05-22 14:11:02 +00:00
Paweł Bara
46a411844a
some more corrections of the python API for cover providers; still not working ;)
2011-05-21 12:19:35 +00:00
Paweł Bara
e0ab8ae5f2
little improvements to the last commit
2011-05-17 18:02:39 +00:00
Paweł Bara
d1d177769a
cover providers are now recreated every search (this will lead to simpler API of theirs in a moment)
...
initial migration from SIP -> PythonQt in cover providers
2011-05-17 17:53:36 +00:00
David Sansome
0b4368aece
Fix build error
2011-04-29 14:07:30 +00:00
David Sansome
5efe63462c
Get album art for Spotify tracks
2011-04-29 13:41:42 +00:00
David Sansome
ccb9f8cf94
Use URLs everywhere instead of filenames. Move the URL parsing and song loading code out of individual playlist parsers and into the base class. Fix the playlist parser unit tests.
2011-04-28 12:27:53 +00:00
Paweł Bara
fdda938c53
now that we have more cover providers, we're bringing the cover manager and the cover searcher goodness to our last.fm-less users
2011-04-27 19:10:37 +00:00
David Sansome
df05bf1195
Fix a bounds check in PlaylistTabBar, convert a couple more things to use qLog()
2011-04-22 17:07:57 +00:00
Paweł Bara
90470e1315
another plugin - Amazon provider for searching of covers
2011-04-21 19:07:39 +00:00
Paweł Bara
6841e183d3
in the Last.fm config dialog, hide the warning icon with the warning itself
...
David's POTs
2011-04-17 15:25:32 +00:00
John Maguire
cb763213bf
Add missing Q_OBJECT macro.
2011-04-07 13:29:42 +00:00
Paweł Bara
3c61fbdade
terminate the search for covers immediately if there are no providers
...
if there's a search timeout, send back the results gathered so far (if any)
fixing the previous commit
2011-04-02 15:31:28 +00:00
Paweł Bara
f86b671272
fixing the minimal build
2011-04-02 14:43:50 +00:00
Paweł Bara
032b5f7e48
initial commit of "multiple covers providers" feature:
...
- simple API for cover providers (both C++ and SIP)
- a new "package" for cover related code
2011-04-02 13:34:06 +00:00