Commit Graph

59 Commits

Author SHA1 Message Date
narunlifescience b6bf54be6c remove magic numbers 2016-02-11 04:41:37 -06:00
Arun Narayanankutty 29b8d308b3 Use icon loader for remaining icons 2016-01-14 06:10:54 -06:00
narunlifescience dd953fd86c check custom icon location, then system theme & then fallback theme
icons added & replaced
2015-10-13 22:35:49 -05:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
John Maguire bebd781fdf Reformat all non-3rd-party C/C++/Objective-C++.
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
 -style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
John Maguire 71893e4847 Use nullptr instead of NULL everywhere. 2014-02-06 17:29:59 +01:00
John Maguire d309d4ab27 Use c++11 instead of boost where possible. 2014-02-06 16:51:39 +01:00
Andreas f805c003eb Show message when there are no covers to export. 2013-05-13 16:09:36 +02:00
Andreas 4e2ded9178 - Finished album cover exporter from keirangtp's branch "export-covers".
- Updated export dialog layout.
- Added option to export downloaded and/or embedded covers.

- Auto. cover fetcher and exporter is now cancelable.
- Minor covermanager layout improvements.
- Covermanager shows count of total and missing covers.

Fixed issue 520.
2013-05-06 21:22:05 +02:00
John Maguire 07abe82ef3 Add a cover manager for the Google Drive library. 2012-10-01 16:39:58 +02:00
John Maguire 6208373b86 Port search field in AlbumCoverManager to QSearchField and add support for placeholder text. 2012-06-28 11:40:05 +02:00
David Sansome bacef04405 Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader. 2012-02-26 14:40:51 +00:00
David Sansome 48f15c9fc7 Refactoring: instead of passing individual pointers to useful core classes (like TaskManager or LibraryBackend) to each class that uses them, pass one singleton-like Application instance everywhere. 2012-02-26 14:40:51 +00:00
David Sansome 7e1b6ef6c4 Use locale aware sorting for the lists of artists and albums in the album cover manager. Fixes issue 1952 2011-08-28 00:25:41 +01:00
David Sansome 38100f5e59 Make CoverProviders not a singleton 2011-07-23 19:34:41 +01:00
David Sansome 7773e98ebf Keep track of some statistics while searching for album covers, and show a statistics dialog at the end. Fixes issue 1921 2011-06-26 15:07:48 +00:00
David Sansome f8045af720 Various album cover search changes:
- Download several covers and use some heuristics to decide which cover is the best, rather than just taking the first one.
 - Timeout album cover downloads after 2.5s
 - Show covers properly in the album cover manager if they were manually unset, and then Clementine was restarted.
2011-06-26 15:07:19 +00:00
David Sansome dd98f8abc8 Make the album cover search results list scroll by pixel instead of item, and re-layout the items when any data changes 2011-06-26 15:06:59 +00:00
David Sansome 62bd3694ec Remove cover provider factories and refactor everything else to use cover providers directly instead. 2011-06-19 23:15:51 +00:00
David Sansome 7415d85dce When initialising a song from a library query, don't always assume the metadata originally came from a file (which means icycast tags are ignored when it is played). Fixes issue 1857 2011-06-17 20:00:10 +00:00
Paweł Bara d1d177769a cover providers are now recreated every search (this will lead to simpler API of theirs in a moment)
initial migration from SIP -> PythonQt in cover providers
2011-05-17 17:53:36 +00:00
David Sansome ccb9f8cf94 Use URLs everywhere instead of filenames. Move the URL parsing and song loading code out of individual playlist parsers and into the base class. Fix the playlist parser unit tests. 2011-04-28 12:27:53 +00:00
Paweł Bara 10fbbca82f disable some more stuff in the cover manager's window if there are no active cover providers 2011-04-27 19:36:42 +00:00
Paweł Bara fdda938c53 now that we have more cover providers, we're bringing the cover manager and the cover searcher goodness to our last.fm-less users 2011-04-27 19:10:37 +00:00
Paweł Bara 032b5f7e48 initial commit of "multiple covers providers" feature:
- simple API for cover providers (both C++ and SIP)
- a new "package" for cover related code
2011-04-02 13:34:06 +00:00
Arnaud Bienner fb36940d5e Add tooltip for cover manager's items, which displays artist and album name info. Fixes issue 451 2011-02-08 22:54:37 +00:00
Paweł Bara 77151d7ebd Hiding some of Song's cover art logic complexity in Song's API (namely: embedded and manually unset covers). 2011-02-02 21:01:08 +00:00
Paweł Bara 8aedda1795 moving the 'Save cover to file' action into AlbumCoverChoiceController; implementing the action in all related places (now playing widget, album cover manager, edit tag dialog)
now playing widget: disable all cover related context menu options (except for the 'save cover' one) when in 'Kittens' mode
2011-02-02 16:22:04 +00:00
Paweł Bara 2fec795b89 fixed an error where entering the Cover Searcher dialog without query would make it show the busy indicator forever
further refactoring of album cover changes (QMenu in controller)
2011-01-25 23:33:27 +00:00
David Sansome 0beb12fc14 Add some options to control what happens when you double click or use the menu to add tracks to the playlist 2011-01-24 21:16:26 +00:00
Paweł Bara 4a9d38bbdd final refactoring stage of cover changing code (common QAction*s)
reset URL in 'Cover from URL' dialog on reentrance
2011-01-24 18:32:09 +00:00
Paweł Bara ebfbdba8a9 further refactoring of cover changing code (saving covers in controller) 2011-01-24 17:53:31 +00:00
Paweł Bara 8bce92e69b refactoring the code that handles common UI album cover related actions into a common controller
fixes a bug where cancelling the 'cover from URL' dialog would set the cover to a previously chosen URL
2011-01-24 00:09:57 +00:00
Paweł Bara 3e2ffd3647 ability to load cover from URL in all the usual places: cover manager, now playing widget and edit tag dialog (fixes issue #517) 2011-01-23 20:24:17 +00:00
David Sansome 135b32642e Refactor all the code that handles adding items to the playlist - whether it be by a context menu item, double clicking in a view or dragging. Everything now uses the models' mimeData() instead of duplicating the same code everywhere. 2011-01-10 22:26:13 +00:00
David Sansome 97d7fe764a Download higher resolution images from last.fm. Thanks markwatkinson. Fixes issue #1187 2010-12-26 20:19:12 +00:00
David Sansome 2a63a746fe Allow changing the cover art from the edit tag dialog 2010-12-20 15:46:38 +00:00
John Maguire 4e2d82f3fb Fix mac build. 2010-12-20 14:49:47 +00:00
David Sansome 05a1bf6e37 Make the clear button a part of the search textbox. Fixes issue #1071 2010-12-18 20:32:05 +00:00
Arnaud Bienner 6ecc69d18b Also filter on artist name on Cover manager (instead of only album name) 2010-12-16 23:38:27 +00:00
Paweł Bara 61d5641c35 try to start the 'load cover' dialog in album cover manager inside the chosen album's folder (Fixes issue #733) 2010-12-15 20:15:46 +00:00
John Maguire b9e642c864 Add more close shortcuts. 2010-12-14 17:55:08 +00:00
John Maguire 6257b29629 Add keyboard shortcut for album cover manager close. 2010-12-14 17:31:39 +00:00
John Maguire 769a78c6a2 UI tweaks for mac album cover manager. 2010-12-14 17:09:41 +00:00
John Maguire 21415ff230 Fix some mac ui and metadata bugs. 2010-12-14 15:00:46 +00:00
David Sansome ed1a25693c Add missing licenses to debian/copyright, and add copyright information to each source file 2010-11-20 13:27:10 +00:00
David Sansome 47004d0ac3 Fix album cover manager test 2010-10-16 18:21:28 +00:00
David Sansome b5f366c40a Add a thread safe network disk cache, and remove the need to pass a NetworkAccessManager around everywhere. Fixes issue #852 2010-10-16 17:20:54 +00:00
John Maguire 90359f84ec Block until AlbumCoverLoader thread has started in cover manager. 2010-09-13 18:53:44 +00:00
John Maguire e67f9a66c8 Load playlist in separate threads on startup. 2010-08-03 18:57:17 +00:00