Commit Graph

2334 Commits

Author SHA1 Message Date
David Sansome 2740ad4370 Oops 2011-02-14 20:15:35 +00:00
David Sansome aeb2ab9625 Only run the MPRIS1 test on Linux 2011-02-14 19:34:54 +00:00
David Sansome 8c691d2b3e Use constants instead of "1eN" literals for converting between time units. 2011-02-14 19:34:37 +00:00
Paweł Bara faa0970c00 fixing SIP binding 2011-02-14 18:12:43 +00:00
Paweł Bara 85b876d112 fixed broken RemoveDuplicates script
maybe fix the issue #1444
2011-02-14 17:44:15 +00:00
Paweł Bara d109b70898 David's comments 2011-02-14 17:29:56 +00:00
Paweł Bara 0182829223 user-friendly name for 'Open in new playlist' playlists (fixes issue #1445) 2011-02-14 17:00:13 +00:00
David Sansome e67f39cedb Fix the windows build 2011-02-13 20:25:55 +00:00
David Sansome f801252e3d Refactor Player and PlaylistManagers to have interfaces and add more MPRIS1 tests 2011-02-13 18:37:45 +00:00
David Sansome 12da941885 Add a really basic unit test for MPRIS1 2011-02-13 18:37:21 +00:00
David Sansome e18409ebf4 Factor out a PlayerInterface from Player, and use it in MPRIS1 and MPRIS2 2011-02-13 18:36:29 +00:00
David Sansome b38ce42ff8 Move the "Reset play counts" button in the edit tag dialog 2011-02-13 18:35:52 +00:00
David Sansome 3a1853a681 Use nanoseconds in playlist parsers, and fix the tests 2011-02-13 18:35:26 +00:00
David Sansome 507c5e2632 Change the fields in Song from seconds to nanoseconds 2011-02-13 18:34:30 +00:00
David Sansome 37618dae96 Use nanoseconds instead of seconds or milliseconds throughout the Player and Engine. 2011-02-13 18:29:27 +00:00
David Sansome 9aefae4e39 Remove a little space in the edit tag dialog 2011-02-13 18:29:13 +00:00
Arnaud Bienner e6b59de56b Corrected center on last played track 2011-02-11 20:16:42 +00:00
Paweł Bara c8aed5fd30 further refactoring of duplicated playlist-insertion related code in RadioServices 2011-02-10 22:24:17 +00:00
Arnaud Bienner 79159700fc Center on last played song when restoring playlist. Fixes issue 410. 2011-02-10 20:55:19 +00:00
Arnaud Bienner 0544cfa90a Sort playlist by ui_order, to keep playlist ordered even if the user re-order them. Most of the code was written, I can't figure out why this code was missing... Anyway, fixes issue 1068 2011-02-10 20:50:57 +00:00
Paweł Bara a6b6147c9d drag and drop to empty playlist-tab-bar's space in order to create a new playlist with the dragged items (fixes issue #1431) 2011-02-09 18:48:31 +00:00
Paweł Bara 38172c39b4 simplifying AddItems API of RadioService 2011-02-09 18:23:14 +00:00
Paweł Bara 60ac6768b8 Fresh new 'open in new playlist' action (Updates issue #1431). 2011-02-09 17:51:59 +00:00
Arnaud Bienner fb36940d5e Add tooltip for cover manager's items, which displays artist and album name info. Fixes issue 451 2011-02-08 22:54:37 +00:00
Paweł Bara 4cd01a43b7 fixing names of all the 'add to playlist' items in context menus (Fixes issue #1421) 2011-02-08 22:42:09 +00:00
Arnaud Bienner de2193f5af Display tooltip info in library only if text displayed is elided (as it was done for playlistdelegates, r2745). Partially fixes issue 451 2011-02-08 21:55:32 +00:00
Paweł Bara 33276132ec when saving cover, start in the album's folder (just like with the similar 'load cover from disk' feature) 2011-02-07 23:53:32 +00:00
Paweł Bara b7cd42fe53 minor C++ stuff 2011-02-06 14:34:47 +00:00
Paweł Bara 82e92bb3ac library view has now three modes: 'all songs', 'duplicates only' and new 'untagged songs only' (check out the http://code.google.com/p/clementine-player/wiki/LibraryViewModes) - fixes issue #305
+ hiding the 'complexity' of QueryOptions filter and query_mode mutual exclusion behind it's API
2011-02-06 13:18:18 +00:00
Paweł Bara e08c6cc6a5 just a prettier expression 2011-02-05 13:45:40 +00:00
Paweł Bara 9a9d8ad177 don't let invalid CUE related media files into library (invalid == those which were not recognized by TagLib)
better logging of erroneous DB queries (error + query + bound values instead of just error)
2011-02-05 13:43:04 +00:00
Paweł Bara a0dfaf89fb be consistent - if we're letting playlist to decide what songs are valid then let's also restore everything it's loaded when Clementine restarts (this actually fixes some problems with a CUE I have) 2011-02-04 17:41:45 +00:00
John Maguire 4fb6f92ad4 Fix compile warning on mac. 2011-02-04 15:25:05 +00:00
John Maguire 8a5455dc7e Fix UI file warnings. 2011-02-04 15:17:29 +00:00
John Maguire df0f3e1589 Fix building tests on mac. 2011-02-04 15:00:27 +00:00
John Maguire 1fc9dd183d Put our CFLAGS after the default ones so they don't get overridden. 2011-02-04 14:35:25 +00:00
John Maguire 01915cc351 Remove taglib prefix from #includes in tests. 2011-02-04 13:29:49 +00:00
John Maguire 084b9a2fe3 Remove taglib prefix from includes as the taglib include path contains it already. 2011-02-04 12:36:56 +00:00
John Maguire ab2f3360e2 Add Linux variable and set -Werror for Linux builds. 2011-02-04 12:07:00 +00:00
John Maguire c680c55379 Fix a couple of warnings found by Clang. 2011-02-04 11:17:31 +00:00
Paweł Bara ed4b7abde0 changed my mind - reverting my playlist changes to previous status quo (just making the PlaylistParser's contract more explicit)
this doesn't mean the previous revision was pointless - it still fixed one CUE related bug which I forgot to mention...
2011-02-03 22:21:15 +00:00
David Sansome a361dc128d Sort out the cmake dependency mess when generating/compiling translations - should hopefully fix some compile issues with parallel jobs. 2011-02-03 22:01:31 +00:00
David Sansome e586ca12e5 Link clementine_lib instead of clementine against qtsparkle, fixing the tests on Windows 2011-02-03 21:06:05 +00:00
David Sansome 3ef0bf65a8 Fix the last.fm icon while a last.fm station is loading 2011-02-03 20:59:53 +00:00
David Sansome 2a68ecc726 Remove some unused bits 2011-02-03 20:59:14 +00:00
Paweł Bara 7bdac8fba6 when loading playlist, take only it's valid songs (+ force validity of CUE and PLS related songs) 2011-02-03 17:47:32 +00:00
Arnaud Bienner 74a878be41 Minor modication thanks to David comment 2011-02-02 23:27:55 +00:00
Arnaud Bienner e8720f5bda Display item info in playlist view only if text displayed is elided 2011-02-02 22:58:19 +00:00
Paweł Bara 2623a170a4 forgot this 2011-02-02 21:05:07 +00:00
Paweł Bara 77151d7ebd Hiding some of Song's cover art logic complexity in Song's API (namely: embedded and manually unset covers). 2011-02-02 21:01:08 +00:00