Commit Graph

5862 Commits

Author SHA1 Message Date
Mark Furneaux efa58bb852 Actually initialize the array 2014-12-22 00:05:46 -05:00
Mark Furneaux 6157865d7b Initialize array in a nicer way 2014-12-21 23:53:42 -05:00
Mark Furneaux 1d31378174 Fix moodbars not generating correctly
The magnitude output from gstfastspectrum was not initialized for the first fft.
In some cases, the memory would contain data that upon math operations becomes nan.
This causes one or more colours of the moodbar to be generated blank, resulting in missing colours or just plain black moodbars.
2014-12-21 23:11:02 -05:00
Mark Furneaux 4f66b6d453 Merge branch 'master' of https://github.com/clementine-player/Clementine 2014-12-21 16:24:37 -05:00
John Maguire 1e752ce99c Merge pull request #4661 from sobkas/master
Fix formatting and general directory structure inside internet/
2014-12-19 11:26:22 +01:00
Krzysztof Sobiecki a6322da196 Fix header copyright tags in internet/ 2014-12-19 00:47:55 +01:00
Krzysztof Sobiecki 17c35e32e5 Fix header order in internet/ 2014-12-19 00:40:30 +01:00
Krzysztof Sobiecki 23ee9170b6 Fix header guards in internet/ 2014-12-18 23:54:21 +01:00
Krzysztof Sobiecki fa9ea6ec5f Fix compilation with moved files in internet/ 2014-12-18 23:35:21 +01:00
Krzysztof Sobiecki 93a286a272 Move files around and make subdirectories inside src/internet, move src/podcasts to src/internet 2014-12-18 00:39:20 +01:00
Krzysztof Sobiecki ff62032568 Various formating changes in src/internet 2014-12-17 22:36:27 +01:00
ArnaudBienner a6d8e3954a Merge pull request #4657 from Chocobozzz/taglib_fixes
Path taglib to skip multiple ID3v2 tags which can cause bugs with length
2014-12-16 22:40:20 +01:00
Chocobozzz c44c7e5f04 Path taglib to skip multiple ID3v2 tags which can cause bugs with length
for example
2014-12-16 22:23:12 +01:00
Krzysztof Sobiecki ad4bc3b88b Cherry pick more make format changes src/podcasts 2014-12-16 14:59:17 +01:00
Krzysztof Sobiecki 8b934b7ada Make formater a little bit more generic 2014-12-16 14:32:10 +01:00
John Maguire cae4aff17d Merge pull request #4656 from sobkas/master
Produce a proper url for date parse error
2014-12-16 13:28:39 +01:00
Krzysztof Sobiecki 4fec417a93 Produce a proper url for date parse error 2014-12-16 13:14:56 +01:00
David Sansome 6851a15dc0 Merge pull request #4651 from sobkas/fix
Fix the parsing of some strange date formats in podcasts, and add a way to limit the number of podcast episodes shown, and hide listened podcasts.  Fixes #3696, fixes #3475
2014-12-16 12:33:50 +11:00
Krzysztof Sobiecki 81537754e8 A better error url 2014-12-16 01:45:54 +01:00
Clementine Buildbot 943e79ebea Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-12-15 10:01:29 +01:00
Krzysztof Sobiecki ba1d73d1aa Fix problems with code 2014-12-14 14:35:21 +01:00
Krzysztof Sobiecki bf55bc08fb Cherry pick make format changes 2014-12-14 12:23:04 +01:00
Krzysztof Sobiecki 6cc72e2f5d Fix a date parser for one podcasts 2014-12-14 12:13:05 +01:00
Krzysztof Sobiecki 958cb42e98 Allow to hide listened podcast episodes and show only n number of episodes.
Fixes #3696
Fixes #3475
2014-12-14 12:12:57 +01:00
John Maguire 946dc0ce3e Merge pull request #4648 from sobkas/master
PodcastDownloader changes
2014-12-14 00:37:37 +01:00
Krzysztof Sobiecki a7e8c927f4 Now without sender 2014-12-13 20:06:39 +01:00
Krzysztof Sobiecki 1922d51780 Fix header files order 2014-12-13 02:24:20 +01:00
Krzysztof Sobiecki 418d65a1a7 Fix header files order 2014-12-13 02:05:08 +01:00
Krzysztof Sobiecki 741bceab02 Ability to cancel downloads in progress
Fixes #3661
2014-12-12 19:38:29 +01:00
Arnaud Bienner 4b48be4a5b Sort Grooveshark favorite songs according to "TSFavorited", as such songs have no "Sort" field.
BTW the compare was buggy (didn't compare against song2). This was OK though, as
we stable sort songs, and they are always ordered as far as I know (I remember
adding this sort just in case they will not be sent ordered on day).
2014-12-10 22:48:49 +01:00
Krzysztof Sobiecki a43a39b669 Fix errors, newline was here 2014-12-10 22:17:10 +01:00
Krzysztof Sobiecki 3bdf765e3d Fix errors, cherry picked make format fixes 2014-12-10 22:13:01 +01:00
Krzysztof Sobiecki 8cbe742d9f Fix errors, needed for a pull 2014-12-10 21:57:09 +01:00
John Maguire fb5181a6e9 Tidy up locking usage around FFTW.
* Move QMutex into the class instead of static.
* Use QMutexLocker
* Only lock around FFTW plan & destroy functions.
2014-12-10 18:57:35 +01:00
Krzysztof Sobiecki 2d2783ab04 Fix copyright notices 2014-12-10 01:25:52 +01:00
Krzysztof Sobiecki 793ece163a Fix copyright notices 2014-12-10 01:24:51 +01:00
Krzysztof Sobiecki a07f115088 Fix copyright notices 2014-12-10 01:23:43 +01:00
Krzysztof Sobiecki 970e86aac5 Allows to download multiple podcasts at the same time
A new PodcastDeleter, it deletes podcast episodes
2014-12-10 00:47:52 +01:00
Krzysztof Sobiecki d1cad6cbc1 Remove podcast episode automatic deleter out of PodcastDownloader 2014-12-10 00:31:40 +01:00
John Maguire fdd669360f Merge pull request #4644 from sbird/fasterstartup
Patches to start clementine faster
2014-12-09 20:02:51 +01:00
Simeon Bird 3f9b5f4663 Do Podcast updates on song change off main thread
Each time the song is changed, the podcast backend checks whether the
new song is a podcast and, if so, mark it as listened to. This requires
1-2 db queries, so do it off the main thread.

Time to change song before: 300 ms
                    after: 50 ms usually, 80 ms sometimes
2014-12-09 12:49:24 -05:00
Simeon Bird 401f07c7cb Avoid db commits during startup
When starting clementine, each playlist is loaded in turn.
When loading a playlist, the new tab order is committed to the db,
but we don't need to do that here because we know that once all the
playlists are loaded the tab order will be the same as it was initially.

This speeds startup substantially.
kstartperf:
Before: 3.5s
After: 1.5s
2014-12-09 12:48:53 -05:00
Simeon Bird 09e839353e Speed up playlist restoring by moving sqlite query off main thread
The playlist fetching uses QtConcurrent to make the playlist on a
different thread (possibly concurrently for each item).
However, profiling reveals that the slow operation is fetching
the rows from the SQLite database, making this redundant.

Instead move the whole playlist loading, including the database access,
into a single function, and call that function in a different thread via
QtConcurrent::run.

This has the side effect of moving all the concurrent stuff from
PlaylistBackend into the callers.

kstartperf measures:

Before: 7.5s cold
        3.6 s warm

After: ~4.0 s cold
       3.5 s warm
2014-12-09 12:47:37 -05:00
Clementine Buildbot 8e0952e0b1 Automatic merge of translations from Transifex (https://www.transifex.com/projects/p/clementine/resource/clementineplayer) 2014-12-08 10:01:25 +01:00
Mark Furneaux de934e4cc7 Merge branch 'master' of https://github.com/clementine-player/Clementine 2014-12-07 11:48:25 -05:00
Andreas b5567a7b27 Try fixing race condition in fftw by adding mutex for fftw_* function calls suggested here: http://www.fftw.org/fftw3_doc/Thread-safety.html. Updates #4643. 2014-12-07 14:07:53 +01:00
Andreas 0f1b29a523 Make sure SongSender is deleted when client disconnects. 2014-12-07 13:54:18 +01:00
Arnaud Bienner 16b2ac547c Sort music brainz releases according to status 2014-12-06 17:54:13 +01:00
Mark Furneaux b1add3d73e Merge branch 'master' of https://github.com/clementine-player/Clementine 2014-12-05 22:11:32 -05:00
Arnaud Bienner f34f868c0f Add Spotify tracks to Spotify playlists by drag and drop 2014-12-03 23:58:09 +01:00