0bf911aec4
Clean up the stream if ownership isn't taken by a taglib file.
2014-06-05 20:20:57 +10:00
36f0cde07d
Revert "Remove deprecated use of static mutex in moodbar."
...
Fixes #4394
This reverts commit 7652e2f780
2014-06-05 11:58:30 +02:00
f14ec51a60
add constant for max tries and correct memory leaks
2014-06-04 18:44:23 +02:00
71c096c170
add new line for schema-45
2014-06-04 18:02:49 +02:00
e484306631
Correction after hatstand's review
2014-06-04 17:58:28 +02:00
1fc95cb7ed
Add Seafile Support
2014-06-03 14:33:07 +02:00
615e8e7614
Merge pull request #4390 from Narfinger/tagfix
...
deleting track/disc/year in the spinbox should correct as expected
2014-06-02 23:12:36 +02:00
fd7daf2839
deleting track/disc/year in the spinbox should correct to the nearest
...
value and not to the last digit
2014-06-02 22:38:42 +02:00
838da7f790
Merge pull request #4375 from paperbagcorner/fix-musicbrainz
...
Fix parsing of MusicBrainz data for discid
2014-06-02 16:45:06 +02:00
ac162c3477
Move qRegisterMetaType back to SetUpTestCase(). Add comment
...
regarding ownership of the optional argument to MusicBrainzClient().
2014-06-02 16:34:03 +02:00
7652e2f780
Remove deprecated use of static mutex in moodbar.
2014-06-02 13:14:52 +02:00
ff371a6769
Add appdata xml to RPM spec
2014-06-02 11:52:33 +02:00
ae1d26d7b7
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-06-02 10:01:57 +02:00
1e3cfb0a2c
Don't try to update the scope if there's no buffer yet. Fixes #4388
2014-06-02 12:46:45 +10:00
e72cd6648a
Set a minimum height on the equaliser sliders. Fixes #4380
2014-06-01 20:45:14 +10:00
3e51d13bc0
Add an AppData file. Fixes #4381
2014-06-01 20:39:15 +10:00
9a06e7822c
Make mock_network_ a std::unique_ptr and create it in SetUp() instead of SetUpTestCase().
2014-05-30 21:56:33 +02:00
162b2efbb0
If we don't know the length of a song from the metadata, get it from the pipeline which has the real length. Fixes #2818 when the length isn't in the podcast metadata.
2014-05-29 21:33:53 +10:00
d99f4032b3
Do case insensitive comparisons on XML namespaces in podcasts. Fixes parsing of the length field in some (most?) podcasts. Fixes #2818 .
2014-05-29 21:11:49 +10:00
453a012f21
Make it impossible to collapse either side of the MainWindow splitter. Fixes #4384
2014-05-29 20:43:43 +10:00
c8661541a4
Merge pull request #4383 from TheUbuntuGuy/libcache
...
Fix memory leak in pixmap disk cache
2014-05-29 07:57:41 +10:00
b463f32459
Fix memory leak in pixmap disk cache
2014-05-28 17:30:07 -04:00
acaa374139
Merge pull request #4382 from TheUbuntuGuy/libcache
...
Add persistent disk cache for library pixmaps. Fixes #4379
2014-05-28 14:55:51 +10:00
b2bd7828c4
More style changes
2014-05-27 20:18:24 -04:00
94b391e0c9
Optimizations and style changes
2014-05-27 18:21:30 -04:00
2332a74bbe
Add persistent disk cache for library pixmaps
...
I'll reference #4379
When viewing the library with album covers visible, the covers load very slowly the first time
as they have to wait on the tagreaders. If I scroll down the library, it takes minutes for the
tagreader to catch up. The nice thing is that the pixmaps are cached. However, once
Clementine is restarted, the whole process has to happen again.
This patch adds a persistent disk cache in the form of a QNetworkDiskCache to store the
pixmaps on disk and load them into the QPixmapCache as required.
I've noted literally night and day performance improvements, not only when scrolling through the library.
There is much better interface responsiveness when searching, and I no longer see the no_cover_icon
temporarily anymore.
2014-05-27 17:40:25 -04:00
f9be68a3a1
Merge pull request #4376 from TheUbuntuGuy/master
...
Fix dbz possibility in moodbar
2014-05-27 12:33:07 +02:00
26014890e9
Automatic merge of translations from Transifex ( https://www.transifex.com/projects/p/clementine/resource/clementineplayer )
2014-05-26 10:01:56 +02:00
134b617ec4
Emit dataChanged when changing skip track state.
...
Otherwise, when changing this for the currently playing track, the "strike out" change wasn't visible.
2014-05-25 18:44:54 +02:00
af42ccea38
Fix dbz possibility in moodbar
...
Took me forever to find this. Randomly happens when changing tracks.
2014-05-25 00:16:12 -04:00
0be0498e94
Reset the model during init of CddaDevice
...
This ensures that the track list in the device tab is correctly updated when a
disc is replaced with one that doesn't exist in the MusicBrainz database.
2014-05-24 13:54:07 +02:00
68d445fed2
Parse discid xml from MusicBrainz correctly. Fixes #4025 .
2014-05-24 13:54:07 +02:00
e14c59948f
Add test for MusicBrainzClient.
2014-05-24 13:54:07 +02:00
f65c48ef9c
Fix the rendering of the little numbers in the boxes on queued items in the playlist
2014-05-24 14:05:21 +10:00
96dd87a4f3
Treat trashed files as deleted. Fixes #4374
2014-05-24 13:48:45 +10:00
5f05353939
Change Name to Action in the Configure Shortcuts settings page. Fixes #4310
2014-05-24 13:29:46 +10:00
566ae6a6e4
Don't compile vreen with link-time optimizations - it makes all the symbols hidden on Arch Linux.
2014-05-23 22:52:37 +10:00
c217450d0c
Fix some bad sizeof -> arraysize changes from revision 41e9c15248.
2014-05-23 21:31:50 +10:00
0e96eb7370
Merge pull request #4372 from TheUbuntuGuy/master
...
Fix random artifacting on nyanalyzer on startup
2014-05-23 21:26:52 +10:00
c404552682
Fix random artifacting on nyanalyzer on startup
...
memset works on bytes, not the source datatype width
2014-05-23 07:20:13 -04:00
0dae8ecf27
Merge pull request #4367 from TheUbuntuGuy/master
...
Add new analyzer "Rainbow Dash"
2014-05-22 16:00:47 +01:00
f2a1defa2a
Make sizeof more generic
2014-05-22 10:58:08 -04:00
663b7430d8
Add new analyzer "Rainbow Dash"
...
As requested in SuperUltraCriticalShowstopper request #2685
I have built an analyzer based on Rainbow Dash
...oh god, what have I done...
This will either make some people happy, or is absolute garbage.
2014-05-22 10:33:21 -04:00
b45cf393bd
Merge pull request #4366 from paperbagcorner/check-invalid
...
Check for error when getting the number of cd tracks
2014-05-22 10:41:12 +01:00
4569bd9f2f
Check for error when getting the number of cd tracks. Build an empty
...
track list table if this is the case.
2014-05-22 07:51:08 +02:00
87af0ef839
Merge pull request #4365 from paperbagcorner/empty-riplist
...
Don't start ripping unless the user has selected some tracks
2014-05-21 17:26:03 +01:00
0c76ca3c45
Don't start ripping unless the user has selected some tracks.
2014-05-21 18:07:48 +02:00
1f97406171
Revert "Send album artist to Last.fm"
...
This reverts commit d7ec8b9103
2014-05-21 17:47:01 +02:00
7702271fe6
Merge pull request #4344 from paperbagcorner/fix-tagging
...
Improve the tagging and the track information handling in the CD ripper
2014-05-21 15:46:00 +01:00
8bb19f1887
Save tags using async calls.
2014-05-21 16:36:46 +02:00
David Sansome
John Maguire
Chocobozzz
Narfinger
Mattias Andersson
Clementine Buildbot
Mark Furneaux
ArnaudBienner