John Maguire
0782489feb
Revert "Fix deprecated comparison."
...
This reverts commit be144d46113f2c4f3318b410efd2abf7f5260ab1.
2020-05-13 12:43:08 +01:00
Jim Broadus
96a17c9f40
settings: Only save settings for visited pages
...
Set a flag when a page is shown. On apply or accept, only save if that flag is
set.
2020-05-12 10:21:44 +01:00
Jim Broadus
77badd37ff
settings: Add dialog methods to settings pages
...
Add Accept, Apply, Reject methods to settings pages to mirror dialog. This will
allow settings pages to handle these events at a more granular level and will
allow common behavor in the base class.
2020-05-12 10:21:44 +01:00
Michael Kuc
be144d4611
Fix deprecated comparison.
...
Using references no longer requires null checking.
2020-05-09 21:38:50 +01:00
Michael Kuc
a07a0de231
Use newer compiler than C++98.
...
Required for standard library headers.
2020-05-09 21:38:50 +01:00
Michael Kuc
3ca4973ea7
Updated GLEW headers.
...
An attempt to fix headers so outdated they no longer compiled.
2020-05-09 21:38:50 +01:00
Jim Broadus
096203ac88
visualisations: Fix close action
...
Pressing the close button on the window sends a close event, where other methods
of exiting visualization just hide the window. If shown again after close, the
window will be empty. To fix this, handle and reject the close event. Call hide
instead.
2020-05-09 13:28:29 +01:00
Jim Broadus
7e7d271b30
Properly handle removal of top level items in StandardItemIconLoader
...
The rowsAboutToBeRemoved signal from the model provides a parent index, but with
QStandardItemModel, top level items are added to an invisible root item that
doesn't have a valid index. This causes the range check to miss top level items
due to a perceived parent mismatch. When the load completes, it attempts to
access an object that has been deleted.
2020-05-04 10:09:51 +01:00
Jim Broadus
dc4270076d
Change StandardItemIconLoader to require a QStandardItemModel
...
This should be a safe assumption since the loader operates on QStandardItem
objects.
2020-05-04 10:09:51 +01:00
John Maguire
cb64d97050
Don't bother with i386 for focal
2020-04-23 22:02:21 +01:00
John Maguire
42b2cd6945
Add focal builds
2020-04-23 22:02:21 +01:00
John Maguire
b007e54b3d
Add liblastfm for windows
2020-04-23 01:18:32 +01:00
Jim Broadus
0ecb773355
Handle lyrics tag for mp4
...
Translation table in mp4tag.cpp for reference.
2020-04-19 14:01:25 +01:00
Jim Broadus
509c65ced7
tagreader: Add debug handler for taglib
...
Pass taglib debug messages through qLog instead of printing directly to stderr.
2020-04-19 14:00:35 +01:00
John Maguire
934fd336da
Install liblastfm for mac
2020-04-17 13:02:26 +01:00
Pierre Langlois
6285c11bc3
Fix tranlations test.
...
"Library" is translated to "Fonoteca" since
1504d8be1c4906ac4767da6a20a0c32754b3a0fe so we can adapt the test.
2020-04-17 11:42:03 +01:00
John Maguire
b0c92ae784
Install windows style plugin
...
Fixes #6523
2020-04-12 22:00:45 +01:00
John Maguire
ae1a99d90c
Copy windows styles plugin
2020-04-12 22:00:45 +01:00
John Maguire
539e7d7e22
Update README.md
2020-04-12 21:07:29 +01:00
John Maguire
c82ff30b43
Update README.md
2020-04-12 21:06:57 +01:00
Sophie Tauchert
ef3021dff2
Add tasks back in using ScopedTask
2020-04-12 21:03:18 +01:00
Sophie Tauchert
38a5d183c2
Cache SubsonicService in SubsonicDynamicPlaylist
2020-04-12 21:03:18 +01:00
Sophie Tauchert
69801a9e2a
Print error on default dynamic playlist type
2020-04-12 21:03:18 +01:00
Sophie Tauchert
af28ad31f1
Remove boost references
2020-04-12 21:03:18 +01:00
Sophie Tauchert
665f7af929
Be more forgiving when fetching albums/songs
2020-04-12 21:03:18 +01:00
Sophie Tauchert
8964c8131f
Add dynamic playlist for random songs
2020-04-12 21:03:18 +01:00
John Maguire
176b1d6c7f
Only build release tags as releases
2020-04-11 20:16:41 +01:00
John Maguire
ca6f42fae1
Fix Fedora version for semver
2020-04-11 20:05:07 +01:00
John Maguire
83f38f8df4
Bump to RC2
...
This might fix Fedora builds
2020-04-11 18:30:40 +01:00
Sophie Tauchert
1d582ba158
Fix songs in dynamic subsonic playlist
2020-04-09 13:49:21 +01:00
John Maguire
06ba555492
Create github prereleases from master
2020-04-02 22:58:35 +01:00
John Maguire
d13e0b79d4
Try pushing master builds to github as drafts
2020-04-02 22:05:09 +01:00
Jim Broadus
72ac3cb88c
OSDPretty: Check return of current_screen in showEvent
2020-03-30 10:55:54 +01:00
Jim Broadus
33ffb4973a
OSDPretty: Fall back to primary screen
...
If current screen can't be find, use primary screen. This the
current behavior when used with older qt versions.
2020-03-30 10:55:54 +01:00
Jim Broadus
8706a39559
OSDPretty: Consolidate current_screen code in OSDPretty
2020-03-30 10:55:54 +01:00
Jim Broadus
a22af31e6e
Add a common LibraryBackend::Init method.
...
Most users of LibraryBackend pass empty strings for directory and subdirectory
tables, so add a second Init method that omits those.
2020-03-24 14:10:43 +00:00
Jim Broadus
52337bf7a4
Use legacy RedirectPolicyAttribute instead of FollowRedirectsAttribute.
...
RedirectPolicyAttribute was introduced in Qt 5.9, but Debian Stretch is at 5.7.
This change can be reverted when the base support version moves to 5.9.
2020-03-23 18:45:25 +00:00
Jim Broadus
a85b3531c3
Handle redirects when downloading Spotify blob.
...
Use the NoLessSafeRedirectPolicy policy which will redirect as long as it isn't
from https to http.
2020-03-23 09:58:15 +00:00
Jim Broadus
94eb2dcfc1
Preserve auth headers when redirecting.
...
When redirecting, copy the original request, which may include extra headers.
2020-03-13 10:38:47 +00:00
Jim Broadus
8e6d09d445
Handle google drive token.
...
Use LoadResult auth header mechanism to pass auth token to pipeline as a header
instead of obsolete query string method.
2020-03-12 18:08:14 +00:00
Jim Broadus
e338939c8b
Add optional auth info to LoadResult.
...
Add auth_header_ to LoadResult. If it exists, populate the MediaPlaybackRequests
headers with an Authorization header with that value.
2020-03-12 18:08:14 +00:00
Jim Broadus
3c7b509d59
Add headers to MediaPlaybackRequest.
...
Add a name/value map for headers to MediaPlaybackRequest. When adding a new
gst source that accepts extra-headers (souphttpsrc), add these headers.
2020-03-12 18:08:14 +00:00
Jim Broadus
9ed5503ee3
Add MediaPlaybackRequest class.
...
Add a class to wrap the URL in the playback engines. In the future, this will
contain authentication information for the specified URL. It can also include
the start and end time as well as other data that is currently specified along
with the URL.
2020-03-11 10:57:21 +00:00
Jim Broadus
2c1ae986c5
Create a GstEngine::IsCurrentPipeline helper function for callbacks.
2020-03-09 10:21:07 +00:00
Jim Broadus
902522f4d3
Fix Qt generated log messages.
...
To avoid infinite recursion, Qt prevents a log generated from an installed
message handler from being handled by that same handler. So when a Qt message
is handled, the logging magic (__logging_message__) that is added by
CreateLogger, and is expected to be detected and stripped by the handler, is
instead dumped to the log.
Instead of sending the Qt messages back through the logging system, use a new
BufferedDebug to build the log message in a buffer, then immeiately print the
buffer to stderr.
2020-03-07 02:41:56 +00:00
Jim Broadus
09723d516c
Use a template for CreateLogger to allow different QDebug derivatives.
2020-03-07 02:41:56 +00:00
Power Snail
4fe845c2c5
Use reference on a const loop var to avoid copy
...
Clang 10 warns that ``s`` might be copied. Use a reference to avoid copying
2020-03-07 02:39:13 +00:00
Jonas Kvinge
b762987cd6
Add missing mapToSource() in MainWindow::PlaylistRightClick
2020-03-06 11:10:02 +00:00
Jim Broadus
79ac16afeb
Move unneeded declarations and macros from logging header.
...
Some functions and macros aren't used outside of logging.cpp and don't need be
declared in header. Functions can be static.
2020-03-06 11:09:20 +00:00
Jim Broadus
90cf4988ea
Fix crash when searching playlist.
...
While iterating over expandList in refreshExpanded, calls to setExpanded cause
the list to be appended. Since QList uses an array implementation that must
reallocate when reserved space is exhausted, iterators are unsafe for this case.
Use indexes, which are O(1) in QLists, instead of iterators.
2020-02-24 13:45:42 +00:00
