Commit Graph

1150 Commits

Author SHA1 Message Date
Domenico Iezzi 3b51f80fa3 Small improvements to Cover Manager (#5645)
* nocover icon was previously loaded and used with the default size
(24x24), causing the list item without a cover in the QListWidget to be
shorter in height with respect to the others. Now the icon is
initialized to 120x120, which is the default size of the list elements.
* Added some padding between "Fetch Missing Cover" and "Export
Covers" buttons.
2017-03-03 11:49:47 +00:00
Florian Bigard 69b2a832db Merge branch 'master' into qt5 2017-01-18 15:57:07 +01:00
John Maguire becb0b3d7f Remove some stray vkontakte code 2017-01-11 18:51:12 +00:00
John Maguire c7b8aacad8 Remove support for VK
Fixes #5591
2017-01-11 18:08:43 +00:00
Pavel Vatagin b52c99755d Fix windows7thumbbar.cpp and osdpretty.cpp (#5588)
* fix problem with toWinHICON() in Qt5

* fix Windows (Qt5) build (conversion to HWND)
2017-01-09 20:11:27 +00:00
Marko Hauptvogel 57d00394ee Bugfix for resume playback on start
This fixes issue #5365.

Because of the asynchronous loading of playlists introduced by
09e83935, the resume playback on startup logic finds the active
playlist as empty, because it is not restored yet. By attaching
the playback resume to the RestoreFinish signal, the playback
will be triggered as soon as the playlist is restored. It may be
possible (but unlikely) that the playlist will already be restored
before we wait for the signal, and playback won't be resumed.

Signed-off-by: Marko Hauptvogel <marko.hauptvogel@googlemail.com>
2017-01-05 17:09:57 +00:00
Santiago Gil d3898d2f47 Add dialog to display streams' audio details (#5547)
* Add Stream Details window

* Fix capitalization in StreamDiscoverer::Discover()

* StreamDiscoverer::Discover(): get URL by const reference

* Refactor StreamDiscoverer::Discover

* Rename StreamDiscoverer callbacks

* StreamDiscoverer::OnDiscovered: fix nullptr comparison

* StreamDiscoverer: rename DiscoverFinished signal

* StreamDiscoverer::DataReady: receive const reference

* StreamDiscoverer: Remove unsigned types

* StreamDetailsDialog: rename Close slot

* StreamDetailsDialog: rename ui pointer to ui_

* MainWindow::ShowStreamDetails: receive a const reference

* StreamDetailsDialog: use unique_ptr, remove unsigned types
2016-12-21 16:57:04 +00:00
Chocobozzz 18a89f78a9 Merge remote-tracking branch 'upstream/master' into qt5 2016-10-07 14:30:09 +02:00
Santiago Gil 8da53abcfa Add option to show/hide sidebar (#5459) 2016-09-06 07:28:25 -05:00
Ilya Selyuminov 09b0fab87c Add new command line option for creating a new one playlist #5373 (#5468) 2016-08-26 08:59:11 -05:00
Santiago Gil 3d399cec8c Restructure edittagdialog layout (corrects #5437) (#5450) 2016-07-25 11:45:57 +01:00
Mattias Andersson 0b6d531bd3 Focus the library tab when using the 'Show in library' feature 2016-07-01 11:37:04 +02:00
Yan Pashkovsky a879b8c7fd make format 2016-06-01 21:58:35 +03:00
Yan Pashkovsky a9a616863d Scrolling over tray icon support 2016-05-30 02:12:03 +03:00
John Maguire 0beb6d3c59 Remove support for Amazon Cloud Drive. 2016-05-16 18:00:10 +01:00
Chocobozzz 0aa3405274 Merge remote-tracking branch 'upstream/master' into qt5 2016-05-09 12:46:08 +02:00
Alex 11670e1760 Fix playlist behaviour (#5330)
* Do not restore playback state on application start if overwritten by command line options

This also fixes unwanted pausing if a new instance is started with commandline URL combined with playback restore.
Note that the actual buggy code (MainWindow::ResumePlayback()) is not fixed here.

* Fix for commandline URLs for new instances are always appended to playlist.
2016-04-12 15:53:43 +01:00
Ivan Leontiev 75d4731534 Move global search settings loading later in "MainWindow" initialisation
Fixes #5312.
2016-03-30 04:58:47 +03:00
Chocobozzz 4898d20ce2 Merge remote-tracking branch 'upstream/master' into qt5 2016-03-28 11:38:22 +02:00
René Tronsgaard Rasmussen 8e70046e4b Add -q,--stop-after-current commandline flag 2016-03-18 20:21:34 +01:00
Chocobozzz e6e189967d Merge remote-tracking branch 'upstream/master' into qt5 2016-02-29 18:03:02 +01:00
John Maguire dcdd81d69f Moar Lazy migrations 2016-02-12 16:10:56 +00:00
John Maguire b99b090adc Refactor simple dialogs to use Lazy 2016-02-12 16:01:35 +00:00
John Maguire 74e6a1744f Convert edit tag & settings dialog to Lazy. 2016-02-12 15:56:08 +00:00
John Maguire 589f2ff62e Lazy initialise organise dialog 2016-02-12 12:25:35 +00:00
John Maguire 729dc8e281 Merge pull request #5182 from abika/fix-fetch_edit_dialog
Fix bug in edit tag dialog when fetching (2)
2016-02-11 15:30:51 +00:00
John Maguire f2daa772c1 Lazy initialise everything in Application. 2016-02-11 15:15:38 +00:00
Alexander Bikadorov 56e95839f0 Revert to iterator usage in edit tag dialog 2016-02-11 16:09:38 +01:00
John Maguire 6844dcc140 Remove unused variable 2016-02-11 14:19:01 +00:00
narunlifescience b6bf54be6c remove magic numbers 2016-02-11 04:41:37 -06:00
Alexander Bikadorov 9d413ad01d Edit tag dialog: merged duplicate code 2016-02-09 21:56:22 +01:00
Arun Narayanankutty 29b8d308b3 Use icon loader for remaining icons 2016-01-14 06:10:54 -06:00
John Maguire c9b0bb2044 Revert "Add an option to inhibit suspend while playing" 2016-01-08 15:09:07 +00:00
John Maguire a9b5947fb0 Merge pull request #5150 from narunlifescience/master
Add an option to inhibit suspend while playing
2016-01-07 18:32:29 +00:00
Alexander Bikadorov ff86ecddc5 Update modified fields boldness when fetching tags 2016-01-04 18:56:28 +01:00
Alexander Bikadorov bad9e4af5e Fix for erasing old tag values when using tag fetcher, replacement for #51311 2016-01-04 17:13:37 +01:00
Santi 98b042d29c Disable translation of shortcuts 2015-12-22 18:33:07 -03:00
narunlifescience 16707f0934 move member variables only used by dbusidlehandler.cpp to anonymous namespace 2015-12-22 10:03:57 -06:00
Chocobozzz 5675091816 Add error message if editing tag from playlist fails 2015-12-20 19:07:15 +01:00
Chocobozzz ff7026c9fe Merge remote-tracking branch 'upstream/master' into qt5 2015-12-13 20:05:12 +01:00
narunlifescience 9f121f4a9d move dbus names to unique namespace -> dbusidlehandler.cc & other minor updates
fix InhibitwhilePlaying signals
2015-12-11 08:49:12 -06:00
narunlifescience b13f0690c8 Add an option to inhibit suspend while playing
minor modifications
2015-12-10 03:20:29 -06:00
narunlifescience 2603cf2088 use iconloader & cleanup previous remnants
update
2015-12-01 00:32:20 -06:00
John Maguire f300946c81 Remove most usages of QFutureWatcher 2015-11-27 14:28:12 +00:00
John Maguire 3cc9c1e446 Remove ModelFutureWatcher 2015-11-26 19:02:08 +00:00
Mark Furneaux fa0a9d315c Respawn mainwindow on correct monitor
PR #5081 created a regression where the mainwindow will always start on the primary monitor regardless of which one it was closed on when maximized. This restores previous functionality.
2015-11-22 00:35:27 -05:00
narunlifescience 5f580f1dd9 add volume icon label to background stream settings page 2015-11-12 03:16:00 -06:00
narunlifescience e2c4b1567c seek time step label
height
2015-11-09 19:51:58 -06:00
John Maguire a7ae275153 Merge pull request #5094 from terrorfisch/issue-3355
Fix 3355: Tag fetcher now ignores songs without any results
2015-11-02 13:02:46 +00:00
John Maguire f92e88e321 Add support for inhibiting the screensaver on windows. 2015-10-30 16:45:51 +00:00
terrorfisch f49ae2f792 Add new line at the end. 2015-10-30 15:17:23 +01:00
terrorfisch a51baefde6 Resolve formatting issues. 2015-10-30 15:13:26 +01:00
terrorfisch c75f046c10 FIX: Tag fetcher applies incorrect tags for songs without any results
Before this fix the fetched data of the first title was applied to all selected titles. If the other titles hat correctly fetched tags, this information was overridden by the correct data. So the error only occured in case of failure during fetching.
2015-10-30 12:44:12 +01:00
narunlifescience 6a11ac6162 remember normal window state when user closes clementine in maximized state 2015-10-20 04:44:42 -05:00
John Maguire 5984c881c6 C++11 initialization list doesn't compile on mac 2015-10-14 14:09:41 +01:00
narunlifescience dd953fd86c check custom icon location, then system theme & then fallback theme
icons added & replaced
2015-10-13 22:35:49 -05:00
Chocobozzz f5cd85c6de Fix the command line options when another instance is running 2015-10-12 14:07:10 +02:00
Ethan Warth 262ea27ec0 consolidated the options for double clicking a playlist
see https://github.com/clementine-player/Clementine/pull/4991#issuecomment-140082879
2015-09-25 22:39:21 -05:00
Chocobozzz 631a6cdabd Merge branch 'master' into qt5 2015-09-16 17:40:54 +02:00
Ethan Warth 1df1260c6a fixing default settings for double clicking a playlist (oops) 2015-09-01 22:41:17 -05:00
Ethan Warth 40d985c7f9 performed a make format 2015-08-14 15:48:01 -05:00
Ethan Warth 2356a9b591 Merge branch 'master' into double_click_playlist
this will allow the make format to happen without causing a merge conflict
2015-08-14 15:45:01 -05:00
Ivan Leontiev e85424cdd7 Fix time labels blinking when playing streams without known duration 2015-08-10 12:01:42 +00:00
Ethan Warth a85f2e3076 fixed the miscellaneous bugs; time for a pull request! 2015-08-10 02:43:45 -05:00
Ethan Warth a7a83b3953 double clicking playlist options should now be implmented
the code compiles; runtime testing will follow
2015-08-09 22:43:16 -05:00
Ethan Warth 89e0e283a2 did more double click playlist work, prettified variable names 2015-07-22 02:10:04 -05:00
Arnaud Bienner a56825048c Use lower case, like everywhere else on this page: this is more coherent, and also, we then have only one string to translate 2015-07-21 20:21:01 +02:00
Ethan Warth 20d25090fb work on adding UI options for double clicking songs in playlist 2015-07-21 02:41:49 -05:00
Eduardo Sánchez Muñoz c051506fdd Fix "menu_previousmode" setting not loading when opening the settings window. 2015-07-15 18:46:18 +02:00
John Maguire bce62a0558 Merge pull request #4938 from eduardosm/esm-branch1
Add option to change the time step when seeking using the keyboard.
2015-07-15 13:42:24 +01:00
Mark Furneaux e9494af3f7 Add sample rate selection
This change provides the ability to set a fixed pipeline sample rate as an alternate to automatically negotiating it.
This can be useful on systems with sound cards that work at a fixed rate, as well as it can triage issues (on Windows)
where changing tracks hangs due to a problem with gstreamer's caps negotiation.
2015-07-09 22:19:31 -04:00
Eduardo Sánchez Muñoz 75e94a64d1 Add option to change the time step when seeking using the keyboard. 2015-07-03 20:54:17 +02:00
Eduardo Sánchez Muñoz 11b61c2a67 Use Player::SeekForward() and Player::SeekBackward() to handle seeking with arrow keys. 2015-07-02 14:59:30 +02:00
Eduardo Sánchez Muñoz e0816800b1 Add support for original year tags. 2015-06-30 18:34:34 +02:00
John Maguire 1323af5025 Merge pull request #4910 from Chocobozzz/global_shortcut
Add love/ban (lastfm) global shortcuts
2015-06-17 09:49:19 -04:00
Chocobozzz 7b8552ab6d Add love/ban (lastfm) global shortcuts 2015-06-17 14:21:24 +02:00
Mark Furneaux f4b7c22bc2 Revert "Revert "Add track intro mode""
This reverts commit ece262f7f4.
2015-06-15 16:27:40 -04:00
John Maguire ece262f7f4 Revert "Add track intro mode" 2015-06-15 15:49:08 -04:00
Mark Furneaux b57cebbf2d Add track intro mode
This repeat mode plays the beginning of each track, good for quickly getting a feel for a new album for example.
2015-06-14 13:32:58 -04:00
Martin Babutzka 0b16dad50f - Fixed decoding of non-ASCII lyric texts
- Lyrics can now be viewed/edited in the metadata-editor

Squashed commit of the following:

commit 0851f619c27348e3ceeaf31a8edc3a567ccee99c
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Wed Jun 10 21:21:50 2015 +0200

    'make format' and brackets in a condition clause.

commit bab7a1d07af3bc53034e3883d352ae6d4dd33e2a
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Sun Jun 7 01:51:31 2015 +0200

    Added capability to SAVE lyrics frames to mp3 files in tagreader.
    Improved scaling properties of edittags dialog.

commit 4bd71a2d6a4479a664bf8b5b3ead05c23c86e15d
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Sat Jun 6 23:33:22 2015 +0200

    Updated lyrics tag buddy to lyrics

commit 2ceb8967f67e76a0f78b25a7a128c4429a93bcd9
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Sun May 17 18:52:33 2015 +0200

    Add lyrics field to tag editor

commit 04b65e33a83e449055659a72a283954311a12fb7
Author: Martin Babutzka <martin.babutzka@online.de>
Date:   Fri May 8 23:24:02 2015 +0200

    Using decode method to fix non-ASCII letters.
2015-06-10 21:23:40 +02:00
Chocobozzz 5d343cbe7f remove useless qt_version defines 2015-06-03 23:13:06 +02:00
Chocobozzz 5aec1c0e24 Merge remote-tracking branch 'upstream/master' into qt5
Update qt version to 5.4.2
2015-06-03 22:57:58 +02:00
Chocobozzz bd2afec107 Fix warning message in behavioursettingspage ui page 2015-06-03 12:27:27 +02:00
Chocobozzz 10de0d8f74 Fix save state when the song was paused 2015-06-02 18:11:58 +02:00
Mark Furneaux b6aa92450e Scale cover art to the current monitor, not the entire virtual screen 2015-05-21 17:47:58 -04:00
Mark Furneaux 361b2420f9 I just remembered we have an about box
Am I worthy? I know it's only been a year, but it would mean a lot to me.
I completely understand otherwise.
I also bumped the height up a tad so that no text gets cut off due to the extra line.
2015-05-18 14:13:32 -04:00
John Maguire e1ea116bfb Remove Grooveshark support.
Well that was nice while it lasted.
2015-05-01 11:57:59 +01:00
Chocobozzz e986ab5a4b Merge master branch and adapt it to qt5 2015-04-16 17:16:34 +02:00
Chocobozzz 4d0e413fb9 Finally use of qtsingleapplication adapted to qt5 2015-04-16 15:06:00 +02:00
Chocobozzz 42aafd247a Update optional components to qt5 2015-04-15 18:26:09 +02:00
Chocobozzz 8b226c2171 Update non optionnals sources to qt5 2015-04-11 23:24:07 +02:00
Martin Babutzka 258ae281d8 IDv3 tag lyrics support.
Squashed the following commits:

5c723ad commit: Fix: Includes alpha sort
15ac350 commit: Fix: Updated Database::kSchemaVersion to 49.
767a26a commit: Fixed small code style issue. Added schema-49 to data.qrc instead schema-48
bf6aa64 commit: fixup! Modified async handling of CollapsibleInfoPane as recommended by Andreas. Display of IDv2 tag lyrics works now.
c1f97e9 commit: fixup! Added support to read/display the ID tag lyrics in MP3 files:
c946b1d commit: Added support to read/display the ID tag lyrics in MP3 files:

-Added schema to the database to store it
-Added readers/writers for ID tags
-Added readers/writers for the database to the song class
-Added the taglyricsinfoprovider to show the lyrics in songinfo
2015-04-10 21:05:07 +02:00
Arnaud Bienner ccf5bffd99 Oops, this should just be a comment (remove warning) 2015-03-30 18:34:45 +02:00
Arnaud Bienner 9877ac49fa Use Alt+Tab to switch between playlist tabs on OS X, as Cmd+Tab is already used by default for switching applications 2015-03-28 17:18:22 +01:00
John Maguire 8d3fd00956 Amazon Cloud Drive support.
Squashed commit of the following:

commit 451a327fabb5f9aba077d93a33d75d8a6a288f5f
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:55:36 2015 +0100

    Revert debug console changes.

commit 52f643c3dc524a837f56268b6da4881187204165
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:49:28 2015 +0100

    Revert extra logging

commit 23645f9fea
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:47:55 2015 +0100

    How did you get there

commit 8153388f19
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:45:12 2015 +0100

    Update copyright headers.

commit fa9e279259
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:43:27 2015 +0100

    Remove logging

commit 47a405543c
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:42:05 2015 +0100

    Show login state correctly for Amazon.

commit 748d88d993
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:28:55 2015 +0100

    Ensure Amazon is connected before serving URLs.

commit 25ec9c65f4
Author: John Maguire <john.maguire@gmail.com>
Date:   Fri Mar 27 14:22:28 2015 +0100

    Refresh Amazon authorisation & follow changes.

commit 27c1a37173
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 18:27:27 2015 +0100

    Revert unneeded OAuthenticator change.

commit 3594af5be1
Author: John Maguire <john.maguire@gmail.com>
Date:   Thu Mar 26 16:52:19 2015 +0100

    Initial support for Amazon Cloud Drive.
2015-03-27 14:56:08 +01:00
Mattias Andersson 7d0d7be568 Some ui changes to the ripcd dialog.
- Move the Rip audio CD menu item to the Tools menu.

- Hide the progress bar if the CD ripper isn't working when the CD ripping
dialog is shown.
2015-02-18 20:08:02 +01:00
Mattias Andersson fc2e4db229 Split the CD ripper into two classes
Separate the cd ripper dialog from the ripper itself.
2015-02-18 20:08:02 +01:00
Mattias Andersson eb8a618197 Move the CD ripper into its own directory. 2015-02-18 20:08:02 +01:00
John Maguire fb2b91c874 Remove some more obsolete os x version checks. 2015-02-18 18:03:46 +01:00
Devyn Collier Johnson b63d1fb661 Update equalizer.cpp
I added more presets for additional generas
2015-02-15 09:32:30 -05:00
Arnaud Bienner 43768d4af8 Small modifications to previous pull request:
- remove reference to iPod, as this is not iPod specific IMO
- make comment clearer
2015-01-19 15:01:33 +01:00
ArnaudBienner 29bcd2e15c Merge pull request #4692 from asiviero/previous_restart
Added iPod-like behavior to previous button (closes #4638)
2015-01-19 14:56:40 +01:00
John Maguire 87fed5d0f4 Merge pull request #4715 from Chocobozzz/albumartist_flac
Fix album artist for FLAC/OGG files (with vorbis comments)
2015-01-19 10:57:31 +01:00
Chocobozzz b96c1f060f Add tests to check the tag edition of FLAC/OGG files and make format 2015-01-17 12:11:33 +01:00
Chocobozzz 2a7d4e6d5e Improve edit tag when set values 2015-01-17 11:31:02 +01:00
John Maguire 66ac5fa1d7 Show simplified & traditional chinese properly. 2015-01-08 17:22:00 +01:00
John Maguire 08449c76c3 Show sr@latin correctly in the language selector 2015-01-08 17:10:00 +01:00
Andre Siviero e4df00050d Includes in alphabetical order, moved Player ReloadSettings() to Player init 2015-01-08 01:10:35 -02:00
Andre Siviero 1120f97844 Added iPod-like behavior to previous button 2015-01-06 02:36:08 -02:00
Krzysztof Sobiecki fa9ea6ec5f Fix compilation with moved files in internet/ 2014-12-18 23:35:21 +01:00
Andreas ff172f6ed4 Network remote can now transcode lossless files before sending them to the remote.
- It is configurable in the settings.
- Any format can be chosen that is supported by the transcoder.
- The status of the transcoder is send to the remote.

- Transcoder format settings have now a postfix so we can define mutliple transcoder formats and use them separatly. Here one for the normal transcoder and one for the network remote transcode. You can pass the postfix in the constructor.
- Fixed Transcoder crash (was introduced with the gstreamer1.0 merge, decodebin doesn't have a "new-decoded-pad").
- Transcoder emits the output filename as well on "JobComplete" signal
- Transcoder can now convert a file to a temporary file ("AddTemporaryJob")
2014-11-13 22:31:49 +01:00
Krzysztof Sobiecki 978a91442c Connect signal to signal 2014-11-05 17:35:14 +01:00
Krzysztof Sobiecki 5045f9b870 Don't use caller in OrganiseDialog 2014-11-05 02:37:44 +01:00
Krzysztof Sobiecki b89c05048a Move connect out of emitter 2014-11-05 00:42:56 +01:00
Krzysztof Sobiecki 578c9ad598 Ability to automatically set podcast as listened after sucesfully sending it to a device 2014-11-05 00:42:55 +01:00
John Maguire 4f4c8f6894 Merge pull request #4580 from Chocobozzz/hide_internet_services
Hide internet services
2014-10-31 12:02:29 +01:00
Arnaud Bienner a8266173c5 Start to reactivate audio CD support 2014-10-26 00:28:03 +02:00
Chocobozzz 50b7b7d889 Make format after update to avoid conflicts 2014-10-15 21:57:57 +02:00
Chocobozzz 8279f21251 Revert "Make format"
This reverts commit 17b1e9fbe6.
2014-10-15 21:55:03 +02:00
Chocobozzz 17b1e9fbe6 Make format 2014-10-15 20:55:24 +02:00
Chocobozzz c54d1baf15 Allow user to hide internet services. Closes #2784 2014-10-15 20:44:09 +02:00
Arnaud Bienner 78804b12c6 Use a save dialog option instead of quick change menu.
This is less confusing IMO. The dialog will shown up only if users decided to in the preferences, so that will not bother users who don't need this.
This reuses lot of things from Alan contribution from #4484
2014-10-07 00:29:46 +02:00
Arnaud Bienner f6e6d3b937 Revert "Finished the changes to the quick change menu. Everything should work."
This reverts commit a468085c3a.

Conflicts:
	src/playlist/playlistcontainer.cpp
	src/playlist/playlistcontainer.h
	src/ui/behavioursettingspage.cpp
2014-10-07 00:29:46 +02:00
Arnaud Bienner f7d2dd94f9 Revert "Add a quick change menu to the playlist container."
This reverts commit 1cddc696ae.

Conflicts:
	src/ui/behavioursettingspage.ui
2014-10-07 00:29:46 +02:00
David Sansome a2408f7c0e Merge branch 'master' into gstreamer-1.2
Conflicts:
	src/moodbar/moodbarloader.cpp
2014-09-21 19:39:27 +10:00
David Sansome 6b32ecec27 Various bits for gstreamer-1.0 compatability 2014-09-21 19:38:13 +10:00
Andreas 38c51508f2 Added a preference to disable the pause notification. Fixes #2450. 2014-09-16 12:54:35 +02:00
ppkt 43a6740b48 Remove unavailable items from playlist 2014-08-24 10:44:27 +02:00
Gavin Howard eb953bdef2 Changed UI messages per Arnaud Bienner's suggestions. 2014-08-20 00:30:49 -06:00
Gavin Howard f41bebbeb2 Ran 'make format' on my patch. 2014-08-18 09:56:01 -06:00
Gavin Howard d8ba0c4f91 Minor changes requested by hatstand. 2014-08-18 08:08:14 -06:00
Gavin Howard a468085c3a Finished the changes to the quick change menu. Everything should work. 2014-08-15 18:52:01 -06:00
Gavin Howard 1cddc696ae Add a quick change menu to the playlist container. 2014-08-15 15:37:31 -06:00
Gavin Howard e8d3aa9254 Slight change to the QSettings keys for playlist paths and metadata. 2014-08-13 22:47:26 -06:00
Gavin Howard 5b7819f14d Added UI and QSettings support for playlist metadata and path types. 2014-08-13 22:47:25 -06:00
Arnaud Bienner 80009ea260 Add a tooltip to this new option. IMO the text description might be not obvious enough to everyone 2014-06-24 21:42:34 +02:00
Gu1 62ecfe19f7 Add an option to disable inline song metadata editing through click 2014-06-23 18:40:00 +02:00
David Sansome 6bb81328e8 Merge branch 'master' into gstreamer-1.2
Conflicts:
	ext/clementine-spotifyblob/mediapipeline.cpp
	gst/moodbar/gstfftwspectrum.c
	src/core/songloader.cpp
	src/core/songloader.h
	src/engines/gstengine.cpp
	src/engines/gstenginepipeline.cpp
	src/moodbar/moodbarpipeline.cpp
	src/musicbrainz/chromaprinter.cpp
	src/transcoder/transcoder.cpp
	src/ui/mainwindow.cpp
	src/visualisations/projectmvisualisation.cpp
2014-06-09 16:20:24 +10:00
David Sansome bfc941bb7f Use a better colour for labels in the edit tag dialog on dark themes. Fixes #4377 2014-06-07 12:48:32 +10:00
John Maguire 96ad4554d9 Merge pull request #4392 from Chocobozzz/master
Add Seafile Support
2014-06-05 16:50:45 +02:00
Chocobozzz 1fc95cb7ed Add Seafile Support 2014-06-03 14:33:07 +02:00
Narfinger fd7daf2839 deleting track/disc/year in the spinbox should correct to the nearest
value and not to the last digit
2014-06-02 22:38:42 +02:00
David Sansome 162b2efbb0 If we don't know the length of a song from the metadata, get it from the pipeline which has the real length. Fixes #2818 when the length isn't in the podcast metadata. 2014-05-29 21:33:53 +10:00
David Sansome 453a012f21 Make it impossible to collapse either side of the MainWindow splitter. Fixes #4384 2014-05-29 20:43:43 +10:00
David Sansome 5f05353939 Change Name to Action in the Configure Shortcuts settings page. Fixes #4310 2014-05-24 13:29:46 +10:00
Mattias Andersson 4569bd9f2f Check for error when getting the number of cd tracks. Build an empty
track list table if this is the case.
2014-05-22 07:51:08 +02:00
Mattias Andersson 0c76ca3c45 Don't start ripping unless the user has selected some tracks. 2014-05-21 18:07:48 +02:00
John Maguire 7702271fe6 Merge pull request #4344 from paperbagcorner/fix-tagging
Improve the tagging and the track information handling in the CD ripper
2014-05-21 15:46:00 +01:00
Mattias Andersson 8bb19f1887 Save tags using async calls. 2014-05-21 16:36:46 +02:00
Mark Furneaux 805d8f85b0 Add icons to extras: hypnotoad, kittens, enterprise
Fixes totally critical bug #1601
2014-05-21 07:26:16 -04:00
Mark Furneaux bd87230301 Change constant format 2014-05-20 07:44:30 -04:00
Mark Furneaux 7fb30f2596 Add constants to track progress timers 2014-05-20 07:29:59 -04:00
Mark Furneaux b76af5f792 Increase update rate of track slider
Increases the refresh rate of the track progress bar to 25fps.
This looks much better with moodbars than the previous 1fps.
All the common code that use to run at 1fps still retains that
rate so the overhead due to this is negligible.
2014-05-19 11:51:40 -04:00
Mattias Andersson 7d4343a826 Give functions a more verbose name. 2014-05-18 14:39:21 +02:00
Mattias Andersson 2137ac4709 Keep working until tagging is complete. 2014-05-18 14:24:46 +02:00
Mattias Andersson 182c90ccf4 Run RipCD::TagFiles in a background thread. 2014-05-13 15:18:42 +02:00
Mattias Andersson 467a1443e4 Capture log messages from the transcoder. 2014-05-12 23:58:51 +02:00
Mattias Andersson 98fd82a371 Use the TagReaderClient to tag the files in the CD ripper instead of
using Taglib directly.
2014-05-12 23:57:11 +02:00
Mattias Andersson bbd83344b8 Initialise cancel_requested_ to false in the constructor's initialisation list. 2014-05-12 17:40:41 +02:00
Mattias Andersson 08f5af3320 Give the mutex lockers a tighter scope. 2014-05-12 17:24:35 +02:00
Mattias Andersson 919f7cbe94 Add a mutex to protect a variable shared between threads. 2014-05-12 16:14:33 +02:00
Mattias Andersson 6235e69ac4 Run 'make format' 2014-05-12 14:38:46 +02:00
Mattias Andersson be09f6e5c7 Merge branch 'master' into ripcd-cancel
Conflicts:
	src/ui/ripcd.cpp
2014-05-12 13:50:34 +02:00
John Maguire 5fe468456a Merge pull request #4171 from asiviero/master
Addressing #4165 and #4166
2014-05-12 13:20:26 +02:00
David Sansome 18f72f3ada Capture this lambda argument by value, since it's a local variable and won't be valid when the outer function exits. 2014-05-11 19:24:22 +10:00
asiviero d448ac1179 Replaced scoped_ptr by unique_ptr 2014-05-10 00:41:32 -03:00
Mark Furneaux 394d8e7b51 Add support for monitors in portrait mode
Album covers bound to width or height, whichever is smaller
2014-05-03 09:54:19 -04:00
Mark Furneaux 9156f8f389 Fix oversized album cover art
When viewing the "Full Size" album covers, if the cover was higher in
resolution than that of the monitor, it would get cut off. Also,
the window was resizable however the image was not. This patch makes
the dialog a fixed size and resizes the cover only if it is too large to
fit on the screen. It also now displays the dimentions of the original
artwork in the title bar.
2014-05-01 12:26:48 -04:00
asiviero 4b7c3a2f8c Using scoped ptr to ripcd window, removing extra parenthesis again 2014-04-29 23:12:18 -03:00
John Maguire b3ef8b0fe0 Try out actually using lambdas for something useful. 2014-04-23 18:05:59 +02:00
David Sansome c7459b1b28 Load songs in a background thread while initialising the Organise dialog 2014-04-23 21:46:05 +10:00
David Sansome 98a328cf97 Switch from foreach to for 2014-04-23 21:13:58 +10:00
David Sansome 25ee987ec7 Recursively add songs in subdirectories to the organise dialog. Broken in revision 35060d6. 2014-04-23 21:06:23 +10:00
Andre Siviero af34bf6062 Removing extra parenthesis 2014-04-16 11:07:50 -03:00
Mattias Andersson 773c3475ba Remove unnecessary string conversion. 2014-04-15 14:47:26 +02:00
Mattias Andersson 44025dc588 Add a call to cdio_get_media_changed in RipCD::CheckCDIOIsValid
This prevents an erroneous message that the media has changed the first
time the ripCD dialog is used.
2014-04-13 14:41:04 +02:00
Mattias Andersson 31400f2740 Run 'make format' 2014-04-12 09:20:25 +02:00
Mattias Andersson d66a73bed5 Merge remote-tracking branch 'origin/master' into HEAD
Conflicts:
	src/ui/mainwindow.cpp
	src/ui/ripcd.cpp
2014-04-12 09:08:21 +02:00
SATOH Fumiyasu 9add1ad708 Update Transifex URL 2014-04-11 16:30:57 +09:00
David Sansome 24404b4357 Make the "buffer low fill" string a bit more understandable 2014-04-05 22:03:36 +11:00
John Maguire 51385cc801 Add a different label for the mavericks shortcut settings.
Fixes issue #4002
2014-04-02 16:27:07 +02:00
John Maguire 30d1c2f8db Remove Ubuntu One support.
http://blog.canonical.com/2014/04/02/shutting-down-ubuntu-one-file-services/
2014-04-02 16:02:00 +02:00
Marcus Fritzsch 22c0a79924 gstenginepipeline: Do not use QString::sprintf() 2014-04-02 12:39:19 +02:00
Marcus Fritzsch e3bea84bea gstenginepipeline: make buffer min fill configurable 2014-04-02 11:54:14 +02:00
David Sansome 25544cb672 Sort the list of Internet Providers in the settings dialog and internet tab 2014-03-30 17:11:19 +11:00
David Sansome 9c66528c0f Add a settings page for OneDrive 2014-03-30 16:35:27 +11:00
David Sansome 2d7be1502f Get audio device names on OS X too. 2014-03-29 22:44:08 +11:00
David Sansome 6d1dc56a7c Get a list of available audio devices from pulseaudio, and let the user choose
from those in the settings dialog instead of just giving him a text box.
2014-03-29 19:31:38 +11:00
John Maguire 4ab4bbc23f Remove Last.fm radio support.
Fixes #4259
2014-03-28 14:55:04 +01:00
Arnaud Bienner 1b7f99127d Add login to SoundCloud + get user tracks and activties (stream)
Still need to handle playlists and to clean up things (e.g. to check why refresh_token doesn't work and if we can do something about this)
2014-03-26 21:33:27 +01:00
Maltsev Vlad a7b0accd93 Add Vk.com plugin. 2014-03-08 00:58:50 +07:00
John Maguire 5146bcdebc Some more NULL -> nullptr conversions. 2014-02-21 17:30:46 +01:00
John Maguire b46e9ff55c Seems this should be the other way around. 2014-02-14 15:51:08 +01:00
John Maguire c162a9316d Fix clang warning. 2014-02-14 14:36:47 +01:00
Arnaud Bienner faaa75cb61 Few style fixes + avoid unneeded copies 2014-02-12 22:11:28 +01:00
John Maguire 192b60d965 Use nullptr as parent parameter default everywhere 2014-02-10 16:03:54 +01:00
John Maguire 3323c2d094 Convert all instances of foreach() to a C++11 for
find ext src -name '*.cpp' -exec \
    sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
David Sansome 67f6560c04 Merge pull request #4194 from abika/master
Use double click settings as default behaviour for new files added as command line arguments.  Fixes #4183
2014-02-09 16:51:10 +11:00
Mladen Pejaković f09a0c00a8 More disabmiguations 2014-02-08 16:09:27 +01:00
Mladen Pejaković da535d6429 More disambiguations 2014-02-08 15:11:06 +01:00