341dc7326f
Reformat all C++
2020-09-22 14:56:06 +01:00
d4fab4a2ea
Merge remote-tracking branch 'upstream/master' into qt5-update
2018-11-11 22:46:07 +01:00
107e945872
Convert uses of QtAlgorithms to std:: algorithms
2018-10-09 19:17:54 +01:00
16b4f9a991
Merge remote-tracking branch 'upstream/master' into qt5
2018-05-14 08:25:27 +02:00
804168edc7
Bring back album cover fetching from discogs. ( #6028 )
...
* Bring back cover fetching from discogs.
2018-03-19 14:18:56 +00:00
c9d954f8a3
Fix bug in covermanager not saving album cover to DB. ( #6011 )
...
* Fix bug in covermanager not saving album cover to DB.
2018-03-04 14:13:34 +00:00
62bc647cbc
Roll back to the cache naming conventions for covers ( #5651 )
2017-03-07 11:46:54 +00:00
99ad5dcd2d
Refactor EffectiveAlbumArtistName()
2017-03-06 18:47:34 +00:00
f5bd7ef5c0
ItemHasCover(): Replace pointer with reference
2017-03-06 18:21:27 +00:00
2c643513e2
Refactor icon handling. Make empty-cover filtering work again.
2017-03-06 18:21:27 +00:00
deb7c33c64
Add support for 'album artist' field in the LibraryBackendInterface
2017-03-06 18:21:27 +00:00
58b7c62f25
Make Cover Manager aware of 'album artist' field
2017-03-06 18:21:27 +00:00
3b51f80fa3
Small improvements to Cover Manager ( #5645 )
...
* nocover icon was previously loaded and used with the default size
(24x24), causing the list item without a cover in the QListWidget to be
shorter in height with respect to the others. Now the icon is
initialized to 120x120, which is the default size of the list elements.
* Added some padding between "Fetch Missing Cover" and "Export
Covers" buttons.
2017-03-03 11:49:47 +00:00
b6bf54be6c
remove magic numbers
2016-02-11 04:41:37 -06:00
29b8d308b3
Use icon loader for remaining icons
2016-01-14 06:10:54 -06:00
dd953fd86c
check custom icon location, then system theme & then fallback theme
...
icons added & replaced
2015-10-13 22:35:49 -05:00
3323c2d094
Convert all instances of foreach() to a C++11 for
...
find ext src -name '*.cpp' -exec \
sed -i -e 's/foreach(\([^,]\+\),/for (\1 :/' {} \;
2014-02-10 14:43:32 +01:00
bebd781fdf
Reformat all non-3rd-party C/C++/Objective-C++.
...
Command line:
find src ext -regex '.*\.\(h\|cpp\|mm\)' -exec clang-format -i
-style='{BasedOnStyle: Google, DerivePointerBinding: false}' {} \;
2014-02-07 16:34:20 +01:00
71893e4847
Use nullptr instead of NULL everywhere.
2014-02-06 17:29:59 +01:00
d309d4ab27
Use c++11 instead of boost where possible.
2014-02-06 16:51:39 +01:00
f805c003eb
Show message when there are no covers to export.
2013-05-13 16:09:36 +02:00
4e2ded9178
- Finished album cover exporter from keirangtp's branch "export-covers".
...
- Updated export dialog layout.
- Added option to export downloaded and/or embedded covers.
- Auto. cover fetcher and exporter is now cancelable.
- Minor covermanager layout improvements.
- Covermanager shows count of total and missing covers.
Fixed issue 520.
2013-05-06 21:22:05 +02:00
07abe82ef3
Add a cover manager for the Google Drive library.
2012-10-01 16:39:58 +02:00
6208373b86
Port search field in AlbumCoverManager to QSearchField and add support for placeholder text.
2012-06-28 11:40:05 +02:00
bacef04405
Refactoring: remove a couple of the AlbumCoverLoader instances and instead use a shared CurrentArtLoader.
2012-02-26 14:40:51 +00:00
48f15c9fc7
Refactoring: instead of passing individual pointers to useful core classes (like TaskManager or LibraryBackend) to each class that uses them, pass one singleton-like Application instance everywhere.
2012-02-26 14:40:51 +00:00
7e1b6ef6c4
Use locale aware sorting for the lists of artists and albums in the album cover manager. Fixes issue 1952
2011-08-28 00:25:41 +01:00
38100f5e59
Make CoverProviders not a singleton
2011-07-23 19:34:41 +01:00
7773e98ebf
Keep track of some statistics while searching for album covers, and show a statistics dialog at the end. Fixes issue 1921
2011-06-26 15:07:48 +00:00
f8045af720
Various album cover search changes:
...
- Download several covers and use some heuristics to decide which cover is the best, rather than just taking the first one.
- Timeout album cover downloads after 2.5s
- Show covers properly in the album cover manager if they were manually unset, and then Clementine was restarted.
2011-06-26 15:07:19 +00:00
dd98f8abc8
Make the album cover search results list scroll by pixel instead of item, and re-layout the items when any data changes
2011-06-26 15:06:59 +00:00
62bd3694ec
Remove cover provider factories and refactor everything else to use cover providers directly instead.
2011-06-19 23:15:51 +00:00
7415d85dce
When initialising a song from a library query, don't always assume the metadata originally came from a file (which means icycast tags are ignored when it is played). Fixes issue 1857
2011-06-17 20:00:10 +00:00
d1d177769a
cover providers are now recreated every search (this will lead to simpler API of theirs in a moment)
...
initial migration from SIP -> PythonQt in cover providers
2011-05-17 17:53:36 +00:00
ccb9f8cf94
Use URLs everywhere instead of filenames. Move the URL parsing and song loading code out of individual playlist parsers and into the base class. Fix the playlist parser unit tests.
2011-04-28 12:27:53 +00:00
10fbbca82f
disable some more stuff in the cover manager's window if there are no active cover providers
2011-04-27 19:36:42 +00:00
fdda938c53
now that we have more cover providers, we're bringing the cover manager and the cover searcher goodness to our last.fm-less users
2011-04-27 19:10:37 +00:00
032b5f7e48
initial commit of "multiple covers providers" feature:
...
- simple API for cover providers (both C++ and SIP)
- a new "package" for cover related code
2011-04-02 13:34:06 +00:00
fb36940d5e
Add tooltip for cover manager's items, which displays artist and album name info. Fixes issue 451
2011-02-08 22:54:37 +00:00
77151d7ebd
Hiding some of Song's cover art logic complexity in Song's API (namely: embedded and manually unset covers).
2011-02-02 21:01:08 +00:00
8aedda1795
moving the 'Save cover to file' action into AlbumCoverChoiceController; implementing the action in all related places (now playing widget, album cover manager, edit tag dialog)
...
now playing widget: disable all cover related context menu options (except for the 'save cover' one) when in 'Kittens' mode
2011-02-02 16:22:04 +00:00
2fec795b89
fixed an error where entering the Cover Searcher dialog without query would make it show the busy indicator forever
...
further refactoring of album cover changes (QMenu in controller)
2011-01-25 23:33:27 +00:00
0beb12fc14
Add some options to control what happens when you double click or use the menu to add tracks to the playlist
2011-01-24 21:16:26 +00:00
4a9d38bbdd
final refactoring stage of cover changing code (common QAction*s)
...
reset URL in 'Cover from URL' dialog on reentrance
2011-01-24 18:32:09 +00:00
ebfbdba8a9
further refactoring of cover changing code (saving covers in controller)
2011-01-24 17:53:31 +00:00
8bce92e69b
refactoring the code that handles common UI album cover related actions into a common controller
...
fixes a bug where cancelling the 'cover from URL' dialog would set the cover to a previously chosen URL
2011-01-24 00:09:57 +00:00
3e2ffd3647
ability to load cover from URL in all the usual places: cover manager, now playing widget and edit tag dialog (fixes issue #517 )
2011-01-23 20:24:17 +00:00
135b32642e
Refactor all the code that handles adding items to the playlist - whether it be by a context menu item, double clicking in a view or dragging. Everything now uses the models' mimeData() instead of duplicating the same code everywhere.
2011-01-10 22:26:13 +00:00
97d7fe764a
Download higher resolution images from last.fm. Thanks markwatkinson. Fixes issue #1187
2010-12-26 20:19:12 +00:00
2a63a746fe
Allow changing the cover art from the edit tag dialog
2010-12-20 15:46:38 +00:00
John Maguire
Jonas Kvinge
Amish Naidu
Chocobozzz
Jonas Kvinge
Santiago Gil
Domenico Iezzi
narunlifescience
John Maguire
Andreas
David Sansome
David Sansome
Paweł Bara
Arnaud Bienner