Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix missing buffers sent to analyzer 

This is a regression in the upgrade to gstreamer1.0.
The gst_buffer_unref() is incorrect as it removes the buffer when it is still needed by the chunker.
Forcing the pointer to be null prevents it from segfaulting but causes it to skip all chunks in the buffer, dropping the framerate and causing a worse case of #4321.
Removing these 2 lines restores original functionality.
This commit is contained in:
Mark Furneaux 2014-10-03 20:53:07 -04:00
parent f6c4eadd96
commit e8c2b4b267
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/engines/gstengine.cpp
View File

@ -317,8 +317,6 @@ void GstEngine::UpdateScope(int chunk_length) {
memcpy(dest, source, bytes); memcpy(dest, source, bytes);
gst_buffer_unmap(latest_buffer_, &map); gst_buffer_unmap(latest_buffer_, &map);
gst_buffer_unref(latest_buffer_);
latest_buffer_ = NULL;
} }
void GstEngine::StartPreloading(const QUrl& url, bool force_stop_at_end, void GstEngine::StartPreloading(const QUrl& url, bool force_stop_at_end,