From e8c2b4b2673f3509126f987f1f691392d7f6210a Mon Sep 17 00:00:00 2001 From: Mark Furneaux Date: Fri, 3 Oct 2014 20:53:07 -0400 Subject: [PATCH] Fix missing buffers sent to analyzer This is a regression in the upgrade to gstreamer1.0. The gst_buffer_unref() is incorrect as it removes the buffer when it is still needed by the chunker. Forcing the pointer to be null prevents it from segfaulting but causes it to skip all chunks in the buffer, dropping the framerate and causing a worse case of #4321. Removing these 2 lines restores original functionality. --- src/engines/gstengine.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/engines/gstengine.cpp b/src/engines/gstengine.cpp index 2c04e23a9..51798253d 100755 --- a/src/engines/gstengine.cpp +++ b/src/engines/gstengine.cpp @@ -317,8 +317,6 @@ void GstEngine::UpdateScope(int chunk_length) { memcpy(dest, source, bytes); gst_buffer_unmap(latest_buffer_, &map); - gst_buffer_unref(latest_buffer_); - latest_buffer_ = NULL; } void GstEngine::StartPreloading(const QUrl& url, bool force_stop_at_end,