Fix to prevent spinning status wheel if incomplete Subsonic credentials are supplied

Fixes issue #3733

src/internet/subsonicservice.cpp

@@ -173,6 +173,9 @@ void SubsonicService::Login() {
   if (IsConfigured()) {
     // Ping is enough to check credentials
     Ping();
+  } else {
+    login_state_ = LoginState_IncompleteCredentials;
+    emit LoginStateChanged(login_state_);
   }
 }
 

src/internet/subsonicservice.h

@@ -37,6 +37,7 @@ class SubsonicService : public InternetService
     LoginState_HostNotFound,
     LoginState_Timeout,
     LoginState_SslError,
+    LoginState_IncompleteCredentials,
   };
 
   enum ApiError {

src/internet/subsonicsettingspage.cpp

@@ -123,6 +123,10 @@ void SubsonicSettingsPage::LoginStateChanged(SubsonicService::LoginState newstat
                                             "SSLv3 option below may workaround some issues."));
     break;
 
+  case SubsonicService::LoginState_IncompleteCredentials:
+    ui_->login_state->SetAccountTypeText(tr("Incomplete configuration, please ensure all fields are populated."));
+    break;
+
   default:
     break;
   }