Funkwhale/Clementine-audio-player-Mac-Linux-Windows
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Improve UpdateItems complexity: still quadratic in wort-case, twice better in average, but linear in best case, which is very likely to happen in real usecases

Browse Source
This commit is contained in:
Arnaud Bienner 2011-11-19 16:01:58 +01:00
parent 6fbe897e82
commit 867a072579
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/playlist/playlist.cpp
View File

@ -47,6 +47,7 @@
#include <QBuffer>
#include <QDirIterator>
#include <QFileInfo>
#include <QLinkedList>
#include <QMimeData>
#include <QMutableListIterator>
#include <QSortFilterProxyModel>
@ -969,9 +970,21 @@ void Playlist::InsertInternetItems(InternetService* service,
void Playlist::UpdateItems(const SongList& songs) {
qLog(Debug) << "Updating playlist with new tracks' info";
foreach (const Song& song, songs) {
// We first convert our songs list into a linked list (a 'real' list),
// because removals are faster with QLinkedList.
// Next, we walk through the list of playlist's items then the list of songs
// we want to update: if an item corresponds to the song (we rely on URL for
// this), we update the item with the new metadata, then we remove song from
// our list because we will not need to check it again.
// And we also update undo actions.
QLinkedList<Song> songs_list;
foreach (const Song& song, songs) songs_list.append(song);
for (int i=0; i<items_.size(); i++) {
// Update current items list
for (int i=0; i<items_.size(); i++) {
QMutableLinkedListIterator<Song> it(songs_list);
while (it.hasNext()) {
const Song& song = it.next();
PlaylistItemPtr& item = items_[i];
if (item->Metadata().url() == song.url() &&
(item->Metadata().filetype() == Song::Type_Unknown ||
@ -996,6 +1009,7 @@ void Playlist::UpdateItems(const SongList& songs) {
if (found_and_updated) break;
}
}
it.remove();
break;
}
}