Funkwhale
/
Clementine-audio-player-Mac-Linux-Windows
mirror of https://github.com/clementine-player/Clementine
1
0
Fork 0
Code Issues Releases Wiki Activity

Add tests for the various format flags

This commit is contained in:
David Sansome 2010-06-24 16:44:12 +00:00
parent b2dcaf5cd4
commit 3de7311c36
2 changed files with 39 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ui/organiseformat.cpp
View File

@ -53,8 +53,15 @@ QString OrganiseFormat::GetFilenameForSong(const Song &song) const {
QString stripped;
for (int i=0 ; i<filename.length() ; ++i) {
const QCharRef c = filename[i];
if (c.toAscii())
if (c < 128)
stripped.append(c);
else {
const QString decomposition = c.decomposition();
if (!decomposition.isEmpty() && decomposition[0] < 128)
stripped.append(decomposition[0]);
else
stripped.append("_");
}
}
filename = stripped;
}

31
tests/organiseformat_test.cpp
View File

@ -92,3 +92,34 @@ TEST_F(OrganiseFormatTest, Blocks) {
song_.set_year(123);
EXPECT_EQ("BeforeInside123After", format_.GetFilenameForSong(song_));
}
TEST_F(OrganiseFormatTest, ReplaceSpaces) {
song_.set_title("The Song Title");
format_.set_format("The Format String %title");
EXPECT_EQ("The Format String The Song Title", format_.GetFilenameForSong(song_));
format_.set_replace_spaces(true);
EXPECT_EQ("The_Format_String_The_Song_Title", format_.GetFilenameForSong(song_));
}
TEST_F(OrganiseFormatTest, ReplaceThe) {
song_.set_title("The Title");
song_.set_artist("The Artist");
format_.set_format("%artist %title");
EXPECT_EQ("The Artist The Title", format_.GetFilenameForSong(song_));
format_.set_replace_the(true);
EXPECT_EQ("Artist The Title", format_.GetFilenameForSong(song_));
}
TEST_F(OrganiseFormatTest, ReplaceNonAscii) {
song_.set_artist(QString::fromUtf8("Röyksopp"));
format_.set_format("%artist");
EXPECT_EQ(QString::fromUtf8("Röyksopp"), format_.GetFilenameForSong(song_));
format_.set_replace_non_ascii(true);
EXPECT_EQ("Royksopp", format_.GetFilenameForSong(song_));
song_.set_artist(QString::fromUtf8("Владимир Высоцкий"));
EXPECT_EQ("________ ________", format_.GetFilenameForSong(song_));
}