2476 Commits

Author SHA1 Message Date
Maurice Parker
dc20aa0e22
Merge pull request #1833 from Wevah/embedded-widget-fix
Embedded widget fix
2020-03-01 14:25:23 -08:00
Maurice Parker
6828cd7325
Merge pull request #1832 from Wevah/article-max-width
Set max-width to 44em (792px with an 18px font-size)
2020-03-01 14:24:04 -08:00
Nate Weaver
82f8951c96 Don't force iframe height to auto
Prevents truncating of YouTube embeds without needing a wrapper div.
2020-02-28 08:24:42 -06:00
Nate Weaver
e183a5406c Only wrap iframes that don't specify their own height 2020-02-28 08:19:40 -06:00
Nate Weaver
65b508ffaa Port inline style stripping changes from master 2020-02-28 08:15:06 -06:00
Nate Weaver
bedaa75eb8 Set max-width to 44em (792px with an 18px font-size) 2020-02-28 07:47:19 -06:00
Maurice Parker
85bd20ca80 Stop media playback when the main window is closed. Issue #1646 2020-02-27 12:15:41 -08:00
Maurice Parker
a465045888 Save last used folder name when adding a feed. Issue #1462 2020-02-27 11:27:41 -08:00
Maurice Parker
7c060bb068 Change so that the tree controller can't be rebuilt before all async deletes have completed. Issue #1002 2020-02-26 17:28:52 -08:00
Maurice Parker
66ce3db1fc Trigger old, expired timers when the computer wakes from sleep to get refreshes going again. Issue #1122 2020-02-26 11:29:59 -08:00
Maurice Parker
42f97172b7 Store the url in the correct location. Issue #1656 2020-02-21 17:22:13 -08:00
Brent Simmons
8b42a19f0f
Merge pull request #1742 from aaronraimist/add-account-btn
Rename Feedbin account "Create" button to "Add Account"
2020-01-31 18:15:37 -08:00
Aaron Raimist
073eee6ff8
Rename Feedbin account "Create" button to "Add Account" 2020-01-29 17:50:37 -06:00
Brent Simmons
a70f16eb37
Merge pull request #1406 from Wevah/wordpress-smiley-mac
Add WordPress specific emoji style
2019-12-05 22:33:54 -08:00
Nate Weaver
c66ed35799 Add WordPress specific emoji style 2019-12-06 00:31:37 -06:00
Brent Simmons
d6b2e6a7df
Merge pull request #1405 from Wevah/ignore-secrets-release
Ignore secrets-related files
2019-12-05 21:59:04 -08:00
Nate Weaver
24510e49ba Ignore secrets-related files 2019-12-05 23:56:19 -06:00
Brent Simmons
3ead2c63bc Remove attachments from the app, since we’re not using attachments in any way. We could always add it back later. 2019-12-03 23:03:15 -08:00
Brent Simmons
e137dca5e3
Merge pull request #1394 from Wevah/ipv6-fix-mac-release
Update RSCore
2019-12-03 21:42:51 -08:00
Nate Weaver
9ce3e73316 Update RSCore
(IPv6 fix.)
2019-12-03 13:16:43 -06:00
Brent Simmons
9dc3ed03c7 Adopt DatabaseQueue. 2019-11-29 21:49:44 -08:00
Brent Simmons
6fdaf773cd Add SyncDatabase to referenced frameworks in project settings. 2019-11-29 21:49:24 -08:00
Brent Simmons
2c58bd31d7 Update to latest RSDatabase. 2019-11-29 21:12:16 -08:00
Maurice Parker
18045f2e2b
Merge pull request #1359 from Wevah/favicon-fix
Fix favicons not loading for certain feeds
2019-11-27 13:27:29 -06:00
Nate Weaver
9de27febf0 Fix favicon loading for sites with multiple/invalid favicons
Load the next favicon if a favicon is invalid

Iterate through multiple favicons and use the first that actually loads

- Add a homePageURL property to SingleFaviconDownloader that notification observers can use.
- Only add a URL to the favicon cache when we're sure it's valid.

Post notification even if the icon failed to load

Update RSParser

Remove single-favicon helper methods

Only load the next favicon if the current load failed

Update RSParser

Make sure to try the default favicon.ico

RSParser test fix update

Update RSParser
2019-11-27 13:02:49 -06:00
Maurice Parker
e2434e620c Get extended subscription information from Feedbin. Issue #917 2019-11-07 19:07:10 -06:00
Brent Simmons
3354d5a569 Delete articles and statuses from feeds no longer subscribed-to. At startup. Fix #899. 2019-10-24 22:28:26 -07:00
Brent Simmons
cd4135bf9a Remove old, comment-out update method in ArticlesTable. 2019-10-24 21:48:24 -07:00
Brent Simmons
eec008ca5b Remove Info.plist from NetNewsWire Tests copy files phase, since it shouldn’t be there. 2019-10-24 21:41:20 -07:00
Brent Simmons
f8376b807a Restore two-step process for OPML exporting. 2019-10-24 21:12:58 -07:00
Brent Simmons
1c06eb27e8 Create separate private extension. Make misc. code formatting changes to match current thinking. 2019-10-23 22:33:21 -07:00
Brent Simmons
6f29497ec8 Move NSTextFieldDelegate conformance to separate extension.
Handle the optional nil case in controlTextDidChange.
2019-10-23 22:27:08 -07:00
Brent Simmons
c01b2c6269
Merge pull request #1145 from Wevah/add-folder-button-fix
Disable "Add Folder" button when the text field is empty
2019-10-23 22:22:12 -07:00
Brent Simmons
06b0e35739 Move Protocol declaration to top of ExportOPMLAccessoryViewController.swift. As critical API, it needs to be easy to spot.
Create separation extensions — one for protocol conformance, one for private methods — ExportOPMLController.

Make minor code formatting change: instead of { return } — which is hard to set a breakpoint on — move the return to its own line.

Remove an internal access qualifier, since internal is default and implied.
2019-10-23 22:00:14 -07:00
Brent Simmons
a6915fe24e
Merge pull request #1148 from Wevah/opml-export-accessory-view
Use an accessory view instead of an intermediate sheet for OPML export
2019-10-23 21:29:35 -07:00
Nate Weaver
37e77a9596 Make delegate-less init() fail since a delegate is currently required 2019-10-22 12:14:38 -05:00
Nate Weaver
e7278017d9 Forgo notifications entirely, and use a delegate instead 2019-10-22 12:14:38 -05:00
Nate Weaver
a762052264 Don't use block-based notification observing 2019-10-22 12:14:38 -05:00
Nate Weaver
7e98869080 Use an accessory view instead of an intermediate sheet for OPML export 2019-10-22 12:14:38 -05:00
Brent Simmons
35e7d23d8a Bump version to 5.0.3. 2019-10-21 22:39:07 -07:00
Nate Weaver
b5d7ce8e8c Disable "Add Folder" button when the text field is empty 2019-10-19 12:31:47 -05:00
Brent Simmons
9b8b1207ad Update version. 2019-10-18 18:53:14 -07:00
Brent Simmons
a11e900a93 Get the y scroll position in the detail view using window.pageYOffset instead of document.body.scrollTop. It appears the latter may be broken — at any rate, it just returns 0 on Catalina. (On Mojave, use the same method as before, so as not to risk a regression.) 2019-10-18 17:37:56 -07:00
Brent Simmons
56fab24cec Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does). 2019-10-17 13:25:11 -07:00
Maurice Parker
19145505c5 Add the ability to import NNW 3 Subscription plist files. Issue #1129 2019-10-14 20:45:58 -05:00
Brent Simmons
427c0da0d3 Fix build error in FetchRequestQueue. 2019-10-13 22:19:49 -07:00
Brent Simmons
31a2afb067 Fix crashing bug in FetchRequestQueue by making sure the completion is called not more than once from FetchRequestOperation. Fix #1133. 2019-10-13 22:08:05 -07:00
Brent Simmons
fcb0f0c439 Remove a no-longer-used Account.update function — we have a new one that’s way faster. Also: assert that we’re in the main thread in that new update function. 2019-10-13 19:23:36 -07:00
Brent Simmons
1d0cacd5fc When syncing, update the database by articleIDs rather than by feeds — this means *far* fewer fetches and much less data pulled from the database. It should help app responsiveness dramatically during sync, and especially during an initial sync. 2019-10-13 19:02:56 -07:00
Brent Simmons
099172d9d2 Empty the database articles cache when NetNewsWire moves to the background. This helps prevent the cache from growing forever. 2019-10-12 15:06:21 -07:00