Brent Simmons
cd4135bf9a
Remove old, comment-out update method in ArticlesTable.
2019-10-24 21:48:24 -07:00
Brent Simmons
eec008ca5b
Remove Info.plist from NetNewsWire Tests copy files phase, since it shouldn’t be there.
2019-10-24 21:41:20 -07:00
Brent Simmons
f8376b807a
Restore two-step process for OPML exporting.
2019-10-24 21:12:58 -07:00
Brent Simmons
1c06eb27e8
Create separate private extension. Make misc. code formatting changes to match current thinking.
2019-10-23 22:33:21 -07:00
Brent Simmons
6f29497ec8
Move NSTextFieldDelegate conformance to separate extension.
...
Handle the optional nil case in controlTextDidChange.
2019-10-23 22:27:08 -07:00
Brent Simmons
c01b2c6269
Merge pull request #1145 from Wevah/add-folder-button-fix
...
Disable "Add Folder" button when the text field is empty
2019-10-23 22:22:12 -07:00
Brent Simmons
06b0e35739
Move Protocol declaration to top of ExportOPMLAccessoryViewController.swift. As critical API, it needs to be easy to spot.
...
Create separation extensions — one for protocol conformance, one for private methods — ExportOPMLController.
Make minor code formatting change: instead of { return } — which is hard to set a breakpoint on — move the return to its own line.
Remove an internal access qualifier, since internal is default and implied.
2019-10-23 22:00:14 -07:00
Brent Simmons
a6915fe24e
Merge pull request #1148 from Wevah/opml-export-accessory-view
...
Use an accessory view instead of an intermediate sheet for OPML export
2019-10-23 21:29:35 -07:00
Nate Weaver
37e77a9596
Make delegate-less init() fail since a delegate is currently required
2019-10-22 12:14:38 -05:00
Nate Weaver
e7278017d9
Forgo notifications entirely, and use a delegate instead
2019-10-22 12:14:38 -05:00
Nate Weaver
a762052264
Don't use block-based notification observing
2019-10-22 12:14:38 -05:00
Nate Weaver
7e98869080
Use an accessory view instead of an intermediate sheet for OPML export
2019-10-22 12:14:38 -05:00
Brent Simmons
35e7d23d8a
Bump version to 5.0.3.
2019-10-21 22:39:07 -07:00
Nate Weaver
b5d7ce8e8c
Disable "Add Folder" button when the text field is empty
2019-10-19 12:31:47 -05:00
Brent Simmons
9b8b1207ad
Update version.
2019-10-18 18:53:14 -07:00
Brent Simmons
a11e900a93
Get the y scroll position in the detail view using window.pageYOffset instead of document.body.scrollTop. It appears the latter may be broken — at any rate, it just returns 0 on Catalina. (On Mojave, use the same method as before, so as not to risk a regression.)
2019-10-18 17:37:56 -07:00
Brent Simmons
56fab24cec
Make importing NetNewsWire 3 subscriptions a one-step process — use an accessory view in the NSOpenPanel. Also: refactor to use immutable structs instead of classes; use static methods on structs; reduce API surface; don’t flatten sub-folders (let the OPML importer handle the flattening, which it already does).
2019-10-17 13:25:11 -07:00
Maurice Parker
19145505c5
Add the ability to import NNW 3 Subscription plist files. Issue #1129
2019-10-14 20:45:58 -05:00
Brent Simmons
427c0da0d3
Fix build error in FetchRequestQueue.
2019-10-13 22:19:49 -07:00
Brent Simmons
31a2afb067
Fix crashing bug in FetchRequestQueue by making sure the completion is called not more than once from FetchRequestOperation. Fix #1133 .
2019-10-13 22:08:05 -07:00
Brent Simmons
fcb0f0c439
Remove a no-longer-used Account.update function — we have a new one that’s way faster. Also: assert that we’re in the main thread in that new update function.
2019-10-13 19:23:36 -07:00
Brent Simmons
1d0cacd5fc
When syncing, update the database by articleIDs rather than by feeds — this means *far* fewer fetches and much less data pulled from the database. It should help app responsiveness dramatically during sync, and especially during an initial sync.
2019-10-13 19:02:56 -07:00
Brent Simmons
099172d9d2
Empty the database articles cache when NetNewsWire moves to the background. This helps prevent the cache from growing forever.
2019-10-12 15:06:21 -07:00
Brent Simmons
fae21082b0
Merge pull request #1110 from correia/bug-1108
...
The Debug menu can now be enabled in release builds.
2019-10-06 21:22:58 -07:00
Jim Correia
be89df884d
The Debug menu can now be enabled in release builds.
...
`defaults write com.ranchero.NetNewsWire-Evergreen ShowDebugMenu -bool YES`
Toggling the Web Inspector uses SPI, so it's always excluded from the Debug
menu when building for the Mac App Store.
2019-10-06 17:56:53 -07:00
Brent Simmons
50276233d1
Add feeds all in one go when processing Feedbin subscriptions. This is a performance enhancement.
2019-10-06 12:37:46 -07:00
Brent Simmons
1613a374d2
Update version number.
2019-09-30 13:33:52 -07:00
Brent Simmons
098128fd0a
Use new Slack group URL with Help menu command. Fix #1087 .
2019-09-29 22:46:40 -07:00
Brent Simmons
27478b0f6f
Make r and u both just toggle read status. Update keyboard shortcuts HTML documentation to match.
2019-09-29 22:44:32 -07:00
Brent Simmons
b62a7afa10
Add keyboard shortcut for toggling starred status — s key. Fix #875 .
2019-09-29 22:34:31 -07:00
Brent Simmons
0f362b7680
Update RSDatabase.
2019-09-29 17:01:20 -07:00
Brent Simmons
37c9818cad
Create and use a cache for DatabaseArticle — this will make fetches faster, since we can skip pulling the same data from the database over and over. Articles in the cache are removed when articles are updated, so the cache is never stale.
2019-09-28 13:51:33 -07:00
Brent Simmons
2b491217f3
Create statusWithRow(_ row: FMResultSet, articleID: String) — it allows us to avoid pulling articleID from the row twice every time we’re creating a DatabaseArticle.
2019-09-28 12:18:08 -07:00
Brent Simmons
d7b45a1413
Change parseDatePublished() to a lazy var parsedDatePublished — it appeared that it was getting called more than once, and date parsing is expensive. Also: use RSDateWithString rather than an NSDateFormatter, since NSDateFormatter is so massively slow.
2019-09-27 23:01:31 -07:00
Brent Simmons
07a631309c
Update RSWeb.
2019-09-27 22:59:15 -07:00
Brent Simmons
cca3089218
Update RSParser.
2019-09-27 21:56:16 -07:00
Maurice Parker
90834fe6b1
Delete conditional get information for taggings if it looks like Feedbin may have renamed a folder. Issue #1050
2019-09-26 11:35:07 -05:00
Maurice Parker
c4ee1edb69
Add externalID to Folder and persist it to OPML file. Issue #1060
2019-09-25 17:01:09 -05:00
Maurice Parker
08a8b8f6c2
Update to Swift 5.1
2019-09-25 15:32:30 -05:00
Maurice Parker
505a7d5149
Merge pull request #1039 from Wevah/web-inspector-outlet-fix
...
Remove enableWebInspectorMenuItem outlet
2019-09-22 18:17:42 -05:00
Nate Weaver
0c99a5f523
Remove enableWebInspectorMenuItem outlet
...
Fixes a console warning about the removed property.
2019-09-22 15:19:23 -05:00
Maurice Parker
cb1ebda28b
Merge pull request #1037 from benubois/resonsive_iframes
...
Make iFrames responsive.
2019-09-20 20:35:58 -05:00
Ben Ubois
cdf643c2a6
Make iFrames responsive.
2019-09-20 17:21:01 -07:00
Maurice Parker
ea13f911f1
Change to ignore unsupported accounts instead of crashing
2019-09-20 11:41:28 -05:00
Maurice Parker
b75f67bc1b
Merge pull request #1035 from Wevah/mac-app-store-hide-web-inspector
...
Disable Web Inspector for App Store builds
2019-09-19 11:45:10 -05:00
Nate Weaver
502f5656b8
Don't hide the Web Inspector menu item since the entire Debug menu is removed for release builds
2019-09-19 11:27:04 -05:00
Nate Weaver
180cc39904
Negate MAC_APP_STORE
...
Oops. (Was un-negated for testing.)
2019-09-19 11:19:25 -05:00
Nate Weaver
4a0bbeacc2
Disable Web Inspector for App Store builds
...
- Hide the "Enable Web Inspector" menu item.
- #if-out notifications/defaults/etc.
- Make toggleWebInspectorEnabled(_) a no-op.
2019-09-19 10:38:17 -05:00
Maurice Parker
9c9517d7d9
Merge pull request #1026 from Wevah/enable-inspector
...
Enable inspector
2019-09-17 14:44:06 -05:00
Maurice Parker
8a8dcde387
Add javascript to remove styling from articles. Issues ##499, #999 , and #947
2019-09-17 14:32:18 -05:00