Commit Graph

1013 Commits

Author SHA1 Message Date
Maurice Parker fc7b0cb05c Delete unneeded constraints 2020-10-27 20:31:51 -05:00
Maurice Parker 485eba3f26 Put accounts in the same order as they are on iOS 2020-10-27 20:26:08 -05:00
Maurice Parker 88399f0fb2 Widen existing accounts and extensions table and prevent horizontal scrolling in them 2020-10-27 20:20:18 -05:00
Maurice Parker 8f08d0d691 Make Extension Point maintenance Voice Over compatible 2020-10-27 20:18:26 -05:00
Maurice Parker de2171bbd0 Upgrade extension point assets to color versions for the Mac 2020-10-27 19:35:05 -05:00
Maurice Parker 4d2b5f0286 Update Mac account assets to be more colorful 2020-10-27 18:04:17 -05:00
Stuart Breckenridge 03611bc6ec
Add Accounts UI Refresh
• An extenison has been added to `AccountType` for iconColors (which have been added to the asset catalogs) and localised account names. SPM can handle resources so it might make sense to move to there.

• Add Account screen now has sections for local, icloud, web, and self-hosted, icons are now tinted and sized a bit smaller, and text is now `body` sized.
2020-10-27 11:42:28 +08:00
Maurice Parker 679cd40e84 Don't allow duplicate Reader API accounts to be created. 2020-10-25 19:41:16 -05:00
Maurice Parker c75dc8b54d Make sure that the error is displayed after the progress window is ended by doing an DispatchQueue.main.async on the error display. 2020-10-25 15:17:02 -05:00
Maurice Parker ecbd7d2f55 Enable adding accounts for the Reader API services. 2020-10-24 20:42:34 -05:00
Maurice Parker bc2a475936 Add Inoreader, BazQux, and The Old Reader assets 2020-10-24 14:18:01 -05:00
Maurice Parker 0a01a9f501 Display "(No Text)" if there isn't a title or summary for the timeline. Fixes #2391 2020-10-23 19:18:35 -05:00
Maurice Parker d735ae91dc Add a confirmation alert for the delete context menu so that it matches other delete functionality. 2020-10-23 16:54:20 -05:00
Maurice Parker be35382f70 Update Feedbin icon to the new design. 2020-10-23 15:44:55 -05:00
Nate Weaver d504a4b1a8 Replace force-unwraps
Fix for #2513.
2020-10-20 12:11:09 -05:00
Nate Weaver 0f8ffb3e01 Replace force-unwraps
Fix for #2513.
2020-10-20 12:02:27 -05:00
Maurice Parker 0d36b276e9 Disable the Import Subscriptions menu item if there aren't any accounts that can import OPML files. 2020-10-18 20:32:10 -05:00
Maurice Parker 065236ada3 Fix row background color. Issue #2503 2020-10-18 18:28:19 -05:00
Maurice Parker 34a2860c97 Fix row background color. Issue #2503 2020-10-18 18:27:36 -05:00
Maurice Parker c028bf42b8 Reenable sandboxing since it was causing CloudKit to fail to sync. 2020-10-18 18:02:50 -05:00
Maurice Parker 40d5625bd6 Use the correct error asset. 2020-10-18 17:04:30 -05:00
Maurice Parker e0bd520ef9 Set the preferences toolbar type so that it is correct on Big Sur. 2020-10-18 17:03:59 -05:00
Maurice Parker 4284ea26c8 Merge branch 'mac-release' into main 2020-10-18 16:37:00 -05:00
Maurice Parker 461f0f35d1 Update to use the Big Sur style icon for the 6.0 release. 2020-10-06 19:03:32 -05:00
Kiel Gillard 🤪 68fd7e7411 Clarify the UX of authorizing a Feedly account by directing users towards their default web browser #2444 2020-09-30 09:39:03 +10:00
Kiel Gillard 🤪 67d80dbaec Activate NetNewsWire after authorizing it with Feedly so users are not left in their browser, unable to see the result of authorizing NNW. 2020-09-30 09:38:40 +10:00
Maurice Parker dc35037740 Remove CSS rule that was interfering with Newsfoot styling 2020-09-29 07:35:05 -05:00
Maurice Parker 46743a0f49 Simplified the delete titles. 2020-09-28 20:28:53 -05:00
Maurice Parker aaff359609 Provide verification dialog for deletes. Issue #1789 2020-09-28 19:50:31 -05:00
Maurice Parker 19a2cc962d Don't allow duplicate accounts to be added for FeedWrangler 2020-09-24 20:29:56 -05:00
Maurice Parker d0cc9654f2 Don't allow duplicate accounts to be added for Feedbin, FeedWrangler, or NewsBlur. Issue #2448 2020-09-24 20:20:01 -05:00
Maurice Parker 2772b5e36d Make current window key and front if we are opening Safari in the background. Issue #2427 2020-09-23 18:30:34 -05:00
Maurice Parker e575aeca3c Restore functionality to mark older as read using keyboard shortcut. Issue #2451 2020-09-22 19:42:14 -05:00
Maurice Parker cb714d6781 Merge branch 'mac-release' of https://github.com/Ranchero-Software/NetNewsWire into mac-release 2020-09-22 19:27:46 -05:00
Maurice Parker f759f947c6 Restore the ability to select the default RSS reader. Issue #2428 2020-09-22 19:27:36 -05:00
Angelo Stavrow 1c4c24721b
Fix action for open-system-preferences button in alert 2020-09-22 07:10:13 -04:00
Maurice Parker fe39863858 Add width constraint to extractor button so that it doesn't move around on the most recent Big Sur beta's 2020-09-18 18:04:46 -05:00
Brent Simmons 0aff2c3311 Turn off sandboxing. 2020-09-14 22:09:26 -07:00
Maurice Parker 3fed4774e3 Make the All Unread feed eligible for the Clean Up command. Issue #2417 2020-09-13 16:35:51 -05:00
Maurice Parker 2879baf7ed Merge branch 'mac-candidate' of https://github.com/Ranchero-Software/NetNewsWire into mac-candidate 2020-09-12 18:09:54 -05:00
Maurice Parker c580877a86 Change to utilize ArticleFetchers instead of Feeds so that the single article fetcher stops getting filtered out. Issue #2416 2020-09-12 18:09:42 -05:00
Brent Simmons c684a08f5b Use correct URLs for Sparkle updates. 2020-09-09 22:50:02 -07:00
Brent Simmons daebe8f467 Update credits; update copyrights. 2020-09-08 20:09:32 -07:00
Maurice Parker feba4a7bc6 Change to respect individual feed filters when multiple feeds are selected. Issue #2399 2020-09-08 17:14:49 -05:00
Maurice Parker 35175fed27 Merge branch 'mac-candidate' of https://github.com/Ranchero-Software/NetNewsWire into mac-candidate 2020-09-08 13:59:54 -05:00
Maurice Parker bc3027507a
Merge pull request #2404 from AngeloStavrow/2401-update-help-link
Update link in Help menu
2020-09-08 13:58:33 -05:00
Maurice Parker 2c209fc51b Make table elements accessible when using voiceover. Issue #2393 2020-09-08 13:57:31 -05:00
Angelo Stavrow b102a8b407
Update link in Help menu to version 5.1 2020-09-08 09:03:11 -04:00
Angelo Stavrow 09853a51da
Ensure window title updates when feed/folder name is changed 2020-09-08 07:15:12 -04:00
Angelo Stavrow 5f095e8966
Set windowTitle in updateUI() method for *InspectorViewControllers 2020-09-08 07:14:54 -04:00
Angelo Stavrow c7aa5656d8
Add windowTitle var to Inspector protocol 2020-09-08 07:14:36 -04:00
Angelo Stavrow ef63c18265
Set window title based on type of Inspector being shown 2020-09-08 07:14:16 -04:00
Nate Weaver 13fb7151c0 Fix sidebar table column width 2020-09-07 18:48:30 -05:00
Angelo Stavrow 8e758b5baf
Check notifications permissions when user clicks showUnreadCountCheckbox 2020-09-06 17:15:46 -04:00
Angelo Stavrow 142ce582e6
Replace binding with IBAction/IBOutlet for Hide Unread Count checkbox 2020-09-06 13:22:35 -04:00
Angelo Stavrow 41156f6670
Add setter for hideUnreadCount in AppDefaults 2020-09-05 15:43:20 -04:00
Maurice Parker a10aa591a2 Remove ability to set default RSS reader. Issue #2381 2020-09-03 18:55:30 -05:00
Maurice Parker 0ed6255b6b Fix layout problems when long names for subreddits or twitter searches were used. 2020-09-02 17:29:55 -05:00
Maurice Parker a04c60caea Fix icon color changing bug. 2020-09-02 13:38:02 -05:00
Maurice Parker 7c7b128380 Fix subtitle for scenario where multiple are selected. 2020-09-02 13:00:09 -05:00
Nate Weaver 302ceeaffb Correctly handle IRIs 2020-09-01 16:41:01 -05:00
Nate Weaver 34685328e0 Changes for IDNA support 2020-09-01 16:41:01 -05:00
Maurice C Parker 78445b354d Fix sidebar width automatic resizing. Issue #2385 2020-08-31 14:58:58 -05:00
Maurice C Parker 72dc09a257 Position the image assets on pixel boundaries. Issue #2350 2020-08-25 17:34:13 -05:00
Brent Simmons 8350586dc3 Use regular font weight for body text in the timeline. 2020-08-23 21:24:52 -07:00
Brent Simmons cb5142cba2 Make the feed name bold in timeline cells. 2020-08-23 19:18:02 -07:00
Brent Simmons dad317680a Revise text and spacing in inspector window’s feed pane. Fix #2353. 2020-08-23 14:54:22 -07:00
Brent Simmons 0a3db80ee4 Change the hold-shift-key text for open-web-page settings to “Press the Shift key to do the opposite.” Change the name of the default browser preference to “Browser.” Rejigger some constraints. Fix #2356. 2020-08-23 14:38:41 -07:00
Maurice C Parker e7ea95aced Revert "Make the on my mac icon sharper."
This reverts commit 99edfe1fe1.
2020-08-21 20:09:39 -05:00
Maurice C Parker 99edfe1fe1 Make the on my mac icon sharper. 2020-08-21 20:05:05 -05:00
Maurice Parker d7b8822587 Merge branch 'mac-candidate' of https://github.com/Ranchero-Software/NetNewsWire into mac-candidate 2020-08-21 17:27:14 -05:00
Maurice Parker ad0cb2d58d Modify Reader View assets so that the look better on 1x displays. Issue #2350 2020-08-21 17:27:04 -05:00
Maurice C Parker d99f12346d Manually draw background and selection so that it encompasses the whole row. Issue #2363 2020-08-21 16:02:09 -05:00
Maurice Parker b051a4c990 Make animation loop smoother. Issue #2377 2020-08-21 15:32:56 -05:00
Maurice C Parker 9abf27ac63 Restore request for notification authorization on startup since we have the badge on by default. Issue #2375 2020-08-21 12:51:53 -05:00
Maurice C Parker 0913963c97 Change table column width to automatically resize with table view. Issue #2373 2020-08-21 11:54:26 -05:00
Maurice Parker 1e7a185134 Use rgba instead of rgb for lightmode 2020-08-20 21:13:18 -05:00
Maurice Parker c1b108f541 Merge branch 'mac-candidate' into main 2020-08-20 21:03:55 -05:00
Maurice Parker 6893c8ebc8 Use the lighter shade of NNW blue for darkmode article view (like iOS) 2020-08-20 21:02:28 -05:00
Maurice Parker 6eae89cf4c Merge branch 'mac-candidate' into main 2020-08-20 20:45:15 -05:00
Maurice Parker 2b35eacc30 Improve new window pane sizes. Issue #2344 2020-08-20 20:00:31 -05:00
Maurice C Parker b20004e8b5 Fix initial Sidebar column sizing issue 2020-08-20 16:49:06 -05:00
Maurice Parker 59893d6b10 Step 2 in fixing StarColor filename 2020-08-20 15:22:30 -05:00
Maurice Parker e3bd4b080d First step in fixing StarColor filename 2020-08-20 15:21:38 -05:00
Maurice Parker 670d45fffd Fix StarColor name 2020-08-19 21:13:58 -05:00
Maurice Parker b0e7ae0324 Merge branch 'mac-candidate' into main 2020-08-19 21:03:55 -05:00
Maurice Parker d3cebfaccb Turn the star color to white if the article is selected. Issue #2364 2020-08-19 20:00:34 -05:00
Maurice Parker f7fb859ea9 Make article source gray. Issue #2368 2020-08-19 12:48:20 -05:00
Maurice Parker bbd2dfad45 Change article accent color to be NNW blue. Issue #2367 2020-08-19 12:31:03 -05:00
Maurice Parker 1f047cdb10 Make the timeline date bold. Issue #2365 2020-08-19 11:56:14 -05:00
Maurice Parker ef99496002 Make summary text a lighter shade of gray. Issue #2366 2020-08-19 11:51:44 -05:00
Maurice Parker d98608fe3a Show add account view controller if user deselects a selected account. Issue #2359 2020-08-18 17:31:21 -05:00
Maurice Parker afc113833b Change shiftkey explanation text to use the secondary label color. Issue #2358 2020-08-18 17:26:23 -05:00
Maurice Parker 68250353fa Set toolbar style to preference so that it looks correct on Big Sur 2020-08-18 17:24:39 -05:00
Maurice Parker 25ec13972c Change margin padding back to 64px. Issue #2360 2020-08-18 17:20:44 -05:00
Maurice Parker b0de353d02 Make clean up availability take read count into consideration. Issue #2352 2020-08-18 15:04:30 -05:00
Maurice Parker 348e8734e7 Make timeline sort menu more closely match Mail's. Issues #2348, #2347, #2349 2020-08-18 12:01:36 -05:00
Maurice Parker 72bd722def Remove sidebar filter button. Issue #2346 2020-08-17 17:50:50 -05:00
Maurice Parker 34247f6d89 Merge branch 'mac-candidate' into main 2020-08-15 14:35:44 -05:00
Maurice Parker 9c0730f4d3 Make sort menu taller so that it won't cut off. Issue #2339 2020-08-15 14:28:29 -05:00
Maurice Parker cddd5cebff
Merge pull request #2338 from stuartbreckenridge/hotfix/2335
Hotfix/2335
2020-08-15 02:11:08 -05:00
Maurice Parker c7fe39791d Merge branch 'mac-candidate' into main 2020-08-15 02:06:31 -05:00
Stuart Breckenridge ddbf0fffb6
Fixes #2335
The `ReleaseNotes` struct has been replaced with an extension on URL. Release Notes can now be opened on all versions of NNW.
2020-08-15 15:01:00 +08:00
Maurice Parker 25528ec886 Remove image size constraints 2020-08-15 01:58:31 -05:00
Maurice Parker 64c548c13f Change filter button assets. Issue #2336 2020-08-15 01:45:47 -05:00
Maurice Parker 24295639ae Set the total unread count in the subtitle when nothing is selected 2020-08-14 14:35:36 -05:00
Maurice Parker eccfd5e15b Finish macOS Share Extension 2020-08-14 10:25:55 -05:00
Maurice Parker ee033398c1 Implement share dialog UI 2020-08-13 20:09:42 -05:00
Maurice Parker 54275225a7 Stub out Share Extension 2020-08-13 18:03:39 -05:00
Maurice Parker d6ed015514 Don't allow users to add Reddit or Twitter feeds if they don't have an extension configured. 2020-08-12 10:27:58 -05:00
Maurice Parker 9a91648acc Remove sidebar toggle from the default set 2020-08-11 21:36:15 -05:00
Maurice Parker 38d01eb151 Add Sidebar toggle 2020-08-11 21:03:19 -05:00
Maurice Parker f8cf5676e9 Don't allow Twitter or Reddit feeds to be added to accounts that can't handle them 2020-08-11 20:19:17 -05:00
Maurice Parker 3188a80d25 Remove CSS rule that was interfering with Newsfoot styling 2020-08-11 10:32:54 -05:00
Maurice Parker cb2eefa56a Implement new article extractor button for Big Sur 2020-08-10 17:34:12 -05:00
Maurice Parker 4ce974daca Rename ArticleExtractorButton to make room for the new ArticleExtractorButton 2020-08-10 15:47:40 -05:00
Maurice Parker 73b120a91c Change any glyphs in the sidebar to white when selected to make them visible regardless of use control color selection 2020-08-10 13:53:21 -05:00
Maurice Parker c652486663 Change all 10.16 version checks to be 11.0 2020-08-10 11:43:18 -05:00
Maurice Parker 7a7784eb75 Enable preferences toolbar to style itself for Big Sur 2020-08-10 11:25:48 -05:00
Maurice Parker 1c9b0feaaf Move tooltip to the toolbar item instead of the button 2020-08-10 09:53:06 -05:00
Maurice Parker 7619f4470b Add article toolbar items 2020-08-10 09:45:48 -05:00
Maurice Parker 38dd0257bb Add search and mark all as read toolbar items 2020-08-10 09:28:45 -05:00
Maurice Parker fe671f079d Change to use programmatic toolbar building 2020-08-10 03:58:19 -05:00
Maurice C Parker c30f9af68c Fix filter button placement on Catalina 2020-08-09 20:35:05 -05:00
Maurice Parker c4599cbcc4 Comment out Toolbar Search Item so that the storyboard can be opened on Catalina 2020-08-09 20:27:47 -05:00
Maurice Parker 58498ef33e Use the SF star for the timeline on Big Sur 2020-08-09 20:05:38 -05:00
Maurice Parker 8ee33c34b3 Hook up new search toolbar item 2020-08-09 16:40:44 -05:00
Maurice Parker 656d327692 Programmatically define the default set of toolbar items 2020-08-09 15:36:32 -05:00
Maurice Parker 0ec9e26db7 Change timeline sort bar appearance 2020-08-09 12:14:41 -05:00
Maurice Parker 258c89bf12 Add new sidebar item menu to toolbar 2020-08-09 11:46:53 -05:00
Maurice Parker f676de1ce1 Change toolbar separators to start with a lower case character to match modern Swift conventions 2020-08-09 10:47:56 -05:00
Maurice Parker c6885baaca Add New Reddit and New Twitter menu items 2020-08-09 06:21:02 -05:00
Maurice Parker afe8d23365 Add separator for timeline and make buttons stateful 2020-08-09 06:02:48 -05:00
Maurice Parker 57d988da95 Fix titles on Big Sur 2020-08-08 21:28:43 -05:00
Maurice Parker 0a9496a583 Initial support for the Unified Toolbar 2020-08-08 20:49:22 -05:00
Maurice Parker f23ebbd8db Use SF Symbols for icons in the Sidebar when on Big Sur Issue #2323 2020-08-08 18:15:45 -05:00
Maurice Parker 1fba0ed247 Don't show a background on symbol images 2020-08-08 17:27:32 -05:00
Maurice Parker c5ec93e8b5 Respect Sidebar size preferences from General preferences Issue #2321 2020-08-08 17:07:21 -05:00
Maurice Parker 314d425c49 Use high resolution Feed icons in the Sidebar #2320 2020-08-07 19:44:12 -05:00
Maurice Parker a7a17e3937 Merge branch 'mac-candidate' into main 2020-08-06 17:06:49 -05:00
Maurice Parker 7baebfeb6a Don't notify the delegate of a selected article change if they haven't actually changed 2020-08-06 17:05:53 -05:00
Maurice Parker 634e9d2979 Set preferences toolbar style to preferences 2020-08-05 11:39:12 -05:00
Maurice Parker 75df979eed Merge branch 'mac-candidate' into main 2020-08-02 18:08:57 -05:00
Angelo Stavrow be8fedbf11
Use conditional in guard statement instead of setting an unused variable 2020-08-02 17:10:57 -04:00
Angelo Stavrow a0fea768bf
Fix race condition between getting and checking notification settings 2020-08-02 17:10:46 -04:00
Angelo Stavrow 88ac27ef50
Only dispatch UI code for async execution 2020-08-02 17:10:41 -04:00
Angelo Stavrow 193aab2cef
Open the Notifications prefPane directly in System Preferences 2020-08-02 17:10:28 -04:00
Angelo Stavrow 3cb47afe65
Group all update-UI functions together in file 2020-08-02 17:10:14 -04:00
Angelo Stavrow 288a5b18db
Improve the open-notifications-prefPane alert's message 2020-08-02 17:10:10 -04:00
Angelo Stavrow 619ddc6ea2
Remove comments, and move post-request actions to the main queue 2020-08-02 17:10:01 -04:00
Angelo Stavrow 42cfe2380a
Present an alert to the user if notifications are denied in System Prefs 2020-08-02 17:09:39 -04:00
Angelo Stavrow 952d066199
Apply same behavior on checkbox toggle as iOS app 2020-08-02 17:09:31 -04:00
Angelo Stavrow 1123a0be86
Try to register for remote notifications when feed inspector appears 2020-08-02 17:09:26 -04:00
Angelo Stavrow 927db2c375
Import UserNotifications 2020-08-02 17:08:44 -04:00
Angelo Stavrow 2d2c14f9ba
Check if authorized for notifications in AppDelegate before registering 2020-08-02 17:08:30 -04:00
Maurice Parker 4820413f74 Make CloudKit and NewsBlur addable accounts 2020-08-02 14:11:35 -05:00
Maurice Parker 844ef03a65 Reenable Extensions for the 5.5 release 2020-08-02 14:10:02 -05:00
Maurice Parker 87fc73c5de Merge branch 'mac-candidate' into main 2020-08-02 14:05:46 -05:00
Maurice Parker fd56a19edf Hard code enable the MarsEdit and Micro.blog extension points so that they work like 5.0.x 2020-08-02 14:03:51 -05:00
Maurice Parker b724658528 Refactor how we do Secrets to work with the new Swift Package structure 2020-07-30 17:40:45 -05:00
Nate Weaver 5630a4eba4 Correctly handle IRIs 2020-07-29 15:42:11 -05:00
Nate Weaver 1f9dfb80e2 Changes for IDNA support 2020-07-29 15:42:11 -05:00
Maurice Parker 32d6d2f3c1 Convert RSCore into an SPM package 2020-07-29 05:11:57 -05:00
Maurice Parker d7caad9f7b
Merge pull request #2294 from Wevah/applescript-article-feed
AppleScript: Add a "feed" property to articles
2020-07-28 21:29:39 -05:00
Maurice Parker f2f3ccbe00 Configure star swipe images as template so that they render in the correct color 2020-07-27 19:32:08 -05:00
Noelle Leigh 39ab38ff42 Fix Mac/AppDelegate.swift 2020-07-26 05:46:48 -04:00
Nate Weaver ae1aafdd31 Add "email" as a synonym of "email address" 2020-07-23 08:04:53 -05:00
Nate Weaver 42f63808f3 AppleScript: Add a "feed" property to articles
- Also make scripts like

feed id "foo" of account id "bar"

find feeds in folders.
2020-07-22 21:08:15 -05:00
Maurice Parker cf233f4825
Merge pull request #2259 from stuartbreckenridge/feature/mac-preferences
Mac Preferences
2020-07-15 19:16:19 -05:00
Stuart Breckenridge 1b5b219e54
Restores storyboard to 36b4907e 2020-07-16 06:49:01 +08:00
Nate Weaver 5c29fde2c6 Fix sidebar column resizing on Mac
Since 17e1247.
2020-07-14 12:16:46 -05:00
Maurice Parker 17e1247ff0 Add sort control for macOS 2020-07-12 19:43:25 -05:00
Stuart Breckenridge 31b93c5d13
small refactoring 2020-07-12 14:07:52 +08:00
Maurice Parker 4af8e0ab1c Select next item in Sidebar on delete. Issue #2114 2020-07-10 16:49:10 -05:00
Maurice Parker 3215c98253 Disable Extensions until we move Mac 5.1 to mac-candidate 2020-07-10 16:28:57 -05:00
Maurice Parker 7480e42455 Remove iCloud and NewsBlur from the available account types until we move 5.1 to mac-candidate 2020-07-10 16:13:42 -05:00
Maurice Parker 95a8f6d72d Merge branch 'swiftui' 2020-07-10 15:28:14 -05:00
Nate Weaver 5acce87995 Mac: Make shift-space scroll up even when the detail view doesn't have focus
Issue #969.
2020-07-10 13:57:34 -05:00
Maurice Parker d15dbe18ef Change AppDefaults to be final classes on macOS and iOS 2020-07-02 05:36:23 -05:00
Stuart Breckenridge a57f98e4e7 NetNewsWire-Mac AppDefaults is now a singleton 2020-07-02 11:17:38 +08:00
Stuart Breckenridge 1f6f5fa054 Adds Mac Preferences
This makes use of `@AppStorage` for preferences. Severeral more need to migrated from AppDefaults etc.
2020-06-29 21:04:50 +08:00
Maurice Parker 67c0e00957 Make multiplatform compile shared app resources 2020-06-28 03:05:01 -05:00
Maurice Parker 9a82d2e233
Merge pull request #2121 from rizwankce/fix/in-app-browser-shortcut
fix open in app browser for mac and iOS
2020-05-29 10:13:07 -05:00
Rizwan Mohamed Ibrahim d671029828
refactor open in app browser for mac and iOS 2020-05-29 19:26:20 +05:30
Rizwan Mohamed Ibrahim eb7ac0f076
fix open in app browser for mac and iOS 2020-05-29 15:44:32 +05:30
Nate Weaver 1b344be2c2 Add some documentation comments 2020-05-28 17:03:28 -05:00
Nate Weaver 36b4907e90 Put the default browser popup under "Web pages:" 2020-05-28 16:57:06 -05:00
Nate Weaver 0da3372b6d Fix Preferences xib and Browser.swift after rebase 2020-05-25 21:32:56 -05:00
Nate Weaver 41d96be8b4 Revert toolbar item updating 2020-05-25 21:25:52 -05:00
Nate Weaver 40b68f6ec6 Revert "Update "Open in Browser" menu item title as well"
This reverts commit 4b2fe7789895993a8bb0e034703bbb7c5a99f6d8.
2020-05-25 21:25:52 -05:00
Nate Weaver baf2dcf0c7 Update "Open in Browser" menu item title as well 2020-05-25 21:24:50 -05:00
Nate Weaver 1ab17b2574 Add a preference for the browser to use to open articles
- Selectable in General Preferences
- Toolbar item now updates to show the browser's icon
2020-05-25 21:24:49 -05:00
Nate Weaver 0c2d057860 Add defaultBrowserID user default and make the appropriate toolbar item use that browser's icon 2020-05-25 21:19:50 -05:00
Nate Weaver b8220d3a9c Show the current default browser in the "Open in Browser" toolbar item 2020-05-25 21:19:29 -05:00
Brent Simmons 64eec7ad6b
Merge pull request #2100 from Wevah/open-in-background-inversion
Make shift key invert the "open in background" preference
2020-05-23 16:06:47 -07:00
Martin Nash 3e48be050e Updated function name to openInBrowserUsingOppositeOfSettings 2020-05-21 22:28:30 -07:00
Martin Nash 834be9edff 2099 | Keyboard shortcut to open in browser in background/foreground contrary to user preference.
- Add openInBrowserAlternate() function
- Add shit-modified entries to to GlobalKeyboardShortcuts.plist to trigger new function
2020-05-20 22:15:00 -07:00
Nate Weaver 82d673851d Tweak constraints, add period 2020-05-20 20:23:13 -05:00
Nate Weaver a38ab12fb3 Add a note about holding the Shift key 2020-05-20 20:14:29 -05:00
Nate Weaver 5cd8dc9d5d Also let the Command key invert the background pref in web views 2020-05-20 20:08:13 -05:00