Commit Graph

4910 Commits

Author SHA1 Message Date
Matthieu De Beule
c362a50e1b Fix #3028: actually use encodedQuery from URLEncoder to avoid encoding issues 2019-03-07 20:53:22 +01:00
orionlee
7a905c0570 remove the commented stopService() call (to avoid future confusion) 2019-03-05 15:07:16 -08:00
orionlee
24915785eb remove the stopService() per review (which might unnecessarily
stop the playback when unsupported media buttons are pressed.)
2019-03-05 15:01:48 -08:00
H. Lehmann
c1bfb9183c
Merge pull request #3013 from hannesa2/buildImprovements
Build improvements
2019-03-05 23:49:00 +01:00
orionlee
e94e95e844 remove dead codes 2019-03-04 13:46:11 -08:00
orionlee
600e0e561e coding style fix per review 2019-03-04 13:44:53 -08:00
H. Lehmann
c0f534e825
Merge pull request #3050 from ByteHamster/add-backup-keyword
Add backup keyword to search
2019-03-04 18:57:37 +01:00
H. Lehmann
cfa9304c82
Merge pull request #3047 from ByteHamster/move-to-unit-test
Moved some implementation tests to unit tests
2019-03-04 18:56:51 +01:00
H. Lehmann
3d9811d1e3
Merge pull request #3044 from mamehacker/min_max_speeds_from_preferences
Set min/max playback speeds from preferences
2019-03-04 18:53:34 +01:00
ByteHamster
579b263a86 Add backup keyword to search 2019-03-04 14:33:39 +01:00
ByteHamster
c50d37fa1b Moved some implementation tests to unit tests 2019-03-03 23:55:52 +01:00
H. Lehmann
1593a06077
Merge pull request #3032 from shortspider/3031-TimecodeRegex
Change Timecode Regex
2019-03-03 23:26:32 +01:00
Nathan Mascitelli
1d0e701525 Another atempt at fixing the regex 2019-03-03 13:36:28 -05:00
Nathan Mascitelli
7e3ccd97da Fix regex 2019-03-02 12:12:26 -05:00
Nathan Mascitelli
6f69b4b140 Adjust regext to ignore X:Y timecodes 2019-03-02 08:47:52 -05:00
orionlee
a3389490bb ensure the service continues to run in the event it takes a long time for the service to load the media to play, e.g.,
streaming over a slow network.
2019-02-27 14:59:31 -08:00
orionlee
ab78c1d410 bug fix for Android8+: revert context.startService() calls back to
ContextCompat.startForegroundService(), to ensure PlaybackService
can be started.

While PlaybackService itself ensures it will be raised to foreground
when appropriate, Android 8+ forbids creating the (background)
services to begin with (and throw IllegalStateException) in some
situation (e.g., BroadcastReceiver).

https://developer.android.com/about/versions/oreo/android-8.0-changes#atap
2019-02-27 14:52:34 -08:00
orionlee
2c5db08e25 minor cleanup of Log codes and comments. 2019-02-27 14:52:34 -08:00
orionlee
221cd4b480 refactor stop PlaybackService setupNotification() - extract common
code as private helper.
2019-02-27 14:52:34 -08:00
orionlee
f0f8623937 refactor stop PlaybackService codes - remove legacy dead codes 2019-02-27 14:52:34 -08:00
orionlee
584865ad18 review stop PlaybackService codes (stopSelf, stopForeground, etc.) 2019-02-27 14:52:34 -08:00
orionlee
3f14fac479 remove static PlaybackService.started, in favor of the start state
managed by inner ServiceManager.
Also add a generic java8-like Optional class for use with RxJava2 where
null was to be returned (RxJava2 requires non-null).
2019-02-27 14:52:34 -08:00
orionlee
e26a54bdbc start playbackService code paths reviewed (context.startService() and
ContextCompat.startForegroundService())
2019-02-27 14:52:34 -08:00
orionlee
76fbab8e82 more #2716 - fix VideoPlayback upon hitting home button. 2019-02-27 14:52:34 -08:00
orionlee
f3980091a9 #2716 Prototype for the revamped PlaybackService to fix phantom
notification. Many rough edges. Notable TODOs are marked with [2716].
2019-02-27 14:52:34 -08:00
Shinichiro Fujiwara
6a56260157 Set min/max playback speeds from preferences 2019-02-27 22:29:28 +09:00
H. Lehmann
335d287d5e
Merge pull request #3041 from ByteHamster/transifex-italian
Transifex: removed duplicate Italian translation
2019-02-26 08:39:45 +01:00
ByteHamster
6dafc8b127 Transifex: removed duplicate Italian translation
Using it_IT for all italian languages because it's 100% finished
2019-02-21 15:17:59 +01:00
Nathan Mascitelli
e94e4bc3d0 Use a single format for short timecodes
It is unlikely that multiple formats for short timecodes would be used
in one document. Therefor we will parse all the short timecodes to see
if they are all less then the duration as HH:MM. If they are we will use
that, otherwise we will parse them as MM:SS.
2019-02-13 21:06:19 -05:00
Nathan Mascitelli
c49e98b546 Handle more then 23 hours 2019-02-12 20:53:17 -05:00
Nathan Mascitelli
39b9df5064 Timecode parsing logic now handles two short formats
We now handle both HH:MM and MM:SS when paring timecodes. We will move
in reverse order (assuming that the timecodes will increase over the
course of the document) and parse short codes as HH:MM. When we get a
result that does not fit into the duration we will change to parse as
MM:SS and use that for the rest of the document.
2019-02-12 19:43:57 -05:00
Nathan Mascitelli
d0f617880c Converter handles HH:MM and MM:SS 2019-02-12 19:43:37 -05:00
Nathan Mascitelli
96b0336b2c Update Timeline regex
Regex now looks for the new types of short and long timestamps.
2019-02-10 18:01:00 -05:00
Nathan Mascitelli
9180be85ba Update tests to handle minute timestamps
The definition of 'short timestamp' now means minutes and seconds, while
'long timestamp' means hours, minutes, and seconds. The first part of a
timestamp may have one or two digits. Tests updated for this new
definition.
2019-02-10 18:00:28 -05:00
H. Lehmann
91987460db
Merge pull request #2688 from orionlee/auto_download_12_hour_option_2685
Episode Cleanup (for automatic download) - support 12 hours after finishing
2019-02-01 16:31:45 +01:00
ByteHamster
abe68ec7bd Merge remote-tracking branch 'upstream/develop' into auto_download_12_hour_option_2685 2019-02-01 16:25:20 +01:00
ByteHamster
73bb2f712e Removed misleading comment
Auto-generating the versionCode breaks F-Droid builds, see #3012
2019-02-01 16:00:13 +01:00
ByteHamster
39c6ff5f31 Finish when closing error dialog 2019-02-01 15:59:30 +01:00
Burt Wiley Snyder
7f100b3fa6 Null handling in OnlineFeedViewActivity (#3004) 2019-02-01 15:57:19 +01:00
Hannes Achleitner
0663e422a6 unify lint options for all modules 2019-01-27 12:54:56 +01:00
Hannes Achleitner
e9c10cdaa8 simplify build concerning maven repos 2019-01-27 12:45:32 +01:00
Hannes Achleitner
9ca7888d92 remove buildtools specification 2019-01-27 12:42:02 +01:00
Martin Fietz
3b67381656
Merge pull request #2994 from orionlee/android_gradle_330_upgrade
Upgrade android gradle plugin to v3.3.0
2019-01-27 11:47:13 +01:00
Martin Fietz
7f37987bda
Merge branch 'develop' into android_gradle_330_upgrade 2019-01-27 11:40:24 +01:00
Martin Fietz
9fe05d96b9
Merge pull request #3012 from hannesa2/SimplifyVersionCode
simplify versionCode
2019-01-27 11:38:44 +01:00
Martin Fietz
bcfc951f1b
Merge branch 'develop' into android_gradle_330_upgrade 2019-01-27 11:35:46 +01:00
Hannes Achleitner
8e5abeea3a simplify versionCode
removed implementation was some Eclipse/ant style, now it's Gradle style
2019-01-27 10:57:45 +01:00
H. Lehmann
0474717ba1
Merge pull request #3005 from pachecosf/fix-ripple-effect
Reimplemented the ripple effect when choosing a nav item
2019-01-23 15:41:51 +01:00
pachecosf
e0d6d35ca5 moved closing backet up one line 2019-01-23 05:22:39 -08:00
H. Lehmann
de7a05f77c
Merge pull request #3006 from pachecosf/fixed-losing-media-data
Fixed losing media data on rotation
2019-01-23 12:30:44 +01:00