Castopod/AntennaPod
1
0
Fork 0
mirror of https://github.com/AntennaPod/AntennaPod.git synced 2024-12-27 09:13:53 +01:00
Code Issues Packages Projects Releases Wiki Activity
4,910 Commits 4 Branches 122 Tags 205 MiB
af31464cd5
Commit Graph

4910 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
ByteHamster
cfd0af55c4 Removed nb translation 2019-04-11 21:54:57 +02:00
ByteHamster
777d92d4be Set number of subscription columns 2019-04-11 21:24:51 +02:00
ByteHamster
6595f49f22 Reduced repetition in styles.xml 2019-04-11 21:02:45 +02:00
ByteHamster
d4c87facaf Fix displaying progress indicator in multi window 2019-04-11 20:54:48 +02:00
H. Lehmann
97d08f3b00
Merge pull request #3097 from ByteHamster/exoplayer-main-thread 
Executing all ExoPlayer methods on main thread
 2019-04-11 20:50:56 +02:00
H. Lehmann
be6eb1c738
Merge pull request #3102 from ByteHamster/no-state-in-fragments 
Do not hold state in fragments
 2019-04-11 20:50:34 +02:00
ByteHamster
1d0e22135e Making sure that ExternalPlayerFragment is updated when starting first media 2019-04-11 20:41:39 +02:00
ByteHamster
5745da75a6 Clarified that it is using caller thread. not main thread 2019-04-11 20:11:40 +02:00
ByteHamster
0e3cabb86d Do not hold state in fragments 2019-04-10 01:05:36 +02:00
Martin Fietz
d8a010ad48
Merge pull request #3100 from orionlee/bugfix_bulk_action_ui_survive_split_screen_3088 
bugfix - bulk actions - make UI survive upon split screen
 2019-04-08 18:54:01 +02:00
Martin Fietz
f5956bcd56
Merge pull request #3101 from orionlee/bugfix_add_podcast_by_url_case_no_feed_in_html_3099 
bugfix - add podcast by URL - show error dialog when URL points to no feed
 2019-04-08 18:53:32 +02:00
orionlee
345e6863c3 bugfix #3099 - add podcast by URL - show error dialog when URL points to no feed. 2019-04-07 14:56:15 -07:00
orionlee
1928411694 bugfix #3088 - bulk edit - make UI survive upon split screen 2019-04-07 14:27:29 -07:00
ByteHamster
156a20734a Fix Sonic playback 2019-04-07 12:54:12 +02:00
ByteHamster
2c9cb25eda Merge branch 'develop' into exoplayer-main-thread 2019-04-07 11:52:24 +02:00
H. Lehmann
3fdf6af1a3
Merge pull request #2974 from orionlee/bugfix_rxjava2_null_returns_2966 
Fix rxjava2 null returns
 2019-04-07 11:35:13 +02:00
ByteHamster
ebe32e795a Executing all ExoPlayer methods on main thread 2019-04-07 00:19:02 +02:00
orionlee
e16f44ad5d bugfix - rxjava2 null return - wrap nullable return with Optional 2019-04-06 14:22:53 -07:00
orionlee
20f1445c06 fix rebase conflicts - remove the incorrect @NonNull from rxjava 2019-04-06 14:19:16 -07:00
orionlee
c04f340ae2 #2966 RxJava2 null - case underlying method has needs to return null. 
Need to wrap return result with Optional<>
Mark code path with TODO. Actual fix is pending #2954 merge.

Rx observer: underlying sources that need to return Optional<>
OnlineFeedViewActivity.parseFeed : <anonymous subscriber>
PlaybackController.bindToService : fixed in #2954
 2019-04-06 13:43:12 -07:00
orionlee
1655d234af #2966 RxJava2 null - case the underlying method may return null, but 
should never happen in the code path, e.g.,
 return the current FeedItem in ItemFragment UI.
Mark underlying method as @Nullable, and let observer's existing
 onError() to handle null case

Rx observer : underlying sources marked as @Nullable
 ItemFragment.load : .loadInBackground
 MediaplayerActivity.checkFavorite : DBReader.getFeedItem
 ItemDescriptionFragment.onViewCreated : DBReader.getFeedItem
 ItemlistFragment.loadItems : .loadData
 2019-04-06 13:43:11 -07:00
orionlee
0472bb9237 #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull 
to be on the safe side, for cases that the consuming observers checks null
unnecessarily.

Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.startFeedDownload : Downloader.getResult
AllEpisodesFragment.loadItems : AllEpisodesFragment.loadData
PlaybackHistoryFragment.loadItems : DBReader.getPlaybackHistory
QueueFragment.loadItems : DBReader.getQueue
SearchFragment.search : .performSearch
 2019-04-06 13:43:11 -07:00
orionlee
670fc124eb #2966 RxJava2 null - explicit mark underlying Rx sources as NonNull 
to be on the safe side, for cases that the consuming observers
already assumes the result is not null.

Rx observer : underlying sources marked as NonNull
OnlineFeedViewActivity.listener member : DBReader.getFeedList
StatisticsActivity.loadStatistics : DBReader.getStatistics
CustomMRControllerDialog.updateViews : CustomMRControllerDialog.fetchArt
CompletedDownloadsFragment.loadItems : DBReader.getDownloadedItems
DownloadLogFragment.loadItems : DBReader.getDownloadedItems
ItemDescriptionFragment.onViewCreated : .loadData, Timeline.processShownotes
SubscriptionFragment.loadSubscriptions : DBReader.getNavDrawerData
SubscriptionFragment.onContextItemSelected (x2) : DBWriter.markFeedSeen, DBWriter.markFeedRead
PreferenceController.export : ExportWorker.output member
 2019-04-06 13:43:11 -07:00
H. Lehmann
5f86af88b1
Merge pull request #3083 from orionlee/bulk_remove_from_queue_1145 
Bulk remove from queue
 2019-04-06 21:45:55 +02:00
H. Lehmann
31194e02a5
Merge pull request #3093 from AntennaPod/bugfix/3084-queue-undo-single 
Create new adapter to show single item after undo
 2019-04-06 21:32:36 +02:00
ByteHamster
74fdabba69 Show single item after undo in EpisodesFragment 2019-04-06 21:32:03 +02:00
orionlee
cb14fd930f refactor - rename string resource name remove_episode_lable , which was ambiguous with typos, to delete_episode_label 
- non-default string resources to be handled by Transifex
 2019-04-06 11:27:20 -07:00
orionlee
075547947e tweak - batch edit UI - support longer action label 2019-04-06 11:15:35 -07:00
orionlee
3bf880e34a remove comment to reduce mental work per review feedback 2019-04-06 11:15:35 -07:00
orionlee
86bf3ef3e0 remove outdated comment - support for vector drawables for pre Android 5 devices is here to stay. 2019-04-06 11:15:34 -07:00
orionlee
0204c1cebd tweak - bulk edit UI - remove hiding FAB during scroll per review feedback 2019-04-06 11:15:34 -07:00
orionlee
3311b4371e tweak - bulk edit UI - use Snackbar for selection message 
- to be consistent with the action message in previous commit.
 2019-04-06 11:15:34 -07:00
orionlee
cc43af110a tweak - bulk edit UI - show a message after an action is applied. 2019-04-06 11:15:14 -07:00
orionlee
46f7805a96 refactor - bulk edit UI - make fab clickable on Pre-Lollipop devices without custom codes. 2019-04-06 11:12:34 -07:00
Martin Fietz
6c3033409d Create new adapter to show single item after undo 2019-04-06 16:28:07 +02:00
orionlee
b3fbf0b4aa refactor - UI - remove the old (and now used) select all / none /intermediate icons 2019-04-04 14:05:51 -07:00
orionlee
836334798d refactor - UI - make OPML import screen use the new select all / none icons as well (so that only single set of icons are needed) 2019-04-04 13:58:50 -07:00
orionlee
d186309066 bulk edit - UI - new select all / none icons, based on 
standard Material icons.
 2019-04-04 13:50:55 -07:00
orionlee
dfe2241b4c bulk remove episodes from queue - UI - icon for dark themes. 2019-04-04 13:12:09 -07:00
Martin Fietz
4797d3ae56
Merge pull request #3086 from ByteHamster/fix-double-slash-url 
Specifying base url
 2019-04-04 19:06:34 +02:00
H. Lehmann
643173de14
Merge pull request #2954 from orionlee/bugfix_phantom_notification_rework_2716 
Fix phantom service notification
 2019-04-04 11:59:30 +02:00
H. Lehmann
f2d103736d
Merge pull request #3085 from ByteHamster/new-items-count 
Respect 'keep updated' for new items counter
 2019-04-04 01:16:26 +02:00
orionlee
b683d33bcb bulk edit - refactor - reorder method parameter for DBWriter.removeQueueItem(Context, FeedItem, boolean) to be consistent with the rest of the API. 2019-04-03 14:21:35 -07:00
orionlee
bcaba92851 bulk edit - refactor - factorize common codes in binding action to its UI and actual logic. 2019-04-03 14:15:05 -07:00
orionlee
1052b393d2 bulk edit - refactor - rename menu ids, to be consistent with single edit counterparts 2019-04-03 13:40:55 -07:00
orionlee
a1d718a59a bulk edit - refactor - rename internal constant flags so that the names are consistent 2019-04-03 13:31:32 -07:00
orionlee
4322e8646f bulk edit - UI tweak - rename "Remove Episode" to "Delete Episode", to be consistent with other UIs 2019-04-03 13:27:31 -07:00
ByteHamster
ce013bb225 Specifying base url 
Fixes <a href="//example.com"> links
 2019-04-03 18:53:11 +02:00
ByteHamster
46510c808a Respect 'keep updated' for new items counter 2019-04-03 18:11:55 +02:00
H. Lehmann
7a98e3c231
Merge pull request #3082 from ByteHamster/mobile-updates 
Mobile updates: Allow images
 2019-04-03 17:43:53 +02:00